From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 00279C30653 for ; Thu, 4 Jul 2024 23:26:38 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 570FA6B00B4; Thu, 4 Jul 2024 19:26:38 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 51F166B00B6; Thu, 4 Jul 2024 19:26:38 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3E65A6B00B8; Thu, 4 Jul 2024 19:26:38 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 1E9426B00B4 for ; Thu, 4 Jul 2024 19:26:38 -0400 (EDT) Received: from smtpin19.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id C52F0A4004 for ; Thu, 4 Jul 2024 23:26:35 +0000 (UTC) X-FDA: 82303656750.19.AA13177 Received: from sin.source.kernel.org (sin.source.kernel.org [145.40.73.55]) by imf15.hostedemail.com (Postfix) with ESMTP id AF66CA0013 for ; Thu, 4 Jul 2024 23:26:33 +0000 (UTC) Authentication-Results: imf15.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=EZYggXcD; spf=pass (imf15.hostedemail.com: domain of akpm@linux-foundation.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1720135560; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=YB/Gq42cr0E8jYOAT16C1qFknw6CZGD/U5nMDZ4PyQs=; b=N1fgR+ZPn0KloiqMZ35mfa7XRorLikRcAXIvm4fyESeusAe+UH57RE/4rEGaE/vG9t9tzc zD2akZtkRIzOKv1S7G60LSvfAtsE/4mdO6965EOoKb0vOp9gaAQ1dpDgBiTxummEVm/o1d n9BkBg6bPG4V8Wt1ROvJrY3ULRemmHU= ARC-Authentication-Results: i=1; imf15.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=EZYggXcD; spf=pass (imf15.hostedemail.com: domain of akpm@linux-foundation.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1720135560; a=rsa-sha256; cv=none; b=br3Y3G+HVDqm8oNPvjvbA/bej98bXL/VvJqN/WuFtegqBbmb3a+VR+mbm2nsKyymdEyGre v7suGtcAlzGx7uEq+ZYWzg0G4BEsh+eLKrr/tvCldezwKFVCzquRej8q21Y4QD6g3M19mn PwfonieoE4ov0YcNAgByIxK3/4Xvf6w= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id 93B13CE3AD8; Thu, 4 Jul 2024 23:26:30 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id B47D0C3277B; Thu, 4 Jul 2024 23:26:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1720135589; bh=4N9YUyDrPaqH7sykixS9Sq/oqokMBdI2QCszV5PFZh8=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=EZYggXcDEOpP7bnex7zXO7Z5q4fsxcdGMMVhq4p6Qg9QyYPPKkJ8qmaeARye2N4yF FU3Bn+gbgI+LSbEpjt12P+WXfZtwjvgznfwgDk3ywRxoIu+j+Cnql/yfq60GuAaNDH uCeYqHuM5fiMF6qZ+3wwXFLMBCC4dq1+yEpZ97IQ= Date: Thu, 4 Jul 2024 16:26:29 -0700 From: Andrew Morton To: Miaohe Lin Cc: Rui Qi , , , Subject: Re: [PATCH] mm/memory-failure: allow memory allocation from emergency reserves Message-Id: <20240704162629.cf750dd1ee58c70d358466f3@linux-foundation.org> In-Reply-To: <070697f1-83f5-ff8e-dfc0-2f99c98c448c@huawei.com> References: <20240625022342.6158-1-qirui.001@bytedance.com> <20240702001940.43a9447a76b51a871d8dec97@linux-foundation.org> <070697f1-83f5-ff8e-dfc0-2f99c98c448c@huawei.com> X-Mailer: Sylpheed 3.8.0beta1 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: AF66CA0013 X-Stat-Signature: xe7km8zpnqh6ft5mocb18woh8gqfprrf X-Rspam-User: X-HE-Tag: 1720135593-471012 X-HE-Meta: U2FsdGVkX18YO0NVXyv07oD9gZkbUCq8WeK4iljmv0jITbNVihO9/5UCulmBy+9hPOdXd914fp3RxjTfQWjD3uHPpF0jmR9LRp4EctRO3a1ZoCOMTm4mzufHtvC7pXj9OKms9OkKhwiOeZWgL1rplJAceqeXj/lPrcMFv2h9Zaz4zBhD9jMlpGmMdseVZtpEPXWXyGR3VN5cjy/9ZRA69jnZjqzsdAISbWswablzIhFDmbyfHGWbLiobikQDKAJO0AJmUs0+SXW14aOnK2uSByI8mDs/YaU1Zx2ztTSQurKg6cI/Ku0NHeh8yf0Q4RHWgXxGvKeaX3mxsx4TqhRHtr2h2+wnhDOv5gsR0uwWLqLfpHlRgJVTTvp/iH5UXOkYfI3OPxcV7cX2yyY0dZms+BC9Ka6rwENGK8vHjgchy1j6lE8fMobrXjSfvqWlcqAfN+5b74wDgv3DRv7FlxQFxExKnhBj3GUk3UQkIh2PqQzTBavtF8J5FNk2PPHYiENtnphFEr/Q56WyquFIlsbes9ntcewYrJA+VMSajP8Rso18mD18G30b/syln9dWqphVAOxg9SOjJYs1h6CIBBsR/QLMMHtnwazkTgUIFNH8lo8vOteYCEFF5+yQJRk3k5ZN0/BX304/bdbwecWLntffB9weOPGJMlSIpBouvenKo/enm4SY/4mfSvQx/LVvxwODkuDInQA85KZ7P+Eob5dT5tWlmpCzsIPO4kxPMX84rcIrxIXsd6VRvhL/a/Me6AaM0JFxegUj4devvkf1jS9CFCV9krAHmDaa0eU4/+fIeJESOZc+omaUYHPk7JVCkqZVoodCdJD9GwjqSE5DeX8+Ju2K4sh6wiTvVaaLkpMhUxPTNPfp2Blkwf0Tm6++JhaU5C1gwCJEEO+4kwZaowJW9T6IIuuLZV/+pE41CylyyIT0IeOHXKoLYsqUOgnDS4ErGmO64gMRONKBr6TO5D1 gU937Lc3 QYjfSCmDLcsbmka0qLA6klh3+ELLxykd+CVUB9EtE0kEk1/5C7Y2gJhHThosoUMIHURjmjtkRhFv7EnUaFO2eOWmx8heafBHb0Cc6DN11R7+BJQYF905dpLFSI2n1wD+qYS7AFXVbBgG6vGKQ9QMc7fHj7m9n2wpCfhVj9DotKiqkT7XfYJ1+y56K/XMFDZeFojJi9guZBdc2xGuK9HVj9dYC0adPCpFeAIr7K47ZulYAAkRRfe7E1RO9KSLakWDtJBt79birX6+ov6LusiyRQeGlXaNakJXyxIkDhuJ3o+ckWk3z3e0zGTPIgTyEj7Gbl7GC X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, 2 Jul 2024 16:04:02 +0800 Miaohe Lin wrote: > >> Tasks might not be killed even to_kill struct is allocated. > >> > >> ... > >> > >>> - raw_hwp = kmalloc(sizeof(struct raw_hwp_page), GFP_ATOMIC); > >>> + raw_hwp = kmalloc(sizeof(struct raw_hwp_page), GFP_ATOMIC | __GFP_MEMALLOC); > >> > >> In already hardware poisoned code path, raw_hwp can be allocated to store raw page info > >> without killing anything. So __GFP_MEMALLOC might not be suitable to use. > >> Or am I miss something? > > > > Yes, I'm doubtful about this patch. I think that rather than poking at a > > particular implementation, it would be helpful for us to see a complete > > description of the issues which were observed, please. Let's see the > > bug report and we can discuss fixes later. > > I agree with you, Andrew. Thanks. :) I dropped the patch. Please let's proceed as discussed above.