From: Andrew Morton <akpm@linux-foundation.org>
To: Miaohe Lin <linmiaohe@huawei.com>
Cc: Rui Qi <qirui.001@bytedance.com>, <linux-mm@kvack.org>,
<linux-kernel@vger.kernel.org>, <nao.horiguchi@gmail.com>
Subject: Re: [PATCH] mm/memory-failure: allow memory allocation from emergency reserves
Date: Thu, 4 Jul 2024 16:26:29 -0700 [thread overview]
Message-ID: <20240704162629.cf750dd1ee58c70d358466f3@linux-foundation.org> (raw)
In-Reply-To: <070697f1-83f5-ff8e-dfc0-2f99c98c448c@huawei.com>
On Tue, 2 Jul 2024 16:04:02 +0800 Miaohe Lin <linmiaohe@huawei.com> wrote:
> >> Tasks might not be killed even to_kill struct is allocated.
> >>
> >> ...
> >>
> >>> - raw_hwp = kmalloc(sizeof(struct raw_hwp_page), GFP_ATOMIC);
> >>> + raw_hwp = kmalloc(sizeof(struct raw_hwp_page), GFP_ATOMIC | __GFP_MEMALLOC);
> >>
> >> In already hardware poisoned code path, raw_hwp can be allocated to store raw page info
> >> without killing anything. So __GFP_MEMALLOC might not be suitable to use.
> >> Or am I miss something?
> >
> > Yes, I'm doubtful about this patch. I think that rather than poking at a
> > particular implementation, it would be helpful for us to see a complete
> > description of the issues which were observed, please. Let's see the
> > bug report and we can discuss fixes later.
>
> I agree with you, Andrew. Thanks. :)
I dropped the patch. Please let's proceed as discussed above.
next prev parent reply other threads:[~2024-07-04 23:26 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-25 2:23 Rui Qi
2024-06-25 20:01 ` Andrew Morton
2024-06-29 2:09 ` Miaohe Lin
2024-07-02 7:19 ` Andrew Morton
2024-07-02 8:04 ` Miaohe Lin
2024-07-04 23:26 ` Andrew Morton [this message]
2024-07-05 1:04 ` Miaohe Lin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240704162629.cf750dd1ee58c70d358466f3@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=linmiaohe@huawei.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=nao.horiguchi@gmail.com \
--cc=qirui.001@bytedance.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox