From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id CBFAFC30653 for ; Thu, 4 Jul 2024 12:47:17 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 2EF106B009A; Thu, 4 Jul 2024 08:47:17 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 29FA26B009B; Thu, 4 Jul 2024 08:47:17 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 18E396B009C; Thu, 4 Jul 2024 08:47:17 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id EED366B009A for ; Thu, 4 Jul 2024 08:47:16 -0400 (EDT) Received: from smtpin18.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 957CE40E87 for ; Thu, 4 Jul 2024 12:47:16 +0000 (UTC) X-FDA: 82302045672.18.C5DD7F7 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by imf03.hostedemail.com (Postfix) with ESMTP id 0658D2002A for ; Thu, 4 Jul 2024 12:47:13 +0000 (UTC) Authentication-Results: imf03.hostedemail.com; dkim=none; dmarc=pass (policy=none) header.from=arm.com; spf=pass (imf03.hostedemail.com: domain of joey.gouly@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=joey.gouly@arm.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1720097213; a=rsa-sha256; cv=none; b=JHxk/f1CsyEOJ7uOmF8VPYsyT9h85PhrrQiQzhpA2r7WDM23u1z8fEbmMin+NuSBWTDKlU 8BnB4/0RFEQGlaY7QUCLdvx0XuWwv7s8nEMOWPxl+7fhOxamL5kQ/CIlf5KNugysCFlNmI VrQAq6yX0rPZ9QIxRxb2Aj5blIOCQjA= ARC-Authentication-Results: i=1; imf03.hostedemail.com; dkim=none; dmarc=pass (policy=none) header.from=arm.com; spf=pass (imf03.hostedemail.com: domain of joey.gouly@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=joey.gouly@arm.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1720097213; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=3VRfPuhN/AytwzoBKdx33khObrsA46bve2QJNOSAYns=; b=jTnfhNbyDl9QHoBZxQPqgRxqLQUmcV5zOCaBVJSY+amQB4WTTtOkbxQ4bK5EMeyvaXL1yh eCK1CiNmapWWxefrgPtVaJEL9TEcd2rZ6TUsSap/1b5rxUTiyKwUkq5CWu3mlWHhGdPaXg zvA1db69EbZfHofECLzrJ/oZd3coqDs= Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 3AE77367; Thu, 4 Jul 2024 05:47:38 -0700 (PDT) Received: from e124191.cambridge.arm.com (e124191.cambridge.arm.com [10.1.197.45]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id A177D3F762; Thu, 4 Jul 2024 05:47:09 -0700 (PDT) Date: Thu, 4 Jul 2024 13:47:04 +0100 From: Joey Gouly To: Catalin Marinas Cc: Amit Daniel Kachhap , linux-arm-kernel@lists.infradead.org, akpm@linux-foundation.org, aneesh.kumar@kernel.org, aneesh.kumar@linux.ibm.com, bp@alien8.de, broonie@kernel.org, christophe.leroy@csgroup.eu, dave.hansen@linux.intel.com, hpa@zytor.com, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linuxppc-dev@lists.ozlabs.org, maz@kernel.org, mingo@redhat.com, mpe@ellerman.id.au, naveen.n.rao@linux.ibm.com, npiggin@gmail.com, oliver.upton@linux.dev, shuah@kernel.org, szabolcs.nagy@arm.com, tglx@linutronix.de, will@kernel.org, x86@kernel.org, kvmarm@lists.linux.dev Subject: Re: [PATCH v4 13/29] arm64: convert protection key into vm_flags and pgprot values Message-ID: <20240704124704.GA3548388@e124191.cambridge.arm.com> References: <20240503130147.1154804-1-joey.gouly@arm.com> <20240503130147.1154804-14-joey.gouly@arm.com> <4f7d8691-fe19-4e8a-95e5-9f7680c82021@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 0658D2002A X-Stat-Signature: 8iaprxa3t8qqujoseorzxuasjey1zyb8 X-Rspam-User: X-HE-Tag: 1720097233-10470 X-HE-Meta: U2FsdGVkX1+Po8Apgl5WXl6qYUK8A0SSASsdqA5TEwwkfA2YX1r/MUBdGKadFNvY+jzD9WWhHkkmsS01GFi/rqE13UdE9wlQZl0yNjbtHvZfRCU0fGxuMSCnlfpcnhChZy0qLELt/n7jMpCKWmpREa7DhVczLWUxYiGQpAONPf+5YpK8GnrkAaeJsCz5Rx7fQS6wHm2FhSfTdH6zKemK3gao3Bjjs4K8vSPypbIyhB7aoAGOCwJRO88Ok80dx8RVBrCKCJHG4pp/fqqls7hLAFLpUrxGI50WO2EkOp6lR9DtIu32v7zkG2Re0A/Zil6AskQne4/FXJK/h56W9iBE78UAh6zXW/nLJcqmf8m9WFPB9NypDnNS6+s0DyGqgJLRA1yZdEi4PRvPHMEvW2GyGLbCV2NmjXxJZdV8u8C8SHa/Rc/7mmSFuUHd5iOlRSyAgc5b+KvPXgYShNdGyJ0Y5nHw+BoykYcc7LEkihYJim0C+A0AFC+OlXmbw4hFYPFVuu1e34vcaChW2VcfqD7jbDsUYZa2rzsNchXG0soZ0UIrDZOTR3TCYbE4TInpkCjT2GNlpQlYNzl+ZM2s2v1V7Pdqa878TvH7IdyU08GZr5krkwnNMlNb2+xfoxNr7snNtpXrQvN6smVettWQZLCKu5X9q4FwzZljHJr0SAAj9XJmAZ2RuRoieqxTOzRbLYHOZsKR4eYdXLPfIqNlnsfgdDvE8+Dn9Bmc+kcu7NvHgqwZpeM/zLoniKk2NBDaF3mANxII9ZWFt06IksUYWXbh7fargrZJaQ2VeqCljnaS/CallBu1hN6XSxTyl0FJ60h/4YU5Jyx4lmL5pljkXJNi1coJqT3StVMTnf8ivWhWEpAbpv6fN/dTO8nsyJUFxVMjj1n2/qPFsBzYXc8+2kWN0ZkySQqw+viP4h/mNvnP0V2JWam6TYG4tHcB7rDXVrUP7Ifv7mEsU+wyZxvVa2H /TByiMBJ z5O50E0qTy3QOE7xUfN/UGS1OPTKmcNqwSir/BVfuj24LhPua4fKjtZnn8xovVMAwZvCLN/1/kqn16dBU9Go0wH+NOE+nvObUBq+mua0QmS0BRGge1kJFpnXK1LrHz6MXLk7fF3BHTthrddFRolggUGZhAUhdLhoeLSmRiR0t5kvCBM5/h4k213Z07ioRIHx3duHi X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Hi, On Wed, Jun 19, 2024 at 05:45:29PM +0100, Catalin Marinas wrote: > On Tue, May 28, 2024 at 12:24:57PM +0530, Amit Daniel Kachhap wrote: > > On 5/3/24 18:31, Joey Gouly wrote: > > > diff --git a/arch/arm64/include/asm/mman.h b/arch/arm64/include/asm/mman.h > > > index 5966ee4a6154..ecb2d18dc4d7 100644 > > > --- a/arch/arm64/include/asm/mman.h > > > +++ b/arch/arm64/include/asm/mman.h > > > @@ -7,7 +7,7 @@ > > > #include > > > static inline unsigned long arch_calc_vm_prot_bits(unsigned long prot, > > > - unsigned long pkey __always_unused) > > > + unsigned long pkey) > > > { > > > unsigned long ret = 0; > > > @@ -17,6 +17,12 @@ static inline unsigned long arch_calc_vm_prot_bits(unsigned long prot, > > > if (system_supports_mte() && (prot & PROT_MTE)) > > > ret |= VM_MTE; > > > +#if defined(CONFIG_ARCH_HAS_PKEYS) > > > > Should there be system_supports_poe() check like above? > > I think it should, otherwise we end up with these bits in the pte even > when POE is not supported. I think it can't get here due to the flow of the code, but I will add it to be defensive (since it's just an alternative that gets patched). I still need the defined(CONFIG_ARCH_HAS_PKEYS) check, since the VM_PKEY_BIT* are only defined then. > > > > + ret |= pkey & 0x1 ? VM_PKEY_BIT0 : 0; > > > + ret |= pkey & 0x2 ? VM_PKEY_BIT1 : 0; > > > + ret |= pkey & 0x4 ? VM_PKEY_BIT2 : 0; > > > +#endif > > > + > > > return ret; > > > } > > > #define arch_calc_vm_prot_bits(prot, pkey) arch_calc_vm_prot_bits(prot, pkey) Thanks, Joey