From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5D50FC30653 for ; Thu, 4 Jul 2024 14:13:35 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id DB7B86B0082; Thu, 4 Jul 2024 10:13:34 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D41366B0092; Thu, 4 Jul 2024 10:13:34 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id BE0E86B0095; Thu, 4 Jul 2024 10:13:34 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id A080E6B0082 for ; Thu, 4 Jul 2024 10:13:34 -0400 (EDT) Received: from smtpin29.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 420A41A13DB for ; Thu, 4 Jul 2024 14:13:34 +0000 (UTC) X-FDA: 82302263148.29.5730435 Received: from sin.source.kernel.org (sin.source.kernel.org [145.40.73.55]) by imf14.hostedemail.com (Postfix) with ESMTP id A0B3D100013 for ; Thu, 4 Jul 2024 14:13:30 +0000 (UTC) Authentication-Results: imf14.hostedemail.com; dkim=none; spf=pass (imf14.hostedemail.com: domain of "SRS0=dMZF=OE=goodmis.org=rostedt@kernel.org" designates 145.40.73.55 as permitted sender) smtp.mailfrom="SRS0=dMZF=OE=goodmis.org=rostedt@kernel.org"; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1720102399; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=5fUOBl0Pl6SL2b1kOVcKqAYZpsqd7fld5OODBEa8OSo=; b=lVS7Dfcczbj9My7vMsofQa82RlWsXRug6B1u5nLTkgTy4d7shR6jSRjjs7C/NbWJpZp921 yrBfL2HFssI3FAE6kzHugDSoRa8qkLikYzcmXOoFa4HkFjFtIIz01T5O+kQz7z0QsD96Oe 0oVGf9N7UsjkbM+bn1zgtEAg77bynZM= ARC-Authentication-Results: i=1; imf14.hostedemail.com; dkim=none; spf=pass (imf14.hostedemail.com: domain of "SRS0=dMZF=OE=goodmis.org=rostedt@kernel.org" designates 145.40.73.55 as permitted sender) smtp.mailfrom="SRS0=dMZF=OE=goodmis.org=rostedt@kernel.org"; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1720102399; a=rsa-sha256; cv=none; b=6Uipz7ut0Mnh//ThKW4kAPO6FbMmL3Qnf6uUySAYX16hSW1YNt9LV25FEif60UdseMI858 Hl86F0hTQiu6hb/LRbrucBJHuuLBna8ZzrwPm3wKLKFUMzy/fh2/g5IdHSb5V7fPmg9zdS RD7X2A1TFKI4tlaRDZnB+SnCMI3yKXU= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id 921A2CE37A5; Thu, 4 Jul 2024 14:13:26 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id C5346C3277B; Thu, 4 Jul 2024 14:13:24 +0000 (UTC) Date: Thu, 4 Jul 2024 10:13:22 -0400 From: Steven Rostedt To: Dave Chinner Cc: Matthew Wilcox , Hongbo Li , muchun.song@linux.dev, mhiramat@kernel.org, mathieu.desnoyers@efficios.com, linux-mm@kvack.org, linux-trace-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org Subject: Re: [PATCH v2 1/2] hugetlbfs: support tracepoint Message-ID: <20240704101322.2743ec24@rorschach.local.home> In-Reply-To: References: <20240704030704.2289667-1-lihongbo22@huawei.com> <20240704030704.2289667-2-lihongbo22@huawei.com> X-Mailer: Claws Mail 3.17.8 (GTK+ 2.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam03 X-Rspam-User: X-Rspamd-Queue-Id: A0B3D100013 X-Stat-Signature: zskgtkuj4dad1usk9a43eho6zu3kco4z X-HE-Tag: 1720102410-268966 X-HE-Meta: U2FsdGVkX1+gXCUSpWZchL1fN/8Kxz5HMbf6+V7qlltNhg6MWd0KKxHHPYF/89Kro42k8nZ2p0YFg2MTrGZvB+jgShji82lCkjzxgHHi3bwy7ykqmx5CSjqJxzleh/Iia3qJbmEyjK7aKKrOsNPhhIKinc45Lvt2KzjO7Ivlkvur7K/ORzAgCr8cgOgD4EgKS/XwPqT38m+ATnqz3dQyiJ4OV6NIX2FeGubb7h02T3FX/i/kP7uJG3T1Y+rAMteochaA2H4wvd7tyr0H5kZ/ECnRpNCrndWh5ZwqVvpZMV6u4qDygW2tdngZFr5GRBde2TJJRuiQ+eUH/lnuKfS3PrDUjyN5BboLSaF8the/cZz7+H9YdI2rbSvFJ/O2hvedcECo2XnvfNRyWqeMf4aPVQOceUsxLsozqxINr9JT5Y8iVbHgaeZ/rVPAe69ioRz1a2gn7KgUeeE+DDr1djkjzeI/dj0herkyzIQCpW8FcTHHcvp0bnkVgCMLl21VIsE9O/1bAwayy3H5VCMm+u7A7e0Xq2yB8l78RQsKYvDx2bR6rl9YcXNO+G66sdKqhSR5KlX75ivR7/OWYU4hIX5QzVugao4ESXzGD5kJ580cbYfL7/4YwBz4z7lM3zZHTf2OVHyNbO4gbx/+xp/Ie7VJKnzfhQHTkSmHFyVfLmeXskNk9ggXb1uBxpBb7Vd1wnALg1bv/7GeXe73BRyNY23lUQfaJC2gH/UyK+offl34zcdti8Of64k2wf4c4ShJAVFFY2+eHDRva0cBdv3khseXf2LLTtOeviVLMrM4lTTK4OV5PbdhCPX/JjnVwXDz5a7o8SC6jintOU0t4jGletTJY6mz9o7iq9P0OnyPOR1p2XbcfCFMiOnlfddyprFkFQ96ZJePBQEtCT1qnwQpfuBN1BomnKFxhtE3vbqB31LByIjDlLrL3iiQor53KmlEmFgApZRJX/zA4y1TYg11BOW Jkuq19Cs Br6Ps611w1sligDL36xiOROEo/iC5RIslS28UEwuiOJNbFRZdKmE5fjkfnOoFAA7EajTwTDpFH2Uikey94fjsWrwN6pnzOM6loP8WgiqxehY7ocvOKPgh7LjwcJUV34RMTOBOMHn6wkExcKZiNgULxM3fN6AB6hJFwr53lwF+2TrFWQEX4Kw6243jdl6OZ0KIIxJmniDW7f9Zso4BTXDUBtTSQO9gqlNKz+0/bNIfW7XxM2+0xv02deQn9YF+pY6V+5bmF9mmom0lZEJEkvjNXEgsQIe6ZFYYXVnZcRd62oC+saQ= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, 4 Jul 2024 22:56:29 +1000 Dave Chinner wrote: > Having to do this is additional work when writing use-once scripts > that get thrown away when the tracepoint output analysis is done > is painful, and it's completely unnecessary if the tracepoint output > is completely space separated from the start. If you are using scripts to parse the output, then you could just enable the "fields" options, which will just ignore the TP_printk() and print the fields in both their hex and decimal values: # trace-cmd start -e filemap -O fields // the above fields change can also be done with: // echo 1 > /sys/kernel/tracing/options/fields # trace-cmd show # tracer: nop # # entries-in-buffer/entries-written: 8/8 #P:8 # # _-----=> irqs-off/BH-disabled # / _----=> need-resched # | / _---=> hardirq/softirq # || / _--=> preempt-depth # ||| / _-=> migrate-disable # |||| / delay # TASK-PID CPU# ||||| TIMESTAMP FUNCTION # | | | ||||| | | less-2527 [004] ..... 61949.896458: mm_filemap_add_to_page_cache: pfn=0x144625 (1328677) i_ino=0x335c6 (210374) index=0x0 (0) s_dev=0xfe00003 (266338307) order=(0) less-2527 [004] d..2. 61949.896926: mm_filemap_delete_from_page_cache: pfn=0x152b07 (1387271) i_ino=0x2d73a (186170) index=0x0 (0) s_dev=0xfe00003 (266338307) order=(0) jbd2/vda3-8-268 [005] ..... 61954.461964: mm_filemap_add_to_page_cache: pfn=0x152b70 (1387376) i_ino=0xfe00003 (266338307) index=0x30bd33 (3194163) s_dev=0x3 (3) order=(0) jbd2/vda3-8-268 [005] ..... 61954.462669: mm_filemap_add_to_page_cache: pfn=0x15335b (1389403) i_ino=0xfe00003 (266338307) index=0x30bd40 (3194176) s_dev=0x3 (3) order=(0) jbd2/vda3-8-268 [005] ..... 62001.565391: mm_filemap_add_to_page_cache: pfn=0x13a996 (1288598) i_ino=0xfe00003 (266338307) index=0x30bd41 (3194177) s_dev=0x3 (3) order=(0) jbd2/vda3-8-268 [005] ..... 62001.566081: mm_filemap_add_to_page_cache: pfn=0x1446b5 (1328821) i_ino=0xfe00003 (266338307) index=0x30bd43 (3194179) s_dev=0x3 (3) order=(0) less-2530 [004] ..... 62033.182309: mm_filemap_add_to_page_cache: pfn=0x13d755 (1300309) i_ino=0x2d73a (186170) index=0x0 (0) s_dev=0xfe00003 (266338307) order=(0) less-2530 [004] d..2. 62033.182801: mm_filemap_delete_from_page_cache: pfn=0x144625 (1328677) i_ino=0x335c6 (210374) index=0x0 (0) s_dev=0xfe00003 (266338307) order=(0) Just an FYI, -- Steve