From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id EF94BC2BD09 for ; Thu, 4 Jul 2024 02:28:03 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 761AB6B0092; Wed, 3 Jul 2024 22:28:03 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 711CB6B0095; Wed, 3 Jul 2024 22:28:03 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5B1BF6B0096; Wed, 3 Jul 2024 22:28:03 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 3CC326B0092 for ; Wed, 3 Jul 2024 22:28:03 -0400 (EDT) Received: from smtpin27.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id D21BA80E40 for ; Thu, 4 Jul 2024 02:28:02 +0000 (UTC) X-FDA: 82300485204.27.3C66844 Received: from mail-ed1-f50.google.com (mail-ed1-f50.google.com [209.85.208.50]) by imf09.hostedemail.com (Postfix) with ESMTP id DB89E140006 for ; Thu, 4 Jul 2024 02:27:59 +0000 (UTC) Authentication-Results: imf09.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=gHSmUHMt; spf=pass (imf09.hostedemail.com: domain of richard.weiyang@gmail.com designates 209.85.208.50 as permitted sender) smtp.mailfrom=richard.weiyang@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1720060047; h=from:from:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=1W34Z3nXW+MCwIvZyWJfAuvbVufFerSj2UpL022AfpA=; b=8F59GOzqY8VcO+TmPqA2K+tOOfKsrG/DpzZ63TfmeNB0RE6QuHyfbpj+qYtny0cP4gOqIu NCl1oARJXX7wtAXw22GNZFCCANxNoSNzhor7LAlM2KjNGgGumqLID8qhY/oH70ngSZx6zK 0YzF43mbp8uhxUintx8veQQRpnuwp4I= ARC-Authentication-Results: i=1; imf09.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=gHSmUHMt; spf=pass (imf09.hostedemail.com: domain of richard.weiyang@gmail.com designates 209.85.208.50 as permitted sender) smtp.mailfrom=richard.weiyang@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1720060047; a=rsa-sha256; cv=none; b=Uo8VrUUrZGrhIHgf4Y7Ter3V5hCah/9nkVA41e+F35Pe7azEA2qmCXd4Y9bGZw7oBABaR5 yI/hyebiq6P+Wb+JC2uzSMcnJGJ1hdt0AQzW9wsnCFtlFoYqhs5B8vHzAMzApxey+NK1q4 0jkwHawxKpao5pJEB4lsIIKb/iayQGM= Received: by mail-ed1-f50.google.com with SMTP id 4fb4d7f45d1cf-57cbc66a0a6so284933a12.1 for ; Wed, 03 Jul 2024 19:27:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1720060078; x=1720664878; darn=kvack.org; h=user-agent:in-reply-to:content-transfer-encoding :content-disposition:mime-version:references:reply-to:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=1W34Z3nXW+MCwIvZyWJfAuvbVufFerSj2UpL022AfpA=; b=gHSmUHMtx7sQhrCk59UikPW5QCa8+qnckNYNLIoDMfyfvHYCBxsb3nuu6FPhy5JjFA 6NmLpjJmAlSGKOoNn3de+sWc9wd4PQCA3qSrexRVMR4YFa4cD/GKD3sLrQcQ+IccSDVc 9FLYVtVLxaQWTP2iuCU+NQen5H0ajte0yPO77mmbsPdgihrkd5vxffZQvz+LMlcDm7cz iaF9mfLqoajjEkMkRkMYxmDoCxGY8R7XWj/Sm6n/8hojR/SpSTYT9jqgJJSjAg3C3Zja wvMOH9CdH5FhkphKGWYvf24j43srLANF2ApKVVyPRq8ifzZUomUzAq8lc8nAawu6e/w9 0iXA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1720060078; x=1720664878; h=user-agent:in-reply-to:content-transfer-encoding :content-disposition:mime-version:references:reply-to:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=1W34Z3nXW+MCwIvZyWJfAuvbVufFerSj2UpL022AfpA=; b=E2XA2Fa6dT9YReaGl/fr0EBNtAvLD0ve+C/reuC1uXpqiapev1qvzac5QJnSrdVdDp YUBPLmZd9z6LPUCX/AYIpdFJNmDWKM38NRTWTEd73tN+z0T/eHnOvRSmLjQu+H7yrr6S mGTXlQ0HMH2CjN0dqgVbihWcci2dD0Uvqpbm0UOsuak57oNkczoE1j3UhCfrH90cNBBL 7DEVOKjTSm6dpm9Ev9G1FpWjHjt/rPH+CFcYiVkWdwkgCMoM1ahUcHNgWBpfNTmYOflH N/WZBb+0UyLQx251zoFqN8c3EitiOH5DOYWZhffiPrd5DRucwIh7Z6/cEhSdYqV45NH3 pTgw== X-Forwarded-Encrypted: i=1; AJvYcCXf3crzqlefWT6jaIZdQEm5DvjVO4MGVOMQRnxgAZtQPGUvMdNWV+7uTeXvuBDA1cqauTaM5bSpKxGuWtTm3NlYeew= X-Gm-Message-State: AOJu0YzZENxvm6uH4pluYMmI7mOeHWjdI6RLURMAOLPo3A+TfHrFidIO lKC1PkkH6+2Zspvc5Cwmh+pmnoYNdAkuWtrVyzV6jxMJ75PMeKll X-Google-Smtp-Source: AGHT+IFQ1rQlYRVYGWOQL+TFM7EZFIuOaPfvUlZLEvmmzwgy+tadg8ktg67t+dr9NGUlhEk4p291qw== X-Received: by 2002:a05:6402:3552:b0:584:21eb:7688 with SMTP id 4fb4d7f45d1cf-58e7c29bed8mr57018a12.14.1720060078029; Wed, 03 Jul 2024 19:27:58 -0700 (PDT) Received: from localhost ([185.92.221.13]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-5861324ec3dsm7986421a12.38.2024.07.03.19.27.57 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Wed, 03 Jul 2024 19:27:57 -0700 (PDT) Date: Thu, 4 Jul 2024 02:27:57 +0000 From: Wei Yang To: Masahiro Yamada Cc: Wei Yang , akpm@linux-foundation.org, nathan@kernel.org, nicolas@fjasle.eu, linux-mm@kvack.org, linux-kernel@vger.kernel.org, linux-kbuild@vger.kernel.org, Mike Rapoport Subject: Re: [PATCH 2/3] modpost: .meminit.* is not in init section when CONFIG_MEMORY_HOTPLUG set Message-ID: <20240704022757.fq62i4nhb5eignvf@master> Reply-To: Wei Yang References: <20240702234008.19101-1-richard.weiyang@gmail.com> <20240702234008.19101-2-richard.weiyang@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: NeoMutt/20170113 (1.7.2) X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: DB89E140006 X-Stat-Signature: opg6u9yymhp95ho9zbr1qfn5mir6xtwr X-Rspam-User: X-HE-Tag: 1720060079-267160 X-HE-Meta: U2FsdGVkX18sZLO1VT6dQXRPqaUuwnCfTNmM1r/Tz9VgWiecWMJiMq5tot1QY6Z+GFPmwJGj6UvUoB7MooheFVFK4jSOgLTXjTMaG0jTe6GOp81+14ETI9PYjiOo0kwXsLP78AeihnyEEOYihjL3dbBltRi/uVJie34tKWFoE7GXvhzPagQxjQgTo96h7T27Nlx9uumv+YXv1No/hdHgCohtR4tqhDvI31cJjKB9HQtzGatQfeoG2PtdGOR1R9hqzecrrxHb+bMi3X2Tl4zx3EH0GndtghpGk9SXZ35Q/jQMyW3Ms5LL5H0CfJJkq7Vblyidlf78YChcKyLJHjmL75/5PxCmaxHXF9Bk81vyIZwbcBab+C6R2+5jC6gtWa2vuCMeZ8n99pfg3oJ7uWejnZBJZrMYm6wqf2YcPQz/Ua3BsjjsAzIw5WFgH0I1/6k7mrkA7dw89KHM3EGAtRr7E8/Z+Km/17d0wU8uVWlOrLHiHSvJE9xREjlvY5iufXX0qnZICVBqHnXN6Egfb6Plk5DHhUaW0CuBDgVXzM6IlsARtxP3+xpBehYo905kstyh3pfs0UK9+mHf1Om4waYy58fqESS16z63gvraXt/zphiC3bKGssTQcSSkAWZAEkwfFlasvozDEUE+JNh71e/ytXM0DVtHf5+pWQs+wF7PkQA/wtvef2H+rmJ4nE6JOPpyWcmH2wzPtX+68UxixvvmtIh1Rxa6qPtDbtPstlJlhn0CLQECWtkaKDm1n0i0LwsPuhbThFNd8EBcFULXInc9l66Dao6ZMFy1yWo8Yvuoz95dug8cczyzHDJ935noVmQ9h9mq4YUQF5QaEkLrmdl/ZVdqeFVO1FqukXkqyekd1gMdDHmyzJJ/QY+iCJsXSUUkCvNq5KW8Xg5X0GTdii18+hakQI74vk8r1OICKBMo3wpYFFahl3OsBO4+r3aWH0giRJ9NH8Pr6fNU3yQtdsg kZd9qN4Z 1hLhURekjXhSwt+7J/Wj7vCB5cienFKrSQQ2jBTMGF9aPXFFXwlbd0EjMwg4XR0CUX45fs/rXdPtDYvqaBDuavGKY6gWrLt1iU4Av91me+WxHyLl52WOdC6N5qeCjrbciU3a1mn2H1cJ2w+lD9U4atMdF8WntoX4DMQwctwz1qSyKOtA13ZMZ1VNBAJoCkFT6BYhPOHcW9oyt4THrQrWv/wuU477tPlwvCwTMxAW6Qn2IpR4v90W8O06p8gNE/EPvwvsQLqKayNmQdetbnoFlqE9hAJo/gsxxBffjvF9HWmyAZI5tA/ZE8ZsxvcpoAq4l0Aa/sxuLZiX160rRDNdvR5ZO65z4u3inSze+ykMk6/MG4PdO4gMzoVWDO7S3g9Zdl8n9863aTI29WY/gkaZU6mnAAdSV9SRCSttj3gHmAJZq46oDIX4navsVgdZexbK6waNGceDkpS4IkX0464Ardz7Z7xaQ/uCJ8B4mcxX6KzTM1wZhU5+5pWuJFoDS4vMfhmEsCjWns/uveNFNk5HK23fSjz09TjWxXpJ+vAG8tRwaB75Bo7iGrvFdxhRODsCal0O1NmFq7bycp9L/wkNk0tIMKN/NtpJbbQW7AnM75qv/PiG9HQ3gi1seNEN/R3HA1kH3shOOh38675e06futiewaCltNhCPxclRTIj/ZAeOE7PbuVEGFdoSDsXmxbEqMeB3KR2YMKD7bh6rjR/AStOBbqFa7k+fvl395CDGwcYXp/a4o3r+l1TxiIm5PDkFrVo0b5qc5pKQhDvxrIfajQTl6qyfzmX5eAGS/FOZqn2n7A5pR12gPXOS4Db0CjZO+31tp2SVDEaUJWS88HEAgaiOdhTJIq8IlgrVnU0QVpMsm3J2M499c1wvoMWBsS5ZodpjdlbGNaKBdCCt6pjNEMRLiFQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000019, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Jul 03, 2024 at 11:44:38PM +0900, Masahiro Yamada wrote: >On Wed, Jul 3, 2024 at 8:40 AM Wei Yang wrote: >> >> .meminit.* is not put into init section when CONFIG_MEMORY_HOTPLUG is >> set, since we define MEM_KEEP()/MEM_DISCARD() according to >> CONFIG_MEMORY_HOTPLUG. >> >> Signed-off-by: Wei Yang >> CC: Mike Rapoport (IBM) >> --- >> scripts/mod/modpost.c | 10 ++++++++++ >> 1 file changed, 10 insertions(+) > > > >NACK. > > >The section mismatch is performed _unconditionally_. > > > >In the old days, we did this depending on relevant CONFIG options. >It was more than 15 years ago that we stopped doing that. > > >See this: > > >commit eb8f689046b857874e964463619f09df06d59fad >Author: Sam Ravnborg >Date: Sun Jan 20 20:07:28 2008 +0100 > > Use separate sections for __dev/__cpu/__mem code/data > > > > >So, if you wanted to check this only when CONFIG_MEMORY_HOTPLUG=n, >you would need to add #ifdef CONFIG_MEMORY_HOTPLUG to include/linux/init.h > You mean something like this? diff --git a/include/linux/init.h b/include/linux/init.h index 58cef4c2e59a..388f0a4c34e9 100644 --- a/include/linux/init.h +++ b/include/linux/init.h @@ -85,10 +85,12 @@ #define __exit __section(".exit.text") __exitused __cold notrace /* Used for MEMORY_HOTPLUG */ +#ifndef CONFIG_MEMORY_HOTPLUG #define __meminit __section(".meminit.text") __cold notrace \ __latent_entropy #define __meminitdata __section(".meminit.data") #define __meminitconst __section(".meminit.rodata") +#endif /* For assembly routines */ #define __HEAD .section ".head.text","ax" >That is what we did in the Linux 2.6.* era, which had much worse >section mismatch coverage. > I guess you mean this is not a good practice. Then I am confused how we do the mismatch check unconditionally? After commit commit eb8f689046b857874e964463619f09df06d59fad Author: Sam Ravnborg Date: Sun Jan 20 20:07:28 2008 +0100 Use separate sections for __dev/__cpu/__mem code/data Sections .meminit.* will be put into INIT_SECTION conditionally, but we always do the mismatch check unconditionally. It will report mismatch when .meminit.* is not in INIT_SECTION. It looks not correct to me. Maybe I am not fully understand your message. Would you mind explaining more on what is the correct way to do? -- Wei Yang Help you, Help me