From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 192F3C2BD09 for ; Thu, 4 Jul 2024 01:29:39 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 86E026B008C; Wed, 3 Jul 2024 21:29:38 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 800516B0092; Wed, 3 Jul 2024 21:29:38 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 66FF56B0093; Wed, 3 Jul 2024 21:29:38 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 429696B008C for ; Wed, 3 Jul 2024 21:29:38 -0400 (EDT) Received: from smtpin21.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id E78D4C0829 for ; Thu, 4 Jul 2024 01:29:37 +0000 (UTC) X-FDA: 82300337994.21.A99B612 Received: from mail-pg1-f175.google.com (mail-pg1-f175.google.com [209.85.215.175]) by imf11.hostedemail.com (Postfix) with ESMTP id 21B5040020 for ; Thu, 4 Jul 2024 01:29:34 +0000 (UTC) Authentication-Results: imf11.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=PA1l5rYu; spf=pass (imf11.hostedemail.com: domain of ioworker0@gmail.com designates 209.85.215.175 as permitted sender) smtp.mailfrom=ioworker0@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1720056550; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=en/S1K7ufPc3QQhnQIZMOSOA2N5wr5GPlScNLierXSU=; b=sVdzxFvGN3xPAC3eIYhY0WLw+XZj4jw5mtlq6MY5SC2gV0zfZYNp9Yoib+aL3xpUfH9xCt Iw0J/KSiCMPS9WqVhwal/ngtWH8sHrP92XfzwqPhLNGY4nnM37O9m27i5I4w9Oa18f9rOv 4AkcJt2NbiXZvO7Gl+8zzh+KXPTc4Qs= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1720056550; a=rsa-sha256; cv=none; b=fjbRQ/fa3iqBlEU/ig6PedJbzA+6p0BYvG/8E+JptlxpDCohR0V6/TD/6JOXjgGrS+Hmgu Q+JHis24LgIe+ABD/pI2n9Hai6z5nB0763RfiQIsPrBLb/4EBz/cAzlORqrVBkfBk/8U37 uvkUBFgvKYPL+g/cgbybCHCK6GpLvcs= ARC-Authentication-Results: i=1; imf11.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=PA1l5rYu; spf=pass (imf11.hostedemail.com: domain of ioworker0@gmail.com designates 209.85.215.175 as permitted sender) smtp.mailfrom=ioworker0@gmail.com; dmarc=pass (policy=none) header.from=gmail.com Received: by mail-pg1-f175.google.com with SMTP id 41be03b00d2f7-7201cb6cae1so42382a12.2 for ; Wed, 03 Jul 2024 18:29:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1720056574; x=1720661374; darn=kvack.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=en/S1K7ufPc3QQhnQIZMOSOA2N5wr5GPlScNLierXSU=; b=PA1l5rYu40xbrYFUi3vRBzegkkV/Av4mv2IQfDAr6lNtIJshFIdB/fejdq4QRNcYY0 fx1jaiZH0doowYNhsMo/eyVjDAs1LIFqxXZKZTRuW+NZzasJxrNn9rk5d2CdKVTp7jty BI3vskP0LGW3w6M+CLmauvHtp2LOTbVGjA7IpIU9N+PUz9/CeehJVfGBQxRK0bQW1MvP RXiSU+941CLrmpVHaz5GpEkXiwwh47muuvMJnrPh0BnZqcRrIM416+QX7NXZAnf1vOUk OspkwYhZwxinu9W/Hse6ha1mVv+dQmcJG2fu0w/a0HRAZt/mNtn6g69a2mQpMFpOc1BH 8S9Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1720056574; x=1720661374; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=en/S1K7ufPc3QQhnQIZMOSOA2N5wr5GPlScNLierXSU=; b=ejbtDqnlH62rEF6U2v0BKm8FpDAZsQMjY9idGH3SrGYG2HYX/WVNosEOL5zEOX1lJq PFUQ1jBfq2F/Ao8gfiAEVpCor59xijBTI0DY8azYeKak/kZFrmyhxYTcvrYfwkh9xKu4 oDmed/OLDr24z55LMyi/3GHS0DTkY/bsAWoHolFeE1hUw5vNviEMONnNiZy1fARKgHNb /Zn5tSmWLDH6q8UqUwpICrcClLeaRfQESorbTeM/38fYb3NHb4NE68Rz0QTUgRVbRLqn 9pA7uRnqF6wAevGaomFEGFrn7GRJKx6oyjD4ckQNNHzmA6fdzGdyMPbphyhOYnPlh3Q5 neNw== X-Forwarded-Encrypted: i=1; AJvYcCX9CGGuT1S9UJRv1UeWnOycVKFYpb32vLqpQYXTJpKNnzUCAeV12jBqt18g2mV/Up6qlXpUYw+fSX95LZoUtb7Mzl4= X-Gm-Message-State: AOJu0YxwMrMIMPwcRs3E8Zr0GKoPBfuT8WPpPE01rR48tiWznEmOlByd /vW4tmclcQ0inrXYJ5QqdlPF+Gv4sB5D0IRWeRcFNXNTQkzWJ/pb X-Google-Smtp-Source: AGHT+IH8h2nR3XKUpaLoYTVF/0kMtRKeMW80TtrbBrxF+W4lZJ6aIxPIG8j8eHodbQfKLiXVzHYJhw== X-Received: by 2002:a05:6a20:12d4:b0:1be:c3c1:7be8 with SMTP id adf61e73a8af0-1c0cc742f4amr152039637.26.1720056573824; Wed, 03 Jul 2024 18:29:33 -0700 (PDT) Received: from EBJ9932692.tcent.cn ([124.156.216.125]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-1fac153767dsm110162735ad.148.2024.07.03.18.29.29 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Wed, 03 Jul 2024 18:29:33 -0700 (PDT) From: Lance Yang To: akpm@linux-foundation.org Cc: dj456119@gmail.com, 21cnbao@gmail.com, ryan.roberts@arm.com, david@redhat.com, shy828301@gmail.com, ziy@nvidia.com, libang.li@antgroup.com, baolin.wang@linux.alibaba.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org, Lance Yang , Barry Song , Mingzhe Yang Subject: [PATCH v3 1/2] mm: add per-order mTHP split counters Date: Thu, 4 Jul 2024 09:29:04 +0800 Message-ID: <20240704012905.42971-2-ioworker0@gmail.com> X-Mailer: git-send-email 2.45.2 In-Reply-To: <20240704012905.42971-1-ioworker0@gmail.com> References: <20240704012905.42971-1-ioworker0@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Rspam-User: X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 21B5040020 X-Stat-Signature: zqdq1iwqb7tmgrruanrdogto3w771mf8 X-HE-Tag: 1720056574-507356 X-HE-Meta: U2FsdGVkX18Pm/TO5fDIDTVXar7K673Kuc6reXr3QNnTvIkaecTmAksZ+eUGipGfN6oUQmR5DC4rm6+boui1emu0EbmkoIDdwjI0K1kshpW3o4qkYXRajriA5sI0ZqEdusWoqu6pUo0fMfiOmg9hjUCfO3mU2ElCrHtpNGtcld2aBXyhJRxvqbike3gJK6/h6BmkrnAp/P8jFt1dIhdtiJT/9gWQn9SM4F7fzMBp7ULrZNEjmTt/ZMXhEzWthuWtJFDIWr44W5ENSJs7HVIiHWEvtrcbzlnZgbOzpc8VQTuEyZUcpScLuK4Preet459NvUTbB/p5mH0MIOB6SU+5NcAql/0nDM7QY+1AScl2S04FzOf0ZCHpLrqQ9se3xx76KPR4ueJlqHjsCukAgTnYZ/E3joA5U11cvOC7jGNCMY5QfFlpppOgDzeKNbPZYfQYc/40EgnkJRv0rzXnWdZE31xT+gp0cQBO4c1kACrnRUjXWvg4BmP/d2g1Dv3sW3fiPKJXHpl/mu0MtXvViMF0vjhOKy7j1aekoBPY+YkvG17E03Ep8/HqFH+OMT+RakdjWcr/vtgTrtKxPtMDlX02dGLBnhOE1YXkg3MXY6OTvkKZKCGyv0ny5kweDv6a6V5CjLFIjKXRKe1T527oB2O/N4jdnTQWbIOtMJnGOu3+D8il8aRsD/nIsyDhyu7uVMmG3ji0ZtgEcE57cGJ11IYEAj35PVEhUB32CxQjsgsDK2uv1eg2LW/s4DXWAakDexEJ8J2rQj+Je9HTPnIUoXEtA4K3vSje7OW2zdIQjuG3NBYO9kEslKF1NT72EDORFp1895Mkbgqb3+nYmMqKMnpl/W+YAXQ9q26bYpxcmC8FsN/0PxCqMPcgkOcXSbxuteBKE+Q4PWEvBbrKVJT7OT8x/yYu1quS5nzAuw4eFZRnkE0XWEMwoieP0OFoExO0VYF7fnYCBeiXpq5gOP+bawb tbGQCrxY 9g0PbjEq1MPxpucOw7BVop3yimmqoAU+YFH/HlIwWiJ1O0423Eybd+Hn6mZoc5ybahpooNmBuU30eVh/4v8o5VzMa0bBg3uvtguJ4vLGb0HzHqV6xIVT1ekH+OWvz4660sHLl6e8DZE0sn+Bx2+UnFAXDqbGKMVO3rUb6rse8lrBwMseRuBaAKriGpn+ZQFPpo/Xf8jI6tTf463JEa9hgpBO5B+teJwIkO4MozBCvsiCyGpiO/ruthXfWkavQuHATQ+++RHWqGjUsDOuLvD0t2E1EEx8Y6zf2EHHhEc/5IlSwOj86VkV907uoMV7Dk+SBl69edBtrBty9+HG1y9AS6mGlYc46jlxro7vP+Ltqt6YqetnN2L0UIIM7Apbsy9iD48vVJ4vTjNMKcWSZQ42oFVV2CWIwzj7OAE6lgZLV7AcTS10LWqGC9RgkZ170E6pUEweMTIAyH4UrLv4zigq/j+w4dRcsqzYHA+0NKwhYrui6x4tf1NFBWUg+/p2lzE9Tg5KI5yKTVPRafrE= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Currently, the split counters in THP statistics no longer include PTE-mapped mTHP. Therefore, we propose introducing per-order mTHP split counters to monitor the frequency of mTHP splits. This will help developers better analyze and optimize system performance. /sys/kernel/mm/transparent_hugepage/hugepages-/stats split split_failed split_deferred Reviewed-by: Ryan Roberts Reviewed-by: Baolin Wang Acked-by: Barry Song Signed-off-by: Mingzhe Yang Signed-off-by: Lance Yang --- include/linux/huge_mm.h | 3 +++ mm/huge_memory.c | 12 ++++++++++-- 2 files changed, 13 insertions(+), 2 deletions(-) diff --git a/include/linux/huge_mm.h b/include/linux/huge_mm.h index 212cca384d7e..cee3c5da8f0e 100644 --- a/include/linux/huge_mm.h +++ b/include/linux/huge_mm.h @@ -284,6 +284,9 @@ enum mthp_stat_item { MTHP_STAT_FILE_ALLOC, MTHP_STAT_FILE_FALLBACK, MTHP_STAT_FILE_FALLBACK_CHARGE, + MTHP_STAT_SPLIT, + MTHP_STAT_SPLIT_FAILED, + MTHP_STAT_SPLIT_DEFERRED, __MTHP_STAT_COUNT }; diff --git a/mm/huge_memory.c b/mm/huge_memory.c index 954c63575917..5cbd838e96e6 100644 --- a/mm/huge_memory.c +++ b/mm/huge_memory.c @@ -559,6 +559,9 @@ DEFINE_MTHP_STAT_ATTR(swpout_fallback, MTHP_STAT_SWPOUT_FALLBACK); DEFINE_MTHP_STAT_ATTR(file_alloc, MTHP_STAT_FILE_ALLOC); DEFINE_MTHP_STAT_ATTR(file_fallback, MTHP_STAT_FILE_FALLBACK); DEFINE_MTHP_STAT_ATTR(file_fallback_charge, MTHP_STAT_FILE_FALLBACK_CHARGE); +DEFINE_MTHP_STAT_ATTR(split, MTHP_STAT_SPLIT); +DEFINE_MTHP_STAT_ATTR(split_failed, MTHP_STAT_SPLIT_FAILED); +DEFINE_MTHP_STAT_ATTR(split_deferred, MTHP_STAT_SPLIT_DEFERRED); static struct attribute *stats_attrs[] = { &anon_fault_alloc_attr.attr, @@ -569,6 +572,9 @@ static struct attribute *stats_attrs[] = { &file_alloc_attr.attr, &file_fallback_attr.attr, &file_fallback_charge_attr.attr, + &split_attr.attr, + &split_failed_attr.attr, + &split_deferred_attr.attr, NULL, }; @@ -3068,7 +3074,7 @@ int split_huge_page_to_list_to_order(struct page *page, struct list_head *list, XA_STATE_ORDER(xas, &folio->mapping->i_pages, folio->index, new_order); struct anon_vma *anon_vma = NULL; struct address_space *mapping = NULL; - bool is_thp = folio_test_pmd_mappable(folio); + int order = folio_order(folio); int extra_pins, ret; pgoff_t end; bool is_hzp; @@ -3253,8 +3259,9 @@ int split_huge_page_to_list_to_order(struct page *page, struct list_head *list, i_mmap_unlock_read(mapping); out: xas_destroy(&xas); - if (is_thp) + if (order >= HPAGE_PMD_ORDER) count_vm_event(!ret ? THP_SPLIT_PAGE : THP_SPLIT_PAGE_FAILED); + count_mthp_stat(order, !ret ? MTHP_STAT_SPLIT : MTHP_STAT_SPLIT_FAILED); return ret; } @@ -3307,6 +3314,7 @@ void deferred_split_folio(struct folio *folio) if (list_empty(&folio->_deferred_list)) { if (folio_test_pmd_mappable(folio)) count_vm_event(THP_DEFERRED_SPLIT_PAGE); + count_mthp_stat(folio_order(folio), MTHP_STAT_SPLIT_DEFERRED); list_add_tail(&folio->_deferred_list, &ds_queue->split_queue); ds_queue->split_queue_len++; #ifdef CONFIG_MEMCG -- 2.45.2