From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7244DC2BD09 for ; Thu, 4 Jul 2024 01:52:59 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D8B046B009D; Wed, 3 Jul 2024 21:52:58 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D3A256B009E; Wed, 3 Jul 2024 21:52:58 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C016B6B009F; Wed, 3 Jul 2024 21:52:58 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id A411E6B009D for ; Wed, 3 Jul 2024 21:52:58 -0400 (EDT) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 27DEE1C0F65 for ; Thu, 4 Jul 2024 01:52:58 +0000 (UTC) X-FDA: 82300396836.01.DC03AB7 Received: from sin.source.kernel.org (sin.source.kernel.org [145.40.73.55]) by imf01.hostedemail.com (Postfix) with ESMTP id EC94B40020 for ; Thu, 4 Jul 2024 01:52:55 +0000 (UTC) Authentication-Results: imf01.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=FS1laYF4; dmarc=none; spf=pass (imf01.hostedemail.com: domain of akpm@linux-foundation.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1720057956; a=rsa-sha256; cv=none; b=t3lxNxEHFX8SfuMq5CaxsRPj1D/WEMW9ryshyU7UUYDr8wv9Lm8JswlDM2pDEKCMMNjtS/ k3SCcPSw6hUsUYYX8dFJwovWSNCONK5BG6wMNOdETPqB/WQCUP+uVcEkqiBCDia060adP1 PbFuNRMkL/jlbvRVWzmdbLlhrRUDg8A= ARC-Authentication-Results: i=1; imf01.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=FS1laYF4; dmarc=none; spf=pass (imf01.hostedemail.com: domain of akpm@linux-foundation.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1720057956; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=mfI0UgeKkyWbADYp6Oh2ZIPqh7QttgCs08n7uT2JJ0w=; b=rb00m3zytQV6CMuKMGmENw1LPuuIPl97AsyixhGzaqpIqI4U7AbrKN97E5f/niecu/x0yg 3+dFFMb+aEDmDSlqVTKgwk0A7HsHacYhvsZ0rkD2MN+TtgS3tatgT308nIVvzduq5GCXrC a3hCW1KOjegr+ATZ62DhVZnUxzGJQEA= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id D66EFCE2F21; Thu, 4 Jul 2024 01:52:52 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8F552C2BD10; Thu, 4 Jul 2024 01:52:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1720057971; bh=F2j2b220f0kH6ASBWQuxfwQDqDRaPBMclWh3MbAtpkY=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=FS1laYF4xPIP8MvziXSKpZ0B6nzToMKWGFhFUaAO0dDn+b2e83ijM0JDu4s7sn6WF Keh0h+ZN1nDmqnMrTmuAGIZEVpZ44oI6zMUFWRI5UFfFxoGdMxpR2l1wWLKGHeLA2z A/vtA0K97oQ3w7cLqXCiNT0JuLC5BSk1wuNlcP70= Date: Wed, 3 Jul 2024 18:52:50 -0700 From: Andrew Morton To: Roman Gushchin Cc: Shakeel Butt , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Johannes Weiner , Michal Hocko , Muchun Song Subject: Re: [PATCH] mm: memcg: move cgroup v1 oom handling code into memcontrol-v1.c: fixup Message-Id: <20240703185250.ab96286a5e4747665520ddb0@linux-foundation.org> In-Reply-To: <20240704002712.2077812-1-roman.gushchin@linux.dev> References: <20240704002712.2077812-1-roman.gushchin@linux.dev> X-Mailer: Sylpheed 3.8.0beta1 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: EC94B40020 X-Stat-Signature: tx8psriko9ofnqm5zcghdncsqqbwbiix X-Rspam-User: X-HE-Tag: 1720057975-989059 X-HE-Meta: U2FsdGVkX1/DMay+PPUeDbdEP3wJ9ZGvZHq/7OJkHWBiIk/Hee93MeToUAB/Axyq4400ApgQIo5ZoxNHOfnEj0hjN0BfUmO0Eo9kNmcfB16drFq8Cw4dDwx2x3v76M60KZ8dbe/1Pc5uCjrKw2St0BBeyXhEECbKrLJ4z7udd4CJST48c/xMZwpiDNNTAFdZH3wcWAASvH5qOl1cCadPy3ra6M8FSHdf4TGgpI06OTgxGJZcstZ7QMawBvpJQh1DnNCGFRY7ni8RjUJW8tzk8EJWtsxAS5/6o/1GZ6aAoWMZ7Kea93GYJKCIXXYcpEdLGTy0ZKrS0stpJPp655/K73cVFoavlablKxV0V/2wXcWxG2wkNLfbto6mO+wD/T3LKUgM3x3zpbpyQPrmwt0Q9jxmRL+6UTDEBDLqP+9NmwCcbP7nHGg5B2Z8tScsR2w+Xe+Rh8Sud6ZNfy9CSZXH928jt/dyt9x3gdtb+eVEeslGh9pM4HgcGyLWTde0bbffrZOByFuWIFT4wIkuMa6EQ26X/zZ3OXWiY0Bm1KqZCAqkB9WjR/PL+iOrCBQAtDT17jcxh+cfWcmyIYpbglI91ycVYW3qNpDnjAO6+eaa3Rpd3N4qPPHZGRqAU96sgzDSKmwPBhlj6dg7V1I9RHYSw9pVtKjhUg1Au25wAwjP4UW0nweUwWWD4IkAtOeXuNkjxTQ8hhfuUn1Cj+nQS1F4XvofUnRvOdazxdHb9RdzADp4mErO9yMux4EtWqkk0xNs1sWdBVOeKeUwuJ0r0883J/hWbEg9f6/njIeqwQaB8T+X9OlmsM82ARgJpd44I1EvjIFIOh+2I99Qdo/1wRWoomJjqqD2PSsm6Z4qgnMAL0NzJ4rqkIiyMNBc1NpeALhUksJD9zt/m5tc4rO+BzthFab6AJKTyE83NEePUTRzxtSp2bqIaJRVmgxJ8bRNoiV0J24rIKNWObaK56XsVQV AAYrAND8 XKH3njgr1AR61EzUqazMQKEGnH0MiANybcN3GqtVUVD6Qa1YBU4e3axXyNZvZkmRvhLDwmPILowUbTxn9THozb4GbzjYUGhQ86VGq2D/qi0ZzRl/o0efqIfQAF9tiTciwObg97F6mWw9OQGyJXizj4zzxZOFSDbGlBoioSG3NX6XJBVYj6+73UotBgPj9K1GE/r04zzoIdklsw7YIuppBYgvaAf4kCEFyFQ0v X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, 4 Jul 2024 00:27:12 +0000 Roman Gushchin wrote: > This is a small fixup for the commit > "mm: memcg: move cgroup v1 oom handling code into memcontrol-v1.c". > > I forgot to actually move two functions mem_cgroup_node_nr_lru_pages() > and mem_cgroup_nr_lru_pages() into mm/memcontrol-v1.c, so that they remain > in mm/memcontrol.c and their commented out duplicated versions in > mm/memcontrol-v1.c. > > Andrew, can you, please, squash it into the original commit? > Seems this wants to live behind "mm: memcg: move cgroup v1 interface files to memcontrol-v1.c" so that's where I placed it.