From: Andrew Morton <akpm@linux-foundation.org>
To: Roman Gushchin <roman.gushchin@linux.dev>
Cc: Shakeel Butt <shakeel.butt@linux.dev>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org,
Johannes Weiner <hannes@cmpxchg.org>,
Michal Hocko <mhocko@kernel.org>,
Muchun Song <muchun.song@linux.dev>
Subject: Re: [PATCH] mm: memcg: move cgroup v1 oom handling code into memcontrol-v1.c: fixup
Date: Wed, 3 Jul 2024 18:52:50 -0700 [thread overview]
Message-ID: <20240703185250.ab96286a5e4747665520ddb0@linux-foundation.org> (raw)
In-Reply-To: <20240704002712.2077812-1-roman.gushchin@linux.dev>
On Thu, 4 Jul 2024 00:27:12 +0000 Roman Gushchin <roman.gushchin@linux.dev> wrote:
> This is a small fixup for the commit
> "mm: memcg: move cgroup v1 oom handling code into memcontrol-v1.c".
>
> I forgot to actually move two functions mem_cgroup_node_nr_lru_pages()
> and mem_cgroup_nr_lru_pages() into mm/memcontrol-v1.c, so that they remain
> in mm/memcontrol.c and their commented out duplicated versions in
> mm/memcontrol-v1.c.
>
> Andrew, can you, please, squash it into the original commit?
>
Seems this wants to live behind "mm: memcg: move cgroup v1 interface
files to memcontrol-v1.c" so that's where I placed it.
next prev parent reply other threads:[~2024-07-04 1:52 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-04 0:27 Roman Gushchin
2024-07-04 1:52 ` Andrew Morton [this message]
2024-07-04 2:06 ` Roman Gushchin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240703185250.ab96286a5e4747665520ddb0@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=hannes@cmpxchg.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@kernel.org \
--cc=muchun.song@linux.dev \
--cc=roman.gushchin@linux.dev \
--cc=shakeel.butt@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox