From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A7274C2BD09 for ; Wed, 3 Jul 2024 05:16:24 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 3063C6B009F; Wed, 3 Jul 2024 01:16:24 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 2B5CE6B00A0; Wed, 3 Jul 2024 01:16:24 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1A5AD6B00A3; Wed, 3 Jul 2024 01:16:24 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id EF4B96B009F for ; Wed, 3 Jul 2024 01:16:23 -0400 (EDT) Received: from smtpin30.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 68EB3A07B7 for ; Wed, 3 Jul 2024 05:16:23 +0000 (UTC) X-FDA: 82297280646.30.7D41F49 Received: from verein.lst.de (verein.lst.de [213.95.11.211]) by imf09.hostedemail.com (Postfix) with ESMTP id 84A44140011 for ; Wed, 3 Jul 2024 05:16:21 +0000 (UTC) Authentication-Results: imf09.hostedemail.com; dkim=none; spf=pass (imf09.hostedemail.com: domain of hch@lst.de designates 213.95.11.211 as permitted sender) smtp.mailfrom=hch@lst.de; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1719983758; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=AGQFWr+dYG3ZSvFZrBhn1phFEcYhyS3xKE7tAUWJd8s=; b=juqCV5hl/TFnhiICoiT7atBQrXW7S0XY7ePSU8C799LIZwsVDZtjfcVnzqt0tXDrqwBeIJ Z93Xx5C94BiRLFLlZAg1ZAGo2Musa0DvUJR8WfieJY+R5pTsWiuTvKtKU1Me3y7E1kOEAB EnlhH3DwV3fqsXcw0NK9nyN9vV8J4rM= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1719983758; a=rsa-sha256; cv=none; b=v8im9/fCxvE9drn7ubo74gFtiXuQBLTmM7LlP0J8W3tbxgijINvZ87Jpfjc1DfqXk+Iuj/ TJ493rGL7FgvuwFn1NG6QmhDP4c39XuU+lwAErCStMauWE8kKCuXpEHirYcdPPwUax0WBE ip+NEShLLRf//6FSP3k7noC9K5gX4NE= ARC-Authentication-Results: i=1; imf09.hostedemail.com; dkim=none; spf=pass (imf09.hostedemail.com: domain of hch@lst.de designates 213.95.11.211 as permitted sender) smtp.mailfrom=hch@lst.de; dmarc=none Received: by verein.lst.de (Postfix, from userid 2407) id 788DD227A87; Wed, 3 Jul 2024 07:16:16 +0200 (CEST) Date: Wed, 3 Jul 2024 07:16:16 +0200 From: Christoph Hellwig To: "Pankaj Raghav (Samsung)" Cc: Matthew Wilcox , Christoph Hellwig , david@fromorbit.com, chandan.babu@oracle.com, djwong@kernel.org, brauner@kernel.org, akpm@linux-foundation.org, linux-kernel@vger.kernel.org, yang@os.amperecomputing.com, linux-mm@kvack.org, john.g.garry@oracle.com, linux-fsdevel@vger.kernel.org, hare@suse.de, p.raghav@samsung.com, mcgrof@kernel.org, gost.dev@samsung.com, cl@os.amperecomputing.com, linux-xfs@vger.kernel.org, Zi Yan Subject: Re: [PATCH v8 06/10] iomap: fix iomap_dio_zero() for fs bs > system page size Message-ID: <20240703051616.GA25052@lst.de> References: <20240625114420.719014-1-kernel@pankajraghav.com> <20240625114420.719014-7-kernel@pankajraghav.com> <20240702074203.GA29410@lst.de> <20240702101556.jdi5anyr3v5zngnv@quentin> <20240702120250.GA17373@lst.de> <20240702140123.emt2gz5kbigth2en@quentin> <20240702154216.GA1037@lst.de> <20240702161329.i4w6ipfs7jg5rpwx@quentin> <20240702171014.reknnw3smasylbtc@quentin> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240702171014.reknnw3smasylbtc@quentin> User-Agent: Mutt/1.5.17 (2007-11-01) X-Stat-Signature: aof1rgqfjyp3kj13fknfrsfsr1td6jeb X-Rspamd-Queue-Id: 84A44140011 X-Rspam-User: X-Rspamd-Server: rspam08 X-HE-Tag: 1719983781-759169 X-HE-Meta: U2FsdGVkX18cZ9nL4zPEhEBk+qV4B3XOixt6uOUQHDh3A6beEs8g/hAE/5INDk52hATVxnsflGsVQG7AAs1tQ5psxEk7qxbMDZxcX/Y0/b84pEwLPiWeEbZUNx6TSQTlU6kHqCe9Vp7aDC+CWNswLXIAH6FmD0lpHIFPPZNHUfTdVjSfcX9wXZ5QX1yiJ1AS9LwQVR/FMrIFLvrelqPMoV8OUBLBKJtYWxWsNZjY/QDBnn4HCBAuLTOhvm9mu8KZ/S4sUSCV6Vwjbwumn/ZJU+rotAAUHuLvf4vrJatuIUSFrIk9q7AXZNS2vDMo+k0f5+QmdFgFlv8u3KHtsSFEI/EcLyhfD9O8WXRqBRU76FWWfPpAts/KABTSyGHlaKNLz9BdN6euXWj4aRcTX55j8VCLQFvNxvujOBeCGJFzV4dYtzW7AseDgU+4m3oHYICDrCFLxjQg/uB/BEr2VGNYZZfG/YAC8A9nXVuV7+Ij7iiqUmxdcjtX21w4D9Qh1VolUJ99A2OvRYC6k6sh007g92Thi1yzNVKJKAdhCGv1E67Ji0sNr7HVyWaNOMUBEjC1ssCoxzypuyuUVFUzW88lm8PG5MWu+B8a79B3+hudekOtkMhopKwgKbLtQoog6/L0NBMNQRGUVcPhTj79xttqM4QZvOVVS15PIlbkGIA822UMJtIVS4TiPjxTs/DGXhN8lsO944Ii+UwoCHjon3L0uKbOjnQggyelAWGjcIxhnFSBlVRkJIqcQr+gZOFbJ4++zRtIWRrO6a/27WK0zJENhcVbjqe2Rt92FHAOfz1GVeo9vriLtuHP2tkf5lPrsflGbMbz4bz7FVGA9f1fiHEYGgdBcQyul+BWFGhncjM0NSmHRANrTqPDZpocKYyIs3d7mJEUZbRrqY6rdHiS9YRwY0c766DyR6MvPiLykShr5xz6wIlM2U7yAXmhBFVfTprlM0AspITPfYkiKZz6GEr zejdp7hQ bjivmOo+lz7wj3VBJtUyGdBk+KLNChdHJDXr64QOEc3vQ1oJA2dRavk9Ncq84tSNobLGRDrBMFB9kPFLDJJyBwps7wRWFQrN4b0iojO7rp0pLgW6IPxo66ODfXA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Jul 02, 2024 at 05:10:14PM +0000, Pankaj Raghav (Samsung) wrote: > > > Yes, I will rename it to ZERO_PAGE_SZ_64K as you suggested. > > > > No. It needs a symbolic name that doesn't include the actual size. > > Maybe ZERO_PAGE_IO_MAX. Christoph suggested using SZ_64K to define > > it, not to include it in the name. > > Initially I kept the name as ZERO_FSB_PAGE as it is used to do sub-block > zeroing. But I know John from Oracle is already working on using it for > rt extent zeroing. So I will just go with ZERO_PAGE_IO_MAX for now. > Understood about the SZ_64K part. Thanks for the clarification. IOMAP_ZERO_PAGE_SIZE ? (I kind regret not going for just adding zero page as originally suggested, but then we'd keep arguing about the nr_vecs sizing and naming :))