[PATCH v3 1/3] mm/memblock: introduce a new helper memblock_estimated_nr_pages()

[PATCH v3 1/3] mm/memblock: introduce a new helper memblock_estimated_nr_pages()

[Wei Yang]

Instead of using raw memblock api, we wrap a new helper for user.

Signed-off-by: Wei Yang <richard.weiyang@gmail.com>
---
 include/linux/memblock.h |  1 +
 mm/memblock.c            | 19 +++++++++++++++++++
 2 files changed, 20 insertions(+)

diff --git a/include/linux/memblock.h b/include/linux/memblock.h
index 40c62aca36ec..7d1c32b3dc12 100644
--- a/include/linux/memblock.h
+++ b/include/linux/memblock.h
@@ -486,6 +486,7 @@ static inline __init_memblock bool memblock_bottom_up(void)
 
 phys_addr_t memblock_phys_mem_size(void);
 phys_addr_t memblock_reserved_size(void);
+unsigned long memblock_estimated_nr_pages(void);
 phys_addr_t memblock_start_of_DRAM(void);
 phys_addr_t memblock_end_of_DRAM(void);
 void memblock_enforce_memory_limit(phys_addr_t memory_limit);
diff --git a/mm/memblock.c b/mm/memblock.c
index e81fb68f7f88..c1f1aac0459f 100644
--- a/mm/memblock.c
+++ b/mm/memblock.c
@@ -1729,6 +1729,25 @@ phys_addr_t __init_memblock memblock_reserved_size(void)
 	return memblock.reserved.total_size;
 }
 
+/**
+ * memblock_estimated_nr_pages - return number of pages from memblock point of
+ * view
+ *
+ * During bootup, system may need number of pages in the whole system to do
+ * some calculation before all pages are freed to buddy system, especially
+ * when CONFIG_DEFERRED_STRUCT_PAGE_INIT is enabled.
+ *
+ * At this point, we can get this information from memblock. Since the system
+ * state is not settle down and address alignment, the value is an estimation.
+ *
+ * Return:
+ * An estimated number of pages from memblock point of view.
+ */
+unsigned long __init memblock_estimated_nr_pages(void)
+{
+	return PHYS_PFN(memblock_phys_mem_size() - memblock_reserved_size());
+}
+
 /* lowest address */
 phys_addr_t __init_memblock memblock_start_of_DRAM(void)
 {
-- 
2.34.1

[PATCH v3 2/3] kernel/fork.c: get totalram_pages from memblock to calculate max_threads

[Wei Yang]

Since we plan to move the accounting into __free_pages_core(),
totalram_pages may not represent the total usable pages on system
at this point when defer_init is enabled.

Instead we can get the total estimated pages from memblock directly.

Signed-off-by: Wei Yang <richard.weiyang@gmail.com>
CC: Mike Rapoport (IBM) <rppt@kernel.org>
CC: David Hildenbrand <david@redhat.com>
CC: Oleg Nesterov <oleg@redhat.com>
---
 kernel/fork.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/kernel/fork.c b/kernel/fork.c
index 99076dbe27d8..e80e889543f3 100644
--- a/kernel/fork.c
+++ b/kernel/fork.c
@@ -44,6 +44,7 @@
 #include <linux/fs.h>
 #include <linux/mm.h>
 #include <linux/mm_inline.h>
+#include <linux/memblock.h>
 #include <linux/nsproxy.h>
 #include <linux/capability.h>
 #include <linux/cpu.h>
@@ -999,7 +1000,7 @@ void __init __weak arch_task_cache_init(void) { }
 static void set_max_threads(unsigned int max_threads_suggested)
 {
 	u64 threads;
-	unsigned long nr_pages = totalram_pages();
+	unsigned long nr_pages = memblock_estimated_nr_pages();
 
 	/*
 	 * The number of threads shall be limited such that the thread
-- 
2.34.1

[PATCH v3 3/3] kernel/fork.c: put set_max_threads()/task_struct_whitelist() in __init section

[Wei Yang]

Function set_max_threads()/task_struct_whitelist() is only used by
fork_init() during bootup.

Let's add __init tag to them.

Signed-off-by: Wei Yang <richard.weiyang@gmail.com>
Suggested-by: Oleg Nesterov <oleg@redhat.com>
---
 kernel/fork.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/kernel/fork.c b/kernel/fork.c
index e80e889543f3..da0b4545d380 100644
--- a/kernel/fork.c
+++ b/kernel/fork.c
@@ -997,7 +997,7 @@ void __init __weak arch_task_cache_init(void) { }
 /*
  * set_max_threads
  */
-static void set_max_threads(unsigned int max_threads_suggested)
+static void __init set_max_threads(unsigned int max_threads_suggested)
 {
 	u64 threads;
 	unsigned long nr_pages = memblock_estimated_nr_pages();
@@ -1023,7 +1023,7 @@ static void set_max_threads(unsigned int max_threads_suggested)
 int arch_task_struct_size __read_mostly;
 #endif
 
-static void task_struct_whitelist(unsigned long *offset, unsigned long *size)
+static void __init task_struct_whitelist(unsigned long *offset, unsigned long *size)
 {
 	/* Fetch thread_struct whitelist for the architecture. */
 	arch_thread_struct_whitelist(offset, size);
-- 
2.34.1

Re: [PATCH v3 1/3] mm/memblock: introduce a new helper memblock_estimated_nr_pages()

[Mike Rapoport]

On Wed, Jul 03, 2024 at 12:51:49AM +0000, Wei Yang wrote:
> Instead of using raw memblock api, we wrap a new helper for user.

The changelog should be more elaborate and explain why this function is
needed.
 
> Signed-off-by: Wei Yang <richard.weiyang@gmail.com>
> ---
>  include/linux/memblock.h |  1 +
>  mm/memblock.c            | 19 +++++++++++++++++++
>  2 files changed, 20 insertions(+)
> 
> diff --git a/include/linux/memblock.h b/include/linux/memblock.h
> index 40c62aca36ec..7d1c32b3dc12 100644
> --- a/include/linux/memblock.h
> +++ b/include/linux/memblock.h
> @@ -486,6 +486,7 @@ static inline __init_memblock bool memblock_bottom_up(void)
>  
>  phys_addr_t memblock_phys_mem_size(void);
>  phys_addr_t memblock_reserved_size(void);
> +unsigned long memblock_estimated_nr_pages(void);
>  phys_addr_t memblock_start_of_DRAM(void);
>  phys_addr_t memblock_end_of_DRAM(void);
>  void memblock_enforce_memory_limit(phys_addr_t memory_limit);
> diff --git a/mm/memblock.c b/mm/memblock.c
> index e81fb68f7f88..c1f1aac0459f 100644
> --- a/mm/memblock.c
> +++ b/mm/memblock.c
> @@ -1729,6 +1729,25 @@ phys_addr_t __init_memblock memblock_reserved_size(void)
>  	return memblock.reserved.total_size;
>  }
>  
> +/**
> + * memblock_estimated_nr_pages - return number of pages from memblock point of
> + * view

This function returns the estimate for free pages, not the number of pages
in RAM.

How about memblock_estimated_nr_free_pages()?

> + * some calculation before all pages are freed to buddy system, especially
> + * when CONFIG_DEFERRED_STRUCT_PAGE_INIT is enabled.

I'm failing to parse this sentence. The return value here won't depend on
CONFIG_DEFERRED_STRUCT_PAGE_INIT.

> + *
> + * At this point, we can get this information from memblock. Since the system
> + * state is not settle down and address alignment, the value is an estimation.
> + *
> + * Return:
> + * An estimated number of pages from memblock point of view.

                            ^ free

> + */
> +unsigned long __init memblock_estimated_nr_pages(void)
> +{
> +	return PHYS_PFN(memblock_phys_mem_size() - memblock_reserved_size());
> +}
> +
>  /* lowest address */
>  phys_addr_t __init_memblock memblock_start_of_DRAM(void)
>  {
> -- 
> 2.34.1
> 

-- 
Sincerely yours,
Mike.

Re: [PATCH v3 1/3] mm/memblock: introduce a new helper memblock_estimated_nr_pages()

[David Hildenbrand]

On 05.07.24 11:09, Mike Rapoport wrote:
> On Wed, Jul 03, 2024 at 12:51:49AM +0000, Wei Yang wrote:
>> Instead of using raw memblock api, we wrap a new helper for user.
> 
> The changelog should be more elaborate and explain why this function is
> needed.
>   
>> Signed-off-by: Wei Yang <richard.weiyang@gmail.com>
>> ---
>>   include/linux/memblock.h |  1 +
>>   mm/memblock.c            | 19 +++++++++++++++++++
>>   2 files changed, 20 insertions(+)
>>
>> diff --git a/include/linux/memblock.h b/include/linux/memblock.h
>> index 40c62aca36ec..7d1c32b3dc12 100644
>> --- a/include/linux/memblock.h
>> +++ b/include/linux/memblock.h
>> @@ -486,6 +486,7 @@ static inline __init_memblock bool memblock_bottom_up(void)
>>   
>>   phys_addr_t memblock_phys_mem_size(void);
>>   phys_addr_t memblock_reserved_size(void);
>> +unsigned long memblock_estimated_nr_pages(void);
>>   phys_addr_t memblock_start_of_DRAM(void);
>>   phys_addr_t memblock_end_of_DRAM(void);
>>   void memblock_enforce_memory_limit(phys_addr_t memory_limit);
>> diff --git a/mm/memblock.c b/mm/memblock.c
>> index e81fb68f7f88..c1f1aac0459f 100644
>> --- a/mm/memblock.c
>> +++ b/mm/memblock.c
>> @@ -1729,6 +1729,25 @@ phys_addr_t __init_memblock memblock_reserved_size(void)
>>   	return memblock.reserved.total_size;
>>   }
>>   
>> +/**
>> + * memblock_estimated_nr_pages - return number of pages from memblock point of
>> + * view
> 
> This function returns the estimate for free pages, not the number of pages
> in RAM.
> 
> How about memblock_estimated_nr_free_pages()?

I was just about to comment exactly that. Agreed!

-- 
Cheers,

David / dhildenb

Re: [PATCH v3 1/3] mm/memblock: introduce a new helper memblock_estimated_nr_pages()

[Wei Yang]

On Fri, Jul 05, 2024 at 12:09:48PM +0300, Mike Rapoport wrote:
>On Wed, Jul 03, 2024 at 12:51:49AM +0000, Wei Yang wrote:
>> Instead of using raw memblock api, we wrap a new helper for user.
>
>The changelog should be more elaborate and explain why this function is
>needed.
> 
>> Signed-off-by: Wei Yang <richard.weiyang@gmail.com>
>> ---
>>  include/linux/memblock.h |  1 +
>>  mm/memblock.c            | 19 +++++++++++++++++++
>>  2 files changed, 20 insertions(+)
>> 
>> diff --git a/include/linux/memblock.h b/include/linux/memblock.h
>> index 40c62aca36ec..7d1c32b3dc12 100644
>> --- a/include/linux/memblock.h
>> +++ b/include/linux/memblock.h
>> @@ -486,6 +486,7 @@ static inline __init_memblock bool memblock_bottom_up(void)
>>  
>>  phys_addr_t memblock_phys_mem_size(void);
>>  phys_addr_t memblock_reserved_size(void);
>> +unsigned long memblock_estimated_nr_pages(void);
>>  phys_addr_t memblock_start_of_DRAM(void);
>>  phys_addr_t memblock_end_of_DRAM(void);
>>  void memblock_enforce_memory_limit(phys_addr_t memory_limit);
>> diff --git a/mm/memblock.c b/mm/memblock.c
>> index e81fb68f7f88..c1f1aac0459f 100644
>> --- a/mm/memblock.c
>> +++ b/mm/memblock.c
>> @@ -1729,6 +1729,25 @@ phys_addr_t __init_memblock memblock_reserved_size(void)
>>  	return memblock.reserved.total_size;
>>  }
>>  
>> +/**
>> + * memblock_estimated_nr_pages - return number of pages from memblock point of
>> + * view
>
>This function returns the estimate for free pages, not the number of pages
>in RAM.
>
>How about memblock_estimated_nr_free_pages()?
>
>> + * some calculation before all pages are freed to buddy system, especially
>> + * when CONFIG_DEFERRED_STRUCT_PAGE_INIT is enabled.
>
>I'm failing to parse this sentence. The return value here won't depend on
>CONFIG_DEFERRED_STRUCT_PAGE_INIT.
>
>> + *
>> + * At this point, we can get this information from memblock. Since the system
>> + * state is not settle down and address alignment, the value is an estimation.
>> + *
>> + * Return:
>> + * An estimated number of pages from memblock point of view.
>
>                            ^ free
>
>> + */
>> +unsigned long __init memblock_estimated_nr_pages(void)
>> +{
>> +	return PHYS_PFN(memblock_phys_mem_size() - memblock_reserved_size());
>> +}
>> +
>>  /* lowest address */
>>  phys_addr_t __init_memblock memblock_start_of_DRAM(void)
>>  {
>> -- 
>> 2.34.1
>> 

Thanks for review. Is this one looks better?

Subject: [PATCH] mm/memblock: introduce a new helper memblock_estimated_nr_free_pages()

During bootup, system may need the number of free pages in the whole system
to do some calculation before all pages are freed to buddy system. Usually
this number is get from totalram_pages(). Since we plan to move the free
pages accounting in __free_pages_core(), this value may not represent
total free pages at the early stage, especially when
CONFIG_DEFERRED_STRUCT_PAGE_INIT is enabled.

Instead of using raw memblock api, let's introduce a new helper for user
to get the estimated number of free pages from memblock point of view.

Signed-off-by: Wei Yang <richard.weiyang@gmail.com>
CC: David Hildenbrand <david@redhat.com>
---
 include/linux/memblock.h |  1 +
 mm/memblock.c            | 22 ++++++++++++++++++++++
 2 files changed, 23 insertions(+)

diff --git a/include/linux/memblock.h b/include/linux/memblock.h
index 40c62aca36ec..7d1c32b3dc12 100644
--- a/include/linux/memblock.h
+++ b/include/linux/memblock.h
@@ -486,6 +486,7 @@ static inline __init_memblock bool memblock_bottom_up(void)
 
 phys_addr_t memblock_phys_mem_size(void);
 phys_addr_t memblock_reserved_size(void);
+unsigned long memblock_estimated_nr_pages(void);
 phys_addr_t memblock_start_of_DRAM(void);
 phys_addr_t memblock_end_of_DRAM(void);
 void memblock_enforce_memory_limit(phys_addr_t memory_limit);
diff --git a/mm/memblock.c b/mm/memblock.c
index e81fb68f7f88..00decc42e02b 100644
--- a/mm/memblock.c
+++ b/mm/memblock.c
@@ -1729,6 +1729,28 @@ phys_addr_t __init_memblock memblock_reserved_size(void)
 	return memblock.reserved.total_size;
 }
 
+/**
+ * memblock_estimated_nr_free_pages - return estimated number of free pages
+ * from memblock point of view
+ *
+ * During bootup, system may need the number of free pages in the whole system
+ * to do some calculation before all pages are freed to buddy system. Usually
+ * this number is get from totalram_pages(). Since we plan to move the free
+ * pages accounting in __free_pages_core(), this value may not represent total
+ * free pages at the early stage, especially when
+ * CONFIG_DEFERRED_STRUCT_PAGE_INIT is enabled.
+ *
+ * While we can get the estimated number of free pages from memblock, which is
+ * good enough for the calculation.
+ *
+ * Return:
+ * An estimated number of free pages from memblock point of view.
+ */
+unsigned long __init memblock_estimated_nr_free_pages(void)
+{
+	return PHYS_PFN(memblock_phys_mem_size() - memblock_reserved_size());
+}
+
 /* lowest address */
 phys_addr_t __init_memblock memblock_start_of_DRAM(void)
 {
-- 
2.34.1


-- 
Wei Yang
Help you, Help me

Re: [PATCH v3 1/3] mm/memblock: introduce a new helper memblock_estimated_nr_pages()

[David Hildenbrand]

On 06.07.24 03:28, Wei Yang wrote:
> On Fri, Jul 05, 2024 at 12:09:48PM +0300, Mike Rapoport wrote:
>> On Wed, Jul 03, 2024 at 12:51:49AM +0000, Wei Yang wrote:
>>> Instead of using raw memblock api, we wrap a new helper for user.
>>
>> The changelog should be more elaborate and explain why this function is
>> needed.
>>
>>> Signed-off-by: Wei Yang <richard.weiyang@gmail.com>
>>> ---
>>>   include/linux/memblock.h |  1 +
>>>   mm/memblock.c            | 19 +++++++++++++++++++
>>>   2 files changed, 20 insertions(+)
>>>
>>> diff --git a/include/linux/memblock.h b/include/linux/memblock.h
>>> index 40c62aca36ec..7d1c32b3dc12 100644
>>> --- a/include/linux/memblock.h
>>> +++ b/include/linux/memblock.h
>>> @@ -486,6 +486,7 @@ static inline __init_memblock bool memblock_bottom_up(void)
>>>   
>>>   phys_addr_t memblock_phys_mem_size(void);
>>>   phys_addr_t memblock_reserved_size(void);
>>> +unsigned long memblock_estimated_nr_pages(void);
>>>   phys_addr_t memblock_start_of_DRAM(void);
>>>   phys_addr_t memblock_end_of_DRAM(void);
>>>   void memblock_enforce_memory_limit(phys_addr_t memory_limit);
>>> diff --git a/mm/memblock.c b/mm/memblock.c
>>> index e81fb68f7f88..c1f1aac0459f 100644
>>> --- a/mm/memblock.c
>>> +++ b/mm/memblock.c
>>> @@ -1729,6 +1729,25 @@ phys_addr_t __init_memblock memblock_reserved_size(void)
>>>   	return memblock.reserved.total_size;
>>>   }
>>>   
>>> +/**
>>> + * memblock_estimated_nr_pages - return number of pages from memblock point of
>>> + * view
>>
>> This function returns the estimate for free pages, not the number of pages
>> in RAM.
>>
>> How about memblock_estimated_nr_free_pages()?
>>
>>> + * some calculation before all pages are freed to buddy system, especially
>>> + * when CONFIG_DEFERRED_STRUCT_PAGE_INIT is enabled.
>>
>> I'm failing to parse this sentence. The return value here won't depend on
>> CONFIG_DEFERRED_STRUCT_PAGE_INIT.
>>
>>> + *
>>> + * At this point, we can get this information from memblock. Since the system
>>> + * state is not settle down and address alignment, the value is an estimation.
>>> + *
>>> + * Return:
>>> + * An estimated number of pages from memblock point of view.
>>
>>                             ^ free
>>
>>> + */
>>> +unsigned long __init memblock_estimated_nr_pages(void)
>>> +{
>>> +	return PHYS_PFN(memblock_phys_mem_size() - memblock_reserved_size());
>>> +}
>>> +
>>>   /* lowest address */
>>>   phys_addr_t __init_memblock memblock_start_of_DRAM(void)
>>>   {
>>> -- 
>>> 2.34.1
>>>
> 
> Thanks for review. Is this one looks better?
> 
> Subject: [PATCH] mm/memblock: introduce a new helper memblock_estimated_nr_free_pages()
> 
> During bootup, system may need the number of free pages in the whole system
> to do some calculation before all pages are freed to buddy system. Usually
> this number is get from totalram_pages(). Since we plan to move the free
> pages accounting in __free_pages_core(), this value may not represent
> total free pages at the early stage, especially when
> CONFIG_DEFERRED_STRUCT_PAGE_INIT is enabled.
> 
> Instead of using raw memblock api, let's introduce a new helper for user
> to get the estimated number of free pages from memblock point of view.
> 
> Signed-off-by: Wei Yang <richard.weiyang@gmail.com>
> CC: David Hildenbrand <david@redhat.com>
> ---
>   include/linux/memblock.h |  1 +
>   mm/memblock.c            | 22 ++++++++++++++++++++++
>   2 files changed, 23 insertions(+)
> 
> diff --git a/include/linux/memblock.h b/include/linux/memblock.h
> index 40c62aca36ec..7d1c32b3dc12 100644
> --- a/include/linux/memblock.h
> +++ b/include/linux/memblock.h
> @@ -486,6 +486,7 @@ static inline __init_memblock bool memblock_bottom_up(void)
>   
>   phys_addr_t memblock_phys_mem_size(void);
>   phys_addr_t memblock_reserved_size(void);
> +unsigned long memblock_estimated_nr_pages(void);
>   phys_addr_t memblock_start_of_DRAM(void);
>   phys_addr_t memblock_end_of_DRAM(void);
>   void memblock_enforce_memory_limit(phys_addr_t memory_limit);
> diff --git a/mm/memblock.c b/mm/memblock.c
> index e81fb68f7f88..00decc42e02b 100644
> --- a/mm/memblock.c
> +++ b/mm/memblock.c
> @@ -1729,6 +1729,28 @@ phys_addr_t __init_memblock memblock_reserved_size(void)
>   	return memblock.reserved.total_size;
>   }
>   
> +/**
> + * memblock_estimated_nr_free_pages - return estimated number of free pages
> + * from memblock point of view
> + *
> + * During bootup, system may need the number of free pages in the whole system
> + * to do some calculation before all pages are freed to buddy system. Usually
> + * this number is get from totalram_pages(). Since we plan to move the free
> + * pages accounting in __free_pages_core(), this value may not represent total
> + * free pages at the early stage, especially when > + * CONFIG_DEFERRED_STRUCT_PAGE_INIT is enabled.

These historical details should be dropped. "Since we plan ..." will 
easily get outdated soon.

* During bootup, subsystems might need a rough estimate of the number of 
* free pages in the whole system, before precise numbers are available
* from the buddy. Especially with CONFIG_DEFERRED_STRUCT_PAGE_INIT, the
* numbers obtained from the buddy might be very imprecise during bootup.

?

Reviewed-by: David Hildenbrand <david@redhat.com>

-- 
Cheers,

David / dhildenb

Re: [PATCH v3 1/3] mm/memblock: introduce a new helper memblock_estimated_nr_pages()

[Wei Yang]

On Sun, Jul 07, 2024 at 09:03:05PM +0200, Oleg Nesterov wrote:
>As I have already said, I can't review this patch.
>
>But I am curious, why set_max_threads() is the only user of the new helper?
>Say, should files_maxfiles_init() use it too or not? Perhaps the changelog
>can explain this?
>

files_maxfiles_init() is called in two places:

  * vfs_caches_init()
  * page_alloc_init_late()

And in page_alloc_init_late(), it is called after deferred_init_memmap(). This
means the totalram_pages() here return the real free pages at this point. So
it is not necessary to touch it now.

>Thanks,
>
>Oleg.
>
>On 07/07, David Hildenbrand wrote:
>>
>> On 06.07.24 03:28, Wei Yang wrote:
>> >On Fri, Jul 05, 2024 at 12:09:48PM +0300, Mike Rapoport wrote:
>> >>On Wed, Jul 03, 2024 at 12:51:49AM +0000, Wei Yang wrote:
>> >>>Instead of using raw memblock api, we wrap a new helper for user.
>> >>
>> >>The changelog should be more elaborate and explain why this function is
>> >>needed.
>> >>
>> >>>Signed-off-by: Wei Yang <richard.weiyang@gmail.com>
>> >>>---
>> >>>  include/linux/memblock.h |  1 +
>> >>>  mm/memblock.c            | 19 +++++++++++++++++++
>> >>>  2 files changed, 20 insertions(+)
>> >>>
>> >>>diff --git a/include/linux/memblock.h b/include/linux/memblock.h
>> >>>index 40c62aca36ec..7d1c32b3dc12 100644
>> >>>--- a/include/linux/memblock.h
>> >>>+++ b/include/linux/memblock.h
>> >>>@@ -486,6 +486,7 @@ static inline __init_memblock bool memblock_bottom_up(void)
>> >>>  phys_addr_t memblock_phys_mem_size(void);
>> >>>  phys_addr_t memblock_reserved_size(void);
>> >>>+unsigned long memblock_estimated_nr_pages(void);
>> >>>  phys_addr_t memblock_start_of_DRAM(void);
>> >>>  phys_addr_t memblock_end_of_DRAM(void);
>> >>>  void memblock_enforce_memory_limit(phys_addr_t memory_limit);
>> >>>diff --git a/mm/memblock.c b/mm/memblock.c
>> >>>index e81fb68f7f88..c1f1aac0459f 100644
>> >>>--- a/mm/memblock.c
>> >>>+++ b/mm/memblock.c
>> >>>@@ -1729,6 +1729,25 @@ phys_addr_t __init_memblock memblock_reserved_size(void)
>> >>>  	return memblock.reserved.total_size;
>> >>>  }
>> >>>+/**
>> >>>+ * memblock_estimated_nr_pages - return number of pages from memblock point of
>> >>>+ * view
>> >>
>> >>This function returns the estimate for free pages, not the number of pages
>> >>in RAM.
>> >>
>> >>How about memblock_estimated_nr_free_pages()?
>> >>
>> >>>+ * some calculation before all pages are freed to buddy system, especially
>> >>>+ * when CONFIG_DEFERRED_STRUCT_PAGE_INIT is enabled.
>> >>
>> >>I'm failing to parse this sentence. The return value here won't depend on
>> >>CONFIG_DEFERRED_STRUCT_PAGE_INIT.
>> >>
>> >>>+ *
>> >>>+ * At this point, we can get this information from memblock. Since the system
>> >>>+ * state is not settle down and address alignment, the value is an estimation.
>> >>>+ *
>> >>>+ * Return:
>> >>>+ * An estimated number of pages from memblock point of view.
>> >>
>> >>                            ^ free
>> >>
>> >>>+ */
>> >>>+unsigned long __init memblock_estimated_nr_pages(void)
>> >>>+{
>> >>>+	return PHYS_PFN(memblock_phys_mem_size() - memblock_reserved_size());
>> >>>+}
>> >>>+
>> >>>  /* lowest address */
>> >>>  phys_addr_t __init_memblock memblock_start_of_DRAM(void)
>> >>>  {
>> >>>-- 
>> >>>2.34.1
>> >>>
>> >
>> >Thanks for review. Is this one looks better?
>> >
>> >Subject: [PATCH] mm/memblock: introduce a new helper memblock_estimated_nr_free_pages()
>> >
>> >During bootup, system may need the number of free pages in the whole system
>> >to do some calculation before all pages are freed to buddy system. Usually
>> >this number is get from totalram_pages(). Since we plan to move the free
>> >pages accounting in __free_pages_core(), this value may not represent
>> >total free pages at the early stage, especially when
>> >CONFIG_DEFERRED_STRUCT_PAGE_INIT is enabled.
>> >
>> >Instead of using raw memblock api, let's introduce a new helper for user
>> >to get the estimated number of free pages from memblock point of view.
>> >
>> >Signed-off-by: Wei Yang <richard.weiyang@gmail.com>
>> >CC: David Hildenbrand <david@redhat.com>
>> >---
>> >  include/linux/memblock.h |  1 +
>> >  mm/memblock.c            | 22 ++++++++++++++++++++++
>> >  2 files changed, 23 insertions(+)
>> >
>> >diff --git a/include/linux/memblock.h b/include/linux/memblock.h
>> >index 40c62aca36ec..7d1c32b3dc12 100644
>> >--- a/include/linux/memblock.h
>> >+++ b/include/linux/memblock.h
>> >@@ -486,6 +486,7 @@ static inline __init_memblock bool memblock_bottom_up(void)
>> >  phys_addr_t memblock_phys_mem_size(void);
>> >  phys_addr_t memblock_reserved_size(void);
>> >+unsigned long memblock_estimated_nr_pages(void);
>> >  phys_addr_t memblock_start_of_DRAM(void);
>> >  phys_addr_t memblock_end_of_DRAM(void);
>> >  void memblock_enforce_memory_limit(phys_addr_t memory_limit);
>> >diff --git a/mm/memblock.c b/mm/memblock.c
>> >index e81fb68f7f88..00decc42e02b 100644
>> >--- a/mm/memblock.c
>> >+++ b/mm/memblock.c
>> >@@ -1729,6 +1729,28 @@ phys_addr_t __init_memblock memblock_reserved_size(void)
>> >  	return memblock.reserved.total_size;
>> >  }
>> >+/**
>> >+ * memblock_estimated_nr_free_pages - return estimated number of free pages
>> >+ * from memblock point of view
>> >+ *
>> >+ * During bootup, system may need the number of free pages in the whole system
>> >+ * to do some calculation before all pages are freed to buddy system. Usually
>> >+ * this number is get from totalram_pages(). Since we plan to move the free
>> >+ * pages accounting in __free_pages_core(), this value may not represent total
>> >+ * free pages at the early stage, especially when > + * CONFIG_DEFERRED_STRUCT_PAGE_INIT is enabled.
>> 
>> These historical details should be dropped. "Since we plan ..." will easily
>> get outdated soon.
>> 
>> * During bootup, subsystems might need a rough estimate of the number of *
>> free pages in the whole system, before precise numbers are available
>> * from the buddy. Especially with CONFIG_DEFERRED_STRUCT_PAGE_INIT, the
>> * numbers obtained from the buddy might be very imprecise during bootup.
>> 
>> ?
>> 
>> Reviewed-by: David Hildenbrand <david@redhat.com>
>> 
>> -- 
>> Cheers,
>> 
>> David / dhildenb
>> 

-- 
Wei Yang
Help you, Help me

Re: [PATCH v3 1/3] mm/memblock: introduce a new helper memblock_estimated_nr_pages()

[Wei Yang]

On Sun, Jul 07, 2024 at 10:17:27AM +0200, David Hildenbrand wrote:
>On 06.07.24 03:28, Wei Yang wrote:
>> On Fri, Jul 05, 2024 at 12:09:48PM +0300, Mike Rapoport wrote:
>> > On Wed, Jul 03, 2024 at 12:51:49AM +0000, Wei Yang wrote:
>> > > Instead of using raw memblock api, we wrap a new helper for user.
>> > 
>> > The changelog should be more elaborate and explain why this function is
>> > needed.
>> > 
>> > > Signed-off-by: Wei Yang <richard.weiyang@gmail.com>
>> > > ---
>> > >   include/linux/memblock.h |  1 +
>> > >   mm/memblock.c            | 19 +++++++++++++++++++
>> > >   2 files changed, 20 insertions(+)
>> > > 
>> > > diff --git a/include/linux/memblock.h b/include/linux/memblock.h
>> > > index 40c62aca36ec..7d1c32b3dc12 100644
>> > > --- a/include/linux/memblock.h
>> > > +++ b/include/linux/memblock.h
>> > > @@ -486,6 +486,7 @@ static inline __init_memblock bool memblock_bottom_up(void)
>> > >   phys_addr_t memblock_phys_mem_size(void);
>> > >   phys_addr_t memblock_reserved_size(void);
>> > > +unsigned long memblock_estimated_nr_pages(void);
>> > >   phys_addr_t memblock_start_of_DRAM(void);
>> > >   phys_addr_t memblock_end_of_DRAM(void);
>> > >   void memblock_enforce_memory_limit(phys_addr_t memory_limit);
>> > > diff --git a/mm/memblock.c b/mm/memblock.c
>> > > index e81fb68f7f88..c1f1aac0459f 100644
>> > > --- a/mm/memblock.c
>> > > +++ b/mm/memblock.c
>> > > @@ -1729,6 +1729,25 @@ phys_addr_t __init_memblock memblock_reserved_size(void)
>> > >   	return memblock.reserved.total_size;
>> > >   }
>> > > +/**
>> > > + * memblock_estimated_nr_pages - return number of pages from memblock point of
>> > > + * view
>> > 
>> > This function returns the estimate for free pages, not the number of pages
>> > in RAM.
>> > 
>> > How about memblock_estimated_nr_free_pages()?
>> > 
>> > > + * some calculation before all pages are freed to buddy system, especially
>> > > + * when CONFIG_DEFERRED_STRUCT_PAGE_INIT is enabled.
>> > 
>> > I'm failing to parse this sentence. The return value here won't depend on
>> > CONFIG_DEFERRED_STRUCT_PAGE_INIT.
>> > 
>> > > + *
>> > > + * At this point, we can get this information from memblock. Since the system
>> > > + * state is not settle down and address alignment, the value is an estimation.
>> > > + *
>> > > + * Return:
>> > > + * An estimated number of pages from memblock point of view.
>> > 
>> >                             ^ free
>> > 
>> > > + */
>> > > +unsigned long __init memblock_estimated_nr_pages(void)
>> > > +{
>> > > +	return PHYS_PFN(memblock_phys_mem_size() - memblock_reserved_size());
>> > > +}
>> > > +
>> > >   /* lowest address */
>> > >   phys_addr_t __init_memblock memblock_start_of_DRAM(void)
>> > >   {
>> > > -- 
>> > > 2.34.1
>> > > 
>> 
>> Thanks for review. Is this one looks better?
>> 
>> Subject: [PATCH] mm/memblock: introduce a new helper memblock_estimated_nr_free_pages()
>> 
>> During bootup, system may need the number of free pages in the whole system
>> to do some calculation before all pages are freed to buddy system. Usually
>> this number is get from totalram_pages(). Since we plan to move the free
>> pages accounting in __free_pages_core(), this value may not represent
>> total free pages at the early stage, especially when
>> CONFIG_DEFERRED_STRUCT_PAGE_INIT is enabled.
>> 
>> Instead of using raw memblock api, let's introduce a new helper for user
>> to get the estimated number of free pages from memblock point of view.
>> 
>> Signed-off-by: Wei Yang <richard.weiyang@gmail.com>
>> CC: David Hildenbrand <david@redhat.com>
>> ---
>>   include/linux/memblock.h |  1 +
>>   mm/memblock.c            | 22 ++++++++++++++++++++++
>>   2 files changed, 23 insertions(+)
>> 
>> diff --git a/include/linux/memblock.h b/include/linux/memblock.h
>> index 40c62aca36ec..7d1c32b3dc12 100644
>> --- a/include/linux/memblock.h
>> +++ b/include/linux/memblock.h
>> @@ -486,6 +486,7 @@ static inline __init_memblock bool memblock_bottom_up(void)
>>   phys_addr_t memblock_phys_mem_size(void);
>>   phys_addr_t memblock_reserved_size(void);
>> +unsigned long memblock_estimated_nr_pages(void);
>>   phys_addr_t memblock_start_of_DRAM(void);
>>   phys_addr_t memblock_end_of_DRAM(void);
>>   void memblock_enforce_memory_limit(phys_addr_t memory_limit);
>> diff --git a/mm/memblock.c b/mm/memblock.c
>> index e81fb68f7f88..00decc42e02b 100644
>> --- a/mm/memblock.c
>> +++ b/mm/memblock.c
>> @@ -1729,6 +1729,28 @@ phys_addr_t __init_memblock memblock_reserved_size(void)
>>   	return memblock.reserved.total_size;
>>   }
>> +/**
>> + * memblock_estimated_nr_free_pages - return estimated number of free pages
>> + * from memblock point of view
>> + *
>> + * During bootup, system may need the number of free pages in the whole system
>> + * to do some calculation before all pages are freed to buddy system. Usually
>> + * this number is get from totalram_pages(). Since we plan to move the free
>> + * pages accounting in __free_pages_core(), this value may not represent total
>> + * free pages at the early stage, especially when > + * CONFIG_DEFERRED_STRUCT_PAGE_INIT is enabled.
>
>These historical details should be dropped. "Since we plan ..." will easily
>get outdated soon.
>
>* During bootup, subsystems might need a rough estimate of the number of *
>free pages in the whole system, before precise numbers are available
>* from the buddy. Especially with CONFIG_DEFERRED_STRUCT_PAGE_INIT, the
>* numbers obtained from the buddy might be very imprecise during bootup.
>

Pretty better, thanks :-)

>?
>
>Reviewed-by: David Hildenbrand <david@redhat.com>
>
>-- 
>Cheers,
>
>David / dhildenb

-- 
Wei Yang
Help you, Help me