From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 93BE7C30658 for ; Wed, 3 Jul 2024 01:52:36 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id EAA506B0099; Tue, 2 Jul 2024 21:52:35 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E59BC6B009A; Tue, 2 Jul 2024 21:52:35 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D22066B009B; Tue, 2 Jul 2024 21:52:35 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id B3AE26B0099 for ; Tue, 2 Jul 2024 21:52:35 -0400 (EDT) Received: from smtpin16.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 322E81606AC for ; Wed, 3 Jul 2024 01:52:35 +0000 (UTC) X-FDA: 82296767070.16.B8D0143 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf16.hostedemail.com (Postfix) with ESMTP id 1E0C2180016 for ; Wed, 3 Jul 2024 01:52:32 +0000 (UTC) Authentication-Results: imf16.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=bbGavs5z; spf=pass (imf16.hostedemail.com: domain of akpm@linux-foundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1719971530; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=0Hm7gAs9MFwsTzyhBQsWcQugIZQTc+6CU4KIqL3ID1Y=; b=UG+eJi5oXoVH2lUjjIdyL3VtXHqa9CfRhtAHXdz695ZfHfbdPxkJ6HNeCrIje+cXQB+sgP Zg+7S03EvD02LJl9Fb2dt0jV7xeHrjGnp9ga3O8EdDDYrGQgFz5SD7YUaEEr/QVXwT5mme PwMSkRgQvD3pg+jPMgoVeKNlGz3/pjc= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1719971530; a=rsa-sha256; cv=none; b=hDZ1ichPZ5tTvpKUDTaWE6ogGBVALoDEF5LYiZSBH/XmwhsEYb2atRCTudrrBe6kviqel2 urwhCbEJ46Pkthuhe2RCypGCfY2xoZhf7ueNFCqJgo5gUL4pi69mcjbkVo1wfC8jFtnqFG ikTT7KQ2Pb2F34cuII1bPOl9gm4rtdk= ARC-Authentication-Results: i=1; imf16.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=bbGavs5z; spf=pass (imf16.hostedemail.com: domain of akpm@linux-foundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id E1E366207E; Wed, 3 Jul 2024 01:52:31 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 45C22C116B1; Wed, 3 Jul 2024 01:52:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1719971551; bh=AZWnEmjzdfWx2rEuZ0R78NSu9kwChSrsvE3QFJGxMI8=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=bbGavs5zhgvk1NpdDqPFgLRXysqzzXjwo0MP2nqM0/j17Oj0Tds1PmE2+dI72hLL5 wRlzl7Kjj6hulYC6F8xO7cDuhzwo7xqEyrxRZ8b1ooGll23gCyvAEchR5+xHmY5gJ0 26tWGWtqveKyi4RaZURe4w6nKVrua89Uvf78uueU= Date: Tue, 2 Jul 2024 18:52:30 -0700 From: Andrew Morton To: Wei Yang Cc: masahiroy@kernel.org, nathan@kernel.org, nicolas@fjasle.eu, linux-mm@kvack.org, linux-kernel@vger.kernel.org, linux-kbuild@vger.kernel.org, Mike Rapoport Subject: Re: [PATCH 2/3] modpost: .meminit.* is not in init section when CONFIG_MEMORY_HOTPLUG set Message-Id: <20240702185230.9ff500bf6a89db888207f8f1@linux-foundation.org> In-Reply-To: <20240702234008.19101-2-richard.weiyang@gmail.com> References: <20240702234008.19101-1-richard.weiyang@gmail.com> <20240702234008.19101-2-richard.weiyang@gmail.com> X-Mailer: Sylpheed 3.8.0beta1 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Stat-Signature: n8sixysdhxmbruthtoog6gpmb4dpaihi X-Rspamd-Queue-Id: 1E0C2180016 X-Rspam-User: X-Rspamd-Server: rspam08 X-HE-Tag: 1719971552-573893 X-HE-Meta: U2FsdGVkX19f9/E86VFeuSJSvWksk6PshkmDxU145n4GxTvr69G+iCiL9NaLrG1AAFenFYBWVCppTKAyeM5rpA1BnxR9YM9logBnHowVs0My/uBSrx4hSaEeIo+yzC/jr4W3X65GjtDWsxFDUMhLcjU9wvyAMCL39dAlOFDtjYxdxUFovGlUh4E9QF1K22lsY+cf7QSUk1jluUnV4rXIoS7Xy8Ve/T/pfLpFsJQeB1dPZvozqdAvfdkCZbo1L7woLrdDKoTr2qRuN+Yem/xt8Mdv4G/p5SUUyZZ3zmZ+2th6lgvMI2HP/i6Awfue83HK7kN1X2ktWnGOxqK6eXs7hBbOdEyPJ7qZRw7LGh6k/STEPs9TYLyaoFfacBVG8GdgwAeLMxmycZn4Gf9WG5mNI/76Bq9RT4NVymBYiNHzhzhqNSlTaWeOZdgBoARmFoMGPXvMwnnfrIWljQFfaqrZn1x/L6zk+r6tMANn6eW5/NuCKbTQ3Q2s80LHob/u0CSy7Qf3fcM4YZkwid3Y5wl7euWvIgi78Nw13Ro6AhwGCvMrbGkJufCon1UXgn1dBiESn+ZiB40siZPP5DkDaMKP05xwn084Yxn76oE+Fzf0/mhVsrQ1mfJ2B+FgIejmx20Ay7xwiecMTRncLi5Uv5PvuVeD/RyPK/pGYs2Kpcd+7afnDNahibNlvxcK6XxKRNFfY+9fZlXTibrjfbvf2rQluDA/akTOw9aIHBajBrwZkOcD0crzEolUXTyrKCsi3w4KxjFdf4GAVwLvmZYsP7VjX8VXmhlSUtMVRf1N2k+7tug9UidfndzhVxRSn+iKCpMEUFVOW9/czA8BgFczY4icaTUWwgX31XA9utJKH+Yl32Bu/UPf/zsELmBzqhmNZaRZB/hLXCZHo0S45UtMDzzsO3gUjdEhdJNQkgRlr77OHsSEFyw+qQ9fuzBw8S2M6UGXjrzeYo+3mz8UGJHatRf D8ryK8ZA YI+w7dgEycd1TlVggAGnSu6iqOVE/Rf+VD4L4j4XTVu+c3Z6gcA6l5neHwklhdJeujXpZrqLR4eGGB39O8ospKNRgL1V01wdKG0OyhVTIQKa2+RaJYkkj85Fxhvtd0SyfUcjF9IONIkA4tfSxboAS8m1FfGd+mvfCN0l8Li5bmszv1HwwRxJGCwmflcIkUDnCmtoXwrhF1KOMkRwM8lkTfjrTCYHv8y7nmX+GmxkXcPNSK/FOSJl2qT/LlfXzmqjGg1MtZOUVnIHcgBX8HRdblNg5UMOn0oPOFuPui8BFZInk8YUACjDCShxlK3GNux0d26+wXY/9O6UkbEIck92SKcNiFCnV6JO0nsYkOkMmEUG0nbfwIyEaGJyf13ReDuP07Vy0FTIDtJg3y3Y= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, 2 Jul 2024 23:40:07 +0000 Wei Yang wrote: > .meminit.* is not put into init section when CONFIG_MEMORY_HOTPLUG is > set, since we define MEM_KEEP()/MEM_DISCARD() according to > CONFIG_MEMORY_HOTPLUG. Please describe how this changes modpost behaviour. Something like: "we're currently not checking for references into meminit and meminitdata when CONFIG_HOTPLUG=y, which may cause us to fail to notice incorrect references.". But I don't think that's correct. So what *is* wrong with the current code?