From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 623CFC30658 for ; Tue, 2 Jul 2024 17:33:51 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id EC0AD6B0088; Tue, 2 Jul 2024 13:33:50 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E708F6B009D; Tue, 2 Jul 2024 13:33:50 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D10006B009E; Tue, 2 Jul 2024 13:33:50 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id B02736B0088 for ; Tue, 2 Jul 2024 13:33:50 -0400 (EDT) Received: from smtpin21.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 3759E1A0318 for ; Tue, 2 Jul 2024 17:33:50 +0000 (UTC) X-FDA: 82295510220.21.C447FA3 Received: from vmicros1.altlinux.org (vmicros1.altlinux.org [194.107.17.57]) by imf01.hostedemail.com (Postfix) with ESMTP id 664B640024 for ; Tue, 2 Jul 2024 17:33:47 +0000 (UTC) Authentication-Results: imf01.hostedemail.com; dkim=none; spf=pass (imf01.hostedemail.com: domain of ldv@altlinux.org designates 194.107.17.57 as permitted sender) smtp.mailfrom=ldv@altlinux.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1719941604; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=NpdfOor0hx9NQp9EFfdkDqkr7vfOMLTgpK9YlNNk+4A=; b=kSDfGbP/qglUaYeribaI608jOVg5bvUs0scmXnfjSkmlEw96PxKyewgkcoDDrdVpbwTc5U strM4baK+ehsV2H11E0+jLVpE7p+PVGjmdkmIDb9DPzjEtYE9gy1J6WAU2CGMm7NyD365P 2pArUpjlnAc8nc/XIjHDL+krYDECAxU= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1719941604; a=rsa-sha256; cv=none; b=R0JvqUY60olOSy5jKZrkJRIglp2HN6SVUjhnpSWtCu8Fer+idr5nvw5p2jLcZkvdBclkyX ux4B6qrgFM6VxU6c7O/K0natYGPxbJU7bifF7dVKpIATLHnqctoLqX0XsxIsuJ/JrJHr4Q FoNbTkU7tPb6rtV73BJO+tRzKf3L608= ARC-Authentication-Results: i=1; imf01.hostedemail.com; dkim=none; spf=pass (imf01.hostedemail.com: domain of ldv@altlinux.org designates 194.107.17.57 as permitted sender) smtp.mailfrom=ldv@altlinux.org; dmarc=none Received: from mua.local.altlinux.org (mua.local.altlinux.org [192.168.1.14]) by vmicros1.altlinux.org (Postfix) with ESMTP id 611CD72C8CC; Tue, 2 Jul 2024 20:33:46 +0300 (MSK) Received: by mua.local.altlinux.org (Postfix, from userid 508) id 53DB67CCB3A; Tue, 2 Jul 2024 20:33:46 +0300 (IDT) Date: Tue, 2 Jul 2024 20:33:46 +0300 From: "Dmitry V. Levin" To: Steven Rostedt Cc: Mathieu Desnoyers , Vincent Donnefort , mhiramat@kernel.org, kernel-team@android.com, rdunlap@infradead.org, rppt@kernel.org, david@redhat.com, linux-trace-kernel@vger.kernel.org, linux-mm@kvack.org, linux-api@vger.kernel.org, linux-kernel@vger.kernel.org, Linus Torvalds Subject: Re: [PATCH v23 3/5] tracing: Allow user-space mapping of the ring-buffer Message-ID: <20240702173346.GA16408@altlinux.org> References: <20240510140435.3550353-1-vdonnefort@google.com> <20240510140435.3550353-4-vdonnefort@google.com> <20240630105322.GA17573@altlinux.org> <20240630084053.0b506916@rorschach.local.home> <9a9c8ea4-8e17-4e7e-95fe-7b51441a228c@efficios.com> <20240702111807.13d2dd2c@rorschach.local.home> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240702111807.13d2dd2c@rorschach.local.home> X-Stat-Signature: som8ywktcdjdw93pmseyn4d5uyf8c35d X-Rspamd-Queue-Id: 664B640024 X-Rspam-User: X-Rspamd-Server: rspam08 X-HE-Tag: 1719941627-986726 X-HE-Meta: U2FsdGVkX1+Jrdwyg/SUY/34Dywh1ywivUp/KRixe8unEXLmLbj3fVjGCE69wQEFN4v1R32Kc1ZOYVPkmcKeRr1G4VvnXVlrgYQ9pEnvkoV7moMgmmrpvfNI7IC9RE2xabdpiWpyL56CJe2xQjvP+fH59SQQUoR2ioKZHjwUPuv635rzNToMojfUmvbyam8xkdep5FM8c9vQYw8E+Sec2DrNIRuvIGFxjFAUajXor2tqBpPxA31E30YfPGu8CrZLf35NnxGwaRviC3BtWWxQb5X0sAYCQ7ScWEVSXwg2OU4ICAXyNVcwsQ2o9wgIHmLMvEuoGB2dvOe2oAIKQwb3EH2lwS2pirP2vbkovqRBolCQH+86m5/83c05oH5h7xYKKb7stoNDlUpIUnlojvg6dIqmra/kiKaOXRYXyUQG05NL3otW9B8efAJMMwk0Ldu+/JLDYPvF9xKeUM69BNpTFkhMFdK17wM4BokHpOdx73GJ8sWta5pPnXs2+NXEBUiYrhKCCaMMNhiLnQUcQVnQnVy4ofB1EOMAjxNeMdwVSnCbUGqZjA//vlZfyPGtItC3S+r2D4JwmQmThXd6Y8kkMFdCGFE0sqr94aYwhshwYQJfiMrNARJs48cDwcmM9CMeKoLZK1znoQyPJNZ2UK1ekodyOYr6vFLKsSakDvvE3p5RccLnxPIXsxsuWGTHx2ThExXvyYbEWbTeVeRftat1O9sP5Mqboe5pFkzaLfcCZNv2oWhlqOs4ByrUOJss+T+Rxh4dOxfxwHp1zZDvs/0fqDjgNJWga9e7CFCY4t6h/RuPqY2DuqBWORpLeFyLap++bNYrMqt9Wzkh+mdPOkerMvyS0hsuGHlhotXgwhsUKfnQcQ09dj4y025qQnmv3YO5LxyGPNk10gop636cDCgr311G0eJ1CevzccamAXKE60+zC4LKk1iZsNc7f8nnCs6im/P0iujXjoio/3+dwtm 2jsAtE9q JEeIZu4NCKNGYJu7Um6FgFYhEDtvJ0MKT/Pu+pVpfgcUGhY+N7zjruyW7lfEL7p6zi7Jj3d2xgiffEIQbiJ09TXoIN7VQhRMPaXATUB9/MSIxvu/BG2WC8RljsY/pfD+gtgiox00/zlnlh4belNohrxcRRIx72ieGxxA1bajPqOrk0M+ecgK3wWXGDXtMxXAsirX/z8PKdZ5liO3YofgslGEEfNS79+YocjXp59Pa6bXKGPfFVGma7tonhe28fGbcpsF1CJzBc5mw8sVVYg5sB65wNwQ24ejy3/tQnt/pCUYAha4= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Jul 02, 2024 at 11:18:07AM -0400, Steven Rostedt wrote: > On Tue, 2 Jul 2024 10:36:03 -0400 > Mathieu Desnoyers wrote: > > > > I can send a patch this week to update it. Or feel free to send a patch > > > yourself. > > > > You need to reserve an unused ioctl Code and Seq# range within: > > > > Documentation/userspace-api/ioctl/ioctl-number.rst > > Ug, it's been so long, I completely forgot about that file. > > Thanks for catching this. > > > > > Otherwise this duplicate will confuse all system call instrumentation > > tooling. > > Agreed, what if we did this then: > > -- Steve > > diff --git a/Documentation/userspace-api/ioctl/ioctl-number.rst b/Documentation/userspace-api/ioctl/ioctl-number.rst > index a141e8e65c5d..9a97030c6c8d 100644 > --- a/Documentation/userspace-api/ioctl/ioctl-number.rst > +++ b/Documentation/userspace-api/ioctl/ioctl-number.rst > @@ -186,6 +186,7 @@ Code Seq# Include File Comments > 'Q' all linux/soundcard.h > 'R' 00-1F linux/random.h conflict! > 'R' 01 linux/rfkill.h conflict! > +'R' 20-2F linux/trace_mmap.h > 'R' C0-DF net/bluetooth/rfcomm.h > 'R' E0 uapi/linux/fsl_mc.h > 'S' all linux/cdrom.h conflict! Just in case, I've checked the list of ioctls known to strace and can confirm that there are no users of 'R' ioctl code in 0x20..0x2f range yet. By the way, this file is definitely not up to date, the 'R' part of it should have contained the following: 'R' 00-1F uapi/linux/random.h conflict! 'R' 01-02 uapi/linux/rfkill.h conflict! 'R' 01-0D uapi/misc/fastrpc.h conflict! 'R' C0-DF net/bluetooth/rfcomm.h 'R' E0 uapi/linux/fsl_mc.h -- ldv