From: "Dmitry V. Levin" <ldv@strace.io>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>,
Vincent Donnefort <vdonnefort@google.com>,
mhiramat@kernel.org, kernel-team@android.com,
rdunlap@infradead.org, rppt@kernel.org, david@redhat.com,
linux-trace-kernel@vger.kernel.org, linux-mm@kvack.org,
linux-api@vger.kernel.org, linux-kernel@vger.kernel.org,
Linus Torvalds <torvalds@linux-foundation.org>
Subject: Re: [PATCH v23 3/5] tracing: Allow user-space mapping of the ring-buffer
Date: Tue, 2 Jul 2024 20:33:46 +0300 [thread overview]
Message-ID: <20240702173346.GA16408@altlinux.org> (raw)
In-Reply-To: <20240702111807.13d2dd2c@rorschach.local.home>
On Tue, Jul 02, 2024 at 11:18:07AM -0400, Steven Rostedt wrote:
> On Tue, 2 Jul 2024 10:36:03 -0400
> Mathieu Desnoyers <mathieu.desnoyers@efficios.com> wrote:
>
> > > I can send a patch this week to update it. Or feel free to send a patch
> > > yourself.
> >
> > You need to reserve an unused ioctl Code and Seq# range within:
> >
> > Documentation/userspace-api/ioctl/ioctl-number.rst
>
> Ug, it's been so long, I completely forgot about that file.
>
> Thanks for catching this.
>
> >
> > Otherwise this duplicate will confuse all system call instrumentation
> > tooling.
>
> Agreed, what if we did this then:
>
> -- Steve
>
> diff --git a/Documentation/userspace-api/ioctl/ioctl-number.rst b/Documentation/userspace-api/ioctl/ioctl-number.rst
> index a141e8e65c5d..9a97030c6c8d 100644
> --- a/Documentation/userspace-api/ioctl/ioctl-number.rst
> +++ b/Documentation/userspace-api/ioctl/ioctl-number.rst
> @@ -186,6 +186,7 @@ Code Seq# Include File Comments
> 'Q' all linux/soundcard.h
> 'R' 00-1F linux/random.h conflict!
> 'R' 01 linux/rfkill.h conflict!
> +'R' 20-2F linux/trace_mmap.h
> 'R' C0-DF net/bluetooth/rfcomm.h
> 'R' E0 uapi/linux/fsl_mc.h
> 'S' all linux/cdrom.h conflict!
Just in case, I've checked the list of ioctls known to strace and can
confirm that there are no users of 'R' ioctl code in 0x20..0x2f range yet.
By the way, this file is definitely not up to date, the 'R' part of it
should have contained the following:
'R' 00-1F uapi/linux/random.h conflict!
'R' 01-02 uapi/linux/rfkill.h conflict!
'R' 01-0D uapi/misc/fastrpc.h conflict!
'R' C0-DF net/bluetooth/rfcomm.h
'R' E0 uapi/linux/fsl_mc.h
--
ldv
prev parent reply other threads:[~2024-07-02 17:33 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20240510140435.3550353-1-vdonnefort@google.com>
2024-05-10 14:04 ` [PATCH v23 2/5] ring-buffer: Introducing ring-buffer mapping functions Vincent Donnefort
2024-05-10 14:06 ` David Hildenbrand
2024-05-10 14:04 ` [PATCH v23 3/5] tracing: Allow user-space mapping of the ring-buffer Vincent Donnefort
2024-06-30 10:53 ` Dmitry V. Levin
2024-06-30 12:40 ` Steven Rostedt
2024-07-02 14:36 ` Mathieu Desnoyers
2024-07-02 15:18 ` Steven Rostedt
2024-07-02 15:32 ` Mathieu Desnoyers
2024-07-02 16:44 ` Dmitry V. Levin
2024-07-02 16:51 ` Steven Rostedt
2024-07-02 17:37 ` Mathieu Desnoyers
2024-07-03 22:26 ` Beau Belgrave
2024-07-02 17:33 ` Dmitry V. Levin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240702173346.GA16408@altlinux.org \
--to=ldv@strace.io \
--cc=david@redhat.com \
--cc=kernel-team@android.com \
--cc=linux-api@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-trace-kernel@vger.kernel.org \
--cc=mathieu.desnoyers@efficios.com \
--cc=mhiramat@kernel.org \
--cc=rdunlap@infradead.org \
--cc=rostedt@goodmis.org \
--cc=rppt@kernel.org \
--cc=torvalds@linux-foundation.org \
--cc=vdonnefort@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox