From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 85B75C30658 for ; Tue, 2 Jul 2024 17:10:28 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id EFBD66B0092; Tue, 2 Jul 2024 13:10:27 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id EABEB6B0093; Tue, 2 Jul 2024 13:10:27 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D72CF6B0095; Tue, 2 Jul 2024 13:10:27 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id B92606B0092 for ; Tue, 2 Jul 2024 13:10:27 -0400 (EDT) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 5B4471602B2 for ; Tue, 2 Jul 2024 17:10:27 +0000 (UTC) X-FDA: 82295451294.25.F562C05 Received: from mout-p-103.mailbox.org (mout-p-103.mailbox.org [80.241.56.161]) by imf13.hostedemail.com (Postfix) with ESMTP id 7958420025 for ; Tue, 2 Jul 2024 17:10:25 +0000 (UTC) Authentication-Results: imf13.hostedemail.com; dkim=pass header.d=pankajraghav.com header.s=MBO0001 header.b=eayMpLs3; spf=pass (imf13.hostedemail.com: domain of kernel@pankajraghav.com designates 80.241.56.161 as permitted sender) smtp.mailfrom=kernel@pankajraghav.com; dmarc=pass (policy=quarantine) header.from=pankajraghav.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1719940213; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=x7S8VUQYyvA/hYjxf+VcnjpFycomG4Q9npc7KT3Na+A=; b=FiqLoRfDs0vs7W7b3QiDkCDxlptuClzneZYrjneoNCuDF60Q2hH4fdSKtJCdDh6B0HCppm IaqkmIBCiL9EEDnnU53MsxNWUFriE+Nvq0AROWvV+nPtivyH/IV1PMTSYITUJ85FEUokzO basKscEocxGwK1NOOxDteaQubphDGOs= ARC-Authentication-Results: i=1; imf13.hostedemail.com; dkim=pass header.d=pankajraghav.com header.s=MBO0001 header.b=eayMpLs3; spf=pass (imf13.hostedemail.com: domain of kernel@pankajraghav.com designates 80.241.56.161 as permitted sender) smtp.mailfrom=kernel@pankajraghav.com; dmarc=pass (policy=quarantine) header.from=pankajraghav.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1719940213; a=rsa-sha256; cv=none; b=IbgfY7M5nFqgIlSw/tHaXJnrsWoaun9Qoemrhr6409VeEFJslh8jQLEA6t+87KcWsY3jXO qghx3mciSIoVT6gNznldPjZMmiE/DXRvKA3VEHytRnDePBoLM57GH3MKuO9/XIxSBKCSu3 HfH9F+BLItzxeIK0yxvOfeiQ3Rndv7c= Received: from smtp2.mailbox.org (smtp2.mailbox.org [IPv6:2001:67c:2050:b231:465::2]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mout-p-103.mailbox.org (Postfix) with ESMTPS id 4WD8YT4Cmhz9sTd; Tue, 2 Jul 2024 19:10:21 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pankajraghav.com; s=MBO0001; t=1719940221; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=x7S8VUQYyvA/hYjxf+VcnjpFycomG4Q9npc7KT3Na+A=; b=eayMpLs3XwLuC/DdNErQ6ZCv5mfKT5+W0WH+14922V/+zVlk7DAIc5Qhilq6qnJhn3vzpV Per+4UR5bylBDnITjTpBuZxRtlYpRhw5AQeljJpeHHodVSalpAu52j5syGpjBz5zOBZ9yx zkdq15e9ib2r3erwIovYKrQ5nOP4WpcDHMU8cRaMtLfcHbTZRhNuO/X86KVi2sftEEjYfU MuUTYP7dwCIyN6raWrXNI5Q3IT+Ma0hzhttMFteYHQwXEC7z9Q8EXfgB/JuB8Nwhx1EawL mCOf4CtVW/gYrv6XnjrKRCMiGDStEaadznZMZn8bI5LrLVV5WDBlfGj9c2fj+Q== Date: Tue, 2 Jul 2024 17:10:14 +0000 From: "Pankaj Raghav (Samsung)" To: Matthew Wilcox Cc: Christoph Hellwig , david@fromorbit.com, chandan.babu@oracle.com, djwong@kernel.org, brauner@kernel.org, akpm@linux-foundation.org, linux-kernel@vger.kernel.org, yang@os.amperecomputing.com, linux-mm@kvack.org, john.g.garry@oracle.com, linux-fsdevel@vger.kernel.org, hare@suse.de, p.raghav@samsung.com, mcgrof@kernel.org, gost.dev@samsung.com, cl@os.amperecomputing.com, linux-xfs@vger.kernel.org, Zi Yan Subject: Re: [PATCH v8 06/10] iomap: fix iomap_dio_zero() for fs bs > system page size Message-ID: <20240702171014.reknnw3smasylbtc@quentin> References: <20240625114420.719014-1-kernel@pankajraghav.com> <20240625114420.719014-7-kernel@pankajraghav.com> <20240702074203.GA29410@lst.de> <20240702101556.jdi5anyr3v5zngnv@quentin> <20240702120250.GA17373@lst.de> <20240702140123.emt2gz5kbigth2en@quentin> <20240702154216.GA1037@lst.de> <20240702161329.i4w6ipfs7jg5rpwx@quentin> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Server: rspam11 X-Rspamd-Queue-Id: 7958420025 X-Stat-Signature: sn7gby3k71pa64he13yior7num6j36d8 X-Rspam-User: X-HE-Tag: 1719940225-839125 X-HE-Meta: U2FsdGVkX187dXoMBQy92zplxy6JCKdlBVpcqewmn6k3x0RqhnSzoWzTVwqo1O6a0OilFDUqqGlbT+cONEw5noPCpI7TgTperxBlbyy42n2O194cXfokODmXj8BwaHWx5HNP0VswqyfDD+Zf8a8or8Dnx7XiMzj5beUnscbAwQhXJJsnk0boH1QkdsfODwEjtm1UiPKiuO3actbDYsXELhCIB9u7WMQYkBGrD+UxQDTUgKcml3Tu8mCt/WIxiKYKXpuamoIHgZI0vCVq0E1EN07patH240iJQlWqgrRsfVRr7rQUjbUpvdJqb9mZclJSEPyYJUa8UavSuy3nxcnFBIMHr1bARQIAXb/LvObw3kYIrOR3RvNwcVdKuzllQuE4qD/f6YRfsjS//Wx/beU6tDGrtKnkqx6hT01oxttzsOTTdyIB0A7IdBB9qFPqj9F9nEqxY0VZVqFZ5rkCUVXzkqU+NtXw/VKabHZTlybq2kxFTTBMD3421tdna9vDni11MJbCJTDbC4Glr6MT7Wc9dapTRjqosF53XTi06T6ycuxlJN8YVEkHEn6bi3z6aOL6OtrU8JkBS/849gboVQapqaCwvpwoASmX78xzsWRX33EG2eChvS7dVPOin7DZTEOiSPUWTp6A94IcRQUI9sftJdf6fCbxbR0xXBNEPQ+cmAktRgwR0SgcG/TVpRjV3KK2lse4bVvs4Y8PKOnB9mzSZN/7+EECJF8OXfyR4Sf8ax3+7peH9naiRgI6p3Ws/yIovgwu40otBvVhzS4Co0Dd0ZUEd/iqJWM+0OH9SyNy29H8CZ4eQh4zmeHPGCt530iLohTKew4ZSxf5KFCUtJgRRjNmBuNiQQZcuGTkq0Qx7mCUqghGWd8tCvZCH1bNdWQ5BNOUnV3geotLNaNzf4eb/h9UnPytj61lU9RhH3SpBx5Y18JK+jAZgodYfd917PVhgl1P8eCeK6UTvS7e/y2 yiQc1tGZ frgj3ejJgZg1UFieR5G+zzKs5Yboj8opnlBiaKmj+jbZyBaR8qB7JHA4ESMQ4gMBFCGBaFNLYxq82dvHowK6rYu6NTEbMPotG3qF9/tELDkkOQlM2evbmgpVSQCD611fQ89wvj5hRsm5YJ/BoV1arFfiAKlFpx706+ChAGjNDEKDaXcfi1HLangCUtNmWa15f/luXE3Vt20GpAuwO9VSdudUk9Vwu2Enby9WlP0k688+HxQ6x71nC2THuktzOlMT7oYDlAKVd1veqViHzcLKToPnEs/RhmfDz4TEY3uDbE3a+KCA= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Jul 02, 2024 at 05:51:54PM +0100, Matthew Wilcox wrote: > On Tue, Jul 02, 2024 at 04:13:29PM +0000, Pankaj Raghav (Samsung) wrote: > > On Tue, Jul 02, 2024 at 05:42:16PM +0200, Christoph Hellwig wrote: > > > On Tue, Jul 02, 2024 at 02:01:23PM +0000, Pankaj Raghav (Samsung) wrote: > > > +static int iomap_dio_zero(const struct iomap_iter *iter, struct iomap_dio *dio, > > > > loff_t pos, unsigned len) > > > > { > > > > struct inode *inode = file_inode(dio->iocb->ki_filp); > > > > struct bio *bio; > > > > > > > > + if (!len) > > > > + return 0; > > > > /* > > > > * Max block size supported is 64k > > > > */ > > > > - WARN_ON_ONCE(len > ZERO_PAGE_64K_SIZE); > > > > + if (len > ZERO_PAGE_64K_SIZE) > > > > + return -EINVAL; > > > > > > The should probably be both WARN_ON_ONCE in addition to the error > > > return (and ZERO_PAGE_64K_SIZE really needs to go away..) > > > > Yes, I will rename it to ZERO_PAGE_SZ_64K as you suggested. > > No. It needs a symbolic name that doesn't include the actual size. > Maybe ZERO_PAGE_IO_MAX. Christoph suggested using SZ_64K to define > it, not to include it in the name. Initially I kept the name as ZERO_FSB_PAGE as it is used to do sub-block zeroing. But I know John from Oracle is already working on using it for rt extent zeroing. So I will just go with ZERO_PAGE_IO_MAX for now. Understood about the SZ_64K part. Thanks for the clarification.