From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0C3A6C30658 for ; Tue, 2 Jul 2024 16:13:42 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 893BE6B0099; Tue, 2 Jul 2024 12:13:42 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 81C9A6B009A; Tue, 2 Jul 2024 12:13:42 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 696986B009B; Tue, 2 Jul 2024 12:13:42 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 3C5E16B0099 for ; Tue, 2 Jul 2024 12:13:42 -0400 (EDT) Received: from smtpin15.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 980B51C111F for ; Tue, 2 Jul 2024 16:13:41 +0000 (UTC) X-FDA: 82295308242.15.FEE29AF Received: from mout-p-103.mailbox.org (mout-p-103.mailbox.org [80.241.56.161]) by imf09.hostedemail.com (Postfix) with ESMTP id 4DC50140014 for ; Tue, 2 Jul 2024 16:13:38 +0000 (UTC) Authentication-Results: imf09.hostedemail.com; dkim=pass header.d=pankajraghav.com header.s=MBO0001 header.b=GTze8lmn; spf=pass (imf09.hostedemail.com: domain of kernel@pankajraghav.com designates 80.241.56.161 as permitted sender) smtp.mailfrom=kernel@pankajraghav.com; dmarc=pass (policy=quarantine) header.from=pankajraghav.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1719936809; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=oA2Wr6VOMzgFZ0qUaQebVyDCKpm9ZO191hQv44sz+Fs=; b=8cGMTjw3Z0KeeBeI/S6lYF7xvxSAW9Rrb3q0Zu/Pa2MORSFa5bJhbtljVOqVyYqM8BV/xo 7t7LHMCJer/IS3qH/uOVwlvZSv1zbni2We5QCjmqJOi+HQnowwHVNWjMsBjTkKiH97VpN9 iOReMKkIlYv0p+iD+wBrb0LrhUFPBIY= ARC-Authentication-Results: i=1; imf09.hostedemail.com; dkim=pass header.d=pankajraghav.com header.s=MBO0001 header.b=GTze8lmn; spf=pass (imf09.hostedemail.com: domain of kernel@pankajraghav.com designates 80.241.56.161 as permitted sender) smtp.mailfrom=kernel@pankajraghav.com; dmarc=pass (policy=quarantine) header.from=pankajraghav.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1719936809; a=rsa-sha256; cv=none; b=bUVGt+6t4udC8ov51R+PCy5EM0EafT0DKbUrmyBEt1rKPZoMhyqfMdkbFm53wJ67FQS5JL ZXdHVxCZn0rDdO1M6gCVOLM26bkCwZ3jugZt9w5S8q4WFZ82kQeAQxu06c1z4C9XAQHyjg ll+2W8iTJeZUWR/9ZHheSvGrwmfoTbs= Received: from smtp202.mailbox.org (smtp202.mailbox.org [IPv6:2001:67c:2050:b231:465::202]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mout-p-103.mailbox.org (Postfix) with ESMTPS id 4WD7Hy1Dr1z9sST; Tue, 2 Jul 2024 18:13:34 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pankajraghav.com; s=MBO0001; t=1719936814; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=oA2Wr6VOMzgFZ0qUaQebVyDCKpm9ZO191hQv44sz+Fs=; b=GTze8lmnNNlFCHrThB/+rsNsw9R8Twukx9Hl2tJi+qQCgI2mMsh/6+J0lnPan0kqT7d0XQ i6zh7ni3jyRVUt67LghCN9oST2X3rtk+66m9JqtltYVdQ4A9f+kGM85FgdKhBqlVam9dn8 5bkKl55oquwI57fbnrw0THmxQDb7sn0ckmNc7jXyGg0uakz9HpUoq+D0kBtY/P/0XStobb v5xK0h+Oy/fTOPu/AzF4QsQjYimxfrFo6Nogyk4PWMk5ugxFCWbht1K3WYl+JQvIAAUsmJ orz3r2CEWAiVfMEHP7Gb5qJ1EH9b59z3ibtoOyBLfzODISoZsBsKbzZh1Snc1A== Date: Tue, 2 Jul 2024 16:13:29 +0000 From: "Pankaj Raghav (Samsung)" To: Christoph Hellwig Cc: david@fromorbit.com, willy@infradead.org, chandan.babu@oracle.com, djwong@kernel.org, brauner@kernel.org, akpm@linux-foundation.org, linux-kernel@vger.kernel.org, yang@os.amperecomputing.com, linux-mm@kvack.org, john.g.garry@oracle.com, linux-fsdevel@vger.kernel.org, hare@suse.de, p.raghav@samsung.com, mcgrof@kernel.org, gost.dev@samsung.com, cl@os.amperecomputing.com, linux-xfs@vger.kernel.org, Zi Yan Subject: Re: [PATCH v8 06/10] iomap: fix iomap_dio_zero() for fs bs > system page size Message-ID: <20240702161329.i4w6ipfs7jg5rpwx@quentin> References: <20240625114420.719014-1-kernel@pankajraghav.com> <20240625114420.719014-7-kernel@pankajraghav.com> <20240702074203.GA29410@lst.de> <20240702101556.jdi5anyr3v5zngnv@quentin> <20240702120250.GA17373@lst.de> <20240702140123.emt2gz5kbigth2en@quentin> <20240702154216.GA1037@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240702154216.GA1037@lst.de> X-Rspam-User: X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: 4DC50140014 X-Stat-Signature: crp3bbmkmorwyqw3qmwu5u77c63xqgno X-HE-Tag: 1719936818-451935 X-HE-Meta: U2FsdGVkX18uvF52hbSzAfDhtAeZBpi69Slij/QyRgRB/Gje0sDAunnj+c8QWxactgh0Zz5EM2F5I60WpaHUNNgxLRnjGbKW1t8LDjRBaM9OnOQTE3gqSQ/VNilaCsbLF25aWoSibVb29aL8aQPtYSdP+Ta3FzD0rzgBJ7y4z/KUwqK51tRiFZgMJlqwbokf+i1F70cySxd6VXDytYre35rh6bC250mN8CJdo0V626Zlge/TZaL7QnP7pYLG6SQTGQ25z6J36XCWlOTpx4W/5YCDMh5e5Gq3Dc5C1m3sM/VdDANL0uv17Trk6AWlyKJBYXVh5x6FtrmO+cVgicW2WTkHX+p25kplVy3P28HtkNA2vebeAYXNIRslBkTatLNC8WEE8UAhDFueK9tHv3qfMWqMKq/R8SZiZOxVnkoGmedqKfv3JX3A/UAlD2Q0qjG+ioUqH2uB56K1BIPNo5821LDEW2EXf3y9hhD8ZacxpiG7RpBZURFO0QUwX86kQHJ0cdHK3iLdzUqPX+kOi8BU/9Q+p+mQiQc1CxX640gjmRdx6BZbMCZ3P2XZwaPDG6UldPCxED8ZaIwLsLick1sO6uHsrs7ZbIvKYbjg50Y6ErlVOiwK0aln8HjBRoDpwEIzwgkwPfbUbnccI+wUCOgElK+xUM8mbNz8Gt752S6Elu0+8XQfAsRBe7SeaLxA5lBABwNZJFoneBlKIS6RlnxVGc1S1vLzBxZzJUxdhTng7HNYvRYmttRSamhPk21B1oxatikLU/6283W8/3Fxv5KHc6Rjj9FNyTwSLTsGt5qAEYmHQFbvVZ0kKIm8isJzlY4DWqllO52pLs3dN9Weg3p5PonVFzpV0S0x5n4WOvfn3YMHOVNeun9QvWUG4pTtIdqwbyzJjh938laXWinH47oT7yV57jVGalhXoxAIictkWvZvB+IockYH1ABSaHkYTPReh4C0XbEaC5yvVXQVQuj 492KjQUR RK5D6q9CGMf3OcfQD8FyxrthATJXlliyaZJhhIkItuBVOR+IJIsiHIn9l3d1G5CVdEK6QiijMM0mgOAky7hlw6aGXIIRKJYFJPRzZbquuXDRbNpML1vu20JEslJZxi6k936PrPf8UFR9AUUPaeA5x/us/WJotqntHOH1N5+WwxUU5vkyIy8E9KSrCOlEYwARut5pZXPy3jVQX7kh0GCYyho457HuoVL+odLGJFKMS7C0W8qq9fBmGhnqBWXgUafA9pD/4U3gX38QfDnzPvn7HHbsuobA9+cFcnelk6GnCCM90fuM= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Jul 02, 2024 at 05:42:16PM +0200, Christoph Hellwig wrote: > On Tue, Jul 02, 2024 at 02:01:23PM +0000, Pankaj Raghav (Samsung) wrote: > +static int iomap_dio_zero(const struct iomap_iter *iter, struct iomap_dio *dio, > > loff_t pos, unsigned len) > > { > > struct inode *inode = file_inode(dio->iocb->ki_filp); > > struct bio *bio; > > > > + if (!len) > > + return 0; > > /* > > * Max block size supported is 64k > > */ > > - WARN_ON_ONCE(len > ZERO_PAGE_64K_SIZE); > > + if (len > ZERO_PAGE_64K_SIZE) > > + return -EINVAL; > > The should probably be both WARN_ON_ONCE in addition to the error > return (and ZERO_PAGE_64K_SIZE really needs to go away..) Yes, I will rename it to ZERO_PAGE_SZ_64K as you suggested. > > > + ret = iomap_dio_zero(iter, dio, pos, fs_block_size - pad); > > Overly lone line here. > > Otherwise this looks good. >