From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1AABBC30658 for ; Tue, 2 Jul 2024 20:11:55 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 439CA6B0082; Tue, 2 Jul 2024 16:11:55 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 3E9416B0083; Tue, 2 Jul 2024 16:11:55 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 289746B0085; Tue, 2 Jul 2024 16:11:55 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 0B7016B0082 for ; Tue, 2 Jul 2024 16:11:55 -0400 (EDT) Received: from smtpin12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id D62E41C14B8 for ; Tue, 2 Jul 2024 20:11:53 +0000 (UTC) X-FDA: 82295908506.12.9307B36 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf13.hostedemail.com (Postfix) with ESMTP id EF86320020 for ; Tue, 2 Jul 2024 20:11:51 +0000 (UTC) Authentication-Results: imf13.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=WIMuzbG9; spf=pass (imf13.hostedemail.com: domain of kees@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=kees@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1719951094; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=m0ifbTF4H8EpLgs9yqbLEvCJ6JGGL7+M10IX0v26SKc=; b=d/XYw7G77gqy0SJH+wqRoHVxMFn0TFHFaYMZNO/OWtlWdqZ8yKqqTGNoCXWh6R2Y9MDbDc QysVleG89i2Kl2hKuIw6kmJjm3v0i6yZ/11iUwpQfsJ32ILeY4pjZaH9s0oytVNacL7b5d Gs8QqpmYw2pehWx61l/UmgznW3CGYKg= ARC-Authentication-Results: i=1; imf13.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=WIMuzbG9; spf=pass (imf13.hostedemail.com: domain of kees@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=kees@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1719951094; a=rsa-sha256; cv=none; b=gom1HtXGhD8TabQpYpOtLN2RvUn3BV8juYdsfFxOysFBf/+kD7BW3RrXz6iPoP9qzf8c0D v6wIOx8DDSdn2vSkFts9qgIZPOWAdAtms/psXtgt9oBRrN49NlgpCUnSWjXxZCeozB0XYe 6JFHA+z471xCAfjekFt6wNL4IoOewgY= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id F3C9D62027; Tue, 2 Jul 2024 20:11:50 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 9DA71C116B1; Tue, 2 Jul 2024 20:11:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1719951110; bh=lvt2df83NkLUTgsbk8BOq8Dapmt5UAWGkzhq+iigNqQ=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=WIMuzbG906YGZpjUEAEondBndofI68Am1PNAkSAzHFzCQIuQhARm55mSr+30UGg/W KUG/fORw60SBI6qCY4gYxh9rm/JK8bXtRA0F9QygwWnkNbvtqUUcRXmrLQyMTy4jmO Is+CeCJ0eG7qcJiXjiNcOyGarMxtr107YgUXZy1FoMQ7T6N+mA5DrifAasjX6ZIcfg nG7uyklKekPzrfi6j1ITmYh7uJ+sxMgv0msYAq9FC3ZKKvdi5O66Omnxe8VEUA21A3 ma2NEaklA64JfjRwg4AUQR8l+jF1a3W+8iOzz7Ykkh6nLVk2eY4gZ+9Dy4C2Q2Zsdg B+aqE16h7B44Q== Date: Tue, 2 Jul 2024 13:11:50 -0700 From: Kees Cook To: Vlastimil Babka Cc: "GONG, Ruiqi" , Christoph Lameter , Pekka Enberg , David Rientjes , Joonsoo Kim , jvoisin , Andrew Morton , Roman Gushchin , Hyeonggon Yoo <42.hyeyoo@gmail.com>, Xiu Jianfeng , Suren Baghdasaryan , Kent Overstreet , Jann Horn , Matteo Rizzo , Thomas Graf , Herbert Xu , "Gustavo A. R. Silva" , Jonathan Corbet , linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-hardening@vger.kernel.org, netdev@vger.kernel.org Subject: Re: [PATCH v6 4/6] mm/slab: Introduce kmem_buckets_create() and family Message-ID: <202407021311.A594875FC6@keescook> References: <20240701190152.it.631-kees@kernel.org> <20240701191304.1283894-4-kees@kernel.org> <5b8e6ddc-6472-4acd-a506-98bc3586f1f3@suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <5b8e6ddc-6472-4acd-a506-98bc3586f1f3@suse.cz> X-Stat-Signature: jp6f41n9r7pc6ororrnb9t95sy337ri4 X-Rspam-User: X-Rspamd-Queue-Id: EF86320020 X-Rspamd-Server: rspam02 X-HE-Tag: 1719951111-952673 X-HE-Meta: U2FsdGVkX19EizpsLwzTEromxfGjzkZgo+G2ddbYc955FqiP09svaexl5OihFboTzT6lQ9d2WM8GdhX0afuMVN/BekD7qyOSKLdZHPJZ4iwbjJaJTmDaWrcNwKkfss23syJf7H4OV75y8Nrbp9Dqj7o+VdUGAl9jZiRusQ18P2lmnjofZ4/4qNmr6QyjbrfbnPR38J1+scTvWjfM1s7AQH2Z6ENymktSySmefVZj775hmRMCUy3CI3zl2EkdDa4lIDFRzIQaB4qbWMXIc9zdbFffkTLDN1lu7xUoZP6yqpORK5CHwBrVvvlpMxRTiBw4hp4EYrgwYIwRvHLdXCFOUbVasqOO8lmfq6A/jjfhsRU0ZXSE5OCioA3ir7Fpv57PZmpuX7qblI9VXDCVdwTqg3byz1jg6N8M1ikYUg8DZbP7Q3ie1BdG86REU+Kq4HsyGjHpF4MjUYDDamWwatwavxNqcF5200Ar64rB8lIil6jEkgTTjKpCB/GpX29TkslBU50jbE7sTSSbGU/JNUd7ehR4jZwO2vBMgEIFb5eFMhjqslIfaBjhx7wmA9jk1xLpss6j/3b0QJBSFhfP4iRopz6cb7aaXf4BtA+B4OrtbQJkbtdh3+ZXth05aTY8AX9DjHTSNqNDsrm8AYMFPwhIBWKraIfsTGfoax0wshMiODGA8yj75+7gK26eKaPXU014zPscS5CK5+DJNFFxXiY61kV5mAJd0U21pevTZn8yBfRSDGvaUmCwGxYHoA2qZetFuL9pt2HQa4AqWTOJ/2nh2QgxcP38NWk4k18Kk9vIq55KrCW3pFFWSNzONMF0rfxh+ZNQWQFT4AHeQARs+vGHlhfNo8rCGUs4sabSh3JUvQUNmG11Z/e0PO2s2jbp6IH8YmtShgYtupOMrZaSgTxapY4nB5jlOIzTsOM0Ddn9tjIo/bLKfyl9gtyflih1gfPDrv6kGIqX2UjFH62rEeX QqB1JNJP LIDOA5RvRX9f6JDlgmU7WMDyszfo4xgQJEgdmDQWbAEKTSjZLWwoi9Vatd+vNd0WKVZ6XfBtxqh1RfEWf/pYYiVk3qsMFA5R4yh2dEXEi+zpIXh1acaHw5mWbkB+QjCgTp//uwIG1BKXzZUwrzNEDrlO1Hhx1Kcul/1/FdZbc7RHhT5MArQCCwwb4tk7taMr1OBiB4cFqa9NU2A9kVaD4/Vnkszp3O+VVblfgYD8QJW4IxY66RnbnTDzGKqoBJnu0aFLCHmKpwYX+imr03NcjLAnL2UJ/ctuTNozJyyA0JHTZzOS/dTFdL9KRp1lMJo4hOK7CxXjc/ie3HeuIKwUGbVYawg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Jul 02, 2024 at 11:19:28AM +0200, Vlastimil Babka wrote: > On 7/1/24 9:13 PM, Kees Cook wrote: > > #ifdef SLAB_SUPPORTS_SYSFS > > /* > > * For a given kmem_cache, kmem_cache_destroy() should only be called > > @@ -931,6 +1023,10 @@ void __init create_kmalloc_caches(void) > > > > /* Kmalloc array is now usable */ > > slab_state = UP; > > + > > + kmem_buckets_cache = kmem_cache_create("kmalloc_buckets", > > + sizeof(kmem_buckets), > > + 0, SLAB_NO_MERGE, NULL); > > Locally adjusted to put this behind "if (IS_ENABLED(CONFIG_SLAB_BUCKETS))" Oops, yes, good catch. Thank you! -- Kees Cook