From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D5C70C30658 for ; Tue, 2 Jul 2024 16:37:59 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 570516B009F; Tue, 2 Jul 2024 12:37:59 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 51FF06B00A0; Tue, 2 Jul 2024 12:37:59 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 40F046B00A2; Tue, 2 Jul 2024 12:37:59 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 24DA36B009F for ; Tue, 2 Jul 2024 12:37:59 -0400 (EDT) Received: from smtpin29.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id E87B4A0417 for ; Tue, 2 Jul 2024 16:37:56 +0000 (UTC) X-FDA: 82295369352.29.C249CF0 Received: from sin.source.kernel.org (sin.source.kernel.org [145.40.73.55]) by imf15.hostedemail.com (Postfix) with ESMTP id CF97CA0024 for ; Tue, 2 Jul 2024 16:37:54 +0000 (UTC) Authentication-Results: imf15.hostedemail.com; dkim=none; spf=pass (imf15.hostedemail.com: domain of "SRS0=9K6F=OC=goodmis.org=rostedt@kernel.org" designates 145.40.73.55 as permitted sender) smtp.mailfrom="SRS0=9K6F=OC=goodmis.org=rostedt@kernel.org"; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1719938264; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=m4t8JHREpOMmf6F/LyJU6yZDIZZekooPcscfFwBKwzE=; b=JmlKcm1AEu9oa+2ngYo0epto7jiMsP0CeFjaX9DWisuf4/yjm6LFSAZHMcnMm0XrFJ/Hji m4h/WXFA9tfk4yykutmXo4DKKsYlHr4g4xYhqqWf/3gVDh7KD+YpPTerdb7tqye08WGCKf GMVR8ir+WQleVNdyqqzTtpTzk3wpOHo= ARC-Authentication-Results: i=1; imf15.hostedemail.com; dkim=none; spf=pass (imf15.hostedemail.com: domain of "SRS0=9K6F=OC=goodmis.org=rostedt@kernel.org" designates 145.40.73.55 as permitted sender) smtp.mailfrom="SRS0=9K6F=OC=goodmis.org=rostedt@kernel.org"; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1719938264; a=rsa-sha256; cv=none; b=u8zGZcZuvkUZ8mseTj3cEH/PGo+suCkpxgxL8dnERJhphNbRZ0NiudA7z9yYmfmJLkqsSZ Yz3vd84UDRhFFgjMDWuFYrD6LWeQQLTA/H31U13hKTTgUiaHgigxVBPUFYu+f5MQVZ1ZtB onNbjx5ttpGpqgcrw3ut5yUZafTTPsI= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id 7D0EACE189A; Tue, 2 Jul 2024 16:37:51 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 4D882C116B1; Tue, 2 Jul 2024 16:37:49 +0000 (UTC) Date: Tue, 2 Jul 2024 12:37:47 -0400 From: Steven Rostedt To: Takaya Saeki Cc: "Masami Hiramatsu (Google)" , Matthew Wilcox , Andrew Morton , Mathieu Desnoyers , Junichi Uekawa , linux-kernel@vger.kernel.org, linux-trace-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH v2] filemap: add trace events for get_pages, map_pages, and fault Message-ID: <20240702123747.796b98c5@rorschach.local.home> In-Reply-To: References: <20240620161903.3176859-1-takayas@chromium.org> <20240626213157.e2d1b916bcb28d97620043d1@kernel.org> <20240626095812.2c5ffb72@rorschach.local.home> X-Mailer: Claws Mail 3.17.8 (GTK+ 2.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam03 X-Rspam-User: X-Rspamd-Queue-Id: CF97CA0024 X-Stat-Signature: hidohp7uqmky8s9qzenfm96ebsekerct X-HE-Tag: 1719938274-25345 X-HE-Meta: U2FsdGVkX1/Z7ejdD1k/OIaIDe1YDyEUVDWLQjxg8DDoRJuhrm4jPtxtAo8ZxeIIvV20jm4/arCRv+YKq7nFqQg6fvcG5adtwKyoQ610lUlGWE539RP3fbqsxPWqSXZCH4wCUIA//etK0OyyCsFSwAYDn/NyIWoqeBICVcrXVCW54XAj06FKTCprZbh2z6598FRBfjGxWcVGUSMrPhe+Ui4Mr/hVTXTkqW5EoeLv7e4kqPpBc9ibCn4SOfCwiBIthj4pKM6PmcMP51rXzXHGx7kSQ0xB41/L/Tx6Fq+ZOfGK3wJxuoYQt+FtuHNkEiJ2QvH0NduKtHRnpI1mpwD0CkGXaLRP6mhHJ9NYx/km20IrOHps4pCqbvKNgEZT75hci4m9hGKboLKY3X4iIcACUjRX5v53Ku9ophndGGNccOmnSDyoXk2MmIcFUjXkOJ3njgM+ZBqFUlw3Bq8XVB5L3tqc/GApKgu40fBlZUvcCC1ekdXkafbeaU9EKzLDtAc5rYITagvbafkUriKKkweY8XcGKJkcqJT9IeF2ba2WnVVjHFAD2nF+OnZkyw9HE8WzHM4eb32ShCQ6J9GhW6VNQ8bvv2LolsQxwDtYkAPO+fDoZsBM3HNfkRkDbuumKHIbd6z+Cw+Fga1eXTjR8CocK11K5yRWgd83tCPrih3S6NKQgUwtOL+bE/nb5M/GIfx/jB5HMUM9qXRtrEsfD74azTv7DRgld7chigfteDD7E2wXmkPJkQ03zhD3nucTZxz1xfKC/fZxO09S5Ae53Haevt05kiXYEbXCbuEqILpZkau9XKuYYpASVwtAk30Ed0OWYYGiNIG5LCHfYaO8PCDqgq4jrFVb71xztGgDCeMu/J7MYSbr2R/A0B6DGA5bv+1zZmMkx/4vb8Q+64nczk+Y5eqpHZZ4lxYapuiCXmKLNxLYJep95492aAvRRll7g9egYzVgZr1aGoTcK6YP0xM cmpOdfSm UB+salC6N9cnHMnDIqbBSifO7eE8MlhWaHei7Y3jisPhuVU1MVVnqrMQXk6RGUCjIzbO+m+Iu3nFdr/rKEuNlRFKZzL6PytscwfFsDWOl++joeDHX+4TgEKF+K/Ppx+DhJAraFEw2ciuEoJACz5kTOi648EAMqWY/+vn2gNNfSQ8HVmmeD9uOy7P6CXG8vyoxwE8IKAe58cmiU8mDgA56+VcPymxY7q8wf0gQjEjgVaX0WcV2FHqQGgHt6B55Xo4Rxf//SN6VNOKK4HtuiGxsnaALrloVoefp6+qeoGO/uWDzXxn76EXGHF7eDfrO+Y3/n0JBzxVmjk8aYYGCYdI8P47iOroQDZFOnCDO X-Bogosity: Ham, tests=bogofilter, spamicity=0.000001, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, 2 Jul 2024 19:27:16 +0900 Takaya Saeki wrote: > Hello all, and thank you so much for the review, Steven and Masami. > > I'm currently considering replacing the `max_ofs` output with > `length`. Please let me know your thoughts. > With the current design, a memory range of an event is an inclusive > range of [ofs, max_ofs + 4096]. I found the `+4096` part confusing > during the ureadahead's upstreaming work. Replacing `max_ofs` with > `length` makes the range specified by an event much more concise. This makes sense to me. Matthew, have any comments on this? Thanks, -- Steve