From: Steven Rostedt <rostedt@goodmis.org>
To: Takaya Saeki <takayas@chromium.org>
Cc: "Masami Hiramatsu (Google)" <mhiramat@kernel.org>,
Matthew Wilcox <willy@infradead.org>,
Andrew Morton <akpm@linux-foundation.org>,
Mathieu Desnoyers <mathieu.desnoyers@efficios.com>,
Junichi Uekawa <uekawa@chromium.org>,
linux-kernel@vger.kernel.org, linux-trace-kernel@vger.kernel.org,
linux-fsdevel@vger.kernel.org, linux-mm@kvack.org
Subject: Re: [PATCH v2] filemap: add trace events for get_pages, map_pages, and fault
Date: Tue, 2 Jul 2024 12:37:47 -0400 [thread overview]
Message-ID: <20240702123747.796b98c5@rorschach.local.home> (raw)
In-Reply-To: <CAH9xa6ej2g+DvCd=cqjj8sx9yZ=DjL6Ffu6aOfebvcjBmGs5pQ@mail.gmail.com>
On Tue, 2 Jul 2024 19:27:16 +0900
Takaya Saeki <takayas@chromium.org> wrote:
> Hello all, and thank you so much for the review, Steven and Masami.
>
> I'm currently considering replacing the `max_ofs` output with
> `length`. Please let me know your thoughts.
> With the current design, a memory range of an event is an inclusive
> range of [ofs, max_ofs + 4096]. I found the `+4096` part confusing
> during the ureadahead's upstreaming work. Replacing `max_ofs` with
> `length` makes the range specified by an event much more concise.
This makes sense to me.
Matthew, have any comments on this?
Thanks,
-- Steve
next prev parent reply other threads:[~2024-07-02 16:37 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-20 16:19 Takaya Saeki
2024-06-26 12:31 ` Masami Hiramatsu
2024-06-26 13:58 ` Steven Rostedt
2024-07-02 10:27 ` Takaya Saeki
2024-07-02 16:37 ` Steven Rostedt [this message]
2024-07-10 8:20 ` Takaya Saeki
[not found] ` <20240807211731.16758171@gandalf.local.home>
2024-08-08 16:19 ` Takaya Saeki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240702123747.796b98c5@rorschach.local.home \
--to=rostedt@goodmis.org \
--cc=akpm@linux-foundation.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-trace-kernel@vger.kernel.org \
--cc=mathieu.desnoyers@efficios.com \
--cc=mhiramat@kernel.org \
--cc=takayas@chromium.org \
--cc=uekawa@chromium.org \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox