From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id CF3E1C3064D for ; Tue, 2 Jul 2024 15:18:19 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 4BC116B009D; Tue, 2 Jul 2024 11:18:19 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 46BC66B009F; Tue, 2 Jul 2024 11:18:19 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 35B296B00A0; Tue, 2 Jul 2024 11:18:19 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 16FBB6B009D for ; Tue, 2 Jul 2024 11:18:19 -0400 (EDT) Received: from smtpin20.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id BE9BFA20BD for ; Tue, 2 Jul 2024 15:18:18 +0000 (UTC) X-FDA: 82295168676.20.F1FBEDA Received: from sin.source.kernel.org (sin.source.kernel.org [145.40.73.55]) by imf17.hostedemail.com (Postfix) with ESMTP id 8A42440026 for ; Tue, 2 Jul 2024 15:18:16 +0000 (UTC) Authentication-Results: imf17.hostedemail.com; dkim=none; spf=pass (imf17.hostedemail.com: domain of "SRS0=9K6F=OC=goodmis.org=rostedt@kernel.org" designates 145.40.73.55 as permitted sender) smtp.mailfrom="SRS0=9K6F=OC=goodmis.org=rostedt@kernel.org"; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1719933474; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=kgXWhO53FcXmKEUU/stuMCVPQGcCFwRbo5B49vX0gME=; b=AcMxWBZnQvKYTBfsvzUokpdm6SGTA272bBgxuPzlh3DzayAllIBzgsWCxPsOqos0zuoZDF z0E+Zzpixzm7q4zqy4L2dy64H5jGeA4LG2L/LU4/Gs+1TvtuAFBjmL1Gmz+gcRQSKxjGVO wF86w4+0FE5Bsg1d3MyNPqyr2H+cpqw= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1719933474; a=rsa-sha256; cv=none; b=s28zNr0KCnohI+IKq53IaSFruKt7TiYMqm80RKlfch5tpin9OhF+mypNV3wZrVdMIjGsCf 6M6jirkje3ITEdrNP+mfLTAm09OvLQ07991wrQuV8F5Bt+U3udpE1aUSUdG49ZfXRGgL2a xihq7yLmTLAPFAKuHlu+jKdL2nUBzC0= ARC-Authentication-Results: i=1; imf17.hostedemail.com; dkim=none; spf=pass (imf17.hostedemail.com: domain of "SRS0=9K6F=OC=goodmis.org=rostedt@kernel.org" designates 145.40.73.55 as permitted sender) smtp.mailfrom="SRS0=9K6F=OC=goodmis.org=rostedt@kernel.org"; dmarc=none Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id 1BAF8CE03F1; Tue, 2 Jul 2024 15:18:12 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id CADA0C116B1; Tue, 2 Jul 2024 15:18:09 +0000 (UTC) Date: Tue, 2 Jul 2024 11:18:07 -0400 From: Steven Rostedt To: Mathieu Desnoyers Cc: "Dmitry V. Levin" , Vincent Donnefort , mhiramat@kernel.org, kernel-team@android.com, rdunlap@infradead.org, rppt@kernel.org, david@redhat.com, linux-trace-kernel@vger.kernel.org, linux-mm@kvack.org, linux-api@vger.kernel.org, linux-kernel@vger.kernel.org, Linus Torvalds Subject: Re: [PATCH v23 3/5] tracing: Allow user-space mapping of the ring-buffer Message-ID: <20240702111807.13d2dd2c@rorschach.local.home> In-Reply-To: <9a9c8ea4-8e17-4e7e-95fe-7b51441a228c@efficios.com> References: <20240510140435.3550353-1-vdonnefort@google.com> <20240510140435.3550353-4-vdonnefort@google.com> <20240630105322.GA17573@altlinux.org> <20240630084053.0b506916@rorschach.local.home> <9a9c8ea4-8e17-4e7e-95fe-7b51441a228c@efficios.com> X-Mailer: Claws Mail 3.17.8 (GTK+ 2.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Stat-Signature: 7dq9rowar7dccfyxo6chmkqm7zh64bzg X-Rspamd-Queue-Id: 8A42440026 X-Rspam-User: X-Rspamd-Server: rspam08 X-HE-Tag: 1719933496-232202 X-HE-Meta: U2FsdGVkX1/5in3TY3JzxEl7YqZpukAwhZDn/KTXRJK7coIbF+m8MnLq9CF1nMZgIWH355n6N+IYil9EbQKJZ8xqRYOgAQKIVTUPi/BM2tRUEdxYyk9FjE2UendiuGqOr+A29PKmsoBhwWRo9rwbvfoPtWrrI0v6qjmPrgoPrVIsU5CxvB22jJDqV9kNnF8IPjwDLqq+EsKi5SySHRAp6w6N0XGO9unVtjdn1YInn6TxHUbaOiVsjbIspt2W3tY2to34bDbmZxujrUD+zog8Sd23bmI0TaYsMLkXxPqwO+PqIQGWY/+IOVP8OvnEIEee8/z9uBLkAmRdRljoCSKjP+LPHy9fGwzLcyPYfD0nu0YS9YOi4DldAbSpq7LGR1RgwyxVstRm/SAzfBvV81jnRP+x/2EOoJKsv07+yAAXKU7shzvwV1S+lhTpXyspIBbxIIERtU5HNaVlL1vmuhxRaKmMVhxe0pw6CgxtxcXd63Ic59xRlT9SIAZr7NVwfiJewPBwKzN0EhhjK4UtZlxTRyr04sXZFzDa68vv2KDVQnjYS3soRs2eG4Ruql1XWYmD9VXv2fkljOFgcQ8PymU/BoZ2CR6nqMaNOI+9YRd+NqC3OukdGbW4Lbmj3JdwQwhIil7Dajtw2Alz9J0inkv3h37uSvMYEZXT2sghQCwz47NHkkMklmHqe9p7evttDhLroJMjEl4QBx5GXCdq7i+K8j/KClSQb/leQlswNuYeXAG6BHLJp1ITAlzzKxTi9wP4Tz3VumthchOpctS7vYb3sfvxI4qRHcZIjrgDhs1YCFlwz2XokQ/0QJUYPl8jEmsEtH3ZAwng2pJS0mDGjiUZzzmQz4+uou/+O8veHXHNMo95Fc9co4cjs83b49FsckRouOqPKfyBwDGl1Xd8NodgwqjqHG3YXq7uC55Ndf6dkEsTy4PG0wrozzSVA5yDDfMMa5og3NFOSx4cfJhOuY4 4boQ9ZK5 haN1g57799PzXdCWsJUrHL3fuXuyp9yB3rQr/AMKsCC0gRkRAzlobVNFPELRCeM3Fkwj3cuf6I/Xz1YOWVXKrL8X5msxe7zfP8v0KB6CgJnvA6Csc4LASIcFWgy5lJum5rGjW1nUbAHvkkEqsPr2kHbx8TXwGpeVus6nHPyHndiiOJn+/Ut67MD2wglA4Am9dArDXbY1PquA+cZovwj4K6EzjYp18+p9xqPVo2cCXdN03Uip44qJ9O9A0ogP+dB4OaKWDDPkyN2HItbgJuN9E0thdN4WRlk0WPD6L3LyLqRyvjvJ1VBIWl/2/Ig== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, 2 Jul 2024 10:36:03 -0400 Mathieu Desnoyers wrote: > > I can send a patch this week to update it. Or feel free to send a patch > > yourself. > > You need to reserve an unused ioctl Code and Seq# range within: > > Documentation/userspace-api/ioctl/ioctl-number.rst Ug, it's been so long, I completely forgot about that file. Thanks for catching this. > > Otherwise this duplicate will confuse all system call instrumentation > tooling. Agreed, what if we did this then: -- Steve diff --git a/Documentation/userspace-api/ioctl/ioctl-number.rst b/Documentation/userspace-api/ioctl/ioctl-number.rst index a141e8e65c5d..9a97030c6c8d 100644 --- a/Documentation/userspace-api/ioctl/ioctl-number.rst +++ b/Documentation/userspace-api/ioctl/ioctl-number.rst @@ -186,6 +186,7 @@ Code Seq# Include File Comments 'Q' all linux/soundcard.h 'R' 00-1F linux/random.h conflict! 'R' 01 linux/rfkill.h conflict! +'R' 20-2F linux/trace_mmap.h 'R' C0-DF net/bluetooth/rfcomm.h 'R' E0 uapi/linux/fsl_mc.h 'S' all linux/cdrom.h conflict! diff --git a/include/uapi/linux/trace_mmap.h b/include/uapi/linux/trace_mmap.h index bd1066754220..c102ef35d11e 100644 --- a/include/uapi/linux/trace_mmap.h +++ b/include/uapi/linux/trace_mmap.h @@ -43,6 +43,6 @@ struct trace_buffer_meta { __u64 Reserved2; }; -#define TRACE_MMAP_IOCTL_GET_READER _IO('T', 0x1) +#define TRACE_MMAP_IOCTL_GET_READER _IO('R', 0x20) #endif /* _TRACE_MMAP_H_ */