From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 21ED5C30658 for ; Tue, 2 Jul 2024 10:19:10 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A86F76B00A6; Tue, 2 Jul 2024 06:19:09 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id A0FD16B00A7; Tue, 2 Jul 2024 06:19:09 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 861FB6B00A8; Tue, 2 Jul 2024 06:19:09 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 61E946B00A6 for ; Tue, 2 Jul 2024 06:19:09 -0400 (EDT) Received: from smtpin28.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id E1BA0A4CA2 for ; Tue, 2 Jul 2024 10:19:08 +0000 (UTC) X-FDA: 82294414776.28.03226EA Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) by imf26.hostedemail.com (Postfix) with ESMTP id 994CE14000F for ; Tue, 2 Jul 2024 10:19:05 +0000 (UTC) Authentication-Results: imf26.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=j7fuXjZk; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=gZn2I7tN; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=j7fuXjZk; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=gZn2I7tN; spf=pass (imf26.hostedemail.com: domain of jack@suse.cz designates 195.135.223.130 as permitted sender) smtp.mailfrom=jack@suse.cz; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1719915535; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=7QgfEvG+VBe8fgiEqH2xll6Fjp3VI8MfOXpkPTjxvqU=; b=2Kx8KEc/tlMK2MBOKEyxbj8/2wksgFt3QDSNbm86inqpJGLAbqpQxKr+N4/3czhZMi1s0d K+bu8ukj4JSZAC4ubjxQu/mkAin+tg2hVrj9pOfEBbLAoSVMAh339lmhmAO7sZiGBIppyP 6C3ocKamxg5qcpily+RNda+PGq1FlMc= ARC-Authentication-Results: i=1; imf26.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=j7fuXjZk; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=gZn2I7tN; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=j7fuXjZk; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=gZn2I7tN; spf=pass (imf26.hostedemail.com: domain of jack@suse.cz designates 195.135.223.130 as permitted sender) smtp.mailfrom=jack@suse.cz; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1719915535; a=rsa-sha256; cv=none; b=JFvpi8SQSR+rMSQGK+HsTEEESYKQF2aLmK9D2u00OOveMCeFulEsiZWFHN/Ms4jQ1xFgjr sF3CQzpz9WKpaJ8Ciddzl+1eQQSrN0gRrZGhvAgfOQX9i28ldDRJB+j+10RpSYnY7wSdnO zWTjG3Ojo+wD9y/OlUcS7IPGsHL6SfE= Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id C13D621AA1; Tue, 2 Jul 2024 10:19:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1719915542; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=7QgfEvG+VBe8fgiEqH2xll6Fjp3VI8MfOXpkPTjxvqU=; b=j7fuXjZkmiE8Ag2HgL272opB8gC348U1vxjpTBOtY6LE+6BtsWFohG7inTzCArFz3+/Y2A fsagrkuxeYfZ8SNgIRc8ho8lY829gEzTHrEt6cB9TicadUdIHt122lBAeI7D6DiGbUVJHp ABYPmNo0+u1Ybzt2b8ywZJKWmP+nEvM= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1719915542; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=7QgfEvG+VBe8fgiEqH2xll6Fjp3VI8MfOXpkPTjxvqU=; b=gZn2I7tNyT6UFDx6bdQBhB0nr4VJsWmxq/IWXZIsvrb6DqDNA3HlA+g+TnuOiGJ/cdZZBe +buovUNEnvNclaAg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1719915542; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=7QgfEvG+VBe8fgiEqH2xll6Fjp3VI8MfOXpkPTjxvqU=; b=j7fuXjZkmiE8Ag2HgL272opB8gC348U1vxjpTBOtY6LE+6BtsWFohG7inTzCArFz3+/Y2A fsagrkuxeYfZ8SNgIRc8ho8lY829gEzTHrEt6cB9TicadUdIHt122lBAeI7D6DiGbUVJHp ABYPmNo0+u1Ybzt2b8ywZJKWmP+nEvM= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1719915542; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=7QgfEvG+VBe8fgiEqH2xll6Fjp3VI8MfOXpkPTjxvqU=; b=gZn2I7tNyT6UFDx6bdQBhB0nr4VJsWmxq/IWXZIsvrb6DqDNA3HlA+g+TnuOiGJ/cdZZBe +buovUNEnvNclaAg== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id B253413A9A; Tue, 2 Jul 2024 10:19:02 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id N46DKxbUg2bdPgAAD6G6ig (envelope-from ); Tue, 02 Jul 2024 10:19:02 +0000 Received: by quack3.suse.cz (Postfix, from userid 1000) id 7219DA08A6; Tue, 2 Jul 2024 12:19:02 +0200 (CEST) Date: Tue, 2 Jul 2024 12:19:02 +0200 From: Jan Kara To: Jeff Layton Cc: Christoph Hellwig , "Darrick J. Wong" , Alexander Viro , Christian Brauner , Jan Kara , Steven Rostedt , Masami Hiramatsu , Mathieu Desnoyers , Chandan Babu R , Theodore Ts'o , Andreas Dilger , Chris Mason , Josef Bacik , David Sterba , Hugh Dickins , Andrew Morton , kernel-team@fb.com, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-trace-kernel@vger.kernel.org, linux-xfs@vger.kernel.org, linux-ext4@vger.kernel.org, linux-btrfs@vger.kernel.org, linux-mm@kvack.org, linux-nfs@vger.kernel.org Subject: Re: [PATCH 01/10] fs: turn inode ctime fields into a single ktime_t Message-ID: <20240702101902.qcx73xgae2sqoso7@quack3> References: <20240626-mgtime-v1-0-a189352d0f8f@kernel.org> <20240626-mgtime-v1-1-a189352d0f8f@kernel.org> <20240701224941.GE612460@frogsfrogsfrogs> <3042db2f803fbc711575ec4f1c4a273912a50904.camel@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Action: no action X-Rspam-User: X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: 994CE14000F X-Stat-Signature: asm76dutykxmpfrbskbbt3q4yqg1zyeq X-HE-Tag: 1719915545-404778 X-HE-Meta: U2FsdGVkX1+O2PP/cuysC10G8UHdR/UgjcvdhtebTSVYc68Ri+PMrQQX1a2pSwG5YzTtCIKCldLbjgFhwvZQH0Ire83EijomyQ7T6QvkWjiXmRio5yN26I/GjY5+vWc8Skaaz0NBamgcJNNkecgWdvxH9/bfvX+NhPtROHOK+EZXQjEGRv2zrGAL9opkpSzLh4EnClZrHuYkqsTX7Ur6jlTNFom84ao7YcbxpSRnRc4K5Y2mTgNxCRh2Y1od121g+TiU7Z/Me5nvjwhcu0ZdCGbL2hluGElwRbxd62e1q5mxHkAYHPBAZMd1jVmWzhHrizkznrQb4rbR2QCiDfwsrkBRc2HW0XSMmZPuwJX9UeWu9izeJ/qCytCzOlmfbmaZUvCNQTc2FJpLKD4dRFCD0jh4ZA6nzFU2banrOUkdTQq4ZGWtuATal5wBsLdoshJz+sfKgAnBDUWCSu6NE611O811WieurLoyMvzbP07DB1WIi+UPKJqn8eXma3+YmAYCtjyB9SvFl8VDKus14WcEkAEhEGbqhzKZ4JFB4TlndMiIWmV9+6x2zSElZa49C+sDbsgj9zr5cYM/8A20uUihIhwNbnT1DM0VwaJ2y5S9R/29b0WEHNTDPfQ+NawU1ej5/VkdH2acb+Q0HRXp4qHRG3em+yIGADuC+MO/ARaq2z/c5BweUpfNNosyXjadCxd26K1JfWAlLcRkbWP7m4zOHxJ7KcwQlK5ylu3lDHLsSTO4sfxUkjq8dZCuQTbBs0VsQ5/T0vZOwogkQLBrka+oK87+2Wi846KAIAEiTfcZsFP3puck+WFeNRD9pPqMdKmqVt0Hu+9un1CNQvViGkyYWtf87LvYtfSKh6c/PZ8hN4+tdKGVQznU7J1GTuivhemzHzHuK2ZlVYkWV+kuvq7IhRM5Ksa08tk/kmahZ6r4CFBtc8sjzWx6EpxwPcBhSRxcFfwwgdUwGB5pMH/AB+A r8Ct2rkz bT1J99LdodTiMiW2jRonYQRyFqLNPGuMF7KkB/U28zrej/nnQDM9VRrGNDd9R3Wjgy/ogfo6JkNkHoQuczIHM57QD73HZjaBY/0iuktBLRtM3o+BrqW/0/9K+rnkRW8qmhzUwCFE3U6xUKOVjkp5h/ELc4cg7CnOs3CSQsDpcXyoaCT2cZXxEmZsp6jAsAyJxyj6DEi4M1FEyyZ83Y2nrpaXgA8cIv6ryi/DaJqmwFW8DiN7UnIKm5cC1y9DeaCH8UjBVxLBVXs/eMq9D0ouKIE1s+ffsgKf36GAHop3dxYUvsZwpMCwXQqYNxrvmKXZ8hHvnGXDru71KHiThBgqOkeQcqdgAfsQs2ODkM9NWIK/4vn4= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue 02-07-24 05:56:37, Jeff Layton wrote: > On Tue, 2024-07-02 at 00:37 -0700, Christoph Hellwig wrote: > > On Mon, Jul 01, 2024 at 08:22:07PM -0400, Jeff Layton wrote: > > > 2) the filesystem has been altered (fuzzing? deliberate doctoring?). > > > > > > None of these seem like legitimate use cases so I'm arguing that we > > > shouldn't worry about them. > > > > Not worry seems like the wrong answer here. Either we decide they > > are legitimate enough and we preserve them, or we decide they are > > bogus and refuse reading the inode. But we'll need to consciously > > deal with the case. > > > > Is there a problem with consciously dealing with it by clamping the > time at KTIME_MAX? If I had a fs with corrupt timestamps, the last > thing I'd want is the filesystem refusing to let me at my data because > of them. Well, you could also view it differently: If I have a fs that corrupts time stamps, the last thing I'd like is that the kernel silently accepts it without telling me about it :) But more seriously, my filesystem development experience shows that if the kernel silently tries to accept and fixup the breakage, it is nice in the short term (no complaining users) but it tends to get ugly in the long term (where tend people come up with nasty cases where it was wrong to fix it up). So I think Christoph's idea of refusing to load inodes with ctimes out of range makes sense. Or at least complain about it if nothing else (which has some precedens in the year 2038 problem). Honza -- Jan Kara SUSE Labs, CR