From: Huan Yang <link@vivo.com>
To: Johannes Weiner <hannes@cmpxchg.org>,
Michal Hocko <mhocko@kernel.org>,
Roman Gushchin <roman.gushchin@linux.dev>,
Shakeel Butt <shakeel.butt@linux.dev>,
Muchun Song <muchun.song@linux.dev>,
Andrew Morton <akpm@linux-foundation.org>,
"Matthew Wilcox (Oracle)" <willy@infradead.org>,
David Hildenbrand <david@redhat.com>,
Ryan Roberts <ryan.roberts@arm.com>, Chris Li <chrisl@kernel.org>,
Dan Schatzberg <schatzberg.dan@gmail.com>,
Huan Yang <link@vivo.com>, Kairui Song <kasong@tencent.com>,
cgroups@vger.kernel.org, linux-mm@kvack.org,
linux-kernel@vger.kernel.org,
Christian Brauner <brauner@kernel.org>, Jan Kara <jack@suse.cz>
Cc: opensource.kernel@vivo.com
Subject: [RFC PATCH 4/4] mm: memcg: pmc: support oom release
Date: Tue, 2 Jul 2024 16:44:07 +0800 [thread overview]
Message-ID: <20240702084423.1717904-5-link@vivo.com> (raw)
In-Reply-To: <20240702084423.1717904-1-link@vivo.com>
This patch let each enabled pmc's memcg register a oom listener,
so if oom will trigger, release all hold pages.
Signed-off-by: Huan Yang <link@vivo.com>
---
include/linux/mmzone.h | 3 +++
mm/memcontrol.c | 31 +++++++++++++++++++++++++++++++
2 files changed, 34 insertions(+)
diff --git a/include/linux/mmzone.h b/include/linux/mmzone.h
index b56dd462232b..640a9cf51791 100644
--- a/include/linux/mmzone.h
+++ b/include/linux/mmzone.h
@@ -622,6 +622,9 @@ struct mem_cgroup_per_node_cache {
unsigned int reaper_wait;
struct delayed_work reaper_work;
+ /* listen oom event, release hold cache */
+ struct notifier_block oom_nb;
+
/* max number to hold page, unit page, default 100MB */
#define DEFAULT_PMC_HOLD_LIMIX ((100 << 20) >> PAGE_SHIFT)
unsigned int hold_limit;
diff --git a/mm/memcontrol.c b/mm/memcontrol.c
index ae6917de91cc..3dfb2a17c1fd 100644
--- a/mm/memcontrol.c
+++ b/mm/memcontrol.c
@@ -7101,6 +7101,33 @@ static ssize_t memory_reclaim(struct kernfs_open_file *of, char *buf,
return nbytes;
}
+/**
+ * This function listen to oom event, if oom will trigger, check and release
+ * all holded pages.
+ */
+static int pmc_oom_notify(struct notifier_block *self,
+ unsigned long notused, void *nfreed)
+{
+ struct mem_cgroup_per_node_cache *node_cachep =
+ container_of(self, struct mem_cgroup_per_node_cache, oom_nb);
+ struct mem_cgroup *memcg = node_cachep->memcg;
+
+ unsigned long *nf = (unsigned long *)nfreed;
+
+ rcu_read_lock();
+ if (!css_tryget(&memcg->css)) {
+ rcu_read_unlock();
+ return NOTIFY_STOP;
+ }
+ rcu_read_unlock();
+
+ nf += mem_cgroup_release_cache(node_cachep);
+
+ css_put(&memcg->css);
+
+ return NOTIFY_OK;
+}
+
/**
* This function use to reaper all cache pages by cycling scan.
* The scan interval time depends on @reaper_wait which can set by `keys` nest
@@ -7176,6 +7203,9 @@ static int __enable_mem_cgroup_cache(struct mem_cgroup *memcg)
p->allow_watermark = DEFAULT_PMC_GAP_WATERMARK;
p->reaper_wait = DEFAULT_PMC_REAPER_TIME;
+ p->oom_nb.notifier_call = pmc_oom_notify;
+ register_oom_notifier(&p->oom_nb);
+
atomic_inc(&pmc_nr_enabled);
INIT_DELAYED_WORK(&p->reaper_work, pmc_reaper);
@@ -7222,6 +7252,7 @@ static int __disable_mem_cgroup_cache(struct mem_cgroup *memcg)
p = nodeinfo->cachep;
+ unregister_oom_notifier(&p->oom_nb);
cancel_delayed_work_sync(&p->reaper_work);
mem_cgroup_release_cache(p);
--
2.45.2
next prev parent reply other threads:[~2024-07-02 8:47 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-02 8:44 [RFC PATCH 0/4] Introduce PMC(PER-MEMCG-CACHE) Huan Yang
2024-07-02 8:44 ` [RFC PATCH 1/4] mm: memcg: pmc framework Huan Yang
2024-07-02 8:44 ` [RFC PATCH 2/4] mm: memcg: pmc support change attribute Huan Yang
2024-07-02 8:44 ` [RFC PATCH 3/4] mm: memcg: pmc: support reaper Huan Yang
2024-07-02 8:44 ` Huan Yang [this message]
2024-07-02 19:27 ` [RFC PATCH 0/4] Introduce PMC(PER-MEMCG-CACHE) Roman Gushchin
2024-07-03 2:23 ` Huan Yang
2024-07-03 17:27 ` Shakeel Butt
2024-07-04 2:49 ` Huan Yang
2024-07-03 22:59 ` T.J. Mercier
2024-07-04 2:29 ` Huan Yang
2024-07-09 0:11 ` T.J. Mercier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240702084423.1717904-5-link@vivo.com \
--to=link@vivo.com \
--cc=akpm@linux-foundation.org \
--cc=brauner@kernel.org \
--cc=cgroups@vger.kernel.org \
--cc=chrisl@kernel.org \
--cc=david@redhat.com \
--cc=hannes@cmpxchg.org \
--cc=jack@suse.cz \
--cc=kasong@tencent.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@kernel.org \
--cc=muchun.song@linux.dev \
--cc=opensource.kernel@vivo.com \
--cc=roman.gushchin@linux.dev \
--cc=ryan.roberts@arm.com \
--cc=schatzberg.dan@gmail.com \
--cc=shakeel.butt@linux.dev \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox