From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E5407C3064D for ; Tue, 2 Jul 2024 07:08:36 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 7CC3F6B0095; Tue, 2 Jul 2024 03:08:36 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 77B916B0098; Tue, 2 Jul 2024 03:08:36 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 66A5A6B0099; Tue, 2 Jul 2024 03:08:36 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 494C06B0095 for ; Tue, 2 Jul 2024 03:08:36 -0400 (EDT) Received: from smtpin16.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id E3E8BC1ABF for ; Tue, 2 Jul 2024 07:08:35 +0000 (UTC) X-FDA: 82293934590.16.4550A13 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf30.hostedemail.com (Postfix) with ESMTP id 1780E80025 for ; Tue, 2 Jul 2024 07:08:33 +0000 (UTC) Authentication-Results: imf30.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=zCqjEJTA; spf=pass (imf30.hostedemail.com: domain of akpm@linux-foundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1719904097; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=LCytVzZ74oes79l/qX8u7XT2f9FwuJv/PcYhZHV84Es=; b=A8EFo1GEWN/KeMzNYeHXI4+LKC+J7GsN6/ZqjRR3Cp9AeOyeaOi6uNQww8gSpI2ttg28BL PSER2koNLUqPUGNOeerfXv4k8mckhpYDgaBcT2mDOVCVWW0P3Fkx1+7X764KC+Do15QNWs XYDom3hHYRfF8BFBYLeLbxaMhEzx5kE= ARC-Authentication-Results: i=1; imf30.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=zCqjEJTA; spf=pass (imf30.hostedemail.com: domain of akpm@linux-foundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1719904097; a=rsa-sha256; cv=none; b=T+65BDrD+Urnl8mbHqa/FtWhVl4GH+iJdt4RoOe5SrUMxJJbbtXdR/PDpigQ+2YUx0WNiu iNKsO2ubHO4DGkZI5Hq0nqhpiaNL9J+B0vy03Po6/ZP97aOhnyi3SINeqsyEdYjRRLSq3q yg8am/x5Mmk2tDzXXbNQ66CntwdGTFc= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id F3B7C6111F; Tue, 2 Jul 2024 07:08:32 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 874AEC32781; Tue, 2 Jul 2024 07:08:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1719904112; bh=Ur2WdYFv11AEMZcdkngitKXmsqaeUBQLwLAbHMfofqQ=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=zCqjEJTA8Q8sDzlE3fVnoXsW80nhlRcI9Dm1p2S/552hY2VlwTTqD7jnz/rySzkQA VDXmtjY1Re0VLgqA+IjGlavO+LLTCRsaaHlFVzZm4z7B3HbZxWtwVxzITW+RE4Hbly QmQp/e3dDhs5/LiiKQT5wgYtCMZazsjrp+0pYkf4= Date: Tue, 2 Jul 2024 00:08:31 -0700 From: Andrew Morton To: kernel test robot Cc: Oleg Nesterov , oe-kbuild-all@lists.linux.dev, Linux Memory Management List Subject: Re: [linux-next:master 9279/9689] kernel/exit.c:451:17: sparse: sparse: incorrect type in assignment (different address spaces) Message-Id: <20240702000831.718e9f9f7ebf335b02b24273@linux-foundation.org> In-Reply-To: <202406300417.JH4krMMP-lkp@intel.com> References: <202406300417.JH4krMMP-lkp@intel.com> X-Mailer: Sylpheed 3.8.0beta1 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Stat-Signature: hmgwauu8y7o7pbt8x7xsj7yweb6kypk7 X-Rspam-User: X-Rspamd-Queue-Id: 1780E80025 X-Rspamd-Server: rspam02 X-HE-Tag: 1719904113-289245 X-HE-Meta: U2FsdGVkX19IAeKGYga/Y7Am/kd6G5HBZ/KBuJLlgffWTIahLscAfyFYCwKi/VLx9Qf3dDZsvXPjRGDQEvoTtljEgqb9pt2rkoYr5oedyTte2s/Ksg4Q8PG0KPmTTh6r9QGQb8NxRe4Q7KVJCccwUQZ0ti7LZfgrxdsxslBEPQ1yaed6AMuQ6sHMrEIYcI21oGDg0383LxpGL6BbgPasNWo56hnvJjVbIR2WwF5qwnn6AjKHUGdbN37bM5KwzMzm2rUm478FpJjQ2WQyYXYHwFX3NUU0HbC9hM605UZEuEt8Slbi6SzfP4i4d/uU7SKD1sOm3vZJILqHQnArObTE6xcFwUFgHdGU8hsZntSsPFCO6WA1ECQwxRYVxhXJLArrfSVfZvLnARA+VWMSnqb7PhFbIl5ZGymXW/sf3oHSMBGBGI/x3zwj8EgFw/99lLsgDg6ckHY0X5bMcOU4eLFgXTxWRAoGAVpXFeYpSbKg5/TABIeVJ2ILQsPii0ETUXmrswrD0j3wfLhbJ/kH2hnLK5hiWsCY/4Uo/E3c22Y/P/JcM/6Te9pAs34/XDr2Bv442lHZWkbZA7GY3Nu+ihkubjYR3NwP3D7M80iWvHhHBTHDLZWVsA7c7p/ZXjwzvN0qOu6qLMha1lKL5o/k9KiDI/A/CY1H2Rx2C+jiF7y4QNY8C9jQvDl3/QB565ir+xOa4tgZciVmzXNKe+YpiLgQwvPFMhhdS/N4gyVAbCl/ipRTMkpW0za0OpoQIeb948xbRhy3saBJJG3DyxvLb5uu5xp8iwWWkNF4/hETJkxhzf/kdRVKIHu1PDUjbHlaZ4BVA+U+Hkxq6imvNkwmbEReBZyrER5zqUnCCDPh6mdsRYinTLOIKRHcu6jAfc1VUBgg1cTq5uMtrhV970obemWiIG8qHdpefrvWHb43qwcl9VRV3Ef1NqrzRcQ0/NSW5OGyUgVtjyXsK7ZOKiqI9l/ Mc0u7BGJ wGIkU0oBH6R2bh5/O6FzHvVfMyIgxHOdbHJCRPCC8Sy7RUbshGVNVINmzk857ZTnQWRbzp1hp7VFeBl+HRr+s8CiFuAgU9OEglXBVWCLHhpU1vkCEyqgx67MyEhazbqiIy4SSqmwUxHw6jhwk7JSAPgzYfcNPwVBP2JtTAffZRQYcqR9P54gnDuJpJHmdsKfea/hhUGZW7SIAnNXhekIpuUVAyo6InHMYNMqJcNLSm3yXniaCYH2MFTUL84IiFqoKr4pnRXEq0CfTz6kgtoRrqddepERKcMnz1IaXCg0+Aj/QmZUjgsY1duQ3cA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Sun, 30 Jun 2024 04:27:24 +0800 kernel test robot wrote: > tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master > head: 1eb586a9782cde8e5091b9de74603e0a8386b09e > commit: acb1a1ec810808c964c21524c1c521c3f75d2f2d [9279/9689] memcg: mm_update_next_owner: kill the "retry" logic > config: i386-randconfig-061-20240629 > compiler: gcc-9 (Ubuntu 9.5.0-4ubuntu2) 9.5.0 > reproduce (this is a W=1 build): > > If you fix the issue in a separate patch/commit (i.e. not just a new version of > the same patch/commit), kindly add following tags > | Reported-by: kernel test robot > | Closes: https://lore.kernel.org/oe-kbuild-all/202406300417.JH4krMMP-lkp@intel.com/ > > >> kernel/exit.c:451:17: sparse: sparse: incorrect type in assignment (different address spaces) @@ expected struct task_struct [noderef] __rcu *volatile @@ got struct task_struct *tsk @@ That's WRITE_ONCE(mm->owner, tsk); and mm->owner indeed has __rcu. This is a cut-n-paste of existing code, so things didn't get worse. We should use rcu_assign_pointer(), but how that interacts with the requirement to use WRITE_ONCE() needs some thought.