From: Andrew Morton <akpm@linux-foundation.org>
To: kernel test robot <lkp@intel.com>
Cc: Oleg Nesterov <oleg@redhat.com>,
oe-kbuild-all@lists.linux.dev,
Linux Memory Management List <linux-mm@kvack.org>
Subject: Re: [linux-next:master 9279/9689] kernel/exit.c:451:17: sparse: sparse: incorrect type in assignment (different address spaces)
Date: Tue, 2 Jul 2024 00:08:31 -0700 [thread overview]
Message-ID: <20240702000831.718e9f9f7ebf335b02b24273@linux-foundation.org> (raw)
In-Reply-To: <202406300417.JH4krMMP-lkp@intel.com>
On Sun, 30 Jun 2024 04:27:24 +0800 kernel test robot <lkp@intel.com> wrote:
> tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
> head: 1eb586a9782cde8e5091b9de74603e0a8386b09e
> commit: acb1a1ec810808c964c21524c1c521c3f75d2f2d [9279/9689] memcg: mm_update_next_owner: kill the "retry" logic
> config: i386-randconfig-061-20240629
> compiler: gcc-9 (Ubuntu 9.5.0-4ubuntu2) 9.5.0
> reproduce (this is a W=1 build):
>
> If you fix the issue in a separate patch/commit (i.e. not just a new version of
> the same patch/commit), kindly add following tags
> | Reported-by: kernel test robot <lkp@intel.com>
> | Closes: https://lore.kernel.org/oe-kbuild-all/202406300417.JH4krMMP-lkp@intel.com/
>
> >> kernel/exit.c:451:17: sparse: sparse: incorrect type in assignment (different address spaces) @@ expected struct task_struct [noderef] __rcu *volatile @@ got struct task_struct *tsk @@
That's
WRITE_ONCE(mm->owner, tsk);
and mm->owner indeed has __rcu. This is a cut-n-paste of existing
code, so things didn't get worse.
We should use rcu_assign_pointer(), but how that interacts with the
requirement to use WRITE_ONCE() needs some thought.
prev parent reply other threads:[~2024-07-02 7:08 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-29 20:27 kernel test robot
2024-07-02 7:08 ` Andrew Morton [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240702000831.718e9f9f7ebf335b02b24273@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=linux-mm@kvack.org \
--cc=lkp@intel.com \
--cc=oe-kbuild-all@lists.linux.dev \
--cc=oleg@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox