From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id CF29DC30658 for ; Tue, 2 Jul 2024 16:19:14 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 600AD6B00A3; Tue, 2 Jul 2024 12:19:14 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 5B10A6B00A4; Tue, 2 Jul 2024 12:19:14 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 478E46B00A5; Tue, 2 Jul 2024 12:19:14 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 27DF76B00A3 for ; Tue, 2 Jul 2024 12:19:14 -0400 (EDT) Received: from smtpin16.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id CB0CDA03B0 for ; Tue, 2 Jul 2024 16:19:13 +0000 (UTC) X-FDA: 82295322186.16.DE64375 Received: from sin.source.kernel.org (sin.source.kernel.org [145.40.73.55]) by imf07.hostedemail.com (Postfix) with ESMTP id B7D4D40020 for ; Tue, 2 Jul 2024 16:19:11 +0000 (UTC) Authentication-Results: imf07.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=oWe8+4vr; spf=pass (imf07.hostedemail.com: domain of brauner@kernel.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=brauner@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1719937140; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Eq8zDJEnwi2nE0xJwgcW+ZK5o3C4OpqK7y+68Wy9gd8=; b=07xkr66kYvn3Tkiw6TY59MxTv9l65MinLRdES1b8S7Ulv+XJwJ/iZxN+CgzuDVdeZTDnMA l7Ric2q8vzlvN6/sMe/LE4I+Oxsf+6B2ktC6MBxww5bPo7MlFa3DB1u224V+jThsNTYvEg aZu6mBWWYXwORpzrDoV7iQx7/S9jQAY= ARC-Authentication-Results: i=1; imf07.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=oWe8+4vr; spf=pass (imf07.hostedemail.com: domain of brauner@kernel.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=brauner@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1719937140; a=rsa-sha256; cv=none; b=szhmpkzdqBnuJx6ZnzbjLPIsYRKQ/5pH0esX1LrYAebOwPjdDZn+JdDbOs5ThD7oU3QX5r Ie58zHklj0S4u5hus5TpXbwE3G8PjBiouINlyi9LpMwKDFLIyajiQzdcFNlnHZB+hvRSYz qV1Y0vlpDHG3xUXFOOBYtPIGwNP8iko= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id 2E102CE1D4E; Tue, 2 Jul 2024 16:19:07 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 47053C116B1; Tue, 2 Jul 2024 16:18:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1719937146; bh=f/Lt6TGAChQhJDo1d9S1C9KYvC+2NSkWdhgXVkkdLDw=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=oWe8+4vrZ82aLpFmQ/xxCaJvhq1zmz0VUCOjwx+pO4joEWaTNHfWjLRMGZoaPiVDt budCT+VnEcgyoSf2Ab8MdsbVsBFm77eny8iEcIwJQ8JyEGL4+bTuUEjbENlNcYIpp/ gL3SnCOgO6dZZl8vgmgZ762DzwQodDtcRzBW6kItR6KjM163XwjU2Lgn7iM5pgI6/7 XBsh3uDkaMZxoYbbDoDEcrrpMrlrSldQO/fACxHAu6ntHbLUVC4HHK5mhcmY/NpEBF XVA4ga3Rk7WIXoZ0aUPw+mEDsMkvhR1DhZmouNn2Tfi29hI2nY5C6cVQ0Pr5Mz7q2M Il08gNdV6QXbQ== Date: Tue, 2 Jul 2024 18:18:57 +0200 From: Christian Brauner To: Jeff Layton Cc: Christoph Hellwig , Jan Kara , "Darrick J. Wong" , Alexander Viro , Steven Rostedt , Masami Hiramatsu , Mathieu Desnoyers , Chandan Babu R , Theodore Ts'o , Andreas Dilger , Chris Mason , Josef Bacik , David Sterba , Hugh Dickins , Andrew Morton , kernel-team@fb.com, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-trace-kernel@vger.kernel.org, linux-xfs@vger.kernel.org, linux-ext4@vger.kernel.org, linux-btrfs@vger.kernel.org, linux-mm@kvack.org, linux-nfs@vger.kernel.org Subject: Re: [PATCH 01/10] fs: turn inode ctime fields into a single ktime_t Message-ID: <20240702-inwiefern-beraten-cc4b5efce8ef@brauner> References: <20240701224941.GE612460@frogsfrogsfrogs> <3042db2f803fbc711575ec4f1c4a273912a50904.camel@kernel.org> <20240702101902.qcx73xgae2sqoso7@quack3> <958080f6de517cf9d0a1994e3ca500f23599ca33.camel@kernel.org> <09ad82419eb78a2f81dda5dca9caae10663a2a19.camel@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: X-Rspamd-Server: rspam11 X-Rspamd-Queue-Id: B7D4D40020 X-Stat-Signature: 1azmcs9j6nwokz7g8wm6wiexoeps9yap X-Rspam-User: X-HE-Tag: 1719937151-214555 X-HE-Meta: U2FsdGVkX1/slw3C4Q8cyRGqXEuwuf/1pMUdu6mnwyhPq/geyWdh8ppaOyl4u16OJpbZ/TVNE5O3CizpQYn5iL+df+8RqSPuE7W0HBCMl2p3phrIPYo2wrcFZjZaoZnHeX8aPgFT0PEQdSnorMQfz6OLHrHI1xkuj1PoUdP2zQ8LeRcp2uiVpfKrEsM82DZrd1cVrvZsU2JmpJ+w8QmMn92OYi0/tL+xtzWhYi9cJwCya0otb8mN70uDiOjmqp/uJ7Gy/RlyxrXUZYxCjD36wgNQgK0k0XgEkDbP0QM99HX3P+HzNGRRj9xMFPOnwbwFP4WXQRWJv8YKFBKY/oX1Md01790WpVdyvid8osdwWoVb0lbZEWv3ZhT1Ytz/PV3qNEG/FvbrKY6r2r1qmbzFlKbPma18F5chCFOM06g9u+EyvKrIiTlkgd579SVr/Vwb2q7MNkPOJ29OPDqq622cQzTRwirvJy9DwdDYePPDsR2MBfcXTw91sl4DzWF3h5r/ToJQzaJa3zKwcGokOcpz624RPHQQEE5Aa2cA/X5Ljhi4eaRaHjkmTFTiIXNH518A3ExLuj+7WFVMTunhIQY5dd5XYSoDibo3mxAembmvOaStQ/wiIlZ+9HOXTkp1rFUCdBKLrapoOiLKdtTYyRuTYE82mIqlyk1HwjQewBgyTRC1R3cim3fYdhf7SuEPcNjKoUAL6Vt+kqi6D6ioHuc72BGkCGzXfg03fqFfExxUqrLEw2iIB+w5UDRJ1o1TzAs/bEN5qHdDShu1yNyTUtE0YaHnmYr7/840KM/pAqDjMmdIegVzmo8tZE3tzKBNWqKULXMMfgBlXLNj0pYJhaKom4Vg+A855IgpA5HD3yplqjdluaqw4I5okyVcppr8L7IFo03blunpHLC3UUKsrfZOsc+BiuVp9rVtb10/PpmkoAOE8RhXDRRi1EgZ3oHIovtmtakQ701sXnZqWrnudMD eL+74/0B YHt8uzwdfC2QqtBK6DFiunvdmsEQ41Siideuun4RA6odCKJ3ng7IPvzsFG8Z09O+6G9Bmg0FQFZKM+hQBZVYmP5E1lAK42Pkq3hHC5HeU+jZbxC0tweXX0TT7d5y6L0TqJNSxQ5hF9h6MwiXyj/lDNZAXPVfx3ZvBtwHHsCZe22OsystH92GgXsJdnDOX5/hMU9d0OcV8fUXZVRxvWke2LBO84SK3KCB1XIeFHPG7VbeAe+Y2RAU0YXeaQWYPXjmyK5ux584O5ryeDN4qfc6jk+ygiKS0fSrBBvRccQw815riUVqRLkRYXPtAs+9ICzA90/tu X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Jul 02, 2024 at 08:21:42AM GMT, Jeff Layton wrote: > On Tue, 2024-07-02 at 05:15 -0700, Christoph Hellwig wrote: > > On Tue, Jul 02, 2024 at 08:09:46AM -0400, Jeff Layton wrote: > > > > > corrupt timestamps like this? > > > > > > > > inode_set_ctime_to_ts should return an error if things are out of > > > > range. > > > > > > Currently it just returns the timespec64 we're setting it to (which > > > makes it easy to do several assignments), so we'd need to change > > > its > > > prototype to handle this case, and fix up the callers to recognize > > > the > > > error. > > > > > > Alternately it may be easier to just add in a test for when > > > __i_ctime == KTIME_MAX in the appropriate callers and have them > > > error > > > out. I'll have a look and see what makes sense. > > > > The seems like a more awkward interface vs one that explicitly > > checks. > > > > Many of the existing callers of inode_ctime_to_ts are in void return > functions. They're just copying data from an internal representation to > struct inode and assume it always succeeds. For those we'll probably > have to catch bad ctime values earlier. > > So, I think I'll probably have to roll bespoke error handling in all of > the relevant filesystems if we go this route. There are also Shudder, let's try and avoid that.