From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 49FC2C2BD09 for ; Mon, 1 Jul 2024 23:48:14 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B7A6E6B0092; Mon, 1 Jul 2024 19:48:13 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B02796B0093; Mon, 1 Jul 2024 19:48:13 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9A3E26B0095; Mon, 1 Jul 2024 19:48:13 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 774A06B0092 for ; Mon, 1 Jul 2024 19:48:13 -0400 (EDT) Received: from smtpin16.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 1708F40E5A for ; Mon, 1 Jul 2024 23:48:13 +0000 (UTC) X-FDA: 82292824866.16.7A7D235 Received: from sin.source.kernel.org (sin.source.kernel.org [145.40.73.55]) by imf07.hostedemail.com (Postfix) with ESMTP id EBAA740010 for ; Mon, 1 Jul 2024 23:48:10 +0000 (UTC) Authentication-Results: imf07.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf07.hostedemail.com: domain of "SRS0=awNW=OB=goodmis.org=rostedt@kernel.org" designates 145.40.73.55 as permitted sender) smtp.mailfrom="SRS0=awNW=OB=goodmis.org=rostedt@kernel.org" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1719877666; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=naoOhCWovImJVKn5UOoJMmyp3v3Ae4Ayo1u33lwKWdQ=; b=YpKJiu5+1vUYx6UiNJl9XrAJxaiQ2FwSdq3UexFgxrKGWpdo3Ojk2cJyTExrn5lqJqi5cK 4DWXklcZY5g0o3Q4uLFZ3rreNUWpNZt4U9/6feJo8LOqokzVlw2XXGK1OqJvgWNfHf1ps7 sWkbqdSG47/TfElAL0/j6kcMl6KaYPU= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1719877666; a=rsa-sha256; cv=none; b=wyAkOY/+KJGZpT0RkZsxLGZuSLCj4ixNqx6tV5Y77HVi7dexmdM9l9EGCWar3S5qtI/BxJ TZrlQi3QTMbLtX1/kajH64oF1UHWbY8voZJl0H7Up081tfSZrmL7FBM2beEaTi4op/g32q y+PFtmV8P+BEbsln07grSrvBCujosZA= ARC-Authentication-Results: i=1; imf07.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf07.hostedemail.com: domain of "SRS0=awNW=OB=goodmis.org=rostedt@kernel.org" designates 145.40.73.55 as permitted sender) smtp.mailfrom="SRS0=awNW=OB=goodmis.org=rostedt@kernel.org" Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id 53020CE1BBF; Mon, 1 Jul 2024 23:48:07 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id C574CC116B1; Mon, 1 Jul 2024 23:48:05 +0000 (UTC) Date: Mon, 1 Jul 2024 19:49:06 -0400 From: Steven Rostedt To: Hongbo Li Cc: , , , , , Subject: Re: [PATCH 2/2] hugetlbfs: use tracepoints in hugetlbfs functions. Message-ID: <20240701194906.3a9b6765@gandalf.local.home> In-Reply-To: <20240612011156.2891254-3-lihongbo22@huawei.com> References: <20240612011156.2891254-1-lihongbo22@huawei.com> <20240612011156.2891254-3-lihongbo22@huawei.com> X-Mailer: Claws Mail 3.20.0git84 (GTK+ 2.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: EBAA740010 X-Stat-Signature: zx5uudqkoqt554xk5zri88kaebu85ecd X-Rspam-User: X-HE-Tag: 1719877690-484082 X-HE-Meta: U2FsdGVkX1+/vO3HOizL1rbvNU3MYv1ySMVRUeZz5ST28B6teiYEGp+AjGS6F8PI0L/nP5n57Q3EEVD4C5Uf7MIakjqXaTcLkPweIbheLPqATWc+8FOdwcCdETfIH+NXcKiAMeik5lTR6dK/3pLJcSmvXpZH44+9rWGUw3urfo+8Ecsi2kAuxQy4ks8AK7HfReSwjih00euFYg3wrUYqk6izoQJg2OOzu45kJeXeGoOIUdCnx7wCp9Yc0m/0yKBYvVaiGGYIEqNvbdpmqssxK17lMG18xOTCpf9sbiaKeCROi+NdoDyLd5HgYaqfRy2Bsf65thqK8XiTm8tZnHALUmf/8YpdtEk4ql3XXAgbCBK482zJLuOEgCR/T0ra96sM7KuS9Hqc0a4rMUbRWj0NWCzGmyr3vopsjzEY7jlebv986SVH1OiblNUcovhS3qsA99dgZ4Y8hBvNzov37BC4lWu320vMQ7UJPexJySd0Jeq//kZKg1qVk5nZR+Dsf7XfsWcd9ZHsv5CSLvGYiabmPKTUM/82c1aXwLRQS06GiFX/6Ebt1JWCkPZFhvEMe1CD7eQW5hom7rphg06CgVofRIj13meo4ONU4EJt4ccw+JT7nS3SuUUUyzlIAwa/Q768m0x9KbdlTbjDIRLHcRzo9GaAajffCBPuYW29BDJjeNUxcb66af6OB1AwdHM6+nYdgmkUpOXjcGvgJ2rV5DoX4/KDdmzo0PPvDfS+3fCPQeuONJPLxbsia+IvsmO8K/5wstXyBdpRZlk61K3nLKjE9NVNG9dmcObIskcfY0fYapGqFSqat2l/naQqSoaOxqvKzh9sYxbdHqLhw8S4AFw3m3OtPBpuJ+9l2kNyaJStltQBrywUs5f4b2hmchBgPFSLMg1oaQ/3GgApNwMgHrFzLXHx0c1IGQk1WJAUlZ+5b1T1fZq00uf53HxQykYZ+0sQvc5Natz6cOR6w6srR4W zmRDMGy3 2iPy7OIsKrRh9ZQkVJkr6n66KEPp9zZ5wozw2Nz2kev1YemJhsRbx6xhBgciwvZ/aHm83OpbeMjp40qhNVgSSD1vNMsjKXeHW9xTdOEiWBG6dqtqfo+qF8DRMAXEnObmAZlrr6U+fODSO+ZjPrcByTVwu8s0pOOh8AdFJ8nWZ/WuhLQgV4tDUtcD1fQ9ql077u+ZEZF+F6bWPRa2+1FJCFysI/bPC2fTEmbw4kOVRjw+HC1kN9QDkoZVChjjRODNqhvyeg12RpZ6e5dQ= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, 12 Jun 2024 09:11:56 +0800 Hongbo Li wrote: > @@ -934,6 +943,12 @@ static int hugetlbfs_setattr(struct mnt_idmap *idmap, > if (error) > return error; > > + trace_hugetlbfs_setattr(inode, dentry->d_name.len, dentry->d_name.name, > + attr->ia_valid, attr->ia_mode, > + from_kuid(&init_user_ns, attr->ia_uid), > + from_kgid(&init_user_ns, attr->ia_gid), > + inode->i_size, attr->ia_size); > + That's a lot of parameters to pass to a tracepoint. Why not just pass the dentry and attr and do the above in the TP_fast_assign() logic? That would put less pressure on the icache for the code part. -- Steve