From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E2520C27C4F for ; Sat, 29 Jun 2024 08:48:37 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 51C966B0092; Sat, 29 Jun 2024 04:48:37 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 4A6206B0095; Sat, 29 Jun 2024 04:48:37 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 31F596B0096; Sat, 29 Jun 2024 04:48:37 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 0F4B26B0092 for ; Sat, 29 Jun 2024 04:48:37 -0400 (EDT) Received: from smtpin30.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 872671A0CA5 for ; Sat, 29 Jun 2024 08:48:36 +0000 (UTC) X-FDA: 82283300232.30.9F43A9B Received: from mail-ed1-f42.google.com (mail-ed1-f42.google.com [209.85.208.42]) by imf06.hostedemail.com (Postfix) with ESMTP id 9DFF0180007 for ; Sat, 29 Jun 2024 08:48:34 +0000 (UTC) Authentication-Results: imf06.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=YVEFe9AH; spf=pass (imf06.hostedemail.com: domain of richard.weiyang@gmail.com designates 209.85.208.42 as permitted sender) smtp.mailfrom=richard.weiyang@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1719650905; h=from:from:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=ALzxbErgfML0p56UFdXj7pSgizzuzskSyEZcd/ECc0o=; b=zuRgsZJ4q+/HSks0zlL8Ir6iOGslR5UVaD8preKO+qLF3hEW8rqD5N8pxQ2FPgfsKfEbn7 k+jj844WLgH5ScV5O0WhIU5iV3gnwAA30Bk7my1O9LFSeQpVnSqzOLSufWiQugVUKIdwa/ caGSOmdAv7kpw2eY+svOzwMWM5cbOEM= ARC-Authentication-Results: i=1; imf06.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=YVEFe9AH; spf=pass (imf06.hostedemail.com: domain of richard.weiyang@gmail.com designates 209.85.208.42 as permitted sender) smtp.mailfrom=richard.weiyang@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1719650905; a=rsa-sha256; cv=none; b=YB4l9EMTAJaQuGgZ0tUXHVX3u9B6zLG0a7r4gKYrPAsD88k6OstR9uQWDrycfOWFbcWsUB 8OZvAAasNgSUL4Ucrhhs3/BXk41GyHl5ilIPTg7Q23LjniL9XRsGmiSg04Wdd42lwASTUW QfBiQcbBTNWbQqRprLJmx+/oK6VuYLI= Received: by mail-ed1-f42.google.com with SMTP id 4fb4d7f45d1cf-57d06101d76so1658934a12.3 for ; Sat, 29 Jun 2024 01:48:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1719650913; x=1720255713; darn=kvack.org; h=user-agent:in-reply-to:content-disposition:mime-version:references :reply-to:message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=ALzxbErgfML0p56UFdXj7pSgizzuzskSyEZcd/ECc0o=; b=YVEFe9AH8tYAjK50lvur3MlDG8cYk3YZKy8xB2XU2oBBdUht9Gt7aL60zaTP+0cXQx hyRCjamcets0Ld2UlZ+Vyy+rb8Xyrw6RewnDm0m4pim0Mb106++u85SOaOIKpXrSGBVA HdlTUcMDIxZ/2ORp9Gmla5RQdV8eLbtUDROJSpegyU2ndV6//Wt9DCqSCQAbmE/Y3iY+ HjT4/YNMCt/DElZW+G3PJO8uZheuhtmdNzQqUTPLdegzhY1QTgWsCxQbA+eRL/oS/XNh GIC5yiv5W0/jilR/YbVvFIJSSEUjQppvF403KdhDpRBKLlpuQobl/9aldMR7AmKYmydR lmjQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1719650913; x=1720255713; h=user-agent:in-reply-to:content-disposition:mime-version:references :reply-to:message-id:subject:cc:to:from:date:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=ALzxbErgfML0p56UFdXj7pSgizzuzskSyEZcd/ECc0o=; b=lTZtIo9nemZ6rW7uq9Ixl4mjrYgI6GlUCb8moLXmVZyK1AR6IuPd5vaqTAuDOoMkP7 iautRspemSWhuXQBHsLqQwO9K8iADdVs4LqzGJqwoo9xi/iMHThHThL0WjHktsIJLfn4 61VlVAdcU/RMr97W8bOCRkQpB6inVXeeIHX2mwNrb66dqbt3TYe43VndElFEX6J97+4s ej1BpN5aksYJm4wMPjnTmLzdttOUQxCL0KWnCz7YS7UH0mcpFYxZmdzj8bXoXxOQ6zxi an2UYXQ/VswXhyhGK73x8tYrSIEweGrzdryDyUEXD4j+3XT7O7Qmi6+Dn/WAI2Cki5nP XSJg== X-Forwarded-Encrypted: i=1; AJvYcCWWZDuBnXF132YzS1NnF123eNPuK0eG+YxJ7LiKfrG6b4zlIorappJNsuBElPW+D/Q1CFEnWNWI2j6VLXMK1jizsDw= X-Gm-Message-State: AOJu0YwUeaC9Cb7XHkrIQq0iBIpdJEoiH6WqSJd7UATfyo3kYzHIYOBS rPxpOEzxWV5889QWvxPBZwcFJMPVhNpamLSgAh1IcLs+ugsuIftVcZkqJTaw X-Google-Smtp-Source: AGHT+IHXg8miA9LPusWhWZRvQP00iHEvNAxWg/FFp+/FlrzGrBDZh6frewIUb5HcTy57gswXrKni5w== X-Received: by 2002:a05:6402:3444:b0:57a:322c:b1a5 with SMTP id 4fb4d7f45d1cf-587a10d8502mr310741a12.38.1719650912897; Sat, 29 Jun 2024 01:48:32 -0700 (PDT) Received: from localhost ([185.92.221.13]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-58612c83707sm2028661a12.15.2024.06.29.01.48.32 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Sat, 29 Jun 2024 01:48:32 -0700 (PDT) Date: Sat, 29 Jun 2024 08:48:31 +0000 From: Wei Yang To: David Hildenbrand Cc: Wei Yang , akpm@linux-foundation.org, rppt@kernel.org, linux-mm@kvack.org Subject: Re: [PATCH 4/4] mm/page_alloc: no need to ClearPageReserved on giving page to buddy system Message-ID: <20240629084831.tlf47h4fd4vftl76@master> Reply-To: Wei Yang References: <20240629013322.12364-1-richard.weiyang@gmail.com> <20240629013322.12364-4-richard.weiyang@gmail.com> <4a93f7b7-8ba8-4877-99c7-1048674d074d@redhat.com> <299a4d6a-6b76-49b7-be2e-573cd66fd46f@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <299a4d6a-6b76-49b7-be2e-573cd66fd46f@redhat.com> User-Agent: NeoMutt/20170113 (1.7.2) X-Rspam-User: X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: 9DFF0180007 X-Stat-Signature: st1w8qikyitqdi4ayp6dg6uyic5qdkez X-HE-Tag: 1719650914-643413 X-HE-Meta: U2FsdGVkX1/0MUfIZ48MuJdpjE+PNpOQ0JhA0FwwJzPBxPBF1zgmNQEFe2oca5Hy5GxTMiluY7mr96OIF5cG7F71YNZ+GyhvME/aus2xgandOHKd1JXfBXuaDdlXIcdVoWfz1lzGdARxTGUYo0X14xO2HrtFO1t7/KE2sX3oG5E1p25VdPkswkiNHrV+qo/xaZHANlkBtnow94fbWgSo2IuNoiSm6Eq96q+6/5e05JmnDjVZ3dMz2mbYGr6zGKds90NCfLg/DYIcT+MKCu+72ZIIHQwAVGk3s5gtGlpHVjyTi/8XQlrl3LRjAPbNBPuxL4Z15ntlyQVCzk1xbzdar2/HGcrjrEtRNc3rPsmbOiPj+trUCo3iolCVbkU7yFZmXWD8sBT7vAMb+s57g5a5ZPHFP+lFE+WhQpqKB7xQTbwYNsrBZ64VXmLCYEN311nQCrX0/PQ2TmV4gHi3AQhpKw29r/8HSfdlgBuZY4uDUBcBi5VR0WTngd58BdHXHKn3MC6AScok3XeDLComgImng0p6emqVxliQl56y8KtRzpCV9rabqpdyC4oQwKxPQVdtJurkhvMGtl0wz+yQPxGFfMPkRhxjNxq7d0iq1KIc+eRToPu69ZoaTMTiMoNgD8JfLSsfkdIEbRb15yZxZXc4ZjLw7iChO3JOZkHkoTxJF3o+32w9rY337QPT0sO9ljU32SzPFDzSrCwz+bZjMRdZ18ii2hsLOdCP05h68Q8env3xnqY8nbYZz3v75NlxpCu4bRHERV0n9eazgMlqy9hooHcFL2t2zTZvMarNNc5tK6Rl69Y+hsj2n4p+S5+GFrn04o6Gdvrhs4RL39FIHVoMyt11XBrm3x5cDWd2nMebcnymieZQFMUJSwA3o72mSwk0enC9KPgzDiRMrT+X7R3s84Tkv6tzljDzJimYrs71tCmyzraw3ozlap/Go97iNXtbES85+72jnDY5NiT6OMa yqH+eKxl SI6CM+IaKI/1qIRYK+NK5Hw3PjdK9HNbbj0qJgcyk1cAq2+x6eAQSZlNTcxtDRK5HMG5oHgEFuBP7H4mKvIr3ZgCbKsDBdlS/17MVt7vbkytY/nKhM5g0LOq/BavNl/IcZaIjcFHUmn9JelgZlM+VRE3zax2y+SizNVE9S9DJ5OkD7fpFOS8a+UkUP/3pClmgwKblDYbPFxi7nYEz74fwC1YoCDoGy04ds+nY7CHU0Jxw6UBtlllyX5TM8Y6X0+n/Fx7+wRzgFhamLK/LwYwXI4et8KdMUMd/li2rFTtddLuWCRnetTHZ7vE/1tHdHG+mXJbhvHhhZfzB8e7BnyPDshi5XGOG1L5YtZh2ZGVP6dNeiITkoToQeovPusY2vo7NAu1tR93ceg6D8CPEQPJ2LpEkcHPYsBexT2pU1/UBtgf4h0m7tBBvmDNvWDbx99WW5EPlCOOxTqEI3xE6j+TXIMzUyjH3wNYhPnYo3QMz1kBOYwl4YyXQBVrnmvUbu6NvqpRdIubI56es21MkWoxH13KlsFFQt2r9iVU0A5DxQWzF7i/uWhIzoonIgg02Q7iv3VaFhaebi9G8+jnXwy6l1UPGL8qS0Nxs1K6rq9pc0TeBu2YTYmYQ3Ieg892nfs0QcKMTvK1xu5QnD1EyL8GTUJPh74twpTVY1fhRY0kYbsbOZZl62IjirX6HycpWM5Ay4Uk5mIIrfNq+hfPGZG+zQwu3sWL6+MEiF257KCEnZUY+YdBYQFccSmozScO0TAGECZVvn/NRB/kD19cYDd2lSo8+MQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Sat, Jun 29, 2024 at 08:28:30AM +0200, David Hildenbrand wrote: >On 29.06.24 08:25, David Hildenbrand wrote: >> On 29.06.24 03:33, Wei Yang wrote: >> > Function __free_pages_core() is only used in the following two cases to >> > put page to buddy system: >> > >> > * free bootmem >> > * free hot-add memory >> > >> > After the above cleanup, there is no case to free page with PG_reserved >> > set. Let's remove the clear operation. >> > >> > The page initialization time shows 6.5% faster with a 6G qemu virtual >> > machine. >> > >> > Signed-off-by: Wei Yang >> > CC: David Hildenbrand >> > CC: Mike Rapoport (IBM) >> > --- >> > mm/page_alloc.c | 2 -- >> > 1 file changed, 2 deletions(-) >> > >> > diff --git a/mm/page_alloc.c b/mm/page_alloc.c >> > index 51a47db375b6..bc7316744a34 100644 >> > --- a/mm/page_alloc.c >> > +++ b/mm/page_alloc.c >> > @@ -1232,10 +1232,8 @@ void __meminit __free_pages_core(struct page *page, unsigned int order) >> > prefetchw(p); >> > for (loop = 0; loop < (nr_pages - 1); loop++, p++) { >> > prefetchw(p + 1); >> > - __ClearPageReserved(p); >> > set_page_count(p, 0); >> > } >> > - __ClearPageReserved(p); >> > set_page_count(p, 0); >> > atomic_long_add(nr_pages, &page_zone(page)->managed_pages); >> >> Again see mm/mm-stable where that code changed. >> >> I think we can still get reserved pages here, for example via >> kmsan_memblock_free_pages(). >> You mean ZONDE_DEVICE pages? If yes, I think the normal memblock_free_pages() still could get reserved pages. Am I right? > >Sorry, I meant kmsan_memblock_discard(). Yep. >-- >Cheers, > >David / dhildenb -- Wei Yang Help you, Help me