From: Luis Chamberlain <mcgrof@kernel.org>
To: p.raghav@samsung.com, hare@suse.de, kbusch@kernel.org,
david@fromorbit.com, neilb@suse.de
Cc: mcgrof@kernel.org, gost.dev@samsung.com,
linux-block@vger.kernel.org, linux-mm@kvack.org,
patches@lists.linux.dev
Subject: [RFC] bdev: use bdev_io_min() for statx DIO min IO
Date: Fri, 28 Jun 2024 14:23:50 -0700 [thread overview]
Message-ID: <20240628212350.3577766-1-mcgrof@kernel.org> (raw)
We currently rely on the block device logical block size for the
offset alignment. While this *works* it doesn't work with performance
in mind. That's exactly what the minimum_io_size attribute is for.
This would for example enhance performance for DIO on 4k IU drives which
have for example an LBA format of 512 bytes for both HDDs and NVMe.
Another use case is to ensure that DIO will be used with 16k IOs on
existing market 16k IU drives with an LBA format of 4k or 512 bytes.
Signed-off-by: Luis Chamberlain <mcgrof@kernel.org>
---
block/bdev.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/block/bdev.c b/block/bdev.c
index 1b4af2cc3b1e..5d0874aa8661 100644
--- a/block/bdev.c
+++ b/block/bdev.c
@@ -1282,7 +1282,7 @@ void bdev_statx(struct inode *backing_inode, struct kstat *stat,
if (request_mask & STATX_DIOALIGN) {
stat->dio_mem_align = bdev_dma_alignment(bdev) + 1;
- stat->dio_offset_align = bdev_logical_block_size(bdev);
+ stat->dio_offset_align = (unsigned int) bdev_io_min(bdev);
stat->result_mask |= STATX_DIOALIGN;
}
--
2.43.0
next reply other threads:[~2024-06-28 21:24 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-28 21:23 Luis Chamberlain [this message]
2024-06-29 6:25 ` Christoph Hellwig
2024-06-30 3:24 ` Luis Chamberlain
2024-06-30 5:54 ` Christoph Hellwig
2024-06-30 20:42 ` Luis Chamberlain
2024-06-30 22:35 ` Dave Chinner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240628212350.3577766-1-mcgrof@kernel.org \
--to=mcgrof@kernel.org \
--cc=david@fromorbit.com \
--cc=gost.dev@samsung.com \
--cc=hare@suse.de \
--cc=kbusch@kernel.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=neilb@suse.de \
--cc=p.raghav@samsung.com \
--cc=patches@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox