From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id CCB3EC2BD09 for ; Fri, 28 Jun 2024 23:59:27 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 69A926B008C; Fri, 28 Jun 2024 19:59:27 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 649566B0092; Fri, 28 Jun 2024 19:59:27 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5428A6B0098; Fri, 28 Jun 2024 19:59:27 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 3379D6B008C for ; Fri, 28 Jun 2024 19:59:27 -0400 (EDT) Received: from smtpin21.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id B6C2E80837 for ; Fri, 28 Jun 2024 23:59:26 +0000 (UTC) X-FDA: 82281966732.21.87F3599 Received: from sin.source.kernel.org (sin.source.kernel.org [145.40.73.55]) by imf19.hostedemail.com (Postfix) with ESMTP id 910221A000A for ; Fri, 28 Jun 2024 23:59:24 +0000 (UTC) Authentication-Results: imf19.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=GGSqFKvO; spf=pass (imf19.hostedemail.com: domain of akpm@linux-foundation.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1719619146; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=INzl0VAMtB9S7QxnFkCqH/p4EcPJarQG0UL4FcqhOq4=; b=tCfi4lI7DG/n5uF3QLvSUkh1+u03dt1sB4YX/wvOkV6tK4nUXuNX0Mf3ar6U+E8K2lfZpG oaPe2h4q9gP/nzLhIPjWxQDHcVZGD5X39CckHCkWMlVWy8Qc1UlrHMd2h2vv571qcBKaWL TTWZfapL1u0aSkkkvSUwdCjvEpSum7w= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1719619146; a=rsa-sha256; cv=none; b=wy02MqYEXwKAJophixzH76C6EYQ/91wVqy7sqWTmU/RdguW24bVWrdJtFD6YbOjJUeaQDn +9woi8skd3xk5oO1jn31E7giZBWFaOboM5f4zMlNHKxiitkvz73st+vG/DxorWOKlMqlGs s5fh/TPNsH0BuusBs+KrtZLTBZDyWi4= ARC-Authentication-Results: i=1; imf19.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=GGSqFKvO; spf=pass (imf19.hostedemail.com: domain of akpm@linux-foundation.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id 3CDBFCE0E7C; Fri, 28 Jun 2024 23:59:20 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 3F0B9C116B1; Fri, 28 Jun 2024 23:59:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1719619159; bh=INzl0VAMtB9S7QxnFkCqH/p4EcPJarQG0UL4FcqhOq4=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=GGSqFKvONULBPIcg9d7uxnX18/RdTnWWAQqVSsoj4b5pHffSZs57Dr3JaM4RePolX Tv7BfovQQ0cAI5IRoZzNcHtN2Wngr6lUSt9r6ods1kfLRcdh3gqRCVpDmJLJB0iVto s0ZDIxl+ee+XiqC4APqXH5uKh+xJc6qkaegV/Uo0= Date: Fri, 28 Jun 2024 16:59:18 -0700 From: Andrew Morton To: Chengming Zhou Cc: david@redhat.com, aarcange@redhat.com, hughd@google.com, shr@devkernel.io, linux-mm@kvack.org, linux-kernel@vger.kernel.org, zhouchengming@bytedance.com Subject: Re: [PATCH v2 0/3] mm/ksm: cmp_and_merge_page() optimizations and cleanup Message-Id: <20240628165918.f9f2d7eb230cf26cd6d0c81b@linux-foundation.org> In-Reply-To: <20240621-b4-ksm-scan-optimize-v2-0-1c328aa9e30b@linux.dev> References: <20240621-b4-ksm-scan-optimize-v2-0-1c328aa9e30b@linux.dev> X-Mailer: Sylpheed 3.8.0beta1 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 910221A000A X-Stat-Signature: oqiyc99p571bonrizgt4g4dwiwduyx44 X-HE-Tag: 1719619164-536571 X-HE-Meta: U2FsdGVkX19/DE34aIB0ZhiDp9+0EPoOxx1eZ8eeA0+gyNMQZHosu3TYfwYcMOcXjsJDhgV55fTXtSMp5cP0tf2vsDS6GA1q8iBbwpEvLofa7S4Gsy0SwDcVB6cgVWez97vdxZMpjrH/BvC9MWD475u/975Vf20BhhMwLg6x+diQtPPTL/ogUsm3nFagfhY2Z2AIWljB+IvnuoylNWb6Da4QfWCGBeyAM1LxkmLiALG1uN71bGjQqkz8hLORtf8c5pOzUdin/o7B0BHHFEnnl8VhjiJsa+o6YPfkZQzHToQowli1Zbr3IZqwNYA5LcCxV0o9bbN818o7o9kwZWkDpjU4Q+WKqh55ZPfkxOW/ooic0G4Fvo1Au9Sfp8atWNm2JC+kcA8UKsDUsA3ZY5iA4j3tYN9klJQoUcPEM36JQuyi5GiSsxeA8goDSyHAxRn/IMKCV4RiDqyBP6oNWAr2e6N/Avw33lIVSkJEfptnqKJyCpjWQf5sOW1GaO86cIKqSVDhO6XyxP/93t3J7eWpxSecihRccUIDGdjylGc9uCA+CysreaoaxmIMEOxt8APnmqIlLq0ddQsOmRC1eHjinmi970IwMZrB/cm6FoxlkiHsVFokOSpm/xR2m1e9yCLJfZlcfdWBruEJQPu5Z2PrUr62p6p92vu2ggE5/O/vtgkh9eGfHJu9cZd0yjjDwxHgRTwfYWFFP8NECpex3dfOmxPcDWMb2IN7Uj8jRuFGhF07DTbQriQMtBpJlzOqV35mkPdsPAStRKqJeupt+uqRhi3+ePOzBEkb56Fvm2+EcfK7Wim7/uNEExeFe5cZw2hj3M79YBTUoOikW9Uv9lDwuc4l0upV89qHjK96U15LMSrjlKvvhMfIdZtFSa8T6qOBX+o8U7TB+mZGouAcS1+qRDlZqI/wihU4UPhRTcEf9YGT0mJlw7Of7rsVkrvq88f9fEoBLatEnGDHDzsqC+2 jvLjTZ0j btR+L+9agNKD3dICRQY/m2mGwEA3kEoJpV2ToKh43t4ODQ6fV6dxI8XWHFjNyp0j6LInzjGUMTpXQbFH0jXjSZNoI3cmcbvczaYtKi19OKV7wNUP6rJco29fdjCgi6GFh/tHRYoa/OSyOKKEnnYn9wx3o3aqtjLB0qadV1tXNIxf50ydrtJT7N7RFAfRWQc1XQFatQap2+rUn0mAgPeFinzEpRlJjCdKi7w2ivAWhg2j6pmV723YWFj8dVw3etFAK8jImBv/XSfxiaBUHoRvM+WYWg+XXXdzdwAUgDAhvwvlSUKg= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, 21 Jun 2024 15:54:28 +0800 Chengming Zhou wrote: > This series mainly optimizes cmp_and_merge_page() to have more efficient > separate code flow for ksm page and non-ksm anon page. Is anyone interested in reviewing this patchset further?