From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E7B34C2BD09 for ; Fri, 28 Jun 2024 02:25:08 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 6E8F76B0092; Thu, 27 Jun 2024 22:25:08 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 671516B0095; Thu, 27 Jun 2024 22:25:08 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5112D6B0096; Thu, 27 Jun 2024 22:25:08 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 31EEE6B0092 for ; Thu, 27 Jun 2024 22:25:08 -0400 (EDT) Received: from smtpin22.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 9B55012023C for ; Fri, 28 Jun 2024 02:25:07 +0000 (UTC) X-FDA: 82278705054.22.8BC84AA Received: from mail-pl1-f181.google.com (mail-pl1-f181.google.com [209.85.214.181]) by imf03.hostedemail.com (Postfix) with ESMTP id C012C2000E for ; Fri, 28 Jun 2024 02:25:05 +0000 (UTC) Authentication-Results: imf03.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=HEXi1DY2; dmarc=pass (policy=none) header.from=chromium.org; spf=pass (imf03.hostedemail.com: domain of senozhatsky@chromium.org designates 209.85.214.181 as permitted sender) smtp.mailfrom=senozhatsky@chromium.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1719541486; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=EzO2A8iz6wHJZqZfsXCD1vEPIy2KLr5tygffi7vIE4Y=; b=koghwbddfklbI2Bd5fn7vfA5iJdijtCkDP8vCPLcJ4OwZMiwlayzPYEd9BB6/N9I1/0ydx ZLazIlCnxZQkTmbvfgRQWpku1JNzGd2Gq9WahWtest4jgGo1XKAtFME4YkDWxv74NWwxhF RqHHrNGwGxnBuCBSMGk2v7FLLDZjWFY= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1719541486; a=rsa-sha256; cv=none; b=hLaf051pGxwEC36JZdSf+nVjaei+zT4FosAPyDhhlviqX5mZNpOtaK97+/gJe9kQvCLF3J rXtiI0z9RtxW5xf3bncFkPcFWilPaEjCH5Zyh7DYRNzjqEwSZ5woGYoNUllFqy2xxtxPxV bD5bZqVqP4sn8SeD5q8hjbfs6gLTNk4= ARC-Authentication-Results: i=1; imf03.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=HEXi1DY2; dmarc=pass (policy=none) header.from=chromium.org; spf=pass (imf03.hostedemail.com: domain of senozhatsky@chromium.org designates 209.85.214.181 as permitted sender) smtp.mailfrom=senozhatsky@chromium.org Received: by mail-pl1-f181.google.com with SMTP id d9443c01a7336-1fa0f143b85so558165ad.3 for ; Thu, 27 Jun 2024 19:25:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1719541504; x=1720146304; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=EzO2A8iz6wHJZqZfsXCD1vEPIy2KLr5tygffi7vIE4Y=; b=HEXi1DY2u0+p3Xcr7M6Q4S1DInjx90aQqiFTbjwT+K96un4dEoclQFtlLW76mX+T5Z dY1TXvmAJlK6pIjZ+SbVX6cMy2aUvo8gEVT7RW3fttwaASmfEBbTdIkoTUYAIqFgOz/E O5dR2MyiGvu4v7HYgsGUZ0c+EPspiJ+CUO1DY= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1719541504; x=1720146304; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=EzO2A8iz6wHJZqZfsXCD1vEPIy2KLr5tygffi7vIE4Y=; b=sMwVG/MRoYIt3Q2YZTc1JvN53cnxjOvgG/XCtcuuBhOQ9bR6lUpiVQ59czMWttf4F5 IV4eFqeXN1EjCLxDgKM4u4WJtOL55cKUUr/joz8sPGCGcptpCSSyQeAk2eqf9w52y0lZ FsflZPqDDeOMqqAEXVM4emkHDbzaOeb1g0mu14KkS/BiTgIYGZcLp2qZr3gsnGGvEgon dgR615GEu0grVWOIsAjhN6QO02KKYwkeV/5hmRmcndWGWDLjn7hW7x2xn8RFFYsdmSYw 4tbI2YH/zS78okiubAcYxEtqh6/P1ixLbgv1H9cyIqwvyL57KS4VNMHRf9bH0FhQlf0i vK3Q== X-Forwarded-Encrypted: i=1; AJvYcCU0JqSP41dFoVIxrn1y4bxUxit+GVdR2X2+/okb1bQDQhlFZ0wGWuljT8ApZs6Qtpg9NVxgFXZHgBiVSw93q8eOa1s= X-Gm-Message-State: AOJu0YxdT0UBhZYzyvTWRWtgIYCa/JaH0d05uj2Y9+HP94JopwqT6IAg 6Hvzqz2AolE+3UkQ74L09GKUIiDMmUBiUt/tO0z4zqZDETiXqFkdJ1eRoSNsvw== X-Google-Smtp-Source: AGHT+IG0Gep/G4bjbFazXgVgd9fSAqw2YFcNgT+qyMOGlRi48ZeT15IrtUQlOudz1cmwPH9WqKNK2g== X-Received: by 2002:a17:902:e887:b0:1f9:e5d9:ead8 with SMTP id d9443c01a7336-1fa23be1ea7mr174919845ad.14.1719541504472; Thu, 27 Jun 2024 19:25:04 -0700 (PDT) Received: from google.com ([2401:fa00:8f:203:c19a:b9a8:4bd1:72c0]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-1fac15388fdsm4417415ad.127.2024.06.27.19.25.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 27 Jun 2024 19:25:04 -0700 (PDT) Date: Fri, 28 Jun 2024 11:25:00 +0900 From: Sergey Senozhatsky To: Chengming Zhou Cc: minchan@kernel.org, senozhatsky@chromium.org, akpm@linux-foundation.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/2] mm/zsmalloc: move record_obj() into obj_malloc() Message-ID: <20240628022500.GF15925@google.com> References: <20240627075959.611783-1-chengming.zhou@linux.dev> <20240627075959.611783-2-chengming.zhou@linux.dev> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240627075959.611783-2-chengming.zhou@linux.dev> X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: C012C2000E X-Stat-Signature: baia4p8qc46owwfciy967gb8s8xugerd X-Rspam-User: X-HE-Tag: 1719541505-328639 X-HE-Meta: U2FsdGVkX1/AbWVEm26bAjNVqZEpF2mWndJeIp1ZLJ8ionmRX+wVyNPkWn7dSHnPihQDzbGTJtP3ys0XJzfCotgaditrZ36UEN+DTaMYh6sdyoH3Ongw9219Fb+Ap5fOLm/5iwJjDYHx4hRnWiN4kXheW3kAJEONsuLHQN1iLsx5H+LKmWlSnKWOI1u0REvTVZLGdnLntCTItb30zuDdg2WKQf5cAggMcOapeDHIOZIxDgrdeOJowCi+jN2RqMEjIZFEHjNdlqWY7JX5kdMwW4LRg4ry11ksxKpyQVzRwI2UADxrT9dK5bezsH57sBM4C68DqKMpPKOu16pXcFPIPGy6VA1S9joCIsqo7klOaWmbEyDNlCsLkWebio1wUs+XoeMXuf/RSJmcYptgWC2iVC4MuibnLtMboRvKXn38aaY0wmuOiQlTozf2hzUgnhBLc70dGGmnxjr38TGER5Z+uoFVlYIdL6ZWcicKnIHFKxhFhu1mQ9j2DisjOVynDT+ABfHyFufg8PrT4q3iwzjrZ/EEic8WqBWo98F76VUyUdgQzajKx+4O0bHQE+TiJIipl9o7KsEF4LX8p+sCBO+IfCNVFxYTCA415+oOFAiRe0y7vquwYgjn32wPylhA6vx+rOl4nkjXMVZG6VUQ0V0D/oSUalPa/yEB45oURZI9wGP2e36MRk+SdU5eXU5uX9jIcwC27T4/HSSv0PZd/hkAGUvEhRdCJklHAha1LwWa6oiKAM1y7n8FHr+c3kQQnjXrqph5q+9AiITk+UXuuDINZDuKDJ683GnRav5bwzhDNSOWcIR2KHXVOTWK7fipK5yFCQpfBlmIeFfE2PehKJg7m+HQ0Oq7BS5yTqwp736duaHrAWDDl0ME5L/bndEye7kvXrVmoLaJlVwEPHJc5DauIaCsZNMoeP01e8PaUGqprvhBauNM63K2Sk4B0URwlJPEbwYIU2F+5vb/XoDnPMv OAYSmXkd eIdAlE2GoinNLT5/S/XsNdMDrKwe1vrlDN06N3qqEEOOMVpZ/A7ZL6jD7YPwhbqO63tC2/8dcetjrkt26lRKz/ESY9Q0Tw2a3Pob51ivdMOWCCdWp+ENParLZlR9kaHqw4wcoLRM1XP4AxPJUa02kG38L3KGxT459VlQIQ7vzcXWwg/CoM8G63vXcRWXWF9wWIwFlNvc3aiCSP8D8PEAoz6W2LSC2IUWtpX0ZKDojp7SlHwHg2KlBDQuFBY9QpLzuj9yITrI6KJ+Oa+x/RgePvsiXvtGA3yBH8qxcVASWUt5Y5FVYlKCnvSecdDAPrggunRDCGGuKHatL1tlIMzr7s/lFLEfCsec3wpdo+WZS4kwcrOh9F9mU3z2+A7XAzecZILYRHVWORaB5zFVnxlFD9LK5xA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.009626, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On (24/06/27 15:59), Chengming Zhou wrote: > We always record_obj() to make handle points to object after obj_malloc(), > so simplify the code by moving record_obj() into obj_malloc(). There > should be no functional change. > > Signed-off-by: Chengming Zhou I guess I don't have a strong opinion on that. FWIW Reviewed-by: Sergey Senozhatsky [..] > @@ -1591,7 +1589,6 @@ static void migrate_zspage(struct zs_pool *pool, struct zspage *src_zspage, > free_obj = obj_malloc(pool, dst_zspage, handle); > zs_object_copy(class, free_obj, used_obj); > obj_idx++; > - record_obj(handle, free_obj); > obj_free(class->size, used_obj); I sort of like how here we would copy the object first and then record it, some sort of "commit" stage. But I don't see any issues with the new code.