From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 010BAC2BD09 for ; Fri, 28 Jun 2024 01:08:20 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 7F3946B00A7; Thu, 27 Jun 2024 21:08:20 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 7A1D56B00A8; Thu, 27 Jun 2024 21:08:20 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 641B76B00A9; Thu, 27 Jun 2024 21:08:20 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 433C56B00A7 for ; Thu, 27 Jun 2024 21:08:20 -0400 (EDT) Received: from smtpin13.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id B476EA4551 for ; Fri, 28 Jun 2024 01:08:19 +0000 (UTC) X-FDA: 82278511518.13.9A26872 Received: from mail-pl1-f173.google.com (mail-pl1-f173.google.com [209.85.214.173]) by imf26.hostedemail.com (Postfix) with ESMTP id E135814000C for ; Fri, 28 Jun 2024 01:08:17 +0000 (UTC) Authentication-Results: imf26.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b="b/akyyM7"; spf=pass (imf26.hostedemail.com: domain of senozhatsky@chromium.org designates 209.85.214.173 as permitted sender) smtp.mailfrom=senozhatsky@chromium.org; dmarc=pass (policy=none) header.from=chromium.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1719536880; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=a2utnmsw1xb4DBsUqmmJwnVko+nFbfKDW1nfGRRIJcA=; b=1IPbDxXc5XdnCSANyNsAjEIbJ6so4D9YlaqkmfxIUQop8b6OQuYdZ80Lr9OzO2kf2E/PZ7 EKke9G3wZvo6KaXlABCRjEzuqGXnpq47TF7rzQ15jzaHWNYpcDT2/nR/aY/mXEEJN/D6Fd hLhu6uCJwUK686lkZSfRmUkE5/TBYsU= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1719536880; a=rsa-sha256; cv=none; b=zuY9xGasK9jyxPcmbN2SNYghx3crNhrLRMNGv0oL9Emyd0r8+7tFycnK9hdAdr5K5wedKI TlTbL/iy8DXvnDESCHEhszlHpUyTKgY/6ba+9SHz6uv203VPjkVg09rZ9C0rQZq8sggtMZ yt5UAvPJt7zH638Pc8RKXABiCz4uiUc= ARC-Authentication-Results: i=1; imf26.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b="b/akyyM7"; spf=pass (imf26.hostedemail.com: domain of senozhatsky@chromium.org designates 209.85.214.173 as permitted sender) smtp.mailfrom=senozhatsky@chromium.org; dmarc=pass (policy=none) header.from=chromium.org Received: by mail-pl1-f173.google.com with SMTP id d9443c01a7336-1f9b364faddso298965ad.3 for ; Thu, 27 Jun 2024 18:08:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1719536896; x=1720141696; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=a2utnmsw1xb4DBsUqmmJwnVko+nFbfKDW1nfGRRIJcA=; b=b/akyyM72eeULjAWLNOuYPrLy3Etl2x8yWNT6uGyazPgpntvtfdshHK8noQYqLR2Xq /SymkfdEoB2gqIbgkrR93hUTZwF6v5niYpCXk4pB1R5FtPbngjzKk6clDVK5oOS2dLQV iTFDcEJbidCgz9F5E0rsEPzKi33DxRsjSGJjo= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1719536896; x=1720141696; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=a2utnmsw1xb4DBsUqmmJwnVko+nFbfKDW1nfGRRIJcA=; b=Y6H5XAoMEfljTAI9Qe85tMkuMsSkw/z8aRtzRIGJyBvla+bLg/BJntNqVI8H/CgHS8 Uer9p44hJeFV+/oY4sktEtpVIqWfYqBRpl+adHSeZ61wfUB8y546bt6IqShgE+6SND+6 BsxtV2jlGPbu8ieYafiCGmmDI2nxBfE35qCpCnVi2z+6shmogO1nlG2AA81CEqPUGzoX pMXoS7p+KJFCCWendEDqBbPZdum6J3NcNMpbGBMcsv68djYTihyVILI37XkW5FcF5f6M esOl9xQ47UDaWVL5rUPdy39aC7obTUVwsZiLLUubH2A2HsOFOiLqqWuEwb0u/PXYANBh Uhnw== X-Forwarded-Encrypted: i=1; AJvYcCXsCydm+lf5f137iK4uAtIKzs06Gwu1hEBwEaSP+HqWHkZFuCWwwbQc/urkcLcEZwqz6dVqYkt3fZJS0Y/Sn5brq+0= X-Gm-Message-State: AOJu0YyDosr/Hi9aUn57QyBULkeS33rqApt5WsLMiyQl1KUOWhDWVo5b vNUoX2S/Fu/iS92XzhM3PRZ/1cCOD97za/8QbOSNOemQWVAHg8k1yoxgpmpxqw== X-Google-Smtp-Source: AGHT+IGwkepPg18peE3iKJtzQXjCutZ85rLoUEu++EzilFhy0HLWBnKs2pOQG8bChfgfC3yiuZlNpw== X-Received: by 2002:a17:903:230e:b0:1f9:f018:6973 with SMTP id d9443c01a7336-1fa240822c2mr154709215ad.51.1719536896549; Thu, 27 Jun 2024 18:08:16 -0700 (PDT) Received: from google.com ([2401:fa00:8f:203:c19a:b9a8:4bd1:72c0]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-1fac159ac64sm3802795ad.295.2024.06.27.18.08.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 27 Jun 2024 18:08:16 -0700 (PDT) Date: Fri, 28 Jun 2024 10:08:12 +0900 From: Sergey Senozhatsky To: Chengming Zhou Cc: minchan@kernel.org, akpm@linux-foundation.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Sergey Senozhatsky Subject: Re: [PATCH 1/2] mm/zsmalloc: fix class per-fullness zspage counts Message-ID: <20240628010812.GD15925@google.com> References: <20240627075959.611783-1-chengming.zhou@linux.dev> <20240628005523.GC15925@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240628005523.GC15925@google.com> X-Rspam-User: X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: E135814000C X-Stat-Signature: nx6hdzdjopgi86tjzsozoqozuwzubi56 X-HE-Tag: 1719536897-148946 X-HE-Meta: U2FsdGVkX19myAQV0UxBy62ItEZGV/+v2SzykZzZ1h1IhCc5UkVHEs+NC6X/oghI5hcC1GRNNviJ/mn7/Jn3//Np4j9CHPdaFsegEuBpVNgrZ01AukbBra2HZW0+vm1+y4XOUENs+5hkHRFvfqDI/J+Pq6XrzS1YJovjwgT+mTfamY5cb8douEeTw0YVaym8JXcAxMxDUq8r4kpXRh3kKkifAxrnIHS23zdSrpx5KSal/lvo0cn+0U8928ydoQVPcXMT1WQH8ZlamRKYvOCCrkET0azbr4hBk6aYI+en5n0wGRHQ2JAbECZVVYrcG9FTwaWPeMD76/yWWFISA2LAvDbkT8fY7O27Hm2WO71V4il+o0ZlCs5jON1SkNS2DIBTlY+9577sHuOnckGuWUu1QqN42EZLGhuzrkoe5DLXKz5oeNwehXE0mhP9UWTzCJu7Riqr+AJPDaQX7pNQwg0vSOjW+7G4lxSfB91gNbjQyE6Eyw7YaAWK2LNDHu4EQV/e9QjJirWtY/Rln3y889hmy/xxotdGgc+Z0B9/FMSuvLmPpltftfwAplBqe/BOcEs63oyt2GDSJpzs6JIWd1XcOg2MmvzP/lIeS0hct6grIuUiFAmNniWfY6dh9e3SNQP4oFBiDbTu3HyjMpT+XDvW7Kbmt/pZ/JhLYWISAm5jnQyK7v8ZHnZkZElxdT12YNaYTEg6I7Rtyemfmygp6SsXFuePFXccbnrYszKnXrAw8vsCGgGbXMbHJcP4hSvD3KAB3YiQQImIDY5EOV12S9MbSXYcw/srY8NYwUekT6XSTdaeHl+weIhUDSFBxoLDtXE84VqkmtzzU2GUu1Ocqg3Ca/901sBal+dr2daLpB33DOCpp9JigPUnvAmcXrbHc1DUhS1MzJyFTS1zxUbfKVnoaGHY7AK8TdH8XYS+AS+C1C7L1NsYGDuKrQ7kwb1p+pd9GW6Jy50AKp36G3cfGvX cIAO9p/t fkTgy4LExDKizwIIk9tB9srmK2dq8MNktKlrCQD4OeJeQpAgcndIegbx9qLNc9oeOi61tjRkuLC8/kOmUIaeyRl7Nt0gX3z8cW9Lp4Ain8go8nHgBmTV2HkRy1eRhEbYP7hk++TLuz5bt/6Iho1EjfV90SRFdu0SiR6u+NaxbO7nug+plCS21sufa0fhI1TN+gG4bSp1c/Nyir4M7Nlehg5QmRFoy3TQVRN5AWUaeX3MIewYNYuw+mM5oGj47YDy9Rt+0rUIIX+2Ldjjaxki5k8ipl9NhhFgIFXH7zxKn2YZ16DHjBcrqfkGm2QfUaipqsZ6aR+y1nxwyNVkLa7wpJ7PcxmFrbK51uBZRZX6y3NSauV8= X-Bogosity: Ham, tests=bogofilter, spamicity=0.111848, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On (24/06/28 09:55), Sergey Senozhatsky wrote: > We can land this patch, if you insist/prefer, but it's some sort of > a NOOP, essentially (in a sense that it has no visible effects). Forgot to mention, sorry. If we land this then I'll ask for a different commit message. "Fix" sounds alarming. It would be better to say something like "keep that stat counter accurate, but RATIO_O is never used anywhere".