From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 94704C2BD09 for ; Thu, 27 Jun 2024 16:19:57 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 28EC76B008A; Thu, 27 Jun 2024 12:19:57 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 23D666B008C; Thu, 27 Jun 2024 12:19:57 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 105816B0095; Thu, 27 Jun 2024 12:19:57 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id E0C056B008A for ; Thu, 27 Jun 2024 12:19:56 -0400 (EDT) Received: from smtpin28.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 7DC5240AFE for ; Thu, 27 Jun 2024 16:19:56 +0000 (UTC) X-FDA: 82277179992.28.2B3B5A1 Received: from mail-qv1-f49.google.com (mail-qv1-f49.google.com [209.85.219.49]) by imf25.hostedemail.com (Postfix) with ESMTP id 9AA68A0023 for ; Thu, 27 Jun 2024 16:19:54 +0000 (UTC) Authentication-Results: imf25.hostedemail.com; dkim=pass header.d=cmpxchg-org.20230601.gappssmtp.com header.s=20230601 header.b=QeLTgrnd; spf=pass (imf25.hostedemail.com: domain of hannes@cmpxchg.org designates 209.85.219.49 as permitted sender) smtp.mailfrom=hannes@cmpxchg.org; dmarc=pass (policy=none) header.from=cmpxchg.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1719505185; a=rsa-sha256; cv=none; b=prOE6+mGoRvlo8ZoZWLWj7SbP3PmQtxTR4CEq0moMZV+duf0SqfWyxtTbZGD+IR6LC/xIY pH3BW80cCi/ziOsGdq2hQDuXZ8LQZxPIuYTaW0II+JvKioI1Es9Q/07THXs55FpCkUoilz GlN49nEEHxM2Uv2RSuOm7aoM6wzfehY= ARC-Authentication-Results: i=1; imf25.hostedemail.com; dkim=pass header.d=cmpxchg-org.20230601.gappssmtp.com header.s=20230601 header.b=QeLTgrnd; spf=pass (imf25.hostedemail.com: domain of hannes@cmpxchg.org designates 209.85.219.49 as permitted sender) smtp.mailfrom=hannes@cmpxchg.org; dmarc=pass (policy=none) header.from=cmpxchg.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1719505185; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=bThwXXxLsCowTNiAzmwpR6Uu07x6nxuk7Uem+NxoepQ=; b=s0cLNa2DoN1W1I0YXBxzQhphhfLlEdqbrqyQth7ZoXJZoT2RcRbB16zc+I7jJDTDGP4Ul1 o3Bf+JA5BGwH+e5UpmU0AFopNHeiIz3xJvzO11kefZyc5mq20UGNlpajv3/4qgV5r/We8r X99XRGmM2/NT+t/lc4G7OUkVz0952WI= Received: by mail-qv1-f49.google.com with SMTP id 6a1803df08f44-6b4fc2b5277so28852206d6.0 for ; Thu, 27 Jun 2024 09:19:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cmpxchg-org.20230601.gappssmtp.com; s=20230601; t=1719505193; x=1720109993; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=bThwXXxLsCowTNiAzmwpR6Uu07x6nxuk7Uem+NxoepQ=; b=QeLTgrndko+u6+R47OjbVaFYyx3LSai5d86shFJddRgJRefFQ/FznV1pPPCOEnaXvE gl4YzJMACQlaYYXEbNh6104EwHcROZlunijHe9XLqN+TrWU8L8Ga09dJFdmVpn490e+h lV6t9xGLGowtSBxj5gPOYMXXit7+smGIMddD2jBnQJsQr8dxOTaoJ1B0ts+nba8j3s7s KG5vlYJlcnKCbSmteuSQNrR//wuRloA2M+2rz3jq+pVZv6hH0O5GCB+TRaZne/32Kp+2 Nl5f+Ep3O4IdFU+466lHArAESFeSGnaXMWC2WEN9CSSH121SLVujjVaxxMQ2ZPBMC6fi L5JQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1719505193; x=1720109993; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=bThwXXxLsCowTNiAzmwpR6Uu07x6nxuk7Uem+NxoepQ=; b=hUlhOxBk9OZq9QjkCkyaddFxKwBU5Tt83XImB+xeytYMggxqwnfm0tsb4stgHy+ZuG Zfkto3FsQvFq72wJpp9XZ9HRuOGVOh+Cjt/Zgnx2NNQSc6zIZIknZHQqzJNemLX8ZPqW ZTDaWBp1v+pw9M1TFF+OKpZ0fPtTY/jAK0Ljfu7F3VzAN4ezUn3WtSdb+5ZKVDgYZ5T6 qh78lbCGen0JsWhfCxBBg31u1Hal+oVXAzZSumoXbkPBGgIPATdZoM4CSlEdgrXjZPa1 aM5sPYQP5ZjjBMBLZlD1PQW4HbsI6HOaNC1lCRNs1uJqaoVvfeuM+ddRm1JgSO21hJ0k /S8Q== X-Forwarded-Encrypted: i=1; AJvYcCXK6IN1BdCAmcozoh9vFtvcvk6Awj5e5mzyCJBZ0/28YAn1Lw+aGv6NASY5Qf9LcSY/xbTttH+OHHc1qYEql5YebUQ= X-Gm-Message-State: AOJu0YwEDdvJ1y5+8doHdnvUgsoEfdJJvtKTv0GHePGBwQCVoCn03+5O I5ZieeJY2p0/pmp5pryY6SDwcE9WMlGg6DBZ5PbUbKFdmwEUxz1t4mqGyce4sUg= X-Google-Smtp-Source: AGHT+IHH909svJOhMGT/Wjd/PkB+PwNb7jRISJkkhTcb9iE8KHrNS3Tsj4OTdZtT8qZCGAuUZE8xzw== X-Received: by 2002:a05:6214:20e2:b0:6b5:24b:f430 with SMTP id 6a1803df08f44-6b540a91d2emr173819906d6.40.1719505193568; Thu, 27 Jun 2024 09:19:53 -0700 (PDT) Received: from localhost ([2603:7000:c01:2716:da5e:d3ff:fee7:26e7]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-6b59266eadasm6248656d6.89.2024.06.27.09.19.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 27 Jun 2024 09:19:53 -0700 (PDT) Date: Thu, 27 Jun 2024 12:19:52 -0400 From: Johannes Weiner To: Usama Arif Cc: akpm@linux-foundation.org, shakeel.butt@linux.dev, david@redhat.com, ying.huang@intel.com, hughd@google.com, willy@infradead.org, yosryahmed@google.com, nphamcs@gmail.com, chengming.zhou@linux.dev, linux-mm@kvack.org, linux-kernel@vger.kernel.org, kernel-team@meta.com, Andi Kleen Subject: Re: [PATCH v7 2/2] mm: remove code to handle same filled pages Message-ID: <20240627161952.GB469122@cmpxchg.org> References: <20240627105730.3110705-1-usamaarif642@gmail.com> <20240627105730.3110705-3-usamaarif642@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240627105730.3110705-3-usamaarif642@gmail.com> X-Stat-Signature: u1s7p46gfckw49mxd1x9tjktqpdx3ks7 X-Rspamd-Queue-Id: 9AA68A0023 X-Rspam-User: X-Rspamd-Server: rspam10 X-HE-Tag: 1719505194-104209 X-HE-Meta: U2FsdGVkX1/MvsGfXnPStHOjRUQekWCjbETnxqHki2h6nE0uH8QX/k0eSmaKImneCz3sZBCA9IadHovmgNPhSjRlC5yamIuB4U+SOeGMwez9Vnip5Codx00Pe1IQUeVxGu0V3Dz3RGs+C27rSTZYugptv+sIbWUVQuzwD+BYB3wAzFXUzaopSwICy2ZNXMCsRArJ9XjrtaWvsb110OQJKr0yRkYzlW7Vrr8pMnwm5oBqvctbpRKiO7oqQ2kcrwpGn4fDwQk3zH5uwR3Fz6mwBlAW/cKy2ZB1pODDrh4LxLp1tSVSha20aJlP2ffz5g5T6SCoTg8M0UdAG26AGmQEj25SJJ8fi4ICRhOZFkUM62Ua5v3tpvh+SUkYT/hOeI9FU1jf2sgJ8+lwkcl5z+A7mRfvKKzrtVR5Qyem8deJCi3JKeq/eV5SPYp03+Lu5eRzORcupilEkB6fE3oGkG3Ef8qFVXuKtn84ZNPP+MyCmwXgXj6hKI4oUf+2alapSVLdNiq07iE6wE8ng/WutW35yoJMroNnBbx+kKXJtM8fdSlLs/ZeMz1bMAqvzhZMwoXCrYzpoTvSHxuob0wwT6VwXULJjfeOANm1ILkgX/OG/otYQ2sGOYnoXogLYXiM4hFsSMNxIRYWIJmVBvpAP+PqfWqc0s84H+wJ5y3HoyOJND2nyWaiw2tc5bvP8EaWd8YpN45+OH8YfhB4X5NByMKGVt6DuKbWTc3uOg4aiyWQ3RprVneJGElJNDk6rTzRJ/3+zFGfNhIfzoW5MTgmOSLSZCRmlKKTmbrxu2Yb1kzC4Jhu0BKClYBJ7EtbKq3rlCyUvtZmxpraHh6AZob6lfp34hwpVWPWL5Lv1mtVEMgEO22ksN8NhD4KaPgO9F53bURZeOo/LF03SN3GeeB/k884Q/Jx0l174NPtU7hATKURVmLkI7QUW/zw4dSuiXGmq1H4tYkDk/ClfpQKMYOUNIT uga8yb4Q XukmW9LAEEQ07Dznsj0X1PY6MCbMKvcMQMoA0aK3OxAJPz+hynMlopLAq+YnqtcWRuBwLx68fQ041l+ZGDWvJbiMvsEN0JsCMCluDGTebNK0nHz5JuvqnNNGJgD0M+0rBSwSrak1gIdpGLMsci9ZNJt53q451ESw0QoqALk1whmJRpwmHzmv9vD7ZB7mEN4Zf2uMoVFKchkf3CEFODX4c5jLFOyP5MZmKqz5HKCLc2UaDUcMSx7YE/ZXePiHP+f5F2ZHu/ECyZlP0vpBZOI0HKKutnDWMlPTEHDix7OEX0xOMDQ2Qxf2+RpY8JbzLf8Ef6zzsL5PGWuoCPERs86TDw4JiHOni+Jq75IbVuuTTWbHQt3IAPzvkOqgVoQUl6G6N6WyrjyAjGtsgCRYQs/d2wnHk4Klvdempy9eEGmNJBsM3eGmbHgWGbunw1FOimkAx0pYu9C7h9BiHOGJDxt0+6Y8nX/uLfk9VpawdQSIHWNAy5S8R19s/NuL6eRB/6OOooigJ8ZsZqtKNFwoGOS2MjQ69EOeNsmHzWz9WEUgsJXFyYYUyask1XUXVcZvGslrwGXOO3izkTekvt88nKXyHYj1bFLNawnMO4+DB16OpJPJAE3lWbo9WZmpBdAgCETRdPqSXuqpJHNoaXYXI5149B4DBxKcc82de41iG X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Jun 27, 2024 at 11:55:30AM +0100, Usama Arif wrote: > With an earlier commit to handle zero-filled pages in swap directly, > and with only 1% of the same-filled pages being non-zero, zswap no > longer needs to handle same-filled pages and can just work on compressed > pages. > > Signed-off-by: Usama Arif > Reviewed-by: Chengming Zhou > Acked-by: Yosry Ahmed > Reviewed-by: Nhat Pham > Cc: Andi Kleen > Cc: David Hildenbrand > Cc: "Huang, Ying" > Cc: Hugh Dickins > Cc: Johannes Weiner > Cc: Matthew Wilcox (Oracle) > Cc: Shakeel Butt > Signed-off-by: Andrew Morton Excellent! Acked-by: Johannes Weiner