From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 89FB6C30659 for ; Wed, 26 Jun 2024 20:40:45 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 1B5026B0093; Wed, 26 Jun 2024 16:40:45 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 13F236B0095; Wed, 26 Jun 2024 16:40:45 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id F20DC6B0096; Wed, 26 Jun 2024 16:40:44 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id D477C6B0093 for ; Wed, 26 Jun 2024 16:40:44 -0400 (EDT) Received: from smtpin03.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 8252B4173A for ; Wed, 26 Jun 2024 20:40:44 +0000 (UTC) X-FDA: 82274208408.03.914D513 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf09.hostedemail.com (Postfix) with ESMTP id CFE5A140013 for ; Wed, 26 Jun 2024 20:40:42 +0000 (UTC) Authentication-Results: imf09.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=tTjdpp+S; spf=pass (imf09.hostedemail.com: domain of akpm@linux-foundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1719434435; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=55+qbqHirk63MdRSfdz7YdCab6Zhn7tzclXpfKcOO0s=; b=M7yzaXW0ZIDgCA5vlX2oEpnta+3hvq1mKJYIDHU7T1LeI/o9ZHZNmaCHXohBhfVC0O3S4V QOeDZgOpLjPPA/T7oHojOENU8M3laYjwIngiYJqhda7Wj2PV2YKVJEv1Hwq3YSJrpVfJnp gy4ZO3bk7hsR0pQwgbVtgiPQOk+Szso= ARC-Authentication-Results: i=1; imf09.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=tTjdpp+S; spf=pass (imf09.hostedemail.com: domain of akpm@linux-foundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1719434435; a=rsa-sha256; cv=none; b=2U3G2aCszogCxBohyTI2fOEk4PRNAwU34xhl+k2MF9thjv+9SLC3Oq61BnRR7RAnqJpJjm HZXpzIl+7A/YtvU1+AYdjrEG+lPWX7DP9klLjz14y+2Owgm6Z8gSEaSfIEBOgvTkgEZvei 67hy8o84myuL0nXzlIcNcCBzsNRJhiE= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id E2E6561D1D; Wed, 26 Jun 2024 20:40:41 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 39183C32786; Wed, 26 Jun 2024 20:40:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1719434441; bh=+MTghs/ruEyPO8KiBbZQEvIF3zJkuIad4OGKhCyeqQM=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=tTjdpp+SHVjyWZT2LNBDjQ2ODFKazV5WkhurSz+62l0adrGbOZ2/7f1Lw8BJZenPg ZD7IFjHX6We+P8Cr8nf5WcaWGgPMtujDZmEooldFSnqPCcS8+7MlrGF+AChOXFCr4K 7FtiMf+tISYzPYPRAL2H9dA/RptZ4PEhWBGwcROo= Date: Wed, 26 Jun 2024 13:40:40 -0700 From: Andrew Morton To: Yang Shi Cc: muchun.song@linux.dev, catalin.marinas@arm.com, will@kernel.org, linux-mm@kvack.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] hugetlbfs: add MTE support Message-Id: <20240626134040.63fe621bff6a5fe1c0503999@linux-foundation.org> In-Reply-To: <20240625233717.2769975-1-yang@os.amperecomputing.com> References: <20240625233717.2769975-1-yang@os.amperecomputing.com> X-Mailer: Sylpheed 3.7.0 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam03 X-Rspam-User: X-Rspamd-Queue-Id: CFE5A140013 X-Stat-Signature: hhxturg3io948urx9k1feu84o8zwfzwt X-HE-Tag: 1719434442-833899 X-HE-Meta: U2FsdGVkX19skCbE3VW0AQkzP42Hf8pE6SsQC1HFMzGq8FQt147Ca9R5WHIU3qf9oKC3p1JF28Wk7DrAJe2ZVq8KjZnYxS4oQGjmHnktIIe1XamnrVdmGfueO6EqO/mbYYhe20mKPO8xAYCNTDogVA24e1HMNcHQkTSzRfrEXt6hH8F6YYVvcjisjyDl0hCpfXH+OVuYcyA8uIZcHV61atrXJdfCMw3PB7WGnDLZTQCaOIPG4BH2kCAk6hood6evErwyXHhaOF2Ih3RLSlNRWYmlLNaHyr3o3u7pb9nFho2NEgKyy2WFB38zSRMR7f8WW84+8zUtBPKVA1jwlQJwGEZeAhGlJlIqas4FrMyxkIMp5RG1bEYXE5PPcU4VAK4zmX3TxWfIPLNaz+xndP81M6giwIPIEUfHUERBMFPBbmR0UZ1Yra7nwxDyoiax8F2J7gkivMa6D8Ffun6kxBW1iG5yIf3QcU73GRQnXqjcKEDziyaiAFztWdJVayxKXBrqJhtSPBYGcW+KWWESnvO3QCNm9fEa5rLpiqZrQDJEkrG/LtUuVKYIM7aEnkY7pjdKSFZSPES2tnO3hdW9wu0x31NTZK0YyCN+aBNNvAGi6NyMWrgXazFAyQrzz8EGay/s7YPvWWp6oNbSDUIaZhdxARUlnuD+i/MAX4j63Ui8YZZY4Zxqfao4TZ9p8SiCInBoDl/yu583nfdTp/imzAhTk5Rdu1soC1Y6yMtIEQ/F0uYDApZ6LntboyiEt+q7GaHs9oEO1U3+h0Xx/trL7Xzzo4uxiZ+riHLBb34rBNlLBehQVSr5CRyqeLAHiCjhvjPc4DqOUDKPmuKq9mc05gaj405j1N1HSYch4q0BDxEBLV2Vzk/mRBVxzX8pii8nRDVXT+YSIISt3B3dK13mo1m2wkv24SQ2ekTUGFna9zRylDCd6UtTNzaGjEHLBboQsrskyuf81NiDXwb4/321zpW uD1uz7hp E2N5qN4zp4vCifg/y8X1MYJH8F+ZDVskuUKS67OS5dXQqAm6+c5U3ZyhCWJnGIrv1ReC7hCrgdU+lHR7PCMmZJ4kn2yo2+G0YqOH1Z4gVDuN6ypjORQxSgZawjU2PKzgMB37Q5YjcDnLZzK6WUulF+m9L9U6esxLOY8i4ZonzzbEuK5uOjRbAZxDWOEhEcDPPvodbhal5VraAZlKJCS1z/QEo4L3PFjmYn8FxvyaaIiJDKJRuWdE+kj9yNofxSSy7CxXTBPdmVmJzDdsOaGmBzkjpCBomScIjNftT X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, 25 Jun 2024 16:37:17 -0700 Yang Shi wrote: > MTE can be supported on ram based filesystem. It is supported on tmpfs. > There is use case to use MTE on hugetlbfs as well, adding MTE support. > > --- a/fs/hugetlbfs/inode.c > +++ b/fs/hugetlbfs/inode.c > @@ -110,7 +110,7 @@ static int hugetlbfs_file_mmap(struct file *file, struct vm_area_struct *vma) > * way when do_mmap unwinds (may be important on powerpc > * and ia64). > */ > - vm_flags_set(vma, VM_HUGETLB | VM_DONTEXPAND); > + vm_flags_set(vma, VM_HUGETLB | VM_DONTEXPAND | VM_MTE_ALLOWED); > vma->vm_ops = &hugetlb_vm_ops; > > ret = seal_check_write(info->seals, vma); How thoroughly has this been tested? Can we expect normal linux-next testing to exercise this, or must testers make special arangements to get the coverage?