From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id F1393C27C4F for ; Wed, 26 Jun 2024 20:38:30 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 622B76B008C; Wed, 26 Jun 2024 16:38:30 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 5D1366B0092; Wed, 26 Jun 2024 16:38:30 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4C0146B0093; Wed, 26 Jun 2024 16:38:30 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 2FD056B008C for ; Wed, 26 Jun 2024 16:38:30 -0400 (EDT) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 6238081836 for ; Wed, 26 Jun 2024 20:38:29 +0000 (UTC) X-FDA: 82274202738.23.19214E1 Received: from sin.source.kernel.org (sin.source.kernel.org [145.40.73.55]) by imf02.hostedemail.com (Postfix) with ESMTP id E4A2080022 for ; Wed, 26 Jun 2024 20:38:26 +0000 (UTC) Authentication-Results: imf02.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=ADa+0mQL; dmarc=none; spf=pass (imf02.hostedemail.com: domain of akpm@linux-foundation.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1719434289; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Fiqy4pUSGaB4F1ZcIaFXGUTRT7YMGuCfh7/c13CYicU=; b=gVi5TRyYtPd+j+W4XGzizTwAJTaHPfN383XZ0xZ241airV7Hn19uzYe26M3mgeEWrKxSn+ yLSByfQrnYi90UEdD3H6YnHBSM4nVP5qx5VRRxQp+oiwTXYGQLrPaxx3qJuFjU9eGxTW0t tvyRDNBYqycKgGLfU/vBVjWTeM3Lcwo= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1719434289; a=rsa-sha256; cv=none; b=Hz6lE/7sqUqyk1pTpADsxNfp7+ilpCq3CD24tetCJZf5Pf11OrGB/75gOUAzI546eeUmsR nYzwvvs8RvfUjOoXJrEmqvaxRFqHtH4ucG4avKF3sxx2ehgF7J0jDqGmns/jxe4OSI5LSd wdKPhj7CtPAV6W1QXhRvGSDeBk6YI1g= ARC-Authentication-Results: i=1; imf02.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=ADa+0mQL; dmarc=none; spf=pass (imf02.hostedemail.com: domain of akpm@linux-foundation.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id 3685ECE2C0D; Wed, 26 Jun 2024 20:38:23 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 1FE7AC116B1; Wed, 26 Jun 2024 20:38:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1719434302; bh=zirWFRyfszQ9k+2aZ/xG+erePQi+7EQ/qwhkvH5heKs=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=ADa+0mQLVJ0yyIY/R7xVja3PS+vFt3Sav+0zX/bIHrEX+5Ty1nTdP/+yEUBFrQHSS sKJlw265qY9oxyWnTpvywb0MNy6y0XYLOs7IGNGeLJh5RWeh/VV6vnLRSlbua0BlT1 WVx+Svb6GHz81ofYfAjGhzUVj+pW0LWZGPwfbEwg= Date: Wed, 26 Jun 2024 13:38:21 -0700 From: Andrew Morton To: Gavin Shan Cc: David Hildenbrand , linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, djwong@kernel.org, willy@infradead.org, hughd@google.com, torvalds@linux-foundation.org, zhenyzha@redhat.com, shan.gavin@gmail.com Subject: Re: [PATCH 0/4] mm/filemap: Limit page cache size to that supported by xarray Message-Id: <20240626133821.b2bba4fd46278fe1e4903052@linux-foundation.org> In-Reply-To: <4b05bdae-22e8-4906-b255-5edd381b3d21@redhat.com> References: <20240625090646.1194644-1-gshan@redhat.com> <20240625113720.a2fa982b5cb220b1068e5177@linux-foundation.org> <33d9e4b3-4455-4431-81dc-e621cf383c22@redhat.com> <20240625115855.eb7b9369c0ddd74d6d96c51e@linux-foundation.org> <4b05bdae-22e8-4906-b255-5edd381b3d21@redhat.com> X-Mailer: Sylpheed 3.7.0 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: E4A2080022 X-Stat-Signature: wbminuoxqajhckguxfauyiptquq6oap9 X-Rspam-User: X-HE-Tag: 1719434306-417570 X-HE-Meta: U2FsdGVkX19KURx1vFkhpmRG6lfY7q2X/bJw8XiBhw+AuMQmvLH+BEEEFxVSbGpN+h2eIfrtnwF9foAP++HK9JATk4qltS40Yqpu+U0i7t6CHAX2HOau96+HrqTQ2R3S65R90cBZCouvXf47b46VoB92uRVoAUQJAFewZoxAdDK1mmXDf+j96EKBOc+s/7KNzeqn74C2E5xPjyGZ5k4v1JHueTiexq2IjnuhKAtMhvrM40br7CNm7zFCcMgXa6sTm/uGD2fQ9t1QdU+BzTZo08h3J0dTCKSQ0lNGqzDjJwauD035WWJD67p+EPUe+HT46aUViA0ENtXg87f1M9EaLSg/vtEif15n8A2/j3XHbK6s/IUywKSHL8lldoEM6g347gm1vBMlPL257AmNddn9AuHSwTtPYCarSFPR18hgPqZXy036XvN3F8wxhzASxKQkNhrleHj+9BJgTKMolNYd59ci1G1lyPKRhbffp5F2imPZ3ZxrqNdDraFLMsVUSCkF4KaLTHRxfj+tzm7i8qDCOlxoRFgsj18rk1qnXZLoSqSqfniZyaAuTpcq602Ocgavnz2GO2xWltXlRvCajgo+Rwr0wIfIlgYFF4jjc+ErcGSySuxp7ylonqzlvNisZkNjEWEjIbt79bs2tLhB7GWCzvLBd7AXpGuDlrobfNnqTaZFdv8d8iIsvbFWRmTSM39CCXGplGBlRwii48TQQINY16YgTMAQXArb5f+bO8d9srAeB0zHSS17Vo132XO8N5LkZ+buEXkB4uBwHnIcxmBXC0bt+q3/kxYV0/M2ZTuEt7q60TQVZ77N46d8uNiD4ok8nni7Ys1VSTXTkoHsF3/YV3k42PWffCT6krSRJ8yKZGyz5fRXDCBNSLe4r8TphbhWXg7boW/jfy+EEDk70VRoSKHJv/epWtXVr4Z8UQCqrnPYbJh7JQvc4UBCPEUP8epuwRdsCS1gMUWWkBVMVvY IIVBF6S2 F7ejjyifSS1vzZVqU6A/CQjI1siLGe9op2u+Nch5U+g80iA6jcjLUl/VmEwSaju+cQHh8AFSuFn+lqVoIjfmLdzbXOLHFyj1HS5iognoBD6ZSZO5gdUCgc13tGidNYOHxHJ/nqmvhOXBYu8YhpXWY/JJNW0/kK0nA8hKp4/RGpU5PgL5P1GxWAK2+vaf/iI8mCbSJfPeGWWjO04g6QYTMs/O7LiJBTZD3r5QQPXom6ZdM+gD1cGaJSWic89hDUYUKcbJ+3ed3sgE8HE58tnHe1rOWeYwx0cls9bLIp+vOtfdNapM54K2HaTQjHirnrlopjM/eM2lKok862Sfflxm5hdPxYHX9NED5Shs+V2dE8pQAGl0jn/Ml4sItZg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, 26 Jun 2024 10:37:00 +1000 Gavin Shan wrote: > > I rechecked the history, it's a bit hard to have precise fix tag for PATCH[4]. > Please let me know if you have a better one for PATCH[4]. > > #4 > Fixes: 800d8c63b2e9 ("shmem: add huge pages support") > Cc: stable@kernel.org # v4.10+ > Fixes: 552446a41661 ("shmem: Convert shmem_add_to_page_cache to XArray") > Cc: stable@kernel.org # v4.20+ > #3 > Fixes: 793917d997df ("mm/readahead: Add large folio readahead") > Cc: stable@kernel.org # v5.18+ > #2 > Fixes: 4687fdbb805a ("mm/filemap: Support VM_HUGEPAGE for file mappings") > Cc: stable@kernel.org # v5.18+ > #1 > Fixes: 793917d997df ("mm/readahead: Add large folio readahead") > Cc: stable@kernel.org # v5.18+ > > I probably need to move PATCH[3] before PATCH[2] since PATCH[1] and PATCH[2] > point to same commit. OK, thanks. I assume you'll be sending a new revision of the series. And Ryan had comments. Please incorporate the above into the updated changelogs as best you can.