From: Audra Mitchell <audra@redhat.com>
To: viro@zeniv.linux.org.uk
Cc: brauner@kernel.org, jack@suse.cz, aarcange@redhat.com,
akpm@linux-foundation.org, rppt@linux.vnet.ibm.com, shli@fb.com,
peterx@redhat.com, linux-fsdevel@vger.kernel.org,
linux-kernel@vger.kernel.org, shuah@kernel.org,
linux-kselftest@vger.kernel.org, raquini@redhat.com,
linux-mm@kvack.org
Subject: [PATCH v3 3/3] Turn off test_uffdio_wp if CONFIG_PTE_MARKER_UFFD_WP is not configured.
Date: Wed, 26 Jun 2024 09:05:13 -0400 [thread overview]
Message-ID: <20240626130513.120193-3-audra@redhat.com> (raw)
In-Reply-To: <20240626130513.120193-1-audra@redhat.com>
If CONFIG_PTE_MARKER_UFFD_WP is disabled, then we turn off three features
in userfaultfd_api (UFFD_FEATURE_WP_HUGETLBFS_SHMEM,
UFFD_FEATURE_WP_UNPOPULATED, and UFFD_FEATURE_WP_ASYNC). Currently this
test always will call uffdio_regsiter with the flag
UFFDIO_REGISTER_MODE_WP. However, the kernel ensures in vma_can_userfault
that if the feature UFFD_FEATURE_WP_HUGETLBFS_SHMEM is disabled, only
allow the VM_UFFD_WP on anonymous vmas, meaning our call to
uffdio_regsiter will fail. We still want to be able to run the test even
if we have CONFIG_PTE_MARKER_UFFD_WP disabled, so check to see if the
feature UFFD_FEATURE_WP_HUGETLBFS_SHMEM has been turned off in the test
and if so, disable us from calling uffdio_regsiter with the flag
UFFDIO_REGISTER_MODE_WP.
Signed-off-by: Audra Mitchell <audra@redhat.com>
---
tools/testing/selftests/mm/uffd-stress.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/tools/testing/selftests/mm/uffd-stress.c b/tools/testing/selftests/mm/uffd-stress.c
index b9b6d858eab8..3266ae885f75 100644
--- a/tools/testing/selftests/mm/uffd-stress.c
+++ b/tools/testing/selftests/mm/uffd-stress.c
@@ -419,6 +419,9 @@ static void parse_test_type_arg(const char *raw_type)
test_uffdio_wp = test_uffdio_wp &&
(features & UFFD_FEATURE_PAGEFAULT_FLAG_WP);
+ if (test_type != TEST_ANON && !(features & UFFD_FEATURE_WP_HUGETLBFS_SHMEM))
+ test_uffdio_wp = false;
+
close(uffd);
uffd = -1;
}
--
2.44.0
next prev parent reply other threads:[~2024-06-26 13:05 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-26 13:05 [PATCH v3 1/3] Fix userfaultfd_api to return EINVAL as expected Audra Mitchell
2024-06-26 13:05 ` [PATCH v3 2/3] Update uffd-stress to handle EINVAL for unset config features Audra Mitchell
2024-06-26 13:05 ` Audra Mitchell [this message]
2024-06-26 13:53 ` [PATCH v3 3/3] Turn off test_uffdio_wp if CONFIG_PTE_MARKER_UFFD_WP is not configured Peter Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240626130513.120193-3-audra@redhat.com \
--to=audra@redhat.com \
--cc=aarcange@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=brauner@kernel.org \
--cc=jack@suse.cz \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=peterx@redhat.com \
--cc=raquini@redhat.com \
--cc=rppt@linux.vnet.ibm.com \
--cc=shli@fb.com \
--cc=shuah@kernel.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox