From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 17054C27C4F for ; Wed, 26 Jun 2024 04:41:33 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 6F7C66B0083; Wed, 26 Jun 2024 00:41:32 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 680786B0085; Wed, 26 Jun 2024 00:41:32 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4FA0A6B0088; Wed, 26 Jun 2024 00:41:32 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 2EBDA6B0083 for ; Wed, 26 Jun 2024 00:41:32 -0400 (EDT) Received: from smtpin03.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id AE2EA4072B for ; Wed, 26 Jun 2024 04:41:31 +0000 (UTC) X-FDA: 82271791182.03.476D6A1 Received: from mail-oi1-f193.google.com (mail-oi1-f193.google.com [209.85.167.193]) by imf30.hostedemail.com (Postfix) with ESMTP id D22E180016 for ; Wed, 26 Jun 2024 04:41:28 +0000 (UTC) Authentication-Results: imf30.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=YnCAdGro; spf=pass (imf30.hostedemail.com: domain of senozhatsky@chromium.org designates 209.85.167.193 as permitted sender) smtp.mailfrom=senozhatsky@chromium.org; dmarc=pass (policy=none) header.from=chromium.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1719376881; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=D5SN5g9dZXd4jHj1UDwEbPoCj2yPZWkE/B6mLbVsHgM=; b=1b3mFS5JxruzvXf3fKHtwq+X/rPcsBBgNkYAFnsKSgbZLfOtCBEVQEKvlWTzO8V+boanaT vqcS0TqEkd1tLIVswlhXLcJ2w7zEFvYIDyb349OjVEuDx/6V2Pxa8XqO3kfsuYhlMEeOxg JuTOBM+9x/CKRJT+qreXMDJdMbRlOC8= ARC-Authentication-Results: i=1; imf30.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=YnCAdGro; spf=pass (imf30.hostedemail.com: domain of senozhatsky@chromium.org designates 209.85.167.193 as permitted sender) smtp.mailfrom=senozhatsky@chromium.org; dmarc=pass (policy=none) header.from=chromium.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1719376881; a=rsa-sha256; cv=none; b=4YkE9LUb6S5+pVbBznIxYgcHItg+QtaUQD8qtjuvWqC3kP9syQp/+Y4jb7ysY8WiIs2Q// 25O7WjBWNCZtmATZZvPgNFv1JWcWXqYc2gv7BjY43kJOuEcqU5rJIrowoLpSIoRsdwrBV9 S8kY+M2098PzLIE1JFy4EiRMtPdDSFY= Received: by mail-oi1-f193.google.com with SMTP id 5614622812f47-3d55e2e032dso582070b6e.3 for ; Tue, 25 Jun 2024 21:41:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1719376888; x=1719981688; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=D5SN5g9dZXd4jHj1UDwEbPoCj2yPZWkE/B6mLbVsHgM=; b=YnCAdGroeTZCPk/OvDCKOScDzewFXOuUTuAWEDRGJ9TSDPhZKbAMXPthnaTKpvbHuS mc+hYDvDYbVZrRE52P7NkJo1OnCik2EKKbEVkoi9P3HMmK6F+n57obJYnMIEk9UEX9Rj 69UsjJqemZ32pNv+7dcWAiKQVn1jR0OAkTxmI= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1719376888; x=1719981688; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=D5SN5g9dZXd4jHj1UDwEbPoCj2yPZWkE/B6mLbVsHgM=; b=YS2UUi/rfl8gzJeoPFF0qlRA8j1U/umd2/EQL+HDIo1nHeA64ZvDFmOxBiwBjENwj+ 2xrwV0pf9xqhK8LYaE9SRlQj9A+gMQ7dJLd1XzCbCgAIqpm7qs2oqvjGHNcHA+eRl+o9 bo8c4AypSlFA5z6e4/yidkV/o7DbiCdi9Z6WjFowkFdUCyTFSjDS38WzjbIhWE0oCoFx 1C20Rbc9i4dJW5r3DxT5Gs5eng5FITxeRuMkoTv5mOGrMsWV0ggg3jOxM9z3yQ10fD8l aTpnZt3yG3mu4+2UwXpL+eitDhrUrWw6omb/9AWztEODzvA7qiwpABgFfd/E6i6u9EuX weww== X-Forwarded-Encrypted: i=1; AJvYcCWhRGrLjtnrsnzVtSTbVO6xuO5sGIBKfcdCW0A6aH3xXD8RQIeqTq0RHZqDJwCTLkybiglfoD/8zSk7DOkIPM8cLHU= X-Gm-Message-State: AOJu0Ywqca8XS5AAPTjGLIMuC5ARyPYuhT0SgM86uiEUHV2Dw0U7sXeN 7vUlCTKyvgco4ADHhCUBDOnVVDvb3sCU7HM35k/GvBbBrJtby5lU2P5eSYYFSQ== X-Google-Smtp-Source: AGHT+IHghuf3tkdv3+yfXxzpfwWFh16zBggDrPPrf7ANaGPxxHHsNrKgPM67fFuG8SW/r2HDYZAv6Q== X-Received: by 2002:a05:6808:210e:b0:3d5:5fbe:b31a with SMTP id 5614622812f47-3d55fbebea0mr1866075b6e.51.1719376886966; Tue, 25 Jun 2024 21:41:26 -0700 (PDT) Received: from google.com ([2401:fa00:8f:203:d7ad:9c6b:494:edc0]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-7069d59dce1sm1970557b3a.169.2024.06.25.21.41.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 25 Jun 2024 21:41:26 -0700 (PDT) Date: Wed, 26 Jun 2024 13:41:22 +0900 From: Sergey Senozhatsky To: Andrew Morton Cc: David Hildenbrand , Matthew Wilcox , Sergey Senozhatsky , linux-kernel@vger.kernel.org, linux-mm@kvack.org, Mike Rapoport , Minchan Kim , Hyeonggon Yoo <42.hyeyoo@gmail.com> Subject: Re: [PATCH v2 3/6] mm/zsmalloc: use a proper page type Message-ID: <20240626044122.GA15925@google.com> References: <20240529111904.2069608-1-david@redhat.com> <20240529111904.2069608-4-david@redhat.com> <20240530050123.GA8400@google.com> <345161ac-3b42-48aa-ab3d-3b183316479a@redhat.com> <20240625153338.8a4d049857d59e692a0d31e6@linux-foundation.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240625153338.8a4d049857d59e692a0d31e6@linux-foundation.org> X-Rspam-User: X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: D22E180016 X-Stat-Signature: kxo9qraxuintkig6cofuc89tdep6zrkc X-HE-Tag: 1719376888-52574 X-HE-Meta: U2FsdGVkX18y6HMblZrZL3TIIge+MjdH41bVML2zpHs+ULbFvZysAldcpdHi5APvzkQgvhuxXc/8NfSy/pd+bMovD5xYrVoMOd7fZWknBfbVqccdiRwyVcGZG9XaTbAhm5tTH9BJu9DOWJjzx911kKmVsYX+O053vVViMysQZ88M9HoU72Ivna1YePOkEXKMehYekYtWowCWmfiFKSAas68B98kKZJ5BqS4k5OqLxlLKRJr0Qg6C10A3R12a+i3oMfF8I1dmar0PYyrvn1tvIGF7vMU4Yn+APwTpQ/mrrK/P41zaga194/n/g7ettn6HsYBsQ03QcYvrmIvJYoVjHR22TGyQ1mjYW8KWYp+6rzY2Yvw+VyHPK5E4PEaIFBtaj9zVfFTxsAwrpVyjbj6v953Lga2jcx07RklmSqXz/eam2M6saZQINYXkewBEKX/XRFx5F50HQDTiLzhCYXMRea5A60H4yCs7/7GkDYhBq5zGyZgqOb1Y6bWk7kP9aK4mftQu1RL+opeQ/KxWhiOc1sRjAMrABMM7vh2by2oMCZK4V9kvlpJUwPLUE8u3EaHUbjzoc8HhvmFMudH6KcP6g4qE4e5QeN8wcaQw7e1+rz0fm1Q89Jp1CU6MPIttswhguaC0bp4VH422UIBj/SCinEkVpHQSzSYEKOAKjJMA0mboUuqHL07tFOrP9uaCxcWyGCuD8Eg+b8HDvjZa93NiyS0wNYZzf2nD3ryY/MIkNwYLkXZtt25tN6wKHP2p8RHnrL0vTKm9z69CU2Pp0vHQSiatdis2EYAHYUpFZsvTkkXsLkc5iAzRTbkawLbHj5fBfziRuz1HQQZbTEYcYPzPWGREurvmA9hT0MiwxAI85Qis4Ewsxsc4c6ITxKI3pkYnXqD9xWFwW8UiI0bVkQibB0yhemRQ/LBldKEHUl1GPTKVQTHo5/iOxGCVn8S1xx9dWkKxFAnKX9fLrVgETpQ cHaxQ0f0 UkECuCwQSMhmZnnhXS029HMJnT/HPqZoOE8pdXGMq1hHs5EfqY0J9O5RdBf/C2XyLGWpvPv05fIn/ycM8/4aHQT2YVM7TGuAeVXpPZ4NzOgtXKiM25MQGtu0cHNGPtoMb6kE0nfjExuqvcabboooqkI1nUn6RNoj+2ZrMHcyyujGuZzgjaojTQuprlivdER1ERbg6P4XuQSPfVSCNGZngWADoru0n/8UXghThyXUI+hmCJm09Pof++FwIvIu+P+htP3ReLBBi29+cJa4aeWBXoTy4tyRt6ozPUmmDVIFuGEetnRXzsqUuf9LzlfCBRKUy1GjR2tomb0Hcb2QGn5hJFdBXa69FTbrvWbegD7WvUHSJBkH5NJ0qL3GMy2k2GcN6gnRgDa+XXrRA92/Vh/azOvbAU/YJZFY6LEwggERokrzMgs0g1RDzWrmutpWpEXFh/s6QKWXVURdjOdv+W1clxiCWUyCUCglLcVVZpsTXXleX0QrPQhH7fKPMUEnmA8baJ+p6sGnE78FLJ5bFeHSZShFoE90qDG/DGXuiKfgsR+xfi9qFmxM/xW0w2ylo9uX90/a0 X-Bogosity: Ham, tests=bogofilter, spamicity=0.002469, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On (24/06/25 15:33), Andrew Morton wrote: > On Fri, 31 May 2024 16:32:04 +0200 David Hildenbrand wrote: > > > On 31.05.24 16:27, Matthew Wilcox wrote: > > > On Thu, May 30, 2024 at 02:01:23PM +0900, Sergey Senozhatsky wrote: > > > 1409: 83 c0 01 add $0x1,%eax > > > if (mapcount < PAGE_MAPCOUNT_RESERVE + 1) > > > 140c: 83 f8 81 cmp $0xffffff81,%eax > > > 140f: 7d 63 jge 1474 > > 4> > > > if (folio_test_hugetlb(folio)) > > > 1411: 80 7b 33 84 cmpb $0x84,0x33(%rbx) > > > 1415: 74 4e je 1465 > > > > > > so we go from "mov, and, cmp, je" to just "cmpb, je", which must surely > > > be faster to execute as well as being more compact in the I$ (6 bytes vs 15). > > > > > > Anyway, not tested but this is the patch I used to generate the above. > > > More for comment than application. > > > > Right, it's likely very similar to my previous proposal to use 8 bit > > (uint8_t) for the type. > > > > https://lore.kernel.org/all/00ba1dff-7c05-46e8-b0d9-a78ac1cfc198@redhat.com/ > > > > I would prefer if we would do that separately; unless someone is able to > > raise why we care about zram + 256KiB that much right now. (claim: we don't) > > > > iow, "this is ok for now", yes? Perhaps. I'm not in position to claim that zram + 256KiB PAGE_SIZE is irrelevant, but I'm also not in position to claim the opposite. Matthew and David have ideas/proposals/patches to fix it should 256KiB PAGE_SIZE become an issue.