From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2A28AC30653 for ; Wed, 26 Jun 2024 12:19:42 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 877676B0085; Wed, 26 Jun 2024 08:19:41 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 8281B6B0088; Wed, 26 Jun 2024 08:19:41 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7158A6B008C; Wed, 26 Jun 2024 08:19:41 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 549936B0085 for ; Wed, 26 Jun 2024 08:19:41 -0400 (EDT) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id B4CDA40FB9 for ; Wed, 26 Jun 2024 12:19:40 +0000 (UTC) X-FDA: 82272945720.23.0B6FA83 Received: from sin.source.kernel.org (sin.source.kernel.org [145.40.73.55]) by imf07.hostedemail.com (Postfix) with ESMTP id 8D46F4001C for ; Wed, 26 Jun 2024 12:19:38 +0000 (UTC) Authentication-Results: imf07.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=pri+ihHX; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf07.hostedemail.com: domain of brauner@kernel.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=brauner@kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1719404367; a=rsa-sha256; cv=none; b=Ti7Xqiz7BtIqiBtJ9hRGeJZM9KUkJXokQ9Hk6hUEkMz84CT0dT1Ssx7Yi3Q9UutAcpDm8e kB0mRrfjVzwmxFQDO4UFm3CWMOuK1Qgbo2h7PoKDVfrT3VehJE23Qx/BhwVugk0CDwq4w6 85KzYZlvxB/YBHYMb6hBexMvhJz87jI= ARC-Authentication-Results: i=1; imf07.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=pri+ihHX; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf07.hostedemail.com: domain of brauner@kernel.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=brauner@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1719404367; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=qnb1LMdZOzuANJ8mCxg/MMmIn0stuhL212pLpyIyklw=; b=1eHylE31XlWxFoeK4kUA1LlBiZ8wfPBHjx5coSRvlVdAsNrb2PEqFa3n4OxknWuV6Qveoc Lcfx+33CzYVQNmDXZU9qOyf5MzUE7pt2LEBQ8lV4txNn025+eYRx0euiA01Up10sQL4ssR WCA0EJrwvZVubKbW445dgap9jIfq4cI= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id 39A07CE21B7; Wed, 26 Jun 2024 12:19:35 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id AA674C2BD10; Wed, 26 Jun 2024 12:19:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1719404374; bh=+a6cKOTvjBqwaDCkw+KkodDw+TAU6VuT99/mNKvMi/o=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=pri+ihHX6LCjoCWfssh1KMC23/kENbI3RJR/QRgf5v1PH+ivyNER4s3d4Y4Ei9wdZ R9wpkRQL5fDkRmkGBcetNtjmbny16WrQt51T62EmpyxJ22VicfdS8GNzFwvOFzfO4H xgn9oLBAzKDwK8EiYEhNUwii6WUaJup+13qLAPWjh8+621zQVTVVK3ga5ofgCNtnvy AiX14y4WmlQfj2MxHsIKbHQE2Mje7Nhhuu5wG7SJpNGR8njRbHxiJ9hD/BITvLibiR auK1zl6EfHYXdpsWHYdprFvHnFmoPMqm3iwygWG8LbwMZFWOvkOeVCteF8T6y6GU/0 ypdq2Pr9emrVg== From: Christian Brauner To: David Howells Cc: Christian Brauner , Matthew Wilcox , Jeff Layton , netfs@lists.linux.dev, v9fs@lists.linux.dev, linux-afs@lists.infradead.org, linux-cifs@vger.kernel.org, linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] netfs: Fix netfs_page_mkwrite() to check folio->mapping is valid Date: Wed, 26 Jun 2024 14:19:24 +0200 Message-ID: <20240626-kennen-westseite-0c15ed37b7a5@brauner> X-Mailer: git-send-email 2.43.0 In-Reply-To: <780211.1719318546@warthog.procyon.org.uk> References: <614257.1719228181@warthog.procyon.org.uk> <780211.1719318546@warthog.procyon.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" X-Developer-Signature: v=1; a=openpgp-sha256; l=1250; i=brauner@kernel.org; h=from:subject:message-id; bh=+a6cKOTvjBqwaDCkw+KkodDw+TAU6VuT99/mNKvMi/o=; b=owGbwMvMwCU28Zj0gdSKO4sYT6slMaTVsPsxi/x9Fmk/c4KNgkXyZiG7vkmT1jWVhYnnml4Ki ZBerBPdUcrCIMbFICumyOLQbhIut5ynYrNRpgbMHFYmkCEMXJwCMBHDV4wMh77GvnLqe1bMGLjb +s+3rABXy/7zq4QPtkbkXnk5/bbTZob/5SnPvHyijp+5nbLx9wdRzQPnpbkvfVljY/2vgi8x7mc fGwA= X-Developer-Key: i=brauner@kernel.org; a=openpgp; fpr=4880B8C9BD0E5106FC070F4F7B3C391EFEA93624 Content-Transfer-Encoding: 8bit X-Rspamd-Queue-Id: 8D46F4001C X-Rspam-User: X-Rspamd-Server: rspam05 X-Stat-Signature: obrhf3iu5bpkf7qy76zwfrfhb3e1761e X-HE-Tag: 1719404378-976300 X-HE-Meta: U2FsdGVkX192Pz/atysxjP/qs44HgwLKiGzQ9HoUqZbL/tlmV+bkKI/JnG4g+wa0enyHFtk9UnnUxoc5ZQuWBy+cFuVTcPFSQ3aEHYc2L6RklT6SU2Il7+bxPhn9f9o/JO0JJ1O6oHjDuJCeA9PwIieBtbvToQtTjhkDYHEWQLe+MSbTN/8Nm1rb+JdkKnvUMoIHDaTmdKwkHPcsWf7EWILvmBhiglLcA6WW6rYEtgAarAMsLbsyd71mNw9aIjzRx8vVNO++L2zdNm9axjKVKOUWCCAEmFu+HMDjF67u3A0FKFeHc9G7rf31YFL+2RWvkOEJDm9r8XOMn8wNTeAcl+Pue6BFeM2TAFm5hj68RGjBNOsngPWSGPCt0vZd2MmxPqaJKihbhGBKbSqEK3mOS32j0aH6I898lNrF0lwzUCO/n+fRcQUIOIoR7AzdB/AF/ZWCciAT/2OKcKK2QgygzYbdqXvnq3zFOswoRHwYAyylLrTyOjN88BTPfinHIJS2W91x0V4w20066be6CNmvEed1beuvujTUCiHCagDWNrhTBXWwOF3ebUHssRI74OSTGoC/yXT4oc4gf/sRkY8wh2rIID8amxBBI4/nQl7LS0VmIJz12sdM2e7Edce2DQR7o79BL+GNWSpzT/AoHVkevySEIfUHZVvpVAWMlGuDIK09FVzx735djNQdv0bjfDY58nnPJZ9Wz9awqfD/JJJbejBNA4hBYBWSeooG122DDrKVYLcQ9ELplifAwHPHLUv9R+BoUDGDPd7R6hKVGyVSo+a2dtI25Yz9KM6qASgONMHMzlu85vIkSwxKdqUnOgFIdnq5YgQ6/urr8HKYZGJrVHMKFaO7XT8AB6czQd9cnvoZr1iuMC/a/Qwl3PGk38UI9KFMl9wgUKX3dN2p3LKfqUwk9On5KfRxwJN2CLFgsTSCEqQxG6dnRTyMRFuCEgMmQPceo781wbYzpc//1k7 cerzNrol shlmhKsdNDKtjrLPZgk/RvL090ypqmE+gudFxrYi0KIv+0jfhkGi889ZzRBE/XWKYyozjEzeodWLehtI52G0zuHbrQSNnOXLsDASpSPJbTbjUMcvMx64NRxRsi5R1bJlX0bLNVvII3hYPindiGw9SSYL7jLiApFxKI5mZ77MFl9E37UckNtjOBuV6pKt/fD1mNZBp2Sd5P7FPsw5N7RfIZDA5zLUUAJNdacf8CuL+Adi0EMHY6XoPZ2fOufD9PRXbKxV/l7I13MsTvbtTllUMumIgxZC0T4LHZn4M2RUT3Av9O3PsDKw2bIH1VzetITKjdFzXba+5JZ8rmpPWgEYa+EYmiw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, 25 Jun 2024 13:29:06 +0100, David Howells wrote: > > Fix netfs_page_mkwrite() to check that folio->mapping is valid once it has > taken the folio lock (as filemap_page_mkwrite() does). Without this, > generic/247 occasionally oopses with something like the following: > > BUG: kernel NULL pointer dereference, address: 0000000000000000 > #PF: supervisor read access in kernel mode > #PF: error_code(0x0000) - not-present page > > [...] Applied to the vfs.fixes branch of the vfs/vfs.git tree. Patches in the vfs.fixes branch should appear in linux-next soon. Please report any outstanding bugs that were missed during review in a new review to the original patch series allowing us to drop it. It's encouraged to provide Acked-bys and Reviewed-bys even though the patch has now been applied. If possible patch trailers will be updated. Note that commit hashes shown below are subject to change due to rebase, trailer updates or similar. If in doubt, please check the listed branch. tree: https://git.kernel.org/pub/scm/linux/kernel/git/vfs/vfs.git branch: vfs.fixes [1/1] netfs: Fix netfs_page_mkwrite() to check folio->mapping is valid https://git.kernel.org/vfs/vfs/c/a81c98bfa40c