linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: "Liam R. Howlett" <Liam.Howlett@oracle.com>
To: linux-mm@kvack.org, Andrew Morton <akpm@linux-foundation.org>
Cc: Suren Baghdasaryan <surenb@google.com>,
	Vlastimil Babka <vbabka@suse.cz>,
	Lorenzo Stoakes <lstoakes@gmail.com>,
	Matthew Wilcox <willy@infradead.org>,
	sidhartha.kumar@oracle.com,
	"Paul E . McKenney" <paulmck@kernel.org>,
	Bert Karwatzki <spasswolf@web.de>, Jiri Olsa <olsajiri@gmail.com>,
	linux-kernel@vger.kernel.org, Kees Cook <kees@kernel.org>,
	"Liam R. Howlett" <Liam.Howlett@oracle.com>
Subject: [PATCH v2 07/15] mm/mmap: Extract validate_mm() from vma_complete()
Date: Tue, 25 Jun 2024 15:11:37 -0400	[thread overview]
Message-ID: <20240625191145.3382793-8-Liam.Howlett@oracle.com> (raw)
In-Reply-To: <20240625191145.3382793-1-Liam.Howlett@oracle.com>

vma_complete() will need to be called during an unsafe time to call
validate_mm().  Extract the call in all places now so that only one
location can be modified in the next change.

Signed-off-by: Liam R. Howlett <Liam.Howlett@oracle.com>
---
 mm/mmap.c | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/mm/mmap.c b/mm/mmap.c
index 2a1a49f98fa3..8d9be791997a 100644
--- a/mm/mmap.c
+++ b/mm/mmap.c
@@ -646,7 +646,6 @@ static inline void vma_complete(struct vma_prepare *vp,
 	}
 	if (vp->insert && vp->file)
 		uprobe_mmap(vp->insert);
-	validate_mm(mm);
 }
 
 /*
@@ -734,6 +733,7 @@ int vma_expand(struct vma_iterator *vmi, struct vm_area_struct *vma,
 	vma_iter_store(vmi, vma);
 
 	vma_complete(&vp, vmi, vma->vm_mm);
+	validate_mm(vma->vm_mm);
 	return 0;
 
 nomem:
@@ -775,6 +775,7 @@ int vma_shrink(struct vma_iterator *vmi, struct vm_area_struct *vma,
 	vma_iter_clear(vmi);
 	vma_set_range(vma, start, end, pgoff);
 	vma_complete(&vp, vmi, vma->vm_mm);
+	validate_mm(vma->vm_mm);
 	return 0;
 }
 
@@ -1103,6 +1104,7 @@ static struct vm_area_struct
 	}
 
 	vma_complete(&vp, vmi, mm);
+	validate_mm(mm);
 	khugepaged_enter_vma(res, vm_flags);
 	return res;
 
@@ -2481,6 +2483,7 @@ static int __split_vma(struct vma_iterator *vmi, struct vm_area_struct *vma,
 
 	/* vma_complete stores the new vma */
 	vma_complete(&vp, vmi, vma->vm_mm);
+	validate_mm(vma->vm_mm);
 
 	/* Success. */
 	if (new_below)
@@ -3353,6 +3356,7 @@ static int do_brk_flags(struct vma_iterator *vmi, struct vm_area_struct *vma,
 		vma_iter_store(vmi, vma);
 
 		vma_complete(&vp, vmi, mm);
+		validate_mm(mm);
 		khugepaged_enter_vma(vma, flags);
 		goto out;
 	}
-- 
2.43.0



  parent reply	other threads:[~2024-06-25 19:12 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-06-25 19:11 [PATCH v2 00/15] Avoid MAP_FIXED gap exposure Liam R. Howlett
2024-06-25 19:11 ` [PATCH v2 01/15] mm/mmap: Correctly position vma_iterator in __split_vma() Liam R. Howlett
2024-06-25 19:11 ` [PATCH v2 02/15] mm/mmap: Introduce abort_munmap_vmas() Liam R. Howlett
2024-06-25 19:11 ` [PATCH v2 03/15] mm/mmap: Introduce vmi_complete_munmap_vmas() Liam R. Howlett
2024-06-25 19:11 ` [PATCH v2 04/15] mm/mmap: Extract the gathering of vmas from do_vmi_align_munmap() Liam R. Howlett
2024-06-25 19:11 ` [PATCH v2 05/15] mm/mmap: Introduce vma_munmap_struct for use in munmap operations Liam R. Howlett
2024-06-25 19:11 ` [PATCH v2 06/15] mm/mmap: Change munmap to use vma_munmap_struct() for accounting and surrounding vmas Liam R. Howlett
2024-06-25 19:11 ` Liam R. Howlett [this message]
2024-06-25 19:11 ` [PATCH v2 08/15] mm/mmap: Inline munmap operation in mmap_region() Liam R. Howlett
2024-06-25 19:11 ` [PATCH v2 09/15] mm/mmap: Expand mmap_region() munmap call Liam R. Howlett
2024-06-25 19:11 ` [PATCH v2 10/15] mm/mmap: Reposition vma iterator in mmap_region() Liam R. Howlett
2024-06-25 19:11 ` [PATCH v2 11/15] mm/mmap: Track start and end of munmap in vma_munmap_struct Liam R. Howlett
2024-06-25 19:11 ` [PATCH v2 12/15] mm/mmap: Avoid zeroing vma tree in mmap_region() Liam R. Howlett
2024-06-25 19:11 ` [PATCH v2 13/15] mm/mmap: Use PHYS_PFN " Liam R. Howlett
2024-06-25 19:11 ` [PATCH v2 14/15] mm/mmap: Use vms accounted pages " Liam R. Howlett
2024-06-26 16:32   ` Kees Cook
2024-06-26 18:04     ` Liam R. Howlett
2024-06-26 18:45       ` Kees Cook
2024-06-25 19:11 ` [PATCH v2 15/15] mm/mmap: Move may_expand_vm() check " Liam R. Howlett
2024-06-26 20:58 ` [PATCH v2 00/15] Avoid MAP_FIXED gap exposure Andrew Morton
2024-06-27  1:15   ` Liam R. Howlett
2024-06-27  1:28     ` Andrew Morton
2024-06-27 13:31       ` Liam R. Howlett

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240625191145.3382793-8-Liam.Howlett@oracle.com \
    --to=liam.howlett@oracle.com \
    --cc=akpm@linux-foundation.org \
    --cc=kees@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=lstoakes@gmail.com \
    --cc=olsajiri@gmail.com \
    --cc=paulmck@kernel.org \
    --cc=sidhartha.kumar@oracle.com \
    --cc=spasswolf@web.de \
    --cc=surenb@google.com \
    --cc=vbabka@suse.cz \
    --cc=willy@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox