From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C47A8C3064D for ; Tue, 25 Jun 2024 18:06:22 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 54D6D6B00AB; Tue, 25 Jun 2024 14:06:22 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 4FBE26B00AC; Tue, 25 Jun 2024 14:06:22 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3C3DA6B00AD; Tue, 25 Jun 2024 14:06:22 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 1DEE76B00AB for ; Tue, 25 Jun 2024 14:06:22 -0400 (EDT) Received: from smtpin03.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id D06CE140475 for ; Tue, 25 Jun 2024 18:06:21 +0000 (UTC) X-FDA: 82270190562.03.BA3AC71 Received: from mout-p-201.mailbox.org (mout-p-201.mailbox.org [80.241.56.171]) by imf02.hostedemail.com (Postfix) with ESMTP id E634880021 for ; Tue, 25 Jun 2024 18:06:18 +0000 (UTC) Authentication-Results: imf02.hostedemail.com; dkim=pass header.d=pankajraghav.com header.s=MBO0001 header.b="Vwv4/oEO"; spf=pass (imf02.hostedemail.com: domain of kernel@pankajraghav.com designates 80.241.56.171 as permitted sender) smtp.mailfrom=kernel@pankajraghav.com; dmarc=pass (policy=quarantine) header.from=pankajraghav.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1719338765; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=8cLTdC1JjfjD0aicUlYHFelZAUVGhDwe+oxU99OeiD0=; b=XejZi6x8rIEhwem3muXLcxh1tIj8ICgu+UQH3Mk1XxDoM/om59FIiLR25jAH/fLkBDKp4A pcC05T0ww8HJ6Hkm8VdPDcCnV2X28wY9cicTwvAdhdWE4Z1kUZwuHXrbPGYf682ABUcxay B7iATM4yn8ibFSydKntsgSYJMSJ8x4c= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1719338765; a=rsa-sha256; cv=none; b=PuJ2g+xm4OQdRRInf/SI9cl5MVXgQYQrCh4dzKJELm6TEZU+qHHIgoCbV+euT44G1MpUrs jFk5twxRcaqdO+7EQlyDXiSS4hb1xje95keIAWYoVGVbaZokFlSMjtfRG476wuGCie1f+7 vP/AgUdmW83T1gy7USsLJksi9WMLIzw= ARC-Authentication-Results: i=1; imf02.hostedemail.com; dkim=pass header.d=pankajraghav.com header.s=MBO0001 header.b="Vwv4/oEO"; spf=pass (imf02.hostedemail.com: domain of kernel@pankajraghav.com designates 80.241.56.171 as permitted sender) smtp.mailfrom=kernel@pankajraghav.com; dmarc=pass (policy=quarantine) header.from=pankajraghav.com Received: from smtp202.mailbox.org (smtp202.mailbox.org [IPv6:2001:67c:2050:b231:465::202]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mout-p-201.mailbox.org (Postfix) with ESMTPS id 4W7t7B3wwXz9scR; Tue, 25 Jun 2024 20:06:14 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pankajraghav.com; s=MBO0001; t=1719338774; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=8cLTdC1JjfjD0aicUlYHFelZAUVGhDwe+oxU99OeiD0=; b=Vwv4/oEO17MkAKBJYU1LN9CPGtx8VtlGI2h5rBL5CmfOAVCQBQ3/XJ5k/+Tg/vTqPfQTY0 YlgpfglA5syMu8H73dNRAtUhay22YPiBOACiSYfvajJcosbu9ANx4eglZKTv5EeEmlKr41 9XWfTNYOS21Qdig+1SNBPZx2AJ0sEDp6DT6C+7M7hnf0+UH3KCxyaioT6tN+Qo+i000VeE rsslKK4S8F0fyoKFPotmbfwf7zeAg/EW8L6MhP8EVItdVa+kn3YHQ00V3sc8ct8gUfqt4B 6jTznTHwuEOEhmNp0dQdpQ1XpFx3B4c7yUiwqeGjgGRTN6oTWVEgEBNx4ccbcA== Date: Tue, 25 Jun 2024 18:06:09 +0000 From: "Pankaj Raghav (Samsung)" To: Matthew Wilcox Cc: david@fromorbit.com, chandan.babu@oracle.com, djwong@kernel.org, brauner@kernel.org, akpm@linux-foundation.org, linux-kernel@vger.kernel.org, yang@os.amperecomputing.com, linux-mm@kvack.org, john.g.garry@oracle.com, linux-fsdevel@vger.kernel.org, hare@suse.de, p.raghav@samsung.com, mcgrof@kernel.org, gost.dev@samsung.com, cl@os.amperecomputing.com, linux-xfs@vger.kernel.org, hch@lst.de, Zi Yan Subject: Re: [PATCH v8 02/10] filemap: allocate mapping_min_order folios in the page cache Message-ID: <20240625180609.z4prikqk7eufl6bi@quentin> References: <20240625114420.719014-1-kernel@pankajraghav.com> <20240625114420.719014-3-kernel@pankajraghav.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Queue-Id: E634880021 X-Stat-Signature: 3mngw1645ttj99t4wzawn7mngiga3ums X-Rspamd-Server: rspam09 X-Rspam-User: X-HE-Tag: 1719338778-537462 X-HE-Meta: U2FsdGVkX1+/xfcD/mneAa61UNdfCcMHRWqszvPevSXhjK/qRsSyRh/a7OCCjFqRYrYyTnc5Na3Q502NSXXFeDRbvQG4oFqe5wCFR42tyCYwONCrpKz+Zs2J6n2pddBBL5flTLc+pnmQUu3Zci7Il+vu6tBmZPY+IkwAwWB5JSm2pSczWizyEdqcilVFNXHp5inbpjCSjISopmcFyLlT0C3546h4UXYQOGtSucRt4IIRavZ8mQUzIYxHY6EWgyEd5iQSfSzyxHs5r9bNYc0u0+3OazsC9XiD35UOAD/TaRrqAUDMUF+ECAdSTsLnEEfpAfnHfbVBlTcAoT4dgSVJ2b/ouzNd/Vj0cN/o/5acM6OkCWQmi3VY3FQGlJZaoqRJpDFbo0K/nAkvAKc02R9tV7BB+GN5Yv5RRCznYy/K4p1a7tfgITIkvdJWBJsLrLRJoGjF/Clh2XhR5AxdUv098D3gQ5y64Gr4z2BRw7BAFIZxZOTCHQyZxp0/wL69oszZEBQTSi6QPCIHBV4/IQAmlRZZNXllealAf1vv4lyiHQNEliBznDZW2bgRSxKNsDSixwWKbIIdr0lPgdSWcmSdeIdzKNXHl7dkcvafWIaAbkw7c8yvAIagN8cEd053k7Jse1WBzgahAYXrwBOKYJopJJOSntNBL5CGW5JPQnD7DF/IlZZYrMAJV+bhCM/CxYIMuSPiEbuUdw47GnTFEPdqmiL9Ffe77ZQRIR981QlVDiiT/dS1Obhy2N6EFL5slPUaVhVtjf8FLVO581bFAf4kv0liKG3CjMhCmjvnVgZ1AO+TYRuoYZ310zwcsG2nHOTX090qcgQcurdEi7owSqE+pQlEwQe8lwWdsqruoX3SeKILpXXGbiIjlYbY9PriFh4ilT+PzX8i2TmtX4cGr9LLOc+c/TMKgem6MhFQpvKYnuWUwgOtacEbBLcOd6LI3LaMXhMMiF78k+BkE1crbF3 lE0EO4ag +lg6ujo7WKr73IIAJ07xA6BYqDQlOuo06ao1BNBBovhmy2fz+Gm+TJv5wNZmeF93/0CpfYX1CsrITtoSyzcpQY13qWmuQLhWGeSIlqrI5GEAcriIqdUfSr7K2yycG4xDKz3TjX72pmaaMv0lfQsy2nLfFqDLmiINDKlOEZYovbdK7GktvVw4MiWf7bdkvEaHas2lOel32yDEq7dSicXHrx0gj8RQEW4/jBNFYqFCB8p5mfd9P7j1CEk+YZ7D6xsfq1t6cnzv9WVmli47+AqXH24OlZqLfs36DGRh/SbH5Ah3c19bra94DV4UL3Ey+gNEQ3cDVCVp0oWVpMVRW5J1Vz+NYvU2ogQg08ZygOSHuSyEpT5Ybx7HHytjmVGXVWnY8uq6Vym4QLPvcQom7X42rnHJbZKdB++tg/dDmELPUXZVJ1trTP2KgzqtM1A== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Jun 25, 2024 at 04:52:03PM +0100, Matthew Wilcox wrote: > On Tue, Jun 25, 2024 at 11:44:12AM +0000, Pankaj Raghav (Samsung) wrote: > > Co-developed-by: Luis Chamberlain > > Signed-off-by: Luis Chamberlain > > Signed-off-by: Pankaj Raghav > > Reviewed-by: Hannes Reinecke > > Reviewed-by: Darrick J. Wong > > Reviewed-by: Matthew Wilcox (Oracle) Thanks! > > after fixing the nits below > > > +/** > > + * mapping_align_index() - Align index based on the min > > + * folio order of the page cache. > > + * mapping_align_index - Align index for this mapping. > > > @@ -1165,7 +1186,7 @@ static inline vm_fault_t folio_lock_or_retry(struct folio *folio, > > void folio_wait_bit(struct folio *folio, int bit_nr); > > int folio_wait_bit_killable(struct folio *folio, int bit_nr); > > > > -/* > > +/* > > * Wait for a folio to be unlocked. > > * > > * This must be called with the caller "holding" the folio, > > Unnecessary whitespace change >