From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5F791C2BBCA for ; Tue, 25 Jun 2024 17:12:11 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 8A4546B0093; Tue, 25 Jun 2024 13:12:10 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 853CE6B0095; Tue, 25 Jun 2024 13:12:10 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 71CF66B0096; Tue, 25 Jun 2024 13:12:10 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 5313C6B0093 for ; Tue, 25 Jun 2024 13:12:10 -0400 (EDT) Received: from smtpin10.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id E9FAB1C1081 for ; Tue, 25 Jun 2024 17:12:09 +0000 (UTC) X-FDA: 82270053978.10.7320C42 Received: from mail-qk1-f173.google.com (mail-qk1-f173.google.com [209.85.222.173]) by imf11.hostedemail.com (Postfix) with ESMTP id D274E4001A for ; Tue, 25 Jun 2024 17:12:07 +0000 (UTC) Authentication-Results: imf11.hostedemail.com; dkim=pass header.d=toxicpanda-com.20230601.gappssmtp.com header.s=20230601 header.b=DO7ZK4RE; spf=none (imf11.hostedemail.com: domain of josef@toxicpanda.com has no SPF policy when checking 209.85.222.173) smtp.mailfrom=josef@toxicpanda.com; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1719335521; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=WZIbVVFwCm0LobQXtGnzuMPIvM8lMcPFoEmqjMJNQvY=; b=xktgIZGAElpdNjAqZXph/I0kPpAT2JK8R5HXng02pG4HikZndi06pmn/aAlBfm/sqhDdd3 3m+u3Ov5dxS1wpsveEcDEchiNI7D6RbjB9p1hQ2zFVVqW/Di31MrXq9DU2kgBnv3Bc9mNe j8gr+wAljVIoZVXQvDTU/JqM+Di85ts= ARC-Authentication-Results: i=1; imf11.hostedemail.com; dkim=pass header.d=toxicpanda-com.20230601.gappssmtp.com header.s=20230601 header.b=DO7ZK4RE; spf=none (imf11.hostedemail.com: domain of josef@toxicpanda.com has no SPF policy when checking 209.85.222.173) smtp.mailfrom=josef@toxicpanda.com; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1719335521; a=rsa-sha256; cv=none; b=WMtjmknyq0qTNKRFmX6COYwRRZ1OSqAJLK0Qq16JAsIr2Jo2eMvun8zIWlSZCc8p3coO2e XQ0/NblqaYaBuynPrtAlh8BFZx6KlknqMwheSzI7ooZVse/8uPnUIAX4uWGbajCMzknV77 myWUv8uEk7mgizdqj//XYkDAX7j7gpU= Received: by mail-qk1-f173.google.com with SMTP id af79cd13be357-79c06c08149so47443885a.3 for ; Tue, 25 Jun 2024 10:12:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=toxicpanda-com.20230601.gappssmtp.com; s=20230601; t=1719335527; x=1719940327; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=WZIbVVFwCm0LobQXtGnzuMPIvM8lMcPFoEmqjMJNQvY=; b=DO7ZK4REVK2EmmP9EaKHatRpLBeYVEvqMiS87LMlo5qtfMVVp70NCKQHj+9WudLJgS yblTs3UI6EWQ+bkxzfreQscz5pvwyA8LAs6d/vor3YdmZUXM9SdeXIyLU9OXIJpinlkh ZbkF1oHdkbsGYgvUiD49QNWHMum0CvsC8xczvQB+GLk0BgLx5sDV2eJzXgqsZ/+W97IN Ow/As8p5XunhiILbn+68UBnBei/P3njIvISZsOAZNJxkUzJfhLSf2Y6bDW6MJaTVTJVN BZdOSjeUis6vgIxRome0/Oe2NL+HXKrI+6UoJg3Mq6LHhwX5CavCceO7DxDzCMbReaI0 SbjA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1719335527; x=1719940327; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=WZIbVVFwCm0LobQXtGnzuMPIvM8lMcPFoEmqjMJNQvY=; b=aAlgf+FSDTbF3zmZ06ihy+Im5jnH4UL65aC4XyeUxRBdRwaqcY+U5ncVQHelQh1+6z H1M/hwFXw5K2yoci8iFEESn4AtT+aq+PCclPdzIREvX3qfihEDAd2+3pDq+GfVK9Ne1z y0/jEtcrGIyP72YUR7p1p5PTezEfVWs8D35oSkmN7cgSBF18IsXqPqhef1NTZJCVr5c3 YkTE57X3BnQQesgwpMWwt0QotTjjtvnxnlLUbrWqHKxLPj/aV6y4Pabkzk9gtjcpJGNC uXv+gEn0+oNi34pgEE5Sagqx5c5ER4ihtr5SBivsqoy/tXkFjmccfXdE2L+R1OSXQehF QWBQ== X-Gm-Message-State: AOJu0YynNvZZGjz2nDw/il8eZK17+xxRT7MnGNK2P7eFp/WGJ1E/yGzV 5Z6LkXzkAIe2WdHfPJFATKOtW/kaPWPrhT8R/0rnvS+0kyLETm6LyvXzurNnKVc= X-Google-Smtp-Source: AGHT+IHczZ57ec4g1O5Pwq+tC1jElf0G+38dBVecKWC5wRHU310zRZoHK2Re1mZ4VgPi9U7QpsGEUA== X-Received: by 2002:a05:6214:17c8:b0:6b5:6a1:f899 with SMTP id 6a1803df08f44-6b53bbbece7mr72186356d6.10.1719335526687; Tue, 25 Jun 2024 10:12:06 -0700 (PDT) Received: from localhost (syn-076-182-020-124.res.spectrum.com. [76.182.20.124]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-6b54e09628fsm22817646d6.20.2024.06.25.10.12.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 25 Jun 2024 10:12:06 -0700 (PDT) Date: Tue, 25 Jun 2024 13:12:05 -0400 From: Josef Bacik To: Jan Kara Cc: linux-mm@kvack.org, Andrew Morton , Matthew Wilcox , linux-fsdevel@vger.kernel.org Subject: Re: [PATCH 0/10] mm: Fix various readahead quirks Message-ID: <20240625171205.GA2948656@perftesting> References: <20240625100859.15507-1-jack@suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240625100859.15507-1-jack@suse.cz> X-Rspam-User: X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: D274E4001A X-Stat-Signature: ejf6xtonaceq3k6jbhnrts778hdpb11f X-HE-Tag: 1719335527-990257 X-HE-Meta: U2FsdGVkX19fBOZfzN0l+eTb9Ny2fxUb4arWZQyS/Z4P1AnprcyVxWMPW1h2C2kSoMlvk0qLSOkt8GE62Tot6M/A6vHynR3zO5XdiyEHpPvqmWvxWtQKQOBypo1JALJ1bi+ENf46lkXBEw8ysh98GjSowFBtre757eht1Rr2aNOtkThh5mLF8iE/wbXBYG0zUqPXAaWGRFSKWL/vRlzyj10PpEAqhoLIum8k+v7eBMWVSZ7JFIyZ1HnrVB8e6eSs3K4tcSZELoxn/M27ovgQzMF1qOfLHBHPalahfCq9nYPkErjPnvY1Tl44/4uzI5h8G1/pqq6IEe7YmuuyDeaUA5lvA2GDmmbP+nNfFtdDhSiim/XDRQsdZMIGz7tO2sysiTLQD+0l0P1ianIH45jwTfGJ/ApRrt+sK2fi3SJm9pBLa3/qTXyYn9OjEPKTYqfpPKXr5cwDT2VkVefbvA4JfgaI/V2eqJeGd05TdIA65YRfIz1Jk1WMKhsUOtMWEXn5FH7eoItXHeiQA85SMfMk5/cyisnkrvfuur24KyRi/C3dyuwt6nrYchqcmVxKnJ9mYBmgLm/MNk0cpT9QkG1x+sv5AbAB5msnT67TBihzBfSuTYcabAVclWLZvRc8LLKDFAbrwOsFP6M4FqeQxvf50bpE6ELbVm26t99jlzhEXjyKzo9KBiR5JWvphS2JY3KvvdPO3YS08nQFQV86kVo7NROuJH3gZ5YnLFJaIvPo720N4dYHN8grXG5+UBDz6CJRWmDGepVoZdrCWFw2UkMLliz1Kbpp2WLYtwZtoroZHYUtesGjKnCDVSh0WIY/QG8nYwDqwWCB2Va8A6jR7/0NfItX4iryIf4Bwd7ovynvsAQJ9xnOPFfqPCj8jzxxhxziNw0GuUwgmeO7te/lXsy99YlMFTkknr23VaCnTVS6RMgWdCGSwxzlSFB0/S0doG2g+ZBvYkCRPWLpdCgLeMS m7ks26WH ezFc4bmPFEcGJIgwzaZK+20a4/Rl2LOWOPTB7o3RtyfhW3UmWeOURhK0FAbdWOb0hfrdKGZyxOyRJ0Qd6yxFdt8Yx+lYx2znPWXB1xdBTzmfELRmIlHRdPqjiINN9kNgVNcilLOVFakFqmq/xwCYSB+4hMJ6doJuXxFwecbCMCbsnefHS2ctdnz9MxBuWPyTEVOjQzm9HMgOVVodRG3sRTNwC60jH7uClLHNpmZKrgkH+9s9GlVbAu9Cxl5l2tBDm2Tb7O2VLQ4SryGsT48ZH6E2nQZiawNmc26EUHWw6yvR+hWWnqOULKVrvhUzUTeeXJI0CEa7O1TKu7QSGPCztrGJc0JnS2UxGJwVtOHtWpzT8wUWDX5++pUmJkIyafATeE62q X-Bogosity: Ham, tests=bogofilter, spamicity=0.000013, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Jun 25, 2024 at 12:18:50PM +0200, Jan Kara wrote: > Hello! > > When we were internally testing performance of recent kernels, we have noticed > quite variable performance of readahead arising from various quirks in > readahead code. So I went on a cleaning spree there. This is a batch of patches > resulting out of that. A quick testing in my test VM with the following fio > job file: > > [global] > direct=0 > ioengine=sync > invalidate=1 > blocksize=4k > size=10g > readwrite=read > > [reader] > numjobs=1 > > shows that this patch series improves the throughput from variable one in > 310-340 MB/s range to rather stable one at 350 MB/s. As a side effect these > cleanups also address the issue noticed by Bruz Zhang [1]. > Reviewed-by: Josef Bacik Thanks, Josef