From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 497AAC30653 for ; Tue, 25 Jun 2024 21:52:58 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 8D8356B0089; Tue, 25 Jun 2024 17:52:57 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 885D66B008A; Tue, 25 Jun 2024 17:52:57 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 74D416B008C; Tue, 25 Jun 2024 17:52:57 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 56C306B0089 for ; Tue, 25 Jun 2024 17:52:57 -0400 (EDT) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 05E531206E6 for ; Tue, 25 Jun 2024 21:52:57 +0000 (UTC) X-FDA: 82270761594.02.A39A3E9 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf27.hostedemail.com (Postfix) with ESMTP id 320304000A for ; Tue, 25 Jun 2024 21:52:55 +0000 (UTC) Authentication-Results: imf27.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=OKHkg445; dmarc=none; spf=pass (imf27.hostedemail.com: domain of akpm@linux-foundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1719352363; a=rsa-sha256; cv=none; b=D6gF8Pwb/nTuTBA2Un0yldg1lzi3yRbk10QwVV24hFZQ7G5hioTefSMNCAYxrGEwLNGErb N8Ha3RBn4L66TLKtFzlhoc/vOkXDs22/GK++0xRaAiPs1z9LDekHYYIh9LAtieE4B+eNF4 mV/kNMqWc6+z3W727o6j1k1JoTVvi1A= ARC-Authentication-Results: i=1; imf27.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=OKHkg445; dmarc=none; spf=pass (imf27.hostedemail.com: domain of akpm@linux-foundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1719352363; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=iFSx0CaeG1WU/O+3vR3DOJSFytyaka6m0kiFkXRnCeM=; b=EKvFYhleSDTQRdQY6hCwY3pV7/VgkAF0NzlhOfOi9efkjDqpXLWaYycQKlbV4d0DyrIwoT P7s0YByL/MsHw/y70RH2XEXAfHA6GUuB6/QobHBtP0FQml92iBe2IfQcWzp6k1fQqAuq2F xX4nODkl6pDVZjh90RBxj8iV5r6W5EE= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id CED2F61769; Tue, 25 Jun 2024 21:52:53 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 4F90CC32781; Tue, 25 Jun 2024 21:52:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1719352373; bh=G6GOHUSnoxrYjNbOCPF7hY75PTqZowehFbGl4aaLeSc=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=OKHkg445PwrR26/Gvds2THaNYUdszmNn2mqwHCeJ3tzbW340Cko9xEGPVYuGqQ/Mf TB2iqdnVRgguJLDilrK83MFBxqkYkdILmTTnGoSKTeJwqaSOJKn0yfnS1Uq+CmuAqm JzAgDO8We3BJvnZEIjHGR3KhXMMVqujz5Sm10n0Q= Date: Tue, 25 Jun 2024 14:52:52 -0700 From: Andrew Morton To: kernel test robot Cc: Lance Yang , llvm@lists.linux.dev, oe-kbuild-all@lists.linux.dev, Linux Memory Management List Subject: Re: [linux-next:master 7701/8232] mm/huge_memory.c:2735:31: warning: variable 'page' is uninitialized when used here Message-Id: <20240625145252.d78d18a109cb6bf84eefb5f7@linux-foundation.org> In-Reply-To: <202406260514.SLhNM9kQ-lkp@intel.com> References: <202406260514.SLhNM9kQ-lkp@intel.com> X-Mailer: Sylpheed 3.8.0beta1 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 320304000A X-Rspam-User: X-Rspamd-Server: rspam05 X-Stat-Signature: krmmz5qxuds5hg9qx8dgzd6yrw8ojsra X-HE-Tag: 1719352375-518966 X-HE-Meta: U2FsdGVkX19AhJO81ZKx3KrAvLp6FxYBLB0SMI4hXTTx/JE7FXxNhatUdnDIkz8VzC0ALf3KMOnqPPcGECdZIoZvL41BDPFkZON4PjTD4JJEVbyRNbhcvVfhAf12rX5d5fftzna/3zfzlgXpV9ODfo7rVH16r5NBgRgRmCW2yYn1IIiIn0Wc1IybL5WMKlcd0pawUdVeYVq0t+f1cyixphcY4Ta+tN0m6MpiBd/cdT5dxcgEzhorG4dCVAXq/cC6ziI+LBxyMccBCWeNDyjl4ddBPqlsP00QIv/ZKjhMElfMm6ru2VRyvx89BB4Qhr9VEp9TbLUlD1MGqBe4QZFlgYWQowb2uSraTLBO/+SrBv80YWgRwXyNc+F8yziiHKeM3TSME0OVgjXEwvbDMstIPzoABQRBoDpoMMOunJEQ7iIFJ3y6+Wa9sIAQUiWGt7F1aXTpnqTZF+aFfJ4EtPfrsZtoWUbmhFacJivTuRicrktnCBeSpG6m+Kjvj66GP5KvntLPTdh66+GcWrgTZnGwBw/iPsTwA9rjFVsRnMShn/ujNcN4xDTAOuHuTgkibvS1XZR61JTgw3a9TMOt1DLQdp0bI2BgNFHR+UinV00Vn4eLIPm18gCzgYtXrK82DDjA3z3k3ypdE+2UrV1KJ8incpm+1H5DuYrKu1cbww0cJNgAj1GDufd5XYEwJIo+N+BgPZhlwAkJgnKgZCfFVSjQ/aHUe/15JfplEnoUYPEE++daHHzT0U6+ibazl8Bem906ZJNWMbx614+KOeewNmRsOmY+jvVOWW/NwvR1VTkD6IERKrQDrGu2vamoolfz0X0JhOKca6iuVerAIRxWdbrZs0abxAS4V0x7IVZLqJMMw/s+Q0pNYCk5bp/U8QW3Zz9NTqBLVIjvWM3CEr42MF/+cV+Nlr7vtooNduT77lZDiGMj/zFXXQHAm4siR9JLBC7s2w6bZ2K0rX6FCl38JmW ofa07Uo5 gbP7rSomNd1BzI+zK8JCCs/D5FNEwjMs7yQcOf1dj/7Wj3esQ7TejIfROyxHrXWWhY2MEK/Uyj8DyHAp8vOngqzLSjp319FW+f8dwrNqWEm0G0+AyYk4TJM9spcWBh0tk529EbSFez9TWu7CDw9ag/z71olc5+WfkouqhOSLzQQqbJ0gUQ5CuPSaMVALGT9mRy/OBp5RGpAc0mq89vK2GFW5h+2w97gZg9olo4BRgIWMSYw0/glzSinfc7BZOfQZ7PCzgx/0/G/I88imxSZ5JgHIi6DAQchMq1gcTGjiZh8l0TZfjUsvXeGph3Hz2stxlkJ5017Dh6qHFsQFI63mGHkWt1Yvjf9AmohuI0MTghkfL8OsxZbxSDevnUL6kfD/EHb8T1MYlep0xTR+iMO1ivoK12OHUxh276g42xixPPyyne7YhQdQb/ilpGyOaXnGkhXYawhIPYzkBU4Q= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, 26 Jun 2024 05:39:54 +0800 kernel test robot wrote: > tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master > head: 0fc4bfab2cd45f9acb86c4f04b5191e114e901ed > commit: 4627108658d68fad359600dbe667b88b501cee71 [7701/8232] mm/vmscan: avoid split lazyfree THP during shrink_folio_list() > config: x86_64-rhel-8.3-rust (https://download.01.org/0day-ci/archive/20240626/202406260514.SLhNM9kQ-lkp@intel.com/config) > compiler: clang version 18.1.5 (https://github.com/llvm/llvm-project 617a15a9eac96088ae5e9134248d8236e34b91b1) > reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240626/202406260514.SLhNM9kQ-lkp@intel.com/reproduce) > > If you fix the issue in a separate patch/commit (i.e. not just a new version of > the same patch/commit), kindly add following tags > | Reported-by: kernel test robot > | Closes: https://lore.kernel.org/oe-kbuild-all/202406260514.SLhNM9kQ-lkp@intel.com/ > > All warnings (new ones prefixed by >>): > > >> mm/huge_memory.c:2735:31: warning: variable 'page' is uninitialized when used here [-Wuninitialized] > 2735 | folio_remove_rmap_pmd(folio, page, vma); > | ^~~~ > mm/huge_memory.c:2699:19: note: initialize the variable 'page' to silence this warning > 2699 | struct page *page; > | ^ > | = NULL > 1 warning generated. > > um yes. https://lore.kernel.org/all/20240622100057.3352-1-ioworker0@gmail.com/T/#u removed the initialization. I'll do this, because I'm about to push a tree out: --- a/mm/huge_memory.c~hack +++ a/mm/huge_memory.c @@ -2697,7 +2697,6 @@ static bool __discard_anon_folio_pmd_loc struct mm_struct *mm = vma->vm_mm; int ref_count, map_count; pmd_t orig_pmd = *pmdp; - struct page *page; if (folio_test_dirty(folio) || pmd_dirty(orig_pmd)) return false; @@ -2733,7 +2732,7 @@ static bool __discard_anon_folio_pmd_loc return false; } - folio_remove_rmap_pmd(folio, page, vma); + folio_remove_rmap_pmd(folio, pmd_page(orig_pmd), vma); zap_deposited_table(mm, pmdp); add_mm_counter(mm, MM_ANONPAGES, -HPAGE_PMD_NR); if (vma->vm_flags & VM_LOCKED) _