From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9F108C3064D for ; Tue, 25 Jun 2024 18:15:31 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 1F8006B0096; Tue, 25 Jun 2024 14:15:31 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 1A7A56B00AC; Tue, 25 Jun 2024 14:15:31 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 097046B00AE; Tue, 25 Jun 2024 14:15:31 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id E25C06B0096 for ; Tue, 25 Jun 2024 14:15:30 -0400 (EDT) Received: from smtpin12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 90BA8A03EA for ; Tue, 25 Jun 2024 18:15:30 +0000 (UTC) X-FDA: 82270213620.12.DD9E2B9 Received: from sin.source.kernel.org (sin.source.kernel.org [145.40.73.55]) by imf17.hostedemail.com (Postfix) with ESMTP id 12D6A4000F for ; Tue, 25 Jun 2024 18:15:27 +0000 (UTC) Authentication-Results: imf17.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=Z0yofwco; spf=pass (imf17.hostedemail.com: domain of akpm@linux-foundation.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1719339321; a=rsa-sha256; cv=none; b=n02bwYSUthPUExm/U/gkGkw8EzfLGwF0BIFfIDDfhzNAjwqgCj3u7pnkfwA1VxrW3e0CnS GDOqzPJtbw59k1YZGojTOpt8wH5kN/WWGqZLE+qia+QZlqbA8urreUCzgEbTbNyb92n6y1 OL087qRDTbSL/PJBJo8GvB+1UMHDMlc= ARC-Authentication-Results: i=1; imf17.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=Z0yofwco; spf=pass (imf17.hostedemail.com: domain of akpm@linux-foundation.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1719339321; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=khvCAdi14yA+k3T90kGzearG/SBilGiQFv8cdnrcHo8=; b=Dgl5vVz3YSZvZC3PikOksFRC8x1hgKYJyyW0PAWc2d6bHcsuvSnCn8NMpzv4hAchLvG+iK Xou6wwkzlewNSLDubfAtmObUVpcn3CNqQBgpHFgmkCmqa+fuFnrDsDfVaH6NuMTbfrS1VW vCrtoxVHpf1jdsG36QZvW4J8Xj4AMWY= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id 39664CE0B62; Tue, 25 Jun 2024 18:15:24 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 538E0C32781; Tue, 25 Jun 2024 18:15:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1719339323; bh=B5hLeC+/MpTqohgqkr15NOeoCPuGPuUmOeXG1p+zKnE=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=Z0yofwcoetIvCA88QUtaAgaOW5GMSNgkm+h2T3DXacHAa2VfUqpiHEzic8KRB0QnS VUz0ZvK0ZtVPHlcAS7NRoFrDD9Qsb7kMT68IajoGlCI+ZWKI8rTgps5TQ6UGNj8mcr jexXZFjX20g8sQxJg1FEfdO361T7XfIytA+hQZEM= Date: Tue, 25 Jun 2024 11:15:22 -0700 From: Andrew Morton To: "yongfa.hu" Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] mm: remove partial comments of kswapd_shrink_node head Message-Id: <20240625111522.045d2302959ce8dde7f47826@linux-foundation.org> In-Reply-To: <20240625121547.23613-1-hushange@163.com> References: <20240625121547.23613-1-hushange@163.com> X-Mailer: Sylpheed 3.8.0beta1 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Stat-Signature: 7wzs38jogpptngjahgh8hbug5tfbf17o X-Rspamd-Queue-Id: 12D6A4000F X-Rspam-User: X-Rspamd-Server: rspam10 X-HE-Tag: 1719339327-240143 X-HE-Meta: U2FsdGVkX183iLVdeWtWCWOUMTHRb9O4q+P0klgwHyPwwpvkK2/cKEQlZcBX84hVljuzQ/EBdfAraZcqDDQGJHQzBqXfVJqrndbh0TY78KfjNei1R/KtOWlKQKqNpfX2qYZlNMja+HN5Rv47mTbl6NrZVju0Z+IfOLWioOeeYjtgIBPDbZPkKFN7BgNtxlga8FrqNxR6lmdCAdtjtpT6+3X84FsaTX/IYXX14coK9/h4P14wMqBFogl4XrPZYiIkPDueMIKktB6bOz+vMDg5/XVxfkAE52FYwrrPTO7/y/xSYqejWK0X8jq8ECBe/r+Xf0tcvfvtAmi95ng6f+xxx0ILynrLcYfIMk2mcNixDREThuZhy73QejqI59C+Q9K0Gj/Ut+nQVLiT5egFcj+REf/8Q2YObyMssToUDb2Rxgp+V/xkyMcYQO1V6Tzik9oM4XCn6K2jw3C/pGtcJA8610snexBCt+Grz4l86AkH/832iJItRiZml07ns3ZWbpUPnwIvrpddlogbz9xIpat4OGcUSCxNxOKo2tvDwaEnu2ZR0GRRymAVLxjyAggnuQgeb1cfD/zBFyKQ8GW3OLoLdd/Ll5Or0cRQL3Ss0blm66Q/bRfFDOAktLOq2gQq0hcd+Ex9KgBoVAdzWGiGYyknqX/5M5B8MIGk7ZltqAbmhsHdTY5+P/F6cAoQZgmjCJJOaPzT7QNJiEZ8NmOgIJzTS4auyyab3fabY/8Zl06SBi3kk6iqcwJ6Zs8j1WybfWsp1Gq40emDPstzAsu8i38OfVlfLWzXfUxJ37dFcKyGhNhcZOjI8/28mWkAjy5hKKwHwMg5LLwIw01wvTfaB3V2+QaSlPd5rwSDLhmrdBCddt45KDiN8U5Bt3gHPnxYxrT7M6pvfAxN2esERyC2/cdi/1ucZpAfrvhYvV+Ng/XMrDCa/YdREYksD+MJT/ZZvLiJbX2E3zfDETC7I60zUxM QnVmGrtj dDqPSsLZ1QdqPupqkY9OMzJHyov0bKI91WWyFBLfuQrvBJo1zdCpmCwrDZSSRJ7/FaJN+9Z+K+xppDuAzNd+g1b8O2qNtQOb/dp+mToFSYZvrVeM/1SMIXicQajNxRgI3mWkXKnD2WAY9+h976nv3Sdf9w0IjZyEF316ogqP4GDee6R5QCzMY3+Ih3/BJm/9BajD0A2t5xVb2AJUtmxe0CHaaQ08WwBYOtsMu/BKFm50GZCUcuEXIcysAI59pLAD2niJ1JBalt+qk7Aae1PK9i448pdBHP9OZEwqHgJul+hvKJGMy1DOMi3YqlS+kGw9tfygbjzYWyCcChjmtjjIDosRUoDWnFzVUIxfMDXZoeb/XOb9J+lsfH58TN3FW18jRvxq2WUB9EysWiImNUlvBkcuNtA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, 25 Jun 2024 20:15:47 +0800 "yongfa.hu" wrote: > when function kswapd_shrink_node return, it will not check the condition > mentioned in the removed comments: "if the lack of progress was > due to pages under writeback", so remove it. Is this correct? shrink_folio_list() can skip under-writeback pages? > --- a/mm/vmscan.c > +++ b/mm/vmscan.c > @@ -6747,8 +6747,7 @@ static bool prepare_kswapd_sleep(pg_data_t *pgdat, int order, > * zone that is currently unbalanced. > * > * Returns true if kswapd scanned at least the requested number of pages to > - * reclaim or if the lack of progress was due to pages under writeback. > - * This is used to determine if the scanning priority needs to be raised. > + * reclaim. This is used to determine if the scanning priority needs to be raised. > */ > static bool kswapd_shrink_node(pg_data_t *pgdat, > struct scan_control *sc) > -- > 2.17.1