* [PATCH] mm: remove partial comments of kswapd_shrink_node head
@ 2024-06-25 12:15 yongfa.hu
2024-06-25 18:15 ` Andrew Morton
0 siblings, 1 reply; 2+ messages in thread
From: yongfa.hu @ 2024-06-25 12:15 UTC (permalink / raw)
To: akpm; +Cc: linux-mm, linux-kernel, hushange
when function kswapd_shrink_node return, it will not check the condition
mentioned in the removed comments: "if the lack of progress was
due to pages under writeback", so remove it.
Signed-off-by: yongfa.hu <hushange@163.com>
---
mm/vmscan.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/mm/vmscan.c b/mm/vmscan.c
index 900bad16e..a2369a3b1 100644
--- a/mm/vmscan.c
+++ b/mm/vmscan.c
@@ -6747,8 +6747,7 @@ static bool prepare_kswapd_sleep(pg_data_t *pgdat, int order,
* zone that is currently unbalanced.
*
* Returns true if kswapd scanned at least the requested number of pages to
- * reclaim or if the lack of progress was due to pages under writeback.
- * This is used to determine if the scanning priority needs to be raised.
+ * reclaim. This is used to determine if the scanning priority needs to be raised.
*/
static bool kswapd_shrink_node(pg_data_t *pgdat,
struct scan_control *sc)
--
2.17.1
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] mm: remove partial comments of kswapd_shrink_node head
2024-06-25 12:15 [PATCH] mm: remove partial comments of kswapd_shrink_node head yongfa.hu
@ 2024-06-25 18:15 ` Andrew Morton
0 siblings, 0 replies; 2+ messages in thread
From: Andrew Morton @ 2024-06-25 18:15 UTC (permalink / raw)
To: yongfa.hu; +Cc: linux-mm, linux-kernel
On Tue, 25 Jun 2024 20:15:47 +0800 "yongfa.hu" <hushange@163.com> wrote:
> when function kswapd_shrink_node return, it will not check the condition
> mentioned in the removed comments: "if the lack of progress was
> due to pages under writeback", so remove it.
Is this correct? shrink_folio_list() can skip under-writeback pages?
> --- a/mm/vmscan.c
> +++ b/mm/vmscan.c
> @@ -6747,8 +6747,7 @@ static bool prepare_kswapd_sleep(pg_data_t *pgdat, int order,
> * zone that is currently unbalanced.
> *
> * Returns true if kswapd scanned at least the requested number of pages to
> - * reclaim or if the lack of progress was due to pages under writeback.
> - * This is used to determine if the scanning priority needs to be raised.
> + * reclaim. This is used to determine if the scanning priority needs to be raised.
> */
> static bool kswapd_shrink_node(pg_data_t *pgdat,
> struct scan_control *sc)
> --
> 2.17.1
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2024-06-25 18:15 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-06-25 12:15 [PATCH] mm: remove partial comments of kswapd_shrink_node head yongfa.hu
2024-06-25 18:15 ` Andrew Morton
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox