From: Andrew Morton <akpm@linux-foundation.org>
To: "yongfa.hu" <hushange@163.com>
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mm: remove partial comments of kswapd_shrink_node head
Date: Tue, 25 Jun 2024 11:15:22 -0700 [thread overview]
Message-ID: <20240625111522.045d2302959ce8dde7f47826@linux-foundation.org> (raw)
In-Reply-To: <20240625121547.23613-1-hushange@163.com>
On Tue, 25 Jun 2024 20:15:47 +0800 "yongfa.hu" <hushange@163.com> wrote:
> when function kswapd_shrink_node return, it will not check the condition
> mentioned in the removed comments: "if the lack of progress was
> due to pages under writeback", so remove it.
Is this correct? shrink_folio_list() can skip under-writeback pages?
> --- a/mm/vmscan.c
> +++ b/mm/vmscan.c
> @@ -6747,8 +6747,7 @@ static bool prepare_kswapd_sleep(pg_data_t *pgdat, int order,
> * zone that is currently unbalanced.
> *
> * Returns true if kswapd scanned at least the requested number of pages to
> - * reclaim or if the lack of progress was due to pages under writeback.
> - * This is used to determine if the scanning priority needs to be raised.
> + * reclaim. This is used to determine if the scanning priority needs to be raised.
> */
> static bool kswapd_shrink_node(pg_data_t *pgdat,
> struct scan_control *sc)
> --
> 2.17.1
prev parent reply other threads:[~2024-06-25 18:15 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-25 12:15 yongfa.hu
2024-06-25 18:15 ` Andrew Morton [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240625111522.045d2302959ce8dde7f47826@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=hushange@163.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox