From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7876AC2BBCA for ; Tue, 25 Jun 2024 14:41:46 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 7E3746B0088; Tue, 25 Jun 2024 10:41:45 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 76C366B008A; Tue, 25 Jun 2024 10:41:45 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5E6C46B008C; Tue, 25 Jun 2024 10:41:45 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 3F24D6B0088 for ; Tue, 25 Jun 2024 10:41:45 -0400 (EDT) Received: from smtpin10.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id D8BB3A0196 for ; Tue, 25 Jun 2024 14:41:44 +0000 (UTC) X-FDA: 82269674928.10.CFE521B Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf08.hostedemail.com (Postfix) with ESMTP id 2C508160026 for ; Tue, 25 Jun 2024 14:41:42 +0000 (UTC) Authentication-Results: imf08.hostedemail.com; dkim=none; spf=pass (imf08.hostedemail.com: domain of "SRS0=txrS=N3=goodmis.org=rostedt@kernel.org" designates 139.178.84.217 as permitted sender) smtp.mailfrom="SRS0=txrS=N3=goodmis.org=rostedt@kernel.org"; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1719326487; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=V3WWCDGoBYRfEtWf0O8AOr41K+WMG7gwkmet8R7FF5A=; b=O/LmL+ef4cRdB0yUtmdLsJI3O7KTi7ukBtAxkAX/y9Pyn8gS6OvYb2QtqUyTzHWFnWeQQ/ sYARsCrDJ+BYVs0FxSpxtmV4JTYt6jIouHyQWiZRuosj1KU23hnwPBWAoAC2dnRu0ttmgP A8JaY5CuP89Yb0liErUZbSUcZO63T88= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1719326487; a=rsa-sha256; cv=none; b=bPWmF5YIA3AAUHwAbAuxDvlalbnULI5imddS2Egw143ZlJgmOdwE1ZyYvxmmmiX5d+rCmP AQvK/BczNBlFT18hl15Si8biBDBx0ObSjpJ/dQW+3l3xDHpnj+l1uvAFmUIOK1Opq6JOv9 pO7WbJlwIjqzn4fE9GngU+/VqCQAaZM= ARC-Authentication-Results: i=1; imf08.hostedemail.com; dkim=none; spf=pass (imf08.hostedemail.com: domain of "SRS0=txrS=N3=goodmis.org=rostedt@kernel.org" designates 139.178.84.217 as permitted sender) smtp.mailfrom="SRS0=txrS=N3=goodmis.org=rostedt@kernel.org"; dmarc=none Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 421A861493; Tue, 25 Jun 2024 14:41:41 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8EDA7C4AF07; Tue, 25 Jun 2024 14:41:38 +0000 (UTC) Date: Tue, 25 Jun 2024 10:41:37 -0400 From: Steven Rostedt To: Vlastimil Babka Cc: Akinobu Mita , Christoph Lameter , David Rientjes , Alexei Starovoitov , Daniel Borkmann , Andrii Nakryiko , "Naveen N. Rao" , Anil S Keshavamurthy , "David S. Miller" , Masami Hiramatsu , Mark Rutland , Jiri Olsa , Roman Gushchin , Hyeonggon Yoo <42.hyeyoo@gmail.com>, linux-kernel@vger.kernel.org, linux-mm@kvack.org, bpf@vger.kernel.org, linux-trace-kernel@vger.kernel.org Subject: Re: [PATCH v2 2/7] error-injection: support static keys around injectable functions Message-ID: <20240625104137.7fbe294d@rorschach.local.home> In-Reply-To: <20240620-fault-injection-statickeys-v2-2-e23947d3d84b@suse.cz> References: <20240620-fault-injection-statickeys-v2-0-e23947d3d84b@suse.cz> <20240620-fault-injection-statickeys-v2-2-e23947d3d84b@suse.cz> X-Mailer: Claws Mail 3.17.8 (GTK+ 2.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Stat-Signature: 965o1pb61ghhnxhd8ep935hq9tfm1i3j X-Rspamd-Queue-Id: 2C508160026 X-Rspam-User: X-Rspamd-Server: rspam08 X-HE-Tag: 1719326502-103537 X-HE-Meta: U2FsdGVkX1/0iBN5JJIEuUz9vgGPFgiX5KwR4b/aLbBbWDhrwJYq4gYL1Z0vd8YQWrxzG9VLIjn5p8XwTq/wgnWKMfDGCfgeant+zEnMiBXmtmJgpkHonxEQ7XCyRozHSc+8MUI2qgNJUrRulk4rBfGQ1jsAN52/7/45zcFkmyxeUxcVLETaRt7DWlU/0npCz0d55iPs6MK4hUY4Yy8Mo7rmXrH71rH+YVc2+iBKciEMfexOq7dm+z5BwpLDkp0L/n5dPhqkHtnamXjhrAq/0s4bnr7Sx5FF6AyQiw6DFksSfEOggD8Ypqu/CgNu1DVuhAnVbq8PaesEgeIGmL20wqSpz6M8n2Q+Do1DRwB3TnGw1VDZa5cDHID3qiAk+y2kAwNCqeagA9oKSQqGC0GZAna75GlbyZSJ9U62FklPr0thK56erB9xAcHsd3EQLQ0a1uofIu0n/dPuX+rQJIDxoed6aO9ZeURrBrKF74sMRG1qy0JCRXOUPQbHfE73neDWPqR3wYN3eOvlBZMCHJUfRKJUi1Ox+C4Eo6LFQa6VVCIfFqMKUI+2WMGc4/SjyalZEQ8YKmKWucTETE9VuHVDxv6vB2JgEYXlz4Ox9yizrIyyklSDKgVWd5UbnpjplTeDsYnOionLdCdhOEhFSsRf9awiJ9zUi89zT4GcFhZEPvXBt2em4GKxtNBOxB6EXAPlGQUoo2wGEowzv6PTlvHWyuIiwRV3sVemZ0GAY2uxmqQCUj1qGsLj8v2pmsX6VwohYhN3sTmpf4ci7infoUGwdQj/+fIJTDzJQUhn0USoiidMVs6eXb/DfSLySCY6O0JXuRGMFloGE0NBbYBvgAm9/g4GCFt1QkS5uBReWu9Zc7fBZ61QykZ571c8ixHJxNDhMWITI8o/aQLsZ/zr/JOLTpGURzdyGpRr7XDcHNRlNLRKuHFqV5T8+3GtT4qJZJOAIDOVn+flbPrKF/f4q1X q8vL2sJi M9zR8CpWwZzisfrl5e134q3ZpR0/YyA9HGm836Sug8v0vOFzAJwyOzvIXZYCH6X4aRtKS/yImIKIDDyEGyCaR1NIZaiu2b5XPa/qdJzVl4hfCpai3e3IT2rJVMzhpXGoO2VDUSP3ZzL1uguiqLD2FN9QO9A0muzR3QKO0HX5sZgbN8gvWiMpUehrfHff6mG3oU9i5Oz0ii1BQRXHxT6IaFtMpUte6O4xBMv2IuUac/7thDFs2DT5IAw/QbZRw/YlW+xWcdUjPHv83BNUmBbKydS6byV/By6L2R5TJ6KZoIiGFN7DCiKMzjMe/8a+2dn/uZxyR5HbBpsrvzpl8QDIdnlF63X/3FOg2jYWgqj5raiZ0nQ/6lxpU3OZ4GZctCAUHBmei X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, 20 Jun 2024 00:48:56 +0200 Vlastimil Babka wrote: > @@ -86,6 +104,7 @@ static void populate_error_injection_list(struct error_injection_entry *start, > ent->start_addr = entry; > ent->end_addr = entry + size; > ent->etype = iter->etype; > + ent->key = (struct static_key *) iter->static_key_addr; Nit, should there be a space between the typecast and the "iter"? > ent->priv = priv; > INIT_LIST_HEAD(&ent->list); > list_add_tail(&ent->list, &error_injection_list); Reviewed-by: Steven Rostedt (Google) -- Steve