From: Steven Rostedt <rostedt@goodmis.org>
To: Vlastimil Babka <vbabka@suse.cz>
Cc: Akinobu Mita <akinobu.mita@gmail.com>,
Christoph Lameter <cl@linux.com>,
David Rientjes <rientjes@google.com>,
Alexei Starovoitov <ast@kernel.org>,
Daniel Borkmann <daniel@iogearbox.net>,
Andrii Nakryiko <andrii@kernel.org>,
"Naveen N. Rao" <naveen.n.rao@linux.ibm.com>,
Anil S Keshavamurthy <anil.s.keshavamurthy@intel.com>,
"David S. Miller" <davem@davemloft.net>,
Masami Hiramatsu <mhiramat@kernel.org>,
Mark Rutland <mark.rutland@arm.com>, Jiri Olsa <jolsa@kernel.org>,
Roman Gushchin <roman.gushchin@linux.dev>,
Hyeonggon Yoo <42.hyeyoo@gmail.com>,
linux-kernel@vger.kernel.org, linux-mm@kvack.org,
bpf@vger.kernel.org, linux-trace-kernel@vger.kernel.org
Subject: Re: [PATCH v2 2/7] error-injection: support static keys around injectable functions
Date: Tue, 25 Jun 2024 10:41:37 -0400 [thread overview]
Message-ID: <20240625104137.7fbe294d@rorschach.local.home> (raw)
In-Reply-To: <20240620-fault-injection-statickeys-v2-2-e23947d3d84b@suse.cz>
On Thu, 20 Jun 2024 00:48:56 +0200
Vlastimil Babka <vbabka@suse.cz> wrote:
> @@ -86,6 +104,7 @@ static void populate_error_injection_list(struct error_injection_entry *start,
> ent->start_addr = entry;
> ent->end_addr = entry + size;
> ent->etype = iter->etype;
> + ent->key = (struct static_key *) iter->static_key_addr;
Nit, should there be a space between the typecast and the "iter"?
> ent->priv = priv;
> INIT_LIST_HEAD(&ent->list);
> list_add_tail(&ent->list, &error_injection_list);
Reviewed-by: Steven Rostedt (Google) <rostedt@goodmis.org>
-- Steve
next prev parent reply other threads:[~2024-06-25 14:41 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-19 22:48 [PATCH v2 0/7] static key support for error injection functions Vlastimil Babka
2024-06-19 22:48 ` [PATCH v2 1/7] fault-inject: add support for static keys around fault injection sites Vlastimil Babka
2024-06-25 14:08 ` Steven Rostedt
2024-06-19 22:48 ` [PATCH v2 2/7] error-injection: support static keys around injectable functions Vlastimil Babka
2024-06-25 14:41 ` Steven Rostedt [this message]
2024-06-19 22:48 ` [PATCH v2 3/7] bpf: support error injection static keys for perf_event attached progs Vlastimil Babka
2024-06-19 22:48 ` [PATCH v2 4/7] bpf: support error injection static keys for multi_link " Vlastimil Babka
2024-06-19 22:48 ` [PATCH v2 5/7] bpf: do not create bpf_non_sleepable_error_inject list when unnecessary Vlastimil Babka
2024-06-20 1:18 ` Alexei Starovoitov
2024-06-20 8:15 ` Vlastimil Babka
2024-06-19 22:49 ` [PATCH v2 6/7] mm, slab: add static key for should_failslab() Vlastimil Babka
2024-06-25 14:24 ` Vlastimil Babka
2024-06-25 17:12 ` Alexei Starovoitov
2024-06-25 17:53 ` Vlastimil Babka
2024-06-19 22:49 ` [PATCH v2 7/7] mm, page_alloc: add static key for should_fail_alloc_page() Vlastimil Babka
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240625104137.7fbe294d@rorschach.local.home \
--to=rostedt@goodmis.org \
--cc=42.hyeyoo@gmail.com \
--cc=akinobu.mita@gmail.com \
--cc=andrii@kernel.org \
--cc=anil.s.keshavamurthy@intel.com \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=cl@linux.com \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=jolsa@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-trace-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mhiramat@kernel.org \
--cc=naveen.n.rao@linux.ibm.com \
--cc=rientjes@google.com \
--cc=roman.gushchin@linux.dev \
--cc=vbabka@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox