From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 73BF6C30653 for ; Tue, 25 Jun 2024 08:00:02 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D5FC86B031C; Tue, 25 Jun 2024 04:00:01 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D0FA76B031D; Tue, 25 Jun 2024 04:00:01 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id BD7146B0322; Tue, 25 Jun 2024 04:00:01 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 956926B031C for ; Tue, 25 Jun 2024 04:00:01 -0400 (EDT) Received: from smtpin11.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 48AE61A0941 for ; Tue, 25 Jun 2024 08:00:01 +0000 (UTC) X-FDA: 82268662602.11.974F7AC Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf18.hostedemail.com (Postfix) with ESMTP id 73F301C000B for ; Tue, 25 Jun 2024 07:59:59 +0000 (UTC) Authentication-Results: imf18.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=WVb1Vx58; spf=pass (imf18.hostedemail.com: domain of brauner@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=brauner@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1719302385; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=leFXFZlmzM29KAPkfiJc7BIlB0bvHIRPsnH9AkNShzs=; b=pBp/Fqv4NLhoJ9OEJT7PlB/U0MJQlJHGRJjJzta3WQynCJad4+wdVO1hvkwbYYDFQp9eWB 7kt8DKKCOv0OagHJzPSH0XevthT1bkWYk0p8ulGCvo1ef7KDVXOre2/l0kqRHlZmCod7zW ZWPYETVHZL2g7JpC3ls4oMq1/2NzpKY= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1719302385; a=rsa-sha256; cv=none; b=aFEbH9EurqKFw+yDsGULr26WpVPxAKSOwzkAX4qveAjS7n+5eVVfpyHDZP3qqPMdoGrouY JMWOgVAKQ8Ju2CCk4W6r1MyIr3d/88gg+22rzed71pMfL1RLU2RBHlRLH1MAVlYgQPKYav ChUvAqqPY3zdnnfxhlFq+KxxL7F45IU= ARC-Authentication-Results: i=1; imf18.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=WVb1Vx58; spf=pass (imf18.hostedemail.com: domain of brauner@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=brauner@kernel.org; dmarc=pass (policy=none) header.from=kernel.org Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 61BE26108A; Tue, 25 Jun 2024 07:59:58 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id A5D23C32781; Tue, 25 Jun 2024 07:59:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1719302398; bh=gGTnt7kgAHESvN4glUsKEh7J/3FnyXZoYJL56AfR++E=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=WVb1Vx58zF4krIFHUGyBD+f8i41UaW7TUHJKtf4NeF3c242pn4AIyeWtx2j4EEvwl pPiBzTzUeYDEXxSg+N67eW1p0rKYTPatEHH+5i18cWzvWLyi6c3IdgIWO0zD1q/29W cFcn7cFQdTzmQHXNN/VcekgWUn3whA2LEjGMkLtNeMh+jLnQS/fjVs89gE213vbh6l sSQ5+F99BXfYu2/9e7gCLy/JZoFBqCO3cTgQOiBuRnANFWQ2eMik+s4FsCqnhMLhvc aq7a9NX6l0N7w//U12COhQCg/0+Vkh1Dq6oDDW0IoOpGQecKzKy98H4yuuIZAQAPR0 M1fYBD9HPR/hA== From: Christian Brauner To: Mateusz Guzik Cc: Christian Brauner , viro@zeniv.linux.org.uk, jack@suse.cz, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, akpm@linux-foundation.org Subject: Re: [PATCH v2] vfs: remove redundant smp_mb for thp handling in do_dentry_open Date: Tue, 25 Jun 2024 09:59:50 +0200 Message-ID: <20240625-freut-geometrie-f11b610f94f0@brauner> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240624085402.493630-1-mjguzik@gmail.com> References: <20240624085402.493630-1-mjguzik@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" X-Developer-Signature: v=1; a=openpgp-sha256; l=1026; i=brauner@kernel.org; h=from:subject:message-id; bh=gGTnt7kgAHESvN4glUsKEh7J/3FnyXZoYJL56AfR++E=; b=owGbwMvMwCU28Zj0gdSKO4sYT6slMaRVVXzzT/8pZqK+6aWrtVr/6fti3VZvQ3xWuU9+cf3m2 hV/03ed7ShlYRDjYpAVU2RxaDcJl1vOU7HZKFMDZg4rE8gQBi5OAZhI8QqG/yk+hwp+auxwv590 9B/nwb7P21w5NX/4H+z6uM4h+cT3TZKMDPdP7T+6WddxYujic4Z7P9UE3m0/EqL3X23blKyL911 +X2QHAA== X-Developer-Key: i=brauner@kernel.org; a=openpgp; fpr=4880B8C9BD0E5106FC070F4F7B3C391EFEA93624 Content-Transfer-Encoding: 8bit X-Rspamd-Queue-Id: 73F301C000B X-Stat-Signature: dpb5qihypd64jwdro6nf91zipu1urnoh X-Rspamd-Server: rspam09 X-Rspam-User: X-HE-Tag: 1719302399-155331 X-HE-Meta: U2FsdGVkX19hTxVyX9zj4hnvbQeo1WqoLQEeNf+EOG+l126ADw4JwlpWz1q62tBDT+z5XFCO4AftGUkQFrnH9IyzT6zvRPCof5kEtsoFFCzSyoWjFJGnvLy3tDfz21QityyaA7Wwysq9gfIohPd/ueEdH/aAZPg/s4Zl2xLo7/hJU7PXYIR+jUJTOrF0ZwuA6MWG2oYO+UYlX5KSqzHA/ernNfoogz6W/e6FfpR+0ZBAR48ltfDQd2G6rFZ+RyJWZTFjQEOGYYeBLEMa4YyVOmJawn9+528FZ3MM5lyy5OFZA15JmyJqRi07xiUKIT2ylat2qMrdjJdO9ZPE2ATIMF0uzy9MTFaUbDh/9kTjtGb8TD6AAQ5dSEbfiCHiGXLa6Qwipb2sECsVexd6HoIh/W05lXw5waWd7+AKN8H6L8cQ5O2imsUvaxi0W0hzqCAvtiGMlTBXm0sHn5lXt0x5EmCA+dEd1aT4N4Q/skhc3vaD4LXSt/WUkPNCxfeQbmJBreKLzdFGakITjX4pJfpm4+Oo9N3AyZcL1U1UEw2NPXwc0PDb+QVnelyFLAzZfpPetlT3yjSh25IN9tT+qgHAm74HM3I+NCrPazmaW+1naCkreLfS1/7GmwP9B5r5NkBQUJrCO/+o1I9N47YQCkd4Cn7qjaRhRJ0375DzgzXjon9B8Lq9LIr4hyahU3LQgb7MEi4jWRtHLAzqR0wCMF9gESPXye6bMw5hpQrhy9aC+w/teQWdtnTZOiLvFn1q3+hUJrAiaWkt7E+f00KPodc8OGglhqxJrADcW4K2c9ifSlJEIoiYHJqarjrdDJs7cdE2mAQvhCwgaeocHcm6sskDZfqDWyxrOlkj5e/ktaCUQPBtLI2mYksSEOuTSx//sCEuslbBPeFhollaZ3sdcXRVxw4QGTHU5UhW/AA7a5bugVZFFGRd0PBK+/Mc4bsjijF7JQuR2UwhvFzjUTjFADX 1H1PbdOn VNuidvfGxwORA6CRYlLkXC9eBCk32NXQpSa6/AX/gTEdstm5CwDOtVebBmZJSfS62zNRmo6npUEq9U5fWkE3Khgtg0wKi9ZOROE0IXrbL3fSGyuu452NLSkhTVP0rtEGMcEnY2xHuoA55ou/LqDn5BoG+V4wqE8xoQnHtiV5b7kUa7VR66DuY2j71AaYOivsWhW9omOBuCiqzs99qoT5KP5hB1H5YYsSjaqp/P4MfEsyXwjo6+JKaoOOolsCKJ+EX+eCp0MxSVs6nn4zeW6aIz1eXFChd/flw0/hB1X9aoJ7qnh5VjJUXbKcAXyDoSIl1aED/IDbaWjY7xELQsGNmF+Y7ug== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, 24 Jun 2024 10:54:02 +0200, Mateusz Guzik wrote: > opening for write performs: > > if (f->f_mode & FMODE_WRITE) { > [snip] > smp_mb(); > if (filemap_nr_thps(inode->i_mapping)) { > [snip] > } > } > > [...] Applied to the vfs.misc branch of the vfs/vfs.git tree. Patches in the vfs.misc branch should appear in linux-next soon. Please report any outstanding bugs that were missed during review in a new review to the original patch series allowing us to drop it. It's encouraged to provide Acked-bys and Reviewed-bys even though the patch has now been applied. If possible patch trailers will be updated. Note that commit hashes shown below are subject to change due to rebase, trailer updates or similar. If in doubt, please check the listed branch. tree: https://git.kernel.org/pub/scm/linux/kernel/git/vfs/vfs.git branch: vfs.misc [1/1] vfs: remove redundant smp_mb for thp handling in do_dentry_open https://git.kernel.org/vfs/vfs/c/badb54d62002