From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 01A13C2BD09 for ; Mon, 24 Jun 2024 23:25:09 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 29FF56B02BC; Mon, 24 Jun 2024 19:25:09 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 227D76B0351; Mon, 24 Jun 2024 19:25:09 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0A1C66B0353; Mon, 24 Jun 2024 19:25:09 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id E02E46B02BC for ; Mon, 24 Jun 2024 19:25:08 -0400 (EDT) Received: from smtpin03.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 2D268A3E7D for ; Mon, 24 Jun 2024 23:25:08 +0000 (UTC) X-FDA: 82267365096.03.6BE43B4 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf24.hostedemail.com (Postfix) with ESMTP id 412D1180008 for ; Mon, 24 Jun 2024 23:25:06 +0000 (UTC) Authentication-Results: imf24.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=T8ERIJuz; spf=pass (imf24.hostedemail.com: domain of akpm@linux-foundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1719271492; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=AZuGxPLxtFi3UJ2vDR7TSm+xQG/TAie2WxNZYEaYIkM=; b=pYx7pDpvYITX801/NM3up43OHQivPsgCCt0Zrhhv9jE44nzB1dhEogl7C3bx4MAYnIuKHF k/eHHKRxUZeIZ1n2vzZ7/RJ0FQm/ba+mz2KkyHsNjC8UNU42uut0VE9m96yIb66tu0nF03 ln2yoWz9NqwBT3CnCFXimSBwpPpnWeY= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1719271492; a=rsa-sha256; cv=none; b=jAnXAallzX3QhbfBFmdwHBhyADYdRnZhY+Ssx3GWwIUUDWMvCjDjNvMBvpPLIVkQ8I81XQ V/25YbtAOLSa+WPJOaY1rI2xkEgDjond/wQqsmqMgqdglL38D2pVy7/UjQq3dEcWrcCmeI IO3wMN3VnzBZUrs09F7qtxrz7mUSUHI= ARC-Authentication-Results: i=1; imf24.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=T8ERIJuz; spf=pass (imf24.hostedemail.com: domain of akpm@linux-foundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 3495A60A7C; Mon, 24 Jun 2024 23:25:05 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 5EE4AC2BBFC; Mon, 24 Jun 2024 23:25:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1719271504; bh=WMMkwBu7WgtyE3mBCT8urby6K5l/l1sjpNKhe5d5cuQ=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=T8ERIJuzx9qJP2atoIKP0PA74mxbs0eEjMG8JZo75ZA+1E+ZdedEOLqdyyoR0DiGr STG+LrhnswZKNShrkelgPgVeYllhrNHENMB0Vr8KNYyoK6QlgSq95k9yxYp63bQyb8 Li0gV7qW0DHurH8J93K9tERZm0EduRUx+plt4Qk0= Date: Mon, 24 Jun 2024 16:25:03 -0700 From: Andrew Morton To: Barry Song <21cnbao@gmail.com> Cc: david@redhat.com, baolin.wang@linux.alibaba.com, chrisl@kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, mhocko@suse.com, ryan.roberts@arm.com, shy828301@gmail.com, surenb@google.com, v-songbaohua@oppo.com, willy@infradead.org, ying.huang@intel.com, yosryahmed@google.com, yuanshuai@oppo.com, yuzhao@google.com Subject: Re: [PATCH v2 2/3] mm: use folio_add_new_anon_rmap() if folio_test_anon(folio)==false Message-Id: <20240624162503.61996134e5e148eea93960af@linux-foundation.org> In-Reply-To: <20240622032002.53033-1-21cnbao@gmail.com> References: <02b87f01-69c9-4007-b0d0-5ce9ce35876d@redhat.com> <20240622032002.53033-1-21cnbao@gmail.com> X-Mailer: Sylpheed 3.8.0beta1 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Stat-Signature: 3q3msnheshp89h33byb1fpb8phj399ph X-Rspamd-Queue-Id: 412D1180008 X-Rspam-User: X-Rspamd-Server: rspam08 X-HE-Tag: 1719271506-244600 X-HE-Meta: U2FsdGVkX19sEIicXFIrjnnlH+CJm6nmc13btZgU+et7NUriy9R1F+iY2r6GTsVenZpDP0C0b5G/eC1VTERy8el/43XTSJ8VsPVvYGCBXhHzNSZUCW6URCippqYGuKyoP5BgWKaSwPnwFHNXO2oI60F2iVFjwnWMOhtG+11xIq/PJnjH3J50fMsoYvRTBqFfZ6jL5IPuiC0po4LdhKCqhDFn2pd7U+M7Wc7pFyMBGCxXvWm0OLwNB96lp4yPNm+M5kN/l7vJXeYTg4J9hyFtWHie3zpd4yd9yYt0g8ggSmoRNClHiOgcMCqxSxkQPLHU7KAelFLa1J4z5XWMedQ8zXwNUN2CRZNBxr7cqXnqv7hWqrBPVqlOpsufYR1puouCw8cdXX7HF2bBNSx2lfD1kk7Cg2mCpfIYeJGz9EU85PMuKVgVaJRwKfYVOL89W7NA+pEpLM7bu73x0IK1jxYvU6K5F1OMD0/olhsB7gZxEDF97iWsH05pY9ScpvreFSDdBOnWHo2HxdG29OJaQJZ9VSgwzOVjrBRd6GOXzvdp+lYuhjIbp0SQVMC1vP1s3uhsPxnYgZeK63rOzrZnZrUrRCH72l68OyDKM4SiqXZeZ9bxQet8NlPFxwYvLfUJHueVXznf8xQLy1OqzjKCYUksen6uiFKZlVJl7/C+EXuMaaogqYAuWdsfHWntNaaFhQTGo5e9Rspq7QVn7WIkiPMVgVN1uXdPlNIgfituG21Fji8L0TKM9JiI0naDliQ8X602dvlSfTAWiDZvAn0EBWGS1w3cqxLeiL5dcCrt53yyDR+d2ownYQ0tC6WDNZoR9I5KoDUaI/AgIr+yJjesIXvQiPxkxa2O2ZG04z4YSoEvxrpwvA8wugfK9UYzkX42kHBNoTEhgJjO00KJFSCDvU3Ul+0mSkyPa7ZMTtJDHVFpVXBa+7E+YfsXict+9mx/QKRi0sIaCeGFzLKhima1UaY BMOTjy9S VWZoXx7ncs334I+Jbtx/sMjZW7CeLWEF6abdnFHQXyBASS3+BRLT/vZ0OtKJzI4wKV3+DANeRF85RS5iUdG0tNm9FWY9DcEw3ea6Qm3hjKDTUj2hEywpNi6efPgH7MG2tf61+UrLc2b6jrFe1K448J4QTfQ29X4SqSAp8Zq5PVzuPr7ztyM7k5MuazpvssG88zy0dNHXzcaQRuoTGQ2bqM0Sj4ejp7JF4R/l3wCEmAe/ONu0ubfWIj//rw2AkTm5cOcYOWtPgkYsiUEQJssj2d2jCnU7FE5Hqwx/f35z+82tpeqr/vV5bnRWrSv9YoJRfraL70UlBB8EdcZgzrUBMOWzPqOdM4XX43vkb X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Sat, 22 Jun 2024 15:20:02 +1200 Barry Song <21cnbao@gmail.com> wrote: > > > > > > Since this is primarily a documentation update, I'll wait for two or > > > three days to see if > > > there are any more Linux-next reports before sending v3 combining these fixes > > > together(I've already fixed another doc warn reported by lkp) and seek Andrew's > > > assistance to drop v2 and apply v3. > > > > Feel free to send fixup patches for such small stuff (for example, as > > reply to this mail). Usually, no need for a new series. Andrew will > > squash all fixups before merging it to mm-stable. > > Hi Andrew, > > Can you please squash this change(another one suggested by David)? sure, but... > From: Barry Song > Date: Sat, 22 Jun 2024 15:14:53 +1200 > Subject: [PATCH] enhance doc- mm: use folio_add_new_anon_rmap() if > folio_test_anon(folio)==false The only description we have here is "enhance doc" > --- a/mm/memory.c > +++ b/mm/memory.c > @@ -4346,6 +4346,7 @@ vm_fault_t do_swap_page(struct vm_fault *vmf) > * here, we have to be careful. > */ > VM_WARN_ON_ONCE(folio_test_large(folio)); > + VM_WARN_ON_FOLIO(!folio_test_locked(folio), folio); And these aren't documentation changes. Please send along a small changelog for this patch.