* [PATCH] memblock tests: fix implicit declaration of function 'numa_valid_node'
@ 2024-06-24 1:54 Wei Yang
2024-06-29 1:39 ` Wei Yang
2024-07-05 8:28 ` Mike Rapoport
0 siblings, 2 replies; 3+ messages in thread
From: Wei Yang @ 2024-06-24 1:54 UTC (permalink / raw)
To: rppt; +Cc: linux-mm, Wei Yang
commit 8043832e2a12 ("memblock: use numa_valid_node() helper to check
for invalid node ID") introduce a new helper numa_valid_node(), which is
not defined in memblock tests.
Let's add it in the corresponding header file.
Signed-off-by: Wei Yang <richard.weiyang@gmail.com>
CC: Mike Rapoport (IBM) <rppt@kernel.org>
---
tools/include/linux/numa.h | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/tools/include/linux/numa.h b/tools/include/linux/numa.h
index 110b0e5d0fb0..c8b9369335e0 100644
--- a/tools/include/linux/numa.h
+++ b/tools/include/linux/numa.h
@@ -13,4 +13,9 @@
#define NUMA_NO_NODE (-1)
+static inline bool numa_valid_node(int nid)
+{
+ return nid >= 0 && nid < MAX_NUMNODES;
+}
+
#endif /* _LINUX_NUMA_H */
--
2.34.1
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] memblock tests: fix implicit declaration of function 'numa_valid_node'
2024-06-24 1:54 [PATCH] memblock tests: fix implicit declaration of function 'numa_valid_node' Wei Yang
@ 2024-06-29 1:39 ` Wei Yang
2024-07-05 8:28 ` Mike Rapoport
1 sibling, 0 replies; 3+ messages in thread
From: Wei Yang @ 2024-06-29 1:39 UTC (permalink / raw)
To: Wei Yang; +Cc: rppt, linux-mm
Mike,
Missed this one?
On Mon, Jun 24, 2024 at 01:54:32AM +0000, Wei Yang wrote:
>commit 8043832e2a12 ("memblock: use numa_valid_node() helper to check
>for invalid node ID") introduce a new helper numa_valid_node(), which is
>not defined in memblock tests.
>
>Let's add it in the corresponding header file.
>
>Signed-off-by: Wei Yang <richard.weiyang@gmail.com>
>CC: Mike Rapoport (IBM) <rppt@kernel.org>
>---
> tools/include/linux/numa.h | 5 +++++
> 1 file changed, 5 insertions(+)
>
>diff --git a/tools/include/linux/numa.h b/tools/include/linux/numa.h
>index 110b0e5d0fb0..c8b9369335e0 100644
>--- a/tools/include/linux/numa.h
>+++ b/tools/include/linux/numa.h
>@@ -13,4 +13,9 @@
>
> #define NUMA_NO_NODE (-1)
>
>+static inline bool numa_valid_node(int nid)
>+{
>+ return nid >= 0 && nid < MAX_NUMNODES;
>+}
>+
> #endif /* _LINUX_NUMA_H */
>--
>2.34.1
--
Wei Yang
Help you, Help me
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] memblock tests: fix implicit declaration of function 'numa_valid_node'
2024-06-24 1:54 [PATCH] memblock tests: fix implicit declaration of function 'numa_valid_node' Wei Yang
2024-06-29 1:39 ` Wei Yang
@ 2024-07-05 8:28 ` Mike Rapoport
1 sibling, 0 replies; 3+ messages in thread
From: Mike Rapoport @ 2024-07-05 8:28 UTC (permalink / raw)
To: Wei Yang; +Cc: Mike Rapoport, linux-mm
On Mon, 24 Jun 2024 01:54:32 +0000, Wei Yang wrote:
> commit 8043832e2a12 ("memblock: use numa_valid_node() helper to check
> for invalid node ID") introduce a new helper numa_valid_node(), which is
> not defined in memblock tests.
>
> Let's add it in the corresponding header file.
>
>
> [...]
Applied to for-next branch of memblock.git tree, thanks!
[1/1] memblock tests: fix implicit declaration of function 'numa_valid_node'
commit: 9364a7e40d54e6858479f0a96e1a04aa1204be16
tree: https://git.kernel.org/pub/scm/linux/kernel/git/rppt/memblock
branch: for-next
--
Sincerely yours,
Mike.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-07-05 8:29 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-06-24 1:54 [PATCH] memblock tests: fix implicit declaration of function 'numa_valid_node' Wei Yang
2024-06-29 1:39 ` Wei Yang
2024-07-05 8:28 ` Mike Rapoport
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox