From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1EF13C27C53 for ; Sat, 22 Jun 2024 10:01:38 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 871686B0152; Sat, 22 Jun 2024 06:01:37 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 820C96B0158; Sat, 22 Jun 2024 06:01:37 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6E8216B015A; Sat, 22 Jun 2024 06:01:37 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 51A4E6B0152 for ; Sat, 22 Jun 2024 06:01:37 -0400 (EDT) Received: from smtpin05.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id DDF29416DE for ; Sat, 22 Jun 2024 10:01:36 +0000 (UTC) X-FDA: 82258082592.05.542DA10 Received: from mail-pf1-f175.google.com (mail-pf1-f175.google.com [209.85.210.175]) by imf14.hostedemail.com (Postfix) with ESMTP id 0FE1A10000D for ; Sat, 22 Jun 2024 10:01:34 +0000 (UTC) Authentication-Results: imf14.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=fZfnnIXQ; spf=pass (imf14.hostedemail.com: domain of ioworker0@gmail.com designates 209.85.210.175 as permitted sender) smtp.mailfrom=ioworker0@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1719050488; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=XqMTUZuiEpOFDB1baLxpBZo9bkFoxkrSKRZCo1yWC2s=; b=8fbKCtyo13HsnKlB7f+lqHef8obZlQ1Ju4gkJPZMYD+m7dXwharbK/4mUvvN6O0vpy8fHA NMYUiPnZdKHq4voJ6YqwlXfLAPmUl65WbSxcxN3g66xJCCVlsxQQB+Mw9lH+kkiyC0KO/S n7HBw0PGmAig0rMvRXt/2sdKB92cVLQ= ARC-Authentication-Results: i=1; imf14.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=fZfnnIXQ; spf=pass (imf14.hostedemail.com: domain of ioworker0@gmail.com designates 209.85.210.175 as permitted sender) smtp.mailfrom=ioworker0@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1719050488; a=rsa-sha256; cv=none; b=XBBb/7nS54lIwI9251OMxwrcdGyscs4RydS0TCMsWLF95uerlpR12So0/bM2rYRwROpQDR Au6RG2SC7YAHVE8thE9I65LBL97kBTMoqWz8LslLMEQ+yCDXDWEWt6JuL1MmuuX213R/Q8 efK5a0ECGKIgV2uJhjQOtfLj4jkQa8o= Received: by mail-pf1-f175.google.com with SMTP id d2e1a72fcca58-706683e5249so236530b3a.2 for ; Sat, 22 Jun 2024 03:01:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1719050494; x=1719655294; darn=kvack.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=XqMTUZuiEpOFDB1baLxpBZo9bkFoxkrSKRZCo1yWC2s=; b=fZfnnIXQaMLhi2KHQjQKAdMUtrdBs5sZhUplZ9yW7yYPk1MdycbFnTBOlcyTckzXtr 1jBqjd5bRFJU8PtmhIKYHDSdXyT95wGzDX1A4TInd4O1jwsDW0VEdKQvP26mAiMkSPH1 MFFvfyaSHsbtcePye8ycShtZuPCO7RpyL9xk2D6aY06/6/A14p8EelB6OEowTjsZgpBy otIginewOnIp7p9NSFCRduh/Xb4uHFcsOjhG0PcJA8R1NOx9ktU6WVZhUkZvEQFe16pr rcixe0orPDFFQzUqYs2AGTKv/aATv44Ol6tBfzZaaSHUip5q5SAW1v1Sg/X4HhK918Rd lTMg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1719050494; x=1719655294; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=XqMTUZuiEpOFDB1baLxpBZo9bkFoxkrSKRZCo1yWC2s=; b=X1b+Fh8qyFMF6BfkVDY/jOW8BdjRZRzsKTntKEedPjfAHLPgkSj1DFpveJ39GO8b4i H5ufTsPi8irTXie6BgZEpUKhRrqHSolfTCmorZQGnzAxl6Ky30B+F5ya10G+cy5Zp/hh gQCgRamUMp5LkpOeSygTekpcVcNTzWssMNV1Pd2NFtsnEFP5/HXzcUaUpj3svkPd2MYm 4hfPltubhepG+0aQZhSJ18ZQtkRlHSShOpf5QAfiMntvBd5PY9bnTdwMm56Il7O+EfmJ YHE5/qXVIN63iaVffsf6yOI+NPm0jK2ox/vy1LfhMgrQn0LXtWUB5OGeA8ohEPxBtYj3 p/1Q== X-Forwarded-Encrypted: i=1; AJvYcCUoHti51VvVKf1Gt6Ct8UjTlMJ+9DOe93Lr2FHB0OJwbBwC96UPt+n991I2VHVn3xaUa+isC4pBdZAKs2qSEvJpfBo= X-Gm-Message-State: AOJu0YxYFjEMZ542B88CjJGjwGc08L1ahFsnYwA4spz53bnY6aScDx4S PbyraxFN5P/DP0d1Zx97//LArs1MpNahgvQS/CkHsMdjNujy9TsM X-Google-Smtp-Source: AGHT+IG5+gqUJ0pcMtEkBAAeVC8MQVAyDbxFzNmRYBsf3upGPEwH2mux8H1fv5kZLq2BlXcL6pgK2Q== X-Received: by 2002:a05:6a00:1701:b0:706:6c38:31f3 with SMTP id d2e1a72fcca58-7066c3833b6mr516508b3a.8.1719050493620; Sat, 22 Jun 2024 03:01:33 -0700 (PDT) Received: from localhost.localdomain ([2403:2c80:6::3057]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-7065129b9edsm2838593b3a.148.2024.06.22.03.01.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 22 Jun 2024 03:01:33 -0700 (PDT) From: Lance Yang To: david@redhat.com, akpm@linux-foundation.org Cc: 21cnbao@gmail.com, baolin.wang@linux.alibaba.com, fengwei.yin@intel.com, ioworker0@gmail.com, libang.li@antgroup.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org, maskray@google.com, mhocko@suse.com, minchan@kernel.org, peterx@redhat.com, ryan.roberts@arm.com, shy828301@gmail.com, sj@kernel.org, songmuchun@bytedance.com, wangkefeng.wang@huawei.com, willy@infradead.org, xiehuan09@gmail.com, ziy@nvidia.com, zokeefe@google.com Subject: Re: [PATCH v8 3/3] mm/vmscan: avoid split lazyfree THP during shrink_folio_list() Date: Sat, 22 Jun 2024 18:00:57 +0800 Message-Id: <20240622100057.3352-1-ioworker0@gmail.com> X-Mailer: git-send-email 2.33.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Rspamd-Server: rspam11 X-Rspamd-Queue-Id: 0FE1A10000D X-Stat-Signature: t68h4bzw31kpzckm71gs9hd3o1y9seep X-Rspam-User: X-HE-Tag: 1719050494-429761 X-HE-Meta: U2FsdGVkX1+l6bruZHLa+jqIGHAMZ48Pe1CuM42VarnC0fNaEyNFkY6jJFw/Qvfg95BS6XpIsS5+7H8wpb14kAH7CsClsA3lqGW4fKmeGixh4zziSpYpDYbSoQ9zcSwAq7QkN5NzuFp0SvkdWCOx+bm0uyzPAhJ/yFbVMNDXkgxVJfuN4nXbLovC3o/i/LM8ySPet9PzthJHwh5m1456x35qeVdps8LvdO3hz6pxc0kdDu+UhFDDzAf4F/J1FZFOsT+nL0H4/iUmixvC0Vrex402+22SIjgaCYUluqf4QfJzBWT9eQ1nAdvRzEZm3nVY6qSVXWyarjqnV5pk4zKC9I5k580JztOE6HRckz8aoJCr5t5o02zozydyC+NUoaP+erWZsc4OJUTjvaaWwK7CjIZbVK3YPSby6KJo8M28ecRudSVZOfUp0PJbHDOSb5Fc6Ldgv7w/rf80EqfYUKm3MHdMdSC3HPUft9vBrE1R3CXVUWpjCYZQ9CJkb9SUitBeuXLl1YXZVcwBM+9hdEAQUgNppgaP19Tk8pRNPb/tkcMMkWyvEjBtuRvia93ecPdo8izqcEhnCCCiJHo64/g6NI5aempcwpB+BYP06fpt9jrbIwMtOy8ja+NxzGUPx6FnVUvQhhMXPaTJD5/m6FCrWDORPXpHklkQFUxMiX6RkpwZ3dQZP88z887TqBGj/HRwpfYRVPFDsDkGjFRPAfWL+DsPG29R3o+gxJFVg2rrK8qkvT8GL+qSef27ZuKj0JlbeAaPBYTMaX7enwEIkFGlv7wM8TfRJaH2kC4jK5onYRuWt/uXhiTvFSbh9NbkPcpeQ2eWup15SBNAfBxTvvOQfSb2bgH6mA/2Izu0/vlIFRXa9z175gH2jvVWeFGtJD4Eawwbx3iV8sXhmEVz6lcftN5qzOSkvbrVDoKv34kNqgYyf8W95Fxc+IsgaP+v4N3pgwCiToCm3SC1QSwc3Yn K2beMvTV WEmVwgrNmZucznZxP5TudLovKo3gATc5WKfXsrufaUY75C1dPn8yiID2jMqow2aMdrl903gmxFYn7+jlAZbLOd72GMN3EfFos6xoRISjnWmuQUKCp/cp1icGnWFlPnOuJVgmeqfy0yAXXrVD0lHPfpSeGhPiOu9yRozwXxLXAQr2VuzXzL9HGjVn4uxFxr38iZgIbDNE+aOuAfXvkLFdKFRprwlvUkXQSaiFdAkVHYyivojOiYDzBOpKhcLBof7VOS+NHC8A4Z5iS9I+WR8sL3fyjGHIOHuWaQRKRB+cDYkeJTc6QTrt8XapajjdFIz1qNSjTx1vofJlF2nvtxoEFtspV0ljjxaCUpqP2FJ/Y/Za2qWGSrMjCL9yOafb95ZrI7KYuDZU3E6n4VF61HvjGMv5Siafcm1s+GLUiouAGb4CQ9TojeF8NYHw+hchfoNz+ifgP1Y8gK2JEMD6auIgPjE+WeRZy66WOAOzMjXaTKi0bisoSbx8sgyWJYQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Hi Andrew, I made some minor changes suggested by David[1]. Could you please fold the following changes into this patch? [1] https://lore.kernel.org/linux-mm/e7c0aff1-b690-4926-9a34-4e32c9f3faaa@redhat.com/ diff --git a/mm/huge_memory.c b/mm/huge_memory.c index 4b2817bb2c7d..0cb52ae29259 100644 --- a/mm/huge_memory.c +++ b/mm/huge_memory.c @@ -2693,21 +2693,11 @@ static bool __discard_anon_folio_pmd_locked(struct vm_area_struct *vma, unsigned long addr, pmd_t *pmdp, struct folio *folio) { - VM_WARN_ON_FOLIO(folio_test_swapbacked(folio), folio); - VM_WARN_ON_FOLIO(!folio_test_anon(folio), folio); - struct mm_struct *mm = vma->vm_mm; int ref_count, map_count; pmd_t orig_pmd = *pmdp; struct page *page; - if (unlikely(!pmd_present(orig_pmd) || !pmd_trans_huge(orig_pmd))) - return false; - - page = pmd_page(orig_pmd); - if (unlikely(page_folio(page) != folio)) - return false; - if (folio_test_dirty(folio) || pmd_dirty(orig_pmd)) return false; diff --git a/mm/rmap.c b/mm/rmap.c index df1a43295c85..b358501fb7e8 100644 --- a/mm/rmap.c +++ b/mm/rmap.c @@ -1678,9 +1678,8 @@ static bool try_to_unmap_one(struct folio *folio, struct vm_area_struct *vma, if (flags & TTU_SPLIT_HUGE_PMD) { /* - * We temporarily have to drop the PTL and start - * once again from that now-PTE-mapped page - * table. + * We temporarily have to drop the PTL and + * restart so we can process the PTE-mapped THP. */ split_huge_pmd_locked(vma, pvmw.address, pvmw.pmd, false, folio); -- Thanks, Lance