From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id AA3D3C27C4F for ; Sat, 22 Jun 2024 03:20:24 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 0DA8E8D01B1; Fri, 21 Jun 2024 23:20:24 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 08B8E8D01AF; Fri, 21 Jun 2024 23:20:24 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E4D268D01B1; Fri, 21 Jun 2024 23:20:23 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id C31B68D01AF for ; Fri, 21 Jun 2024 23:20:23 -0400 (EDT) Received: from smtpin03.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 3F3761C2B82 for ; Sat, 22 Jun 2024 03:20:23 +0000 (UTC) X-FDA: 82257071526.03.1404236 Received: from mail-oo1-f45.google.com (mail-oo1-f45.google.com [209.85.161.45]) by imf03.hostedemail.com (Postfix) with ESMTP id 71A332000D for ; Sat, 22 Jun 2024 03:20:21 +0000 (UTC) Authentication-Results: imf03.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=gBqYtWmo; spf=pass (imf03.hostedemail.com: domain of 21cnbao@gmail.com designates 209.85.161.45 as permitted sender) smtp.mailfrom=21cnbao@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1719026415; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=noIRKzwOenkJYlyIgDWrCHnrYGfNUC84Fg2QmqzIHaQ=; b=4I35xjmtx6HUWj5ouRZSJysgIKqdv+5ZTLYhi8fuA72N+ShEvwL7tuNaBdo3W/ns2Dob+N PBHsd8Ts9ox65L0N4GrqOshcs7iIo+COrCJSrB57W2ZZvCHjV2JwyFd0plbrjElu00fzXn omB6Q8rSc0uKQ2ilWwxmiXt6FPv54Jw= ARC-Authentication-Results: i=1; imf03.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=gBqYtWmo; spf=pass (imf03.hostedemail.com: domain of 21cnbao@gmail.com designates 209.85.161.45 as permitted sender) smtp.mailfrom=21cnbao@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1719026415; a=rsa-sha256; cv=none; b=XEmUmmbVVTW6s7m+sE3Q9eAviFz6P/EzQsHnig6TTc4OIYGSzODH/G4hmLodoxGW54G8oL QlcLLbeM6Od+OBIzhkHZBcZB1mNhYiKmsP+1Wq78NlCFBisYA7bCeuRX7ubc0lVKALElTq 15EU6Mh4zhv6SDNTDcWkh35ymKmZFYM= Received: by mail-oo1-f45.google.com with SMTP id 006d021491bc7-5bb041514c1so1406281eaf.0 for ; Fri, 21 Jun 2024 20:20:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1719026420; x=1719631220; darn=kvack.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=noIRKzwOenkJYlyIgDWrCHnrYGfNUC84Fg2QmqzIHaQ=; b=gBqYtWmoYzCQ9cZfliahzCYrle2+4bf/KElZUMgZo1KihvE4NMzmk32Y+Lh78Yfv+2 shHYZKFQHsPvWak/7D3wIW8Ej4W1Fw8OcHTOHIpMq2ma2XG1gTxHU2rGN/mEQKTRgdvW 9Kx4GQJh4kKL6morri3MVCAb31iqiTB2HFQsmoBjCcQgqgKihAsC3vqV+8awRnMDLKJA BKsTEP9hL2Bj2sPQDSge8qlZHilyNHQdbmR58S7hC8uhO8DQ4ZCtkLj4jHVIeEQWh0EF /5vC4le+i+s+D9JAKeLxA549pSIlga1xMVUGlo1WDR36740euvmaH2G1eQRjPgrVK9do kcrQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1719026420; x=1719631220; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=noIRKzwOenkJYlyIgDWrCHnrYGfNUC84Fg2QmqzIHaQ=; b=vDuhB83kfxEJ/MDvEqJVSxj29a1mDb32aAtomyZeULrF7XWU2snThzUkedb7vzKPLn zCmLcFfKOi/JXjMdrTPVufifIB33Lg7EV65fml8ucV1vpN37RhYaNH10nlHopDk7L5c+ 5p1cvAQ/GFpVb8ALEh1ROc3pmAgmIIHg6fpkgXe3bVGKfLQiNX180EPTHS2nBsAVMhpy N1WnhHQsi+S25J34dMVmKL+yeDH9v2QTBBPmr/8UdmWsdr86YoVif6t/F6ix8o1/A73k Ul96F7Pr73DXB0K2vhmue2xsXBmMOHl7BU7thb0CRDG2ZyT6V0LRvvJEv64qIAzMGySB Hz8A== X-Forwarded-Encrypted: i=1; AJvYcCUueKXOw31j8Uxo5GR8bYoY1RXYLYeKXVsQYhgrnkNfRcJhlHqYcpaKn1AYhSc4SbgLWV/1LXiCskr4hKys7hGKV00= X-Gm-Message-State: AOJu0YyQbBC1I2KGU70m8pu7NkjXIJOhiUoum0NCqc/mWeg0u9E4zjRA PSEjuNQpHl34EV6kI3UgW0z2/afMCaNx/Vhb9UBdT9yVOOqAZTu+ X-Google-Smtp-Source: AGHT+IFzHnx7M3tBygs51isXq4OUoLtq5aQdebcrHujNqGD7L2U/YJtdQ0FFKqmCpZXizQf75nioOw== X-Received: by 2002:a05:6358:6f11:b0:19f:174c:7fa0 with SMTP id e5c5f4694b2df-1a1fd559d12mr1201106555d.24.1719026420184; Fri, 21 Jun 2024 20:20:20 -0700 (PDT) Received: from localhost.localdomain ([2407:7000:8942:5500:aaa1:59ff:fe57:eb97]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-2c738c1bb81sm5388045a91.1.2024.06.21.20.20.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 21 Jun 2024 20:20:19 -0700 (PDT) From: Barry Song <21cnbao@gmail.com> To: david@redhat.com, akpm@linux-foundation.org Cc: baolin.wang@linux.alibaba.com, chrisl@kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, mhocko@suse.com, ryan.roberts@arm.com, shy828301@gmail.com, surenb@google.com, v-songbaohua@oppo.com, willy@infradead.org, ying.huang@intel.com, yosryahmed@google.com, yuanshuai@oppo.com, yuzhao@google.com Subject: Re: [PATCH v2 2/3] mm: use folio_add_new_anon_rmap() if folio_test_anon(folio)==false Date: Sat, 22 Jun 2024 15:20:02 +1200 Message-Id: <20240622032002.53033-1-21cnbao@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <02b87f01-69c9-4007-b0d0-5ce9ce35876d@redhat.com> References: <02b87f01-69c9-4007-b0d0-5ce9ce35876d@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Rspamd-Server: rspam11 X-Rspamd-Queue-Id: 71A332000D X-Stat-Signature: isjiunjipf8m9udn5tcug8twxcq776pe X-Rspam-User: X-HE-Tag: 1719026421-958556 X-HE-Meta: U2FsdGVkX191p7CLCwUDIYOMh3dxwt14tBsjFob25X2ztp1N0UwMZInFIEqU7MUW1hdlRGawpOsLj9iqYHfzqjxPnfTLtnaCSgNTOcEPnzcIlbTwMpm1AgsgLMHTl42Skg5rVjGtLW4Emwu+lM5fb/oMkszV4z7eAezdCW/ehWBx+AckRtoQ+wL0cGBp2S7fOXfCKkDb9T7+olgcjCMVWi30JYJSFWFYnlbgbczxQ7tBFETZXXCbpS/pGZ3uQnN44+7u2Onx9fkF4Ki3jFFFzaZs6TswGd+Oc+RxYLrLmPVTJPXbbjxPfTbVBDII7NCzxDHE1gp6p3f/xizFc2X+uAvdFCRPtXM2EzDDn6ubW93iL45uhQEQ65Vr1o/kp7dSZ4N4S5YKmHPOjlqvgbZY4FMhqV2/Oiy/fLbe/FDAlSfaSZVCF5pUWfjwoKI1qCAXWHzlsevkywhzolopFN8OXtNygfGHawHpsGOOQ7prauR34NrOs1OvTQbBj1UMyZZDB0qYZXywbOdHuHERvjbtdP17n9slrC0LIxNB4yREx3OBE4PjdZ+TiqwvaAdhRDkQ7sKp7VZjQtfjHJp5Uo72DOB5S2txv3IC1+2fvHXYZCQkbjLnBm8eGhL7cIL0hzL2aE/TeAjTCnGv+P+NDPiYv2zKdxXxTp7EBI1l7mvxjGu7rlJEyPEMxikE6OwpkzbY2HPsIk4bvpVO9+rnMpRmA7ZgbAk7oecISXe4oQamevXkqLvrdxR0HVKDfkmzjB83XXJwvney1jfAT25KzD+OSqDsxpqHW3QTslHCMDLeLtNXvUCBF+7sIYJ6k/oZDKJdADZADHKGYZ2J8L/66b1LC4sf1oL0dP7PJ0myNfOLx1UG44WOSw6435F/PFEZehFvUdh+a0YVXXqQlD569FpEfilBSnkbwhDo5Lc846Ecs2oNcxCwBb1lyFDUB5ibOqAJDtQgXwjdE42NxwpbS4V nHtXZ7m1 Lv0Jvt3i8/gRk8CSUUHugOrME8X19ySo8KcI27xpD2qX1Laf3S4kEL6Z27q5/ZHGL4lptV3h4HerGbS0jI5PQMzz2D5JD+VXOKgqIlZdZfJS3nEQMBxBE2hTKQOaciL0cxCt91oZaoqhyFJskzw3sLkBeKCAgZjQABiDQQPrXbI7UM07aep+K7lg92AuSYkl3bgfwSYUxDUMrQGT8TybzsOEROujkH+Q7fF6+yJ7/LEiPCD2y6YtnEljJlFWj5MAyZLzXVKcPCfg1xiraks7pij4S2T6WHdIyU67F8Z7wmrD7pZv+mzADUBtZZ/rPjJRtN9BI5FaChcUailEKsSRrzzOVvARQgWwCXfRpJzyHdilGsYlbNdj4twDfwoopU0ftfI+haYxpsHB9pMG7a5dVN8aBF+D8mSEZSv4xiuvOELLdgwi4pFWqqvqImqD8t2KQCMYbkAVkaYXB2s0Z/kCpWuOo4fD1iNVhmsq6gbm4qLhzHqCYAhbcyNQoUg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: > > > > Since this is primarily a documentation update, I'll wait for two or > > three days to see if > > there are any more Linux-next reports before sending v3 combining these fixes > > together(I've already fixed another doc warn reported by lkp) and seek Andrew's > > assistance to drop v2 and apply v3. > > Feel free to send fixup patches for such small stuff (for example, as > reply to this mail). Usually, no need for a new series. Andrew will > squash all fixups before merging it to mm-stable. Hi Andrew, Can you please squash this change(another one suggested by David)? From: Barry Song Date: Sat, 22 Jun 2024 15:14:53 +1200 Subject: [PATCH] enhance doc- mm: use folio_add_new_anon_rmap() if folio_test_anon(folio)==false Suggested-by: David Hildenbrand Signed-off-by: Barry Song --- mm/memory.c | 1 + mm/swapfile.c | 1 + 2 files changed, 2 insertions(+) diff --git a/mm/memory.c b/mm/memory.c index 00728ea95583..982d81c83d49 100644 --- a/mm/memory.c +++ b/mm/memory.c @@ -4346,6 +4346,7 @@ vm_fault_t do_swap_page(struct vm_fault *vmf) * here, we have to be careful. */ VM_WARN_ON_ONCE(folio_test_large(folio)); + VM_WARN_ON_FOLIO(!folio_test_locked(folio), folio); folio_add_new_anon_rmap(folio, vma, address, rmap_flags); } else { folio_add_anon_rmap_ptes(folio, page, nr_pages, vma, address, diff --git a/mm/swapfile.c b/mm/swapfile.c index b99b9f397c1c..ace2440ec0b7 100644 --- a/mm/swapfile.c +++ b/mm/swapfile.c @@ -1923,6 +1923,7 @@ static int unuse_pte(struct vm_area_struct *vma, pmd_t *pmd, */ if (!folio_test_anon(folio)) { VM_WARN_ON_ONCE(folio_test_large(folio)); + VM_WARN_ON_FOLIO(!folio_test_locked(folio), folio); folio_add_new_anon_rmap(folio, vma, addr, rmap_flags); } else { folio_add_anon_rmap_pte(folio, page, vma, addr, rmap_flags); -- 2.34.1 > > -- > Cheers, > > David / dhildenb > Thanks Barry